Commit graph

34851 commits

Author SHA1 Message Date
Manuel
bc6882ea4b
Merge branch 'frappe:develop' into multiple_imap_folder 2021-10-13 15:19:43 +02:00
Ankush Menat
a6bfbe4f1a
Merge pull request #14427 from ankush/app_uninstall_failure
fix: app uninstallation failure if module def link field isn't called "module"
2021-10-13 16:38:18 +05:30
mtraeber
f608fbeddd feat: sync mutliple IMAP folders in Email Account
When working with IMAP accounts, frappe should allow the user
to choose multiple folders to look for new mails. This helps
users to separate their frappe-related email from other
conversations. Use cases range from sieve filters in the
mail server that stuff incoming mail in various mail folders
to people manually sorting their e-mail. In both cases, we
can have different import policies for different folders, and
we can avoid importing unrelated email.

Created a new child table `IMAP Folder` with following fields:
 - Folder Name (user-modifiable)
 - Append To (user-modifiable)
 - UIDVALIDITY (hidden)
 - UIDNEXT (hidden)

Doctype `Email Account` and `receive.py` code adjusted so that
emails with the changes are processed correctly and Frappe
only logs in to the imap server once per sync.

Created a patch that copies the data from the old fields into
the new child table with `INBOX` as default `folder_name`. This
keeps existing setups working without manual changes.

The original fields
 - uidvalidity
 - uidnext
 - append_to
are still available for the pop3 setups. In IMAP, these fields
are hidden user and not used.

Added a test case in `Email Account` that validates data to make
sure a IMAP folder is provided if the use_imap is true.

Also added some code formatting changes in email_account.js to get rid
of sider checks failures that block this change
2021-10-13 10:27:18 +02:00
Manuel
201e0e278c
Merge branch 'frappe:develop' into develop 2021-10-12 15:30:01 +02:00
gavin
8e7d83c88d
Merge pull request #14246 from saxenabhishek/aks-fix-migration
feat: Hash based comparison migration
2021-10-12 17:50:49 +05:30
Ankush Menat
35b242fe27
test: remove app unit tests 2021-10-12 17:33:29 +05:30
abhishek
ba78852c73 docs: add docstring for import_file_by_path 2021-10-12 17:15:12 +05:30
Ankush Menat
70fcac8acf
refactor: change _delete_modules for testability 2021-10-12 17:10:14 +05:30
Ankush Menat
aa372b0990
fix: change order of deletion
Previous order was:
1. Delete DocTypes
2. Delete linked records
3. Drop tables

Now if linked records belonged to deleted doctypes it causes
uninstallation failure.

Changed order to:

1. Delete linked records
2. Delete DocTypes
3. Drop tables
2021-10-12 16:52:18 +05:30
Ankush Menat
412aa9f5cc
fix: fieldname for linkfield hardcoded to "module"
Remove_app assumed that all link fileds linking to "Module Def" are
called "module", this causes uninstall failure and leaves bench in
pseudo-irrecoverable state. (requiring some manual cleanup)
2021-10-12 16:52:18 +05:30
Ankush Menat
ae88fca3ef
refactor: split remove_app in smaller functions 2021-10-12 16:52:17 +05:30
Suraj Shetty
05231f97f8
Merge pull request #14424 from frappe/fix-group-by-child-table-field 2021-10-12 14:20:36 +05:30
Suraj Shetty
18df0b0f8c test: Fix test 2021-10-12 13:46:06 +05:30
Suraj Shetty
74ec9657da test: Update aggregation test 2021-10-12 13:36:30 +05:30
Suraj Shetty
828d158e4d
Merge pull request #14380 from pateljannat/discussions-single-topic 2021-10-12 13:35:42 +05:30
Mohammad Hasnain Mohsin Rajan
b3465f7972
Merge pull request #14429 from anupamvs/customize-print-format-btn-issue
fix: Customize is not listed in menu item [Print]
2021-10-12 13:01:00 +05:30
Anupam
f6e83dbcaf fix: Customize is not listed in menu item [Print] 2021-10-12 12:35:40 +05:30
Suraj Shetty
ab00980389
refactor: Use f-string
Co-authored-by: gavin <gavin18d@gmail.com>
2021-10-12 12:06:08 +05:30
Suraj Shetty
8febefae9c test: Add test case to validate aggregation
- based on child table field
2021-10-12 12:05:05 +05:30
Suraj Shetty
c6538cf318
Merge branch 'develop' into discussions-single-topic 2021-10-12 11:41:04 +05:30
Suraj Shetty
14ae20bdb8 fix: Push aggregate_on_field to field list
- for proper extraction of child table
2021-10-12 09:54:09 +05:30
abhishek
86f29aeaa3 fix: missing logical cases
- handle first time imports
- update hash and timestamps
2021-10-12 03:21:08 +05:30
mergify[bot]
d7edd05a5d
Merge pull request #14309 from shariquerik/hide-show-filter
fix: Hide 'Show Saved' filter button if there is no saved filters
2021-10-11 14:30:45 +00:00
Mohammad Hasnain Mohsin Rajan
b7de4b3cae
Merge pull request #14355 from shariquerik/notification_overlap_filter
fix: Filter pop-up overlaps the Notification Window
2021-10-11 19:36:19 +05:30
Shariq Ansari
875f35ec14
fix: Rate limiter on blog feedback (#14322)
* fix: Added rate limiter on blog feedback

* test: Updated test to support rate limiter
2021-10-11 19:35:51 +05:30
mergify[bot]
20c38aa704
Merge pull request #14414 from mituldavid/comment-imgs
fix: Private images in comments are not visible
2021-10-11 13:43:36 +00:00
Gavin D'souza
2622f3398e style: Black-ish queries
* feat(minor): Added DocType to frappe.query_builder namespace
2021-10-11 19:00:52 +05:30
abhishek
f3d810414a refactor: sync_for() - first install module 2021-10-11 18:59:06 +05:30
abhishek
0be59cee80 chore: add missing document_types 2021-10-11 18:59:06 +05:30
abhishek
547111841a refactor: sql in update_modified() to frappe.qb 2021-10-11 18:58:15 +05:30
abhishek
3ac65adb94 style: misc changes 2021-10-11 18:57:46 +05:30
MitulDavid
33bfd5bd19 fix: Private images in comments are not visible 2021-10-11 18:43:12 +05:30
abhishek
69d8eddf5a refactor: remove unused args
refactor: remove unused args
2021-10-11 17:23:17 +05:30
abhishek
822fdce4d6 fix: doctype doc hash creation 2021-10-11 17:23:17 +05:30
abhishek
278883edb0 fix: missing migration hash column 2021-10-11 17:23:17 +05:30
abhishek
b2b391e90a style: misc 2021-10-11 17:23:17 +05:30
Gavin D'souza
c3be3d35e8 fix: "function"al programming++ 2021-10-11 17:23:17 +05:30
Gavin D'souza
db6fc6a5fb feat: Hash based comparison migration 2021-10-11 17:23:17 +05:30
mergify[bot]
3312deb97d
Merge pull request #14363 from Aradhya-Tripathi/at/safeqb
feat: Added safe query builder for server scripts
2021-10-11 10:42:36 +00:00
Aradhya-Tripathi
5362d367d1 fix(minor): fixed execute_query patch 2021-10-11 14:15:01 +05:30
Aradhya-Tripathi
fe7b45c068 fix: fixing safeqb in server scripts 2021-10-11 14:01:17 +05:30
Manuel
82d4c2777a
Merge branch 'frappe:develop' into develop 2021-10-11 09:45:17 +02:00
Gavin D'souza
4e7be5b3ec Merge branch 'develop' of github.com:frappe/frappe into at/safeqb 2021-10-11 12:45:03 +05:30
Gavin D'souza
cfa2d65394 refactor(safe_exec): Manage in-safe frappe.db.sql
* Check if flag in_safe_exec to check if SELECT query in frappe.db.sql
* Get rid of read_sql...refactor logic
* Enable frappe.qb just like that ;)
* Add support fro *args in .run
2021-10-11 12:28:36 +05:30
pateljannat
f9104c846f fix: removed opacity and added lighter color to divider 2021-10-11 12:05:53 +05:30
gavin
c0380cdd06
Merge pull request #14401 from gavindsouza/better-replacing-sql
fix: Don't load entire SQL file into memory during restoration
2021-10-11 10:10:52 +05:30
mergify[bot]
06a5cfc0b1
Merge pull request #14325 from shariquerik/modal-scrollbar-fix
fix: Scrollbar is hidden when search modal is minimised
2021-10-11 04:22:37 +00:00
Suraj Shetty
11bf47d9f9
Merge branch 'develop' into modal-scrollbar-fix 2021-10-11 09:33:04 +05:30
mergify[bot]
0dbc9b3fa5
Merge pull request #14140 from deepeshgarg007/server_script_enhancements
feat: Enhancements in Server Script
2021-10-11 04:01:19 +00:00
Deepesh Garg
1127d3d184 fix: Restrict commit and rollback for doc events 2021-10-10 17:41:26 +05:30