Ankush Menat
bcd5d78dab
fix: skip undefined path
2023-12-28 17:58:25 +05:30
Ankush Menat
9b458ad354
Merge pull request #23835 from akhilnarang/sentry-sync-fc
...
refactor(sentry): sync up with FC implementation
2023-12-28 17:38:06 +05:30
Rushabh Mehta
210fd03c53
Merge pull request #24005 from rmehta/sidebar-item-spacing-fix
...
fix(minor): spacing for sidebar item with child items
2023-12-28 15:59:28 +05:30
Rushabh Mehta
1501c5e1d3
fix(minor): spacing for sidebar item with child items
2023-12-28 15:58:44 +05:30
Ankush Menat
3a918fb18c
Merge pull request #24001 from ankush/fix_filter_check
...
fix: incorrect duplicate filter check
2023-12-28 14:56:37 +05:30
Ankush Menat
acf032f607
refactor: simplify duplicate filter checking code
...
keeping track of `exists` variable is weird to read and prone to bugs...
what if next field makes exist = false, even if one filter already
exists?
2023-12-28 14:53:45 +05:30
mergify[bot]
a9bb994f15
fix!: deterministic fixture import order ( #22210 )
...
* feat: #20753 fixture export prefix and fixture import order
(cherry picked from commit 6a9c56a568e4ccf181fe9cb4153d0b9e4f02ac3d)
* refactor: clarify prefix logic, see c4866921df (r1196249038)https://github.com/frappe/frappe/pull/22210#discussion_r1331587501
---------
Co-authored-by: To Finke <tom.finke@webterra.de>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-28 14:24:45 +05:30
Ankush Menat
ad8ad088c5
fix: force [] as default for child tables ( #24000 )
2023-12-28 13:48:35 +05:30
Ankush Menat
5d51ec2ba1
Revert "fix(text_editor): Fix bubble's link tooltip clipping ( #23911 )" ( #23999 )
...
This reverts commit 91405493e5
2023-12-28 12:21:09 +05:30
mergify[bot]
3c015a1fd7
fix: sudan country info ( #23709 ) ( #23998 )
...
* Update country_info.json
Update Sudan Currency
* chore: fix currency symbol
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
[skip ci]
(cherry picked from commit 6b24b9aa13df00a257adfcd40892e4acce688fd4)
Co-authored-by: Ayman Mustafa <84941140+MEClouds@users.noreply.github.com>
2023-12-28 11:40:03 +05:30
Ankush Menat
ac338b07da
Merge pull request #23975 from niraj2477/fix/import-log
...
fix(Data Import): show failed import logs
2023-12-28 11:09:31 +05:30
Raffael Meyer
3527489a04
feat: sort multicheck by label ( #23985 )
...
* feat: sort multicheck by label
* fix: avoid double translation
* fix: always cast to string before comparing
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-12-28 11:07:49 +05:30
Anas AlGhanem
8583c01cad
fix(Geo): Add timezone for palestinian territory country ( #23986 )
...
* Add timezone for palestinian territory country. It's blocking the first start wizard from completion.
* add currency and additional timezone for Palestine
[skip ci]
2023-12-28 11:03:48 +05:30
Revant Nandgaonkar
37803a00d4
fix: strip exc from json response if traceback not allowed ( #23989 )
...
* fix: strip exc from json response if traceback not allowed
* fix: use pop instead of del to avoid key error
* fix: Avoid showing exc when traceback is disabled
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-28 10:45:06 +05:30
Ankush Menat
0162d3bda0
Merge pull request #23982 from ankush/new_js_child_table
...
fix!: initialize child tables correctly
2023-12-27 19:51:18 +05:30
Ankush Menat
e814af0aeb
fix!: Init child tables as empty array on client side
2023-12-27 19:35:55 +05:30
Ankush Menat
c7e5afee6a
refactor: Use arr.includes(item) instead of in_list(arr, item)
2023-12-27 19:33:13 +05:30
Akhil Narang
70bb2f45bb
Merge pull request #23590 from GursheenK/treeview-filters
2023-12-27 19:03:05 +05:30
Akhil Narang
d5d35704d8
feat(sentry): skip validation errors
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 18:43:33 +05:30
Gursheen Kaur Anand
0fadb6d9fc
fix: use sbool for better typecasting
...
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 18:40:44 +05:30
Akhil Narang
34f03a2de2
fix(data_import): respect the value of show_failed_logs checkbox
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 16:58:04 +05:30
Ankush Menat
6e914dfdf6
test: use doctype that supports prompt naming ( #23980 )
2023-12-27 11:15:42 +00:00
Jannat Patel
32469b5a81
fix: roles editor ( #23976 )
2023-12-27 16:17:31 +05:30
Ankush Menat
4996b8ac7b
refactor: postgres version check
2023-12-27 16:12:40 +05:30
hhharsha36
445da4319b
fix: error - permission denied for schema public from Postgres >= 15 during initial DB setup ( #23799 )
...
Error from Postgres:
ERROR: permission denied for schema public at character 14
Error from Frappe:
psql:/home/frappe/frappe-bench/apps/frappe/frappe/database/postgres/framework_postgres.sql:72: ERROR: permission denied for schema public
Error Causer:
Starting Postgres version >= 15, all users will have the `CREATE` permission revoked by default.
Fix:
Grant relevant privileges to the database in question for the user. In this case, DB owner privilege.
Note: the below two permission attempts were unsuccessful and still caused the same public schema permission error
GRANT USAGE, CREATE ON SCHEMA public TO {frappe.conf.db_name};
GRANT ALL ON SCHEMA public TO {frappe.conf.db_name}
References:
https://stackoverflow.com/questions/74110708/postgres-15-permission-denied-for-schema-public
https://stackoverflow.com/questions/67276391/why-am-i-getting-a-permission-denied-error-for-schema-public-on-pgadmin-4
2023-12-27 16:04:21 +05:30
Corentin Flr
91405493e5
fix(text_editor): Fix bubble's link tooltip clipping ( #23911 )
...
* fix(text_editor): Use body as bounds to avoid bubble's tooltip clipping
* fix(text_editor): Allow overflow for link tooltip
2023-12-27 16:03:18 +05:30
14987
2e730d7056
fix(Data Import): show failed import logs
2023-12-27 15:06:24 +05:30
Ankush Menat
6367194620
perf: skip network call if no doc ( #23967 )
...
If link field has no value then its title will always be undefined.
2023-12-27 14:15:20 +05:30
Maharshi Patel
c3cc310496
Merge pull request #23287 from fadilsiddique/numbercard_fix
...
fix: number card layout
only align flex-start for shortcut-widget-box instead of all widget-head
2023-12-27 13:46:41 +05:30
Maharshi Patel
53ab3c6491
Merge branch 'develop' into numbercard_fix
2023-12-27 13:39:00 +05:30
Maharshi Patel
39136b01b6
fix: shortcut-widget-box should have flex-start
...
As we changed align-items to space-between for widget head,
we need to override .shortcut-widget-box to flex-start
2023-12-27 13:32:04 +05:30
Maharshi Patel
547523c7b4
fix(minor): mobile menu class ( #23970 )
...
removed `.collapse.show` class as it is removed during opening animation of menu.
2023-12-27 13:16:02 +05:30
Maharshi Patel
fe906966d4
fix(minor): Onboarding check if element available ( #23947 )
...
only try to find parent_element_selector if element exists
2023-12-27 12:02:37 +05:30
Akhil Narang
64b63d5969
fix(sentry): don't set context if not enabled
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 11:38:01 +05:30
Ankush Menat
a16db1be32
fix: show relative path in loaded JS ( #23964 )
...
[skip ci]
2023-12-27 10:46:30 +05:30
Akhil Narang
ba01eb99cb
Merge pull request #23892 from jjaycaneza/fix-childTable-skip_dirty_trigger-param
...
fix: add skip_dirty_trigger param for child_table
2023-12-26 17:54:22 +05:30
Fierflame
3ee00cf1e4
fix: Solve the problem that the filter conditions are regarded as the same when the filter values are equivalent arrays in the filter
2023-12-26 20:17:58 +08:00
Sagar Vora
f54e0c94b7
Merge pull request #23948 from frappe-tianjy/fix/frappe.ui.Capture.prototype.setup_remove_action
2023-12-26 17:35:14 +05:30
Fierflame
c5990938fd
fix: Solve the problem that there is no forEach instance method in HTMLCollection in some environments, which leads to the failure of camera-related functions.
2023-12-26 19:50:33 +08:00
猛火
854cebd5b1
fix: Solve the problem that the document editor will report an error when the type name includes multiple spaces ( #23940 )
2023-12-26 14:34:48 +05:30
Ankush Menat
4b5658a507
Merge pull request #23926 from cogk/fix-child-doc-defaults
...
fix(document): Pass parent_doc and parentfield for child in _set_defaults
2023-12-26 13:27:05 +05:30
Akhil Narang
067104ca9c
refactor(sentry): sync up with FC implementation
...
Co-authored-by: Aditya Hase <aditya@adityahase.com>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 12:30:10 +05:30
Ankush Menat
bedf270bc4
Merge pull request #23935 from barredterra/print-font
...
fix: use system font for printing
2023-12-26 12:21:15 +05:30
Ankush Menat
2dfef73ae8
Merge pull request #22915 from akhilnarang/dont-extract-backup-unconditionally
...
perf: don't extract gzipped backups
2023-12-26 12:19:10 +05:30
Xiaoguang Sun
68d4a5ad82
Do not call begin in updatedb after syncing ( #23934 )
...
Do not call begin in updatedb after syncing as commit does it already.
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
2023-12-26 12:12:19 +05:30
Akhil Narang
43021911ff
fix: simplify parsing version for older backups
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
6e8f32af58
chore: don't pipe output through pv
...
No point if we're using `execute_in_shell()`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
3fe840fb31
fix(postgres): make use of common helper
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
76c9fbd0cd
fix: use source before changing its contents
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
b010dc584f
chore(installer): fix output when prompting user about downgrade
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
