Commit graph

52 commits

Author SHA1 Message Date
Ankush Menat
3bb70a905d
fix: restrict method types in few whitelisted funcs (#32984) 2025-06-18 11:02:57 +05:30
sokumon
b79c5476a7 fix: restrict fields according to permlevel after update as well 2025-06-17 20:17:50 +05:30
Raino-Harvest
33f3b54e09
refactor: handled condition in single line for status alert in submittable doctype
Removed unnecessary lines in "if-else" condition and handled in single line.
2025-03-28 12:36:10 +05:30
Raino-Harvest
aa203e3341
fix: condition based alert for Submittable DocTypes while Save and Submit 2025-03-27 20:44:32 +05:30
Sagar Vora
146d50e5d4 chore: fix typo in new DocStatus constant 2025-03-05 08:29:47 +05:30
Sagar Vora
fcf657ba80 perf: improved DocStatus API and other minor improvements 2025-02-24 12:51:10 +05:30
ruthra kumar
cb89393d24 refactor: temporary key for child rows 2025-01-02 15:33:15 +05:30
Rutwik Hiwalkar
c195b3b649 fix: typo 2024-04-17 22:05:46 +05:30
Rutwik Hiwalkar
82d61b32e4 fix: misc fixes for discard action
* use write perms instead of cancel
* update docstring
* remove discard from global namespace
2024-04-17 12:32:34 +05:30
Rutwik Hiwalkar
b274c45992 feat: discard draft transactions 2024-04-16 19:46:34 +05:30
Maharshi Patel
fd1fe44850 fix: cypress and add check for __islocal
changed check for __islocal as well in savedocs

As new route ends with random hash instead of numbers,
updated cypress test to just check start of data-route instead of entire path
2023-10-17 17:19:53 +05:30
Maharshi Patel
d9a8b7ee78 chore: rename __temporary_name & check temp_doc_name
* renamed file_relink_temp_docname to __temporary_name
* added check for temp_doc_name in relink_files in case someone
    calls the function it directly
2023-10-13 10:20:03 +05:30
Maharshi Patel
53cdd6d1bf fix: relink attachments before saving doc
Certain people add attachment, before filling mandatory fields
which will raise Missing Fields error.

Or any other kind of errors raised by different validators due to which
file is uploaded but doc is not saved.

This will lead to orphaned/mislinked files. ex. new-purchase-receipt-1

This fix changes name of new docs to new-<doctype>-<no>-<10digithash>
after saving the document we can use this new name to find any mislinked
files created in past hour and relink them to the new doc on save.
2023-10-10 23:49:16 +05:30
Ankush Menat
4f70200bd5 chore: track update actions per doctype
[skip ci]
2023-06-22 12:10:43 +05:30
Ankush Menat
2ed2f8747d chore: track doc creation
This is alternate to "Activation" level that already exists, activation
level will be phased out over time.
2023-05-29 13:34:24 +05:30
Raffael Meyer
ed30a6d59f
refactor(minor): use DocStatus (#19545) 2023-01-10 17:38:11 +05:30
Aradhya
3759e5bbcd refactor: lint
fix: removed time.sleep
2022-11-12 20:06:17 +05:30
Aradhya
b33efdc634 refactor: moved is_submittable validation from save to submission queue 2022-10-11 17:16:07 +05:30
Aradhya
eff6c4fc5d fix: checking if doc is submittable before queueing 2022-10-08 17:38:12 +05:30
Aradhya
d8ff47aac2 fix: checking and unlocking the correct doc 2022-10-08 04:50:09 +05:30
phot0n
c790ad51a3 fix(minor): only queue in background for submit action 2022-10-07 16:24:01 +05:30
phot0n
cb796a4e64 refactor(minor): better notification
* changed completed_at fieldname to ended_at (in submission queue doctype)
* added rollback on exception in queue_in_background method
2022-10-06 13:06:03 +05:30
Aradhya
4bdffe73dd refactor: moved background submit to Submission Queue DocType
Co-authored-by: phot0n ritwikpuri5678@gmail.com
2022-10-04 23:06:46 +05:30
Aradhya
198bc39085 refactor: moved submission from document class 2022-10-04 17:20:14 +05:30
Aradhya
eae73ae5d4 feat: log reports for queued submits 2022-10-03 17:36:33 +05:30
Aradhya Tripathi
b787a49428
refactor: removed excess checks
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-10-03 13:46:06 +05:30
Aradhya
8b1a01e4b7 refactor: changed field name & removed queueing from save 2022-09-30 19:25:06 +05:30
Aradhya
7ed111aff7 Merge branch 'bg-submissions' of https://github.com/Aradhya-Tripathi/frappe into bg-submissions 2022-09-28 19:00:47 +05:30
Ankush Menat
967cc26fab feat: capture custom values in frappe monitor
lets monitor add extra info for:
- Save/Submit by doctype
- Report generation time by standard report name
2022-09-25 15:07:30 +05:30
Aradhya
f62d1540cf feat: Background submissions for submittable doctypes 2022-09-24 14:00:55 +05:30
Ankush Menat
e9a9496ebc fix: duplicate tracebacks in console 2022-07-04 11:25:47 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Saqib Ansari
a85842b6d1 fix: remove unwanted message 2021-01-12 16:02:15 +05:30
Saqib Ansari
4f5002251d chore: hide 'did not cancel' message if exception is raised 2021-01-12 13:29:33 +05:30
Rushabh Mehta
334ae82e52 fix(naming): added multiple rules for naming series 2020-09-21 10:28:11 +05:30
marination
1c2b06829c fix: Remove unnecessary try catch
- Try catch only caught name errors that handle themselves wherever they occur
- Catching a well handled exception to raise it again is pointless
2020-07-08 12:37:15 +05:30
marination
c2c6d9fa7f fix: Duplicate Name Error Message on saving document 2020-07-03 14:10:44 +05:30
Rushabh Mehta
4c578e8238 fix: dont show double messages 2019-05-04 14:14:56 +05:30
Rushabh Mehta
f72e74d8e8 fix: route history and allow longer energy point reviews 2019-05-02 15:51:57 +05:30
Faris Ansari
ef3a3fce9f
Chart Builder (#5019)
* Chart Builder

- X Axis selectable
- Multiple Y Axes
- Change Chart Type

* minor

* codacy
2018-02-19 11:08:17 +05:30
tundebabzy
6fbe20caaa Except and raise statement python 3 compatible style (#3216)
* changes exception and raise statements to python 3 style

* changes except statement to python 3 style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* adds six.reraise to fix python 3 style raise statements with traceback

* fixes indentation
2017-05-11 10:51:59 +05:30
Rushabh Mehta
7c870d6ba4 [fix] dont update modified timestamp if called from post save methods 2016-07-20 12:55:19 +05:30
Rushabh Mehta
22c3f7966d [enhance] run actions in background doc.queue_action("submit") 2016-07-19 17:12:37 +05:30
Rushabh Mehta
b891f66507 [feature] a better msgprint 2016-06-12 11:02:32 +05:30
Nabin Hait
337c730e34 Set workflow state on cancellation 2015-08-05 14:42:07 +05:30
Rushabh Mehta
eb21f50c0f [cleanup] frappe.get_user() 2015-05-01 10:33:23 +05:30
Anand Doshi
b620cab412 Update recent documents for user 2015-03-04 17:21:09 +05:30
Anand Doshi
2995f02f3b Web Notes to Frappe, better alerts, css fixes, fixed splash 2015-03-03 15:09:34 +05:30