Commit graph

233 commits

Author SHA1 Message Date
Ankush Menat
1a7da4f025
fix: keep setup_complete in sync with rest (#33215)
For backward compatbility of whatever reads System Settings.
2025-07-03 18:19:23 +05:30
Rohit Waghchaure
41c2f49bd1 fix: setup wizard issue 2025-07-01 18:05:36 +05:30
Sagar Vora
b3e1eda4c8
feat: global frappe.in_test flag (#32960)
* feat: global `frappe.in_test` flag

* feat: helper utility to toggle `frappe.in_test`

* fix: use `toggle_test_mode` util

* fix: use `frappe.in_test`

* chore: add comment explaining global `in_test`

* chore: ignore commit replacing flag usage

* test: temporarily disable `frappe.in_test`

this worked earlier because flag was set in werkzeug.local which was separate for API test client

* test: add comment explaining change
2025-06-17 19:19:31 +05:30
rohitwaghchaure
5c6b2b5bec
refactor: track completed app setup wizards and re-run the setup wizard upon new app installation. (#32640) 2025-06-03 12:36:22 +05:30
Ankush Menat
0e1388d90a
Revert "fix: single checkbox to track telemetry & allow recording" (#32749)
This reverts commit 8e7da4cd7e.
2025-06-02 14:05:05 +00:00
Akhil Narang
8d42b4d3d6
Merge pull request #32268 from akhilnarang/drop-example-email-address-creation
fix: don't create example email domains and email accounts
2025-04-29 12:50:29 +05:30
Akhil Narang
39523916d4
fix: don't create example email domains and email accounts
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-04-23 14:53:56 +05:30
Ankush Menat
70e56b2e14
perf: Selectively switch to LIFO ordering when queue is starved (#32226)
When queue is overloaded every job gets delayed by size of the queue,
this means even interactive jobs like prepared reports face significant
wait times.

This flag allows developer to selectively enable LIFO on such jobs where
ordering doesn't matter. Any time we observe queue to be too large,
we'll insert the job at front so it gets highest priority.

This is a common strategy to deal with queue starvation, we are only
applying it explicitly because job execution order matters for
correctness in some cases.
2025-04-23 11:54:21 +05:30
Suhail
d5adcf4323
fix(setup-wizard): fetch translation messages only if language is changed (#32224) 2025-04-21 11:14:19 +00:00
Suhail
f7f408bfd2
fix: selection of timezone after changing the language (#32211)
It works without changing language because the timezone was auto-filled on country selection.
2025-04-19 12:09:14 +00:00
diptanilsaha
79a24c895e fix: language change on setup wizard doesnt load options 2025-04-18 14:43:56 +05:30
Suhail
331c89c505
fix(setup-wizard): create system user on initialising setup data (#32181) 2025-04-17 10:08:20 +00:00
Suhail
dafc73836f
feat: initialise and preload system settings and user for setup wizard (#32108)
used in press to smoothen the signup experience
2025-04-15 18:30:39 +05:30
Ankush Menat
daa52b8802
build!: Drop maxmind IP database (#29213)
1. It's severly outdated and free version isn't that accurate to begin
   with.
2. I replaced country detection using timezone a long time ago: c8ec528aa7/frappe/desk/page/setup_wizard/setup_wizard.js (L664-L676)

This is good enough for setup wizard for most popular countries. Use
IP-API if you need better guarantees (we have a license).
2025-01-17 12:03:09 +05:30
Sanket322
b119513dc1 fix: sanitize user input during setup wizard 2024-12-23 16:32:28 +05:30
mahsem
e8698a98de
fix: add strings and fields to translation 2024-12-21 13:17:01 +01:00
Hussain Nagaria
465793849c fix: store and use default currency from system settings 2024-11-04 16:08:27 +05:30
Akhil Narang
69179e8e94
fix(setup_wizard): update wording for password field for non-admins
It's an optional field because the user already exists, clarify that
that this can just update their password, otherwise the original
password will still work.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-16 11:40:06 +05:30
Akhil Narang
2e3f8ce5af
fix(setup_wizard): don't crash if a country doesn't have a timezone specified
Currently, this event is getting triggered by the country and its translated value
The translated value isn't present in the country info list, and so doesn't have any data

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-11 17:46:35 +05:30
Shariq Ansari
cc5db784f3 fix: boot.default_path is moved to boot.apps_data.default_path 2024-08-30 17:20:36 +05:30
Rushabh Mehta
b31cf8ba79 fix(style): sidebar overlay + polishes 2024-08-23 22:15:35 +05:30
Raffael Meyer
02d8026c1b
fix: mark genders and salutations as translatable (#27462) 2024-08-20 21:11:54 +00:00
Shariq Ansari
67eb28d836 fix: redirect to apps if multiple apps installed or redirect to apps portal 2024-08-08 18:29:16 +05:30
Shariq Ansari
8e7da4cd7e fix: single checkbox to track telemetry & allow recording 2024-08-08 18:29:16 +05:30
RitvikSardana
80c232b1e0 fix: allow guest to check geolocation IP 2024-06-20 14:39:49 +05:30
Raffael Meyer
4a7de16019
fix: don't automatically add system manager (#26540)
* fix: don't automatically add system manager

* feat: remove User.a_system_manager_should_exist

* feat: remove User.add_system_manager_role

* feat: remove User.is_system_manager_disabled

* feat: remove User.get_other_system_managers

* feat: add "System Manager" role to User created by setup wizard
2024-05-24 08:29:30 +00:00
mahsem
424d5e14bc
fix: Add some strings for translation (#26322) 2024-05-04 20:04:18 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Rucha Mahabal
04de8b2271 fix(setup wizard): skip user creation if email is not provided
- user setup slide is not shown if developer mode is enabled
2024-01-23 12:26:43 +05:30
Rucha Mahabal
53c5383f52 chore: silence semgrep warnings for overusing args 2024-01-15 16:02:15 +05:30
Rucha Mahabal
49bbd0d1d7 fix(setup wizard): allow setting user password for an existing user 2024-01-11 14:42:38 +05:30
Ankush Menat
9620a3c596 Merge branch 'develop' into po-translation 2024-01-10 16:17:47 +05:30
Ankush Menat
8a7707e3fa
fix(DX): store tracebacks with context (#24059) 2024-01-01 07:16:47 +00:00
Ankush Menat
1ae79badf7 fix: only set change listener if available 2023-12-28 19:11:12 +05:30
barredterra
3a76fb2253 feat: support CSV and gettext at the same time 2023-12-26 19:13:10 +01:00
barredterra
d384bb4506 Merge remote-tracking branch 'upstream/develop' into po-translation 2023-12-26 16:45:05 +01:00
Shariq Ansari
fc13ff5f29 chore: minor fix 2023-12-23 11:39:39 +05:30
mahsem
551aaafefc
fix: update setup_wizard.py translation (#23583)
* Update setup_wizard.py translation

Import frappe _  and translate some untranslated strings

* style: format

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-04 18:23:09 +05:30
Ankush Menat
91cebdace8 Merge branch 'develop' into po-translation 2023-12-02 19:43:32 +05:30
Ankush Menat
1d5d06e924
Merge pull request #23418 from akhilnarang/return-traceback-for-setupwizard-failure
fix(setup_wizard): don't suppress original exception
2023-11-27 11:51:40 +05:30
Akhil Narang
db3ffaf658
refactor: check for last response error
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 18:25:31 +05:30
Akhil Narang
d48c3f5f60
refactor: return message in response as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 18:25:07 +05:30
Akhil Narang
461f479b45
feat(setup_wizard): store error in error log as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:43:44 +05:30
Akhil Narang
9aec553b89
fix(setup_wizard): sync password character limit with other places (#23419)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:26:34 +05:30
Akhil Narang
838a49ebc2
fix(setup_wizard): don't suppress original exception
Raise it so that the user can know what went wrong

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:13:34 +05:30
barredterra
67404e0cd0 Merge branch 'develop' into po-translation 2023-11-06 19:40:25 +01:00
Ankush Menat
86e4a3a6e1 fix: Respect "Do Not Track" settings
Don't offer telemetry as option if DNT is set in browser.

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/doNotTrack
2023-11-01 15:07:27 +05:30
barredterra
c38ff0e83f feat: optionally use gettext for translation 2023-10-29 15:32:01 +01:00
Bernd Oliver Sünderhauf
67376e26d4
fix: Set system timezone for Administrator and Guest users. (#22440)
* fix: Set system timezone for Administrator and Guest users.

* refactor: use constant instead of duplicating

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 15:26:00 +05:30
Ankush Menat
1b406edd54 feat: Desk User role 2023-08-28 22:31:23 +05:30