vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
50544 commits 1 branch 0 tags 587 MiB
Commit graph

186 commits

Author SHA1 Message Date
Akhil Narang
40e6241c1f
Merge pull request #28786 from gbm001/virtual_custom_link_fields 
fix: Allow cancellation/rename of doctypes linked by a virtual custom field
 2025-08-01 13:44:46 +05:30
sokumon
3827d86f87 fix: more cleanup 2025-04-17 00:26:57 +05:30
Ankush Menat
546260162d perf: Skip link checking on internal deletes 
These are deletes that aren't user triggered and these documents are
typically never "linked" somewhere else. So skip all expensive link /
dynamic link checks.
 2025-01-06 11:48:19 +05:30
Andrew McLeod
4151fccb5c style: ruff formatter style correction 2024-12-16 14:22:59 +00:00
Andrew McLeod
d3a525edb7 fix: Remove unnecessary checks for existing of 'is_virtual' field 2024-12-16 13:52:55 +00:00
Andrew McLeod
9469652fea fix: Allow cancellation/rename of doctypes linked by a virtual custom field 2024-12-16 11:44:10 +00:00
Faris Ansari
f7c005dc09
Merge pull request #28629 from netchampfaris/autoincrement-renaming 
fix: allow renaming autoincrement documents
 2024-12-02 14:25:05 +05:30
Faris Ansari
94b051e05f fix: cast name in UserSettings query 2024-12-02 13:29:36 +05:30
Faris Ansari
46022ff257 chore: formatting 2024-11-30 16:08:10 +05:30
Faris Ansari
e76c33cdbc fix: cast values for renaming autoincrement documents 
- cast `name` values to integer
- cast `link_field` values to string
 2024-11-30 14:59:59 +05:30
Akhil Narang
a70973b0c5
fix(rename): check for permissions for merged document as well 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-11-28 15:59:45 +05:30
Sumit Bhanushali
87ef74bb7e fix(DocRename): on rename ignore link validation when updating values in single doctype 2024-11-22 16:30:32 +05:30
Akhil Narang
97bb23960d
refactor(rename_doc): also set a 10 hour timeout 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-10-24 11:25:41 +05:30
Akhil Narang
d5a73683db
refactor(rename): use long queue by default 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-10-23 17:38:37 +05:30
barredterra
49c66c4d9f feat: redirect to new form if it has been renamed 2024-09-27 18:30:35 +02:00
Akhil Narang
a87de09e79
fix(rename_doc): check permissions for the specific document 
A user can have access to write to a document without having access to the whole doctype

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-09-13 11:16:53 +05:30
Gursheen Anand
8bfb213481 fix: syntax error for link field query 2024-06-25 18:46:41 +05:30
Raffael Meyer
da740081c6
fix: make rename_doc work pre_model_sync (#26419) 2024-05-13 13:32:23 +05:30
Kareem Kouddous
27948bccc7
fix: Renaming when doctype is used as a virtual link docfield fails (#26025) 2024-04-23 11:35:30 +00:00
Ankush Menat
ce124d8ec2
fix: Skip virtual doctype rename for dynamic links (#25479) 2024-03-15 14:01:40 +00:00
Ankush Menat
b28db475fd
fix: Skip virtual doctypes while renaming (#25473) 2024-03-15 18:56:22 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-21 16:20:28 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Ankush Menat
447f02e8d3
fix!: Remove misleading "raise_exception" (#24266) 
frappe.permission.has_permission won't accept raise_exception anymore,
it was extremely misleading argument and actual purpose of the argument
was to print perm check logs.
 2024-01-11 08:24:18 +00:00
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
barredterra
c35476256f refactor: simplify conditional logic 
Command: `sourcery review --fix --enable de-morgan .`
 2023-12-05 11:14:41 +01:00
ruthra kumar
94b2e509b9 fix: dont rename link fields in Virtual doctypes 2023-11-20 10:11:42 +05:30
anandbaburajan
ebccab0652 fix: copy any flags if required in rename_doc() only on validate 2023-11-17 00:32:28 +05:30
Ankush Menat
5fd0dfb163 fix: dont allow rename+merge for case changes 2023-08-29 18:03:16 +05:30
Ankush Menat
94e522185d
fix: configurable rename job queue (#21996) 
This is useful for doctypes like company where very large number of
documents will be affected on a large DB.

original change:

fix: move rename enqueue action to long queue

When trying to rename company the job constantly fails.

possibly alternate fix to https://github.com/frappe/frappe/pull/21995

Job timed out because of 300 seconds timeout, no amount of optimization
will fix this because it's rewriting practically every row in
transactions.
 2023-08-10 10:02:16 +05:30
gavin
05893bef42
fix: Rename document/update title via toolbar (update_document_title API) (#21404) 
* fix: update_document_title

* Fix broken socket event
* Fix broken title + name doc update

* fix: if only title updated then dont enqueue

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-06-21 15:46:09 +05:30
Ankush Menat
3005e66e45 refactor!: Drop previously deprecated code 2023-06-13 16:00:43 +05:30
Ankush Menat
45c86e2ff8
fix: nestedset rename (#20498) 2023-03-29 12:49:28 +05:30
Ankush Menat
07529ff1c3
fix: Consider parenttype when renaming (#19901) 2023-02-02 17:05:44 +05:30
Saqib Ansari
f6677125d3
fix: do not rename select field options and values on doctype rename (#19223) 2022-12-09 16:36:58 +05:30
Saqib Ansari
6997f9e90f
fix: do not rename fieldtype options (#18143) 2022-09-15 17:30:52 +05:30
Sagar Vora
63e760e3ad chore: remove old code where User Permissions were set in tabDefaultValue 2022-08-22 19:03:30 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all 
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
 2022-08-22 11:35:14 +05:30
Gavin D'souza
71b5c77e6e Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor 2022-07-05 14:55:02 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367) 
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
 2022-07-01 11:51:05 +05:30
Gavin D'souza
25b87a9d49 chore: NoneType alias for < PY310 2022-06-16 15:04:35 +05:30
Ankush Menat
c31eca3ba5
fix: circular imports (#16830) 
Circular imports issue when loading modules in background worker. Doesn't happen in web worker or console 🤷
 2022-05-04 19:09:53 +05:30
Gavin D'souza
6cdd33f26b fix: Generate hash of length 8 for save point 2022-04-20 16:41:25 +05:30
Gavin D'souza
66655eb8ed Merge branch 'develop' of github.com:frappe/frappe into bg-rename_doc 2022-04-14 13:41:56 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453) 
Co-authored-by: Frappe Bot <developers@frappe.io>
 2022-04-12 10:59:25 +05:30
Gavin D'souza
28f9802fd9 fix: rollback to savepoint to avoid partial commits 
It's better to keep the validations in and out AND separate...this is a
humble attempt for the same :)
 2022-03-28 18:47:26 +05:30
Gavin D'souza
f92f77dab7 fix(qb): Make Table importable 2022-03-22 20:31:37 +05:30
Gavin D'souza
3351cc9c80 refactor(rename_doc): Use QB notation inplace of raw SQLs 
* Converted ~22 queries from raw SQL to use frappe.qb notation
* Made queries DRY-er
 2022-03-22 20:31:10 +05:30
Gavin D'souza
1cb956d835 fix(rename_doc): Use sbool instead of cint 
cint("false") returns True which is what is sent by frappe dialog. This
may be required to be fixed in the client alone but making this change
to make the API more "robust" as this has been working in this
particular way for far too long now :')
 2022-03-22 17:33:51 +05:30