Commit graph

1460 commits

Author SHA1 Message Date
Akhil Narang
0cd2f9ef05
fix: jinja template had missing }} (#33541)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-08-05 11:56:33 +00:00
Elton Lobo
6d1008933f
feat: add user invitation doctype & related public methods (#33308)
* feat: add user invitation doctype & related public methods

* style(user-invitation): execute formatters & add semgrep comments

* refactor(user-invitation): use `is` to compare `None` values

* fix(user-invitation): skip fetching `after_accept` for default app

* fix(user-invitation): translate email templates

* fix(user-invitaton): return pending invites from invite by email api

* refactor(user-invitation): improve code quality

* fix(user-invitation): translate all error messages

* refactor(user-invitation): improve security & readability

Improvements:
- move invite expiration check to `daily_maintenance`
- explicitly import all of the used packages
- specify methods for all security-critical endpoints
- improve error messages and give them suitable titles
- remove unnecessary utility functions
- make invitation key management secure
- translate all of the subjects of the sent emails
- use the `app_title` hook to create email titles
- commit the work done after each iteration of the background invitation
  expiry checker
- restructure code to improve readability
- use `user.reset_password` to generate the target link
- use clear long names to name identifiers
- add document states with relevant colors (User Invitation doctype)
- differ `sendmail` emails whenever possible
- send an email to the invitation creator instead of the invitee after
  the invite has expired
- remove `User Invitation Manager` role

* fix(user-invitation): use valid emails to test doctype & related code

* feat(user-invitation): support adding multiple roles

* refactor(user-invitation): mark relevant fields `set only once`

* feat(user-invitation): add `Cancelled` status

* test(user-invitation): correct broken tests

* test(user-invitation): form valid f-strings & run code formatter

* feat(user-invitation): make doctype usable from desk

* fix(user-invitation): remove delete permission from invitation doctype

* feat(user-invitation): pass user inserted info to `after_accept` hook

* refactor(user-invitation): improve custom action methods & errors

Improvements:
- trigger actions only when the invitation is in the `Pending` state
- use lowercase letters to start error messages
- handle cases where `user_invitation_hook` is not defined

* refactor(user-invitation): remove site name from email templates

* docs(user-invitation): add internal documentation

* feat(user-invitation): add 'get pending' & cancel invites apis

* fix(user-invitation): make invitation app specific

* refactor(user-invitation): avoid mixing function programming

* fix(user-invitation): make apis usable for app specific valid users

* fix(user-invitation): allow app specific invites

* feat(user-invitation): make list view & permission checks app specific

* refactor(user-invitation): convert class methods to static when possible

* feat(user-invitation): add `app_only_for` method to the doc

* fix(user-invitation): f-string syntax error in `get_permission_query_conditions`

* docs(user-invitation): add examples & improve the internal doc

* refactor: rename method name

static_ is unnecessary
only_for doesn't make sense in this context when arguments are not roles

* fix: Support POST request too

We dont follow REST semantics 100%, anything that modifies something
should ideally be doable with POST too.

* chore: cap

* fix: Avoid ignore_permissions as user arg

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2025-07-28 16:25:53 +05:30
Soham Kulkarni
64db88228f
refactor: seperate blogs into a seperate app (#32737)
* fix: remove doctypes,workspace blocks, files

* fix: minor python tests and UI tests

* fix: remove blog post from tests

* fix: remove blogger as role for tests

* fix: add check for if doctype exists

* fix: ui test

* fix: more cleanup

* fix: cleanup comments and fix test_query

* fix: resolve conflicts

* fix: add warning and handle comments
2025-07-28 14:35:02 +05:30
Ernesto Ruiz
57067b9af7
chore: add translation function to file_backup_notification template (#33231) 2025-07-07 11:28:05 +05:30
Vishal Sindham
e1217282ac feat(password-reset-form): Add show/hide toggle option to password reset form 2025-06-29 19:47:02 +05:30
Soham Kulkarni
e1aa789acf
Merge pull request #32971 from sokumon/newsletter-removal
refactor: seperate newsletter into app
2025-06-27 11:59:02 +05:30
Sagar Vora
2e5c8bea03 feat: frappe.utils.orjson_dumps 2025-06-26 17:37:51 +05:30
sokumon
32a87f53d6 fix: delete newsletter related files 2025-06-18 16:23:36 +05:30
Corentin Forler
26b279864f
fix: Fix link in delete data confirmation email template (#32544) 2025-05-16 10:00:20 +05:30
Corentin Forler
35d557f46d
chore: remove empty template (#32543) 2025-05-16 09:58:45 +05:30
Ankush Menat
66e91445f5 fix: remove eps template 2025-04-23 12:05:01 +05:30
Ejaaz Khan
ed6dd8cd5b fix: print builder beta print option not working 2025-04-14 11:32:44 +05:30
marination
4dcd579b47 fix: Translate Footer Items 2025-02-25 13:22:57 +01:00
Ejaaz Khan
2fb0629197
fix: alignment Issues with Serial Numbers and Descriptions (#29093)
* fix: serial numbers not aligned with other cells

* refactor: remove top margin from editor
2025-01-13 11:50:01 +05:30
Ejaaz Khan
93c33de489 fix: splash logo is not rendering properly 2025-01-09 16:24:04 +05:30
mahsem
e8698a98de
fix: add strings and fields to translation 2024-12-21 13:17:01 +01:00
Akhil Narang
4509e75179
fix: convert frappe.boot to JSON properly
We have `frappe.as_json` set as the jinja filter for json

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-12-13 11:45:57 +05:30
Faris Ansari
4eafaea3e7 fix: remove text align justify from newsletter 2024-12-09 16:59:33 +05:30
Suraj Shetty
def2874e0a
Merge pull request #28012 from dhiashalabi/fix/rtl-lang-support 2024-11-05 10:47:58 +05:30
Rushabh Mehta
cef8c12ee4 fix(style): fix oauth authorisation page and standardise error responses 2024-10-24 15:21:34 +05:30
Corentin Forler
78fbd39b2a
fix: Translate OAuth confirmation details 2024-10-16 12:32:49 +02:00
DHia' SHalabi
71e99a1729 fix: add dynamic RTL support to the base template 2024-10-07 17:07:03 +03:00
Akhil Narang
7b0c4f495c
Merge pull request #27818 from cogk/feat-add-hide-label-checkbox-on-print-format
feat(print_format): Add checkbox to hide label
2024-10-01 16:30:13 +05:30
Akhil Narang
f4ca408376
Merge pull request #27817 from cogk/fix-labels-for-text-editor-fields
fix(print)!: Add labels on Text Editor fields
2024-10-01 16:29:59 +05:30
Rushabh Mehta
30cef42d8f
Merge pull request #27898 from rmehta/fix-error-not-found
fix(style): update error, not found pages
2024-09-25 16:46:35 +05:30
Rushabh Mehta
23f52c1720 fix(style): update error, not found pages 2024-09-25 15:46:24 +05:30
P-Godfroid
2349221255
fix(translation): search placeholders (#27812)
* Translatable placeholder

* Translatable Search word.html

* " instead of ' for commiter tool.js

* Cleaner way to translate.js

* So the issue was prettier.js

* Style : prettier.js

* style(translation): line break removed from string
2024-09-24 10:57:40 +05:30
Rushabh Mehta
70c98abc84 fix(minor): only select public workspaces by default 2024-09-23 16:53:31 +05:30
Rushabh Mehta
f88c508c23 fix(style): Update icons, new design for /me 2024-09-18 14:27:37 +05:30
Corentin Forler
1210ab33dc
feat(print_format): Add checkbox to hide label 2024-09-18 10:16:37 +02:00
Corentin Forler
0e5af04c10
fix(print)!: Re-add labels on Text Editor fields 2024-09-18 10:13:33 +02:00
Rushabh Mehta
c2652fed39 fix(minor): page creation 2024-09-06 14:12:34 +05:30
Shariq Ansari
03986075d2 fix: login page route fix 2024-08-13 12:40:08 +05:30
Shariq Ansari
5a668acb03 fix: do not show Apps option for website user in /me page 2024-08-08 18:29:16 +05:30
Shariq Ansari
a568017335 fix: include apps link in navbar in login screen 2024-08-02 20:12:22 +05:30
Rushabh Mehta
f179a1286f
Merge pull request #26748 from blaggacao/perf/smaller-website-body
perf: significantly smaller website body
2024-07-18 07:33:56 +05:30
Gursheen Kaur Anand
5a1d670f0b
Merge pull request #27084 from GursheenK/2FA-email-verification
fix: send 2FA OTP email synchronously
2024-07-16 16:34:47 +05:30
Gursheen Anand
3491f9d88a chore: add warning for workflow actions email 2024-07-15 20:21:22 +05:30
Gursheen Anand
fd3502f8f4 fix: send 2FA OTP email synchronously 2024-07-12 12:50:21 +05:30
mahsem
d9d9f33594 fix: translation in breadcrumbs.html
fix: translation in breadcrumbs.html
2024-07-11 12:00:16 +00:00
Maharshi Patel
82a86fd046 fix: check image before trying to load in print. 2024-07-08 13:45:23 +05:30
mahsem
52b562a7e0
fix: make web sidebar translatable (#26921) 2024-07-01 19:02:04 +02:00
barredterra
d908271da3 refactor(web list): use CSS class d-none instead of hidden
`hidden` is just a wrapper for `d-none`, but `d-none` will work even if the wrapper is not availbale (for example, using a custom app's CSS).
2024-06-19 00:43:42 +02:00
David
e2517d11e8
chore: add include_icons jinja global 2024-06-11 20:03:15 +02:00
David
37d8e2bb36
perf: lazy load svg sprictes on websites 2024-06-11 20:01:55 +02:00
Ankush Menat
737628734d
fix: signup routing (#26685)
closes https://github.com/frappe/frappe/issues/26683
2024-06-05 07:23:47 +00:00
Ankush Menat
1eab8c2f51
refactor!: Drop v1 style routing (using #) (#26626) 2024-05-31 15:21:02 +05:30
barredterra
33d59d6e58 fix: compute modal title server side 2024-04-26 17:41:00 +02:00
Rutwik Hiwalkar
a73e65581d
fix: disabled user login from login via link feature (#26134)
* fix(ui): button color for login via link template

- blue > black

* fix: restrict login via link for disabled users

* fix: validate user on session.resume
2024-04-24 15:49:17 +05:30
Ankush Menat
83eadd7257
Merge pull request #25677 from barredterra/in-context-translation
feat: In-Context Translation
2024-03-27 20:42:07 +05:30