Commit graph

6198 commits

Author SHA1 Message Date
Akhil Narang
36ccf32ab3
fix: don't try to scan encrypted PDFs
Also fix reversed logic of JS check

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-10 15:44:09 +05:30
Corentin Forler
64aa4787be
fix: Don't check PDF content if not defined (#33914) 2025-09-09 15:29:57 +05:30
Rahul Agrawal
c52e5157b4
feat: allow users to export report in background (#33861)
* feat: allow users to email prepared report

* fix: add export in background checkbox in export dialog

* chore: use a common function to send report email

* feat: delete generated files from system after user defined duration

* feat: add exported reports in a folder and periodically clean it

* test: add test for export via report

* fix: add exported folder path as constant

* chore: un-edit report.json

* refactor: for readability

* chore: type hint

* refactor: let the BG job fail if email fails

* refactor: consistent `report_name`

* it reads better now, e.g. attached_to_name=report_name instead of attached_to_name=title

* refactor: `return_file` to its inverse `populate_response`

* chore: more specific error message

---------

Co-authored-by: Rahul Agrawal <deathstarconsole@Rahuls-MacBook-Air.local>
Co-authored-by: Hussain Nagaria <hussainbhaitech@gmail.com>
2025-09-05 14:34:55 +00:00
Akhil Narang
60b2d92af8
fix(data_import): set payload count from existing importer
Don't create a new one, especially one that doesn't have all parameters (main issue here: console=False)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-03 17:56:41 +05:30
Akhil Narang
7ad1378d00
Merge pull request #33772 from erjeve/fix-data-import-payload-count
fix: initialize payload_count in import_file function
2025-09-03 17:10:10 +05:30
Hussain Nagaria
dcbc397400
fix: comparison accuracy 2025-09-03 11:33:53 +05:30
Rahul Agrawal
de1249ecec refactor: extract expression into separate variable 2025-09-03 11:28:46 +05:30
Rahul Agrawal
c4c151ed9b chore: update field name 2025-09-03 10:57:37 +05:30
Rahul Agrawal
4829b50a8b feat: allow users to define max signups per hour 2025-09-03 10:36:27 +05:30
Raffael Meyer
cc82ab19ab
feat: syntax highlighting in field description (#33791) 2025-09-03 03:21:34 +02:00
Soham Kulkarni
b7129419ef
Merge pull request #33675 from sokumon/pdf-issue
fix: scan pdfs before uploading
2025-09-02 18:41:13 +05:30
Akhil Narang
629211f059
fix(server_script): check for type being scheduler AND frequency being cron to show cron field (#33872)
Resolves #33847

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-02 18:03:31 +05:30
Akhil Narang
bd05f6a7b7
Merge pull request #33534 from AMR-Mannesmann/develop
fix: resolve issue in validate_user_pass_login frappe#33528
2025-09-01 19:17:06 +05:30
mergify[bot]
c7ba132315
Merge branch 'develop' into drive-integration 2025-09-01 06:14:16 +00:00
Raffael Meyer
6aed5b91d3
feat!: remove the "Transaction Log" DocType and a related report (#33844) 2025-08-31 20:02:43 +02:00
sokumon
fd29103149 fix: make the checking more robust 2025-08-29 13:13:19 +05:30
sokumon
bbc093640b fix: better message 2025-08-29 13:13:19 +05:30
sokumon
ca5831b1a8 fix: better function name, check before writing the file 2025-08-29 13:13:19 +05:30
sokumon
577ba89c28 fix(XSS): verify pdf content before uploading 2025-08-29 13:13:19 +05:30
Hussain Nagaria
85768a2eb0
fix: don't show filters and columns for Report Builder reports (#33825) 2025-08-29 10:49:01 +05:30
Akhil Narang
719af6e722
Merge pull request #33815 from raizasafeel/fix/translation-trailing-spaces
fix: remove trailing spaces in translatable strings
2025-08-28 16:31:45 +05:30
Ejaaz Khan
86c719ec6d
Merge pull request #33809 from mihir-kandoi/33758
feat: enable non negative validation for Percent type fields
2025-08-28 15:06:48 +05:30
Elton Lobo
d930335161
fix: role based invite restriction (#33806)
* refactor(user-invitation): validate invite role based on user's roles

* refactor(user-invitation): start error msgs with a capital letter

* docs(user-invitation): update the hooks structure
2025-08-28 12:02:54 +05:30
Raizaaa
aa3bb0e4d7 fix: remove trailing spaces in translatable strings 2025-08-27 13:23:17 +03:00
Mihir Kandoi
c24bda0481 feat: enable non negative validation for Percent type fields 2025-08-26 22:12:23 +05:30
Rohit Waghchaure
ac4272b510 fix: setup complete issue 2025-08-25 17:35:33 +05:30
Safwan Samsudeen
03bff35b5e chore: pre-commit 2025-08-25 13:23:32 +05:30
Safwan Samsudeen
6131aa63fd fix: allow all internal urls 2025-08-25 11:00:55 +05:30
Rob Visser
7b8b486109 fix: initialize payload_count in import_file function
- Fixes TypeError when using bench data-import command
- Adds missing reference_doctype and import_file initialization
- Calls set_payload_count() before creating Importer
- Resolves: '<' not supported between instances of 'int' and 'NoneType'

The import_file() function was creating a Data Import document
without initializing required fields, causing payload_count to be None
and failing comparison in importer.py line 117.

Tested on Frappe v16 - bug persists from v15.x series.
2025-08-23 16:54:10 +00:00
Safwan Samsudeen
adc477f255 feat: tweak to allow drive links 2025-08-22 14:54:24 +05:30
Rohit Waghchaure
6d1517e7fb fix: only consider the Frappe and ERPNext apps for setup completion checks
(cherry picked from commit d5e1bf06b2b42cea72ee827582831e79edefee66)

# Conflicts:
#	frappe/__init__.py
2025-08-20 10:53:32 +00:00
Saqib Ansari
352173f922
fix: setup completion logic for insights (#33677)
* insights doesn't have setup slides, so installing insights after framework setup is complete, breaks the setup wizard page
2025-08-20 14:35:25 +05:30
Akhil Narang
7c0500f560
Merge pull request #33657 from Rl0007/fix/module-profile-sync
fix: sync user block_modules on update
2025-08-19 15:03:32 +05:30
Bhushan Barbuddhe
70dc9b83ab
refactor(hook): Execute send_sms hooks before receiver_list validation (#33649)
* feat: add hook for custom SMS OTP sender (mobile_otp_sms_sender) in 2FA

* [ADD]: Hooks for send SMS

* [fix]: Hook changed to send token.

* chore: remove unnecessary comment

* refactor(hook): Execute send_sms hooks before receiver_list validation
2025-08-18 13:53:01 +05:30
Rahul Agrawal
71a8a6f7c1 test: remove unneccssary if condition 2025-08-17 13:25:50 +05:30
Rahul Agrawal
8d04ecba9e ci: add unit tests 2025-08-17 10:29:10 +05:30
Rahul Agrawal
2dcee71150 fix: remove unneccssary condition 2025-08-16 13:41:04 +05:30
Rahul Agrawal
7166caf9be fix: disable module checkbox if module profile is selected 2025-08-16 13:36:48 +05:30
Rahul Agrawal
f711e52fc9 fix: sync user block_modules on update 2025-08-16 09:20:01 +05:30
Elton Lobo
86e38ecade
fix: invitation user relation (#33603)
* fix(user-invitation): unlink user from invitations on delete

* fix(user-invitation): disallow inviting disabled users

* style(user-invitation): format code

* test(user-invitation): correct tests after invitation user relation fix

* test(user-invitation): add invite by email api's disabled user test

* docs(user-invitation): mention disabled users processing

* refactor(user-invitation): add `User invitation` doctype to `ignore_links_on_delete`

* Revert "refactor(user-invitation): add `User invitation` doctype to `ignore_links_on_delete`"

This reverts commit a70e4800c8182ea562b28a65239c82e1bed5e612.
2025-08-14 16:26:23 +05:30
Hussain Nagaria
6e880bdcfe
fix: version diff for empty datetime fields (#33605)
* fix: version diff for empty datetime fields

* fix: remove debug print
2025-08-11 11:49:21 +00:00
Hussain Nagaria
fd2068b6e1
fix: show null as string if value is null (#33577)
* fix: show `null` as string if value is null

* refactor: DRY up formatting
2025-08-08 07:46:37 +00:00
Hussain Nagaria
873d020ced
Merge pull request #32638 from Abdeali099/new-ui-for-api-key 2025-08-05 14:07:36 +05:30
Hussain Nagaria
ee43c1b063
fix: improve copy for token based auth docs link
Co-authored-by: Ejaaz Khan <67804911+iamejaaz@users.noreply.github.com>
2025-08-05 12:24:46 +05:30
Hussain Nagaria
7070eeb8c8
fix: improve warning message copy
Co-authored-by: Ejaaz Khan <67804911+iamejaaz@users.noreply.github.com>
2025-08-05 12:24:14 +05:30
DanielRadlAMR
e7c9b02a22 fix: resolve issue in validate_user_pass_login #33528 2025-08-04 17:38:51 +02:00
Hussain Nagaria
ec6460924d chore: UI cleanup 2025-08-01 16:45:23 +05:30
Bhushan Barbuddhe
7df795cf99
feat: Add hooks for custom SMS and OTP SMS sending (#33444)
* feat: add hook for custom SMS OTP sender (mobile_otp_sms_sender) in 2FA

* [ADD]: Hooks for send SMS

* [fix]: Hook changed to send token.

* chore: remove unnecessary comment
2025-07-30 16:47:12 +05:30
RitvikSardana
7b71c3aeb7
Merge pull request #33389 from RitvikSardana/auto-append-email-account
feat: Auto append email account name to 'append_to' doctype
2025-07-29 13:03:48 +05:30
Ayush Chaudhari
761751f269
feat: App-Defined Workflow Tasks and Server Scripts on Transition (#33255)
* feat: add workflow task doctypes

* chore: add Workflow Task to Script Type of Server Scripts

* chore: add description for Workflow Tasks

* feat: fetch dotted paths and corresponding names from hooks

* fix: use Select field instead of Autocomplete

* feat: execute tasks in the background on state transition

* fix: throw error when task not found

* fix: naming for transition task set by user

* fix: child table views

* feat: support for server scripts

* chore: comments and description

* fix: change the casing of docevent options

* fix: change test casing

* feat: Add Workflow Transition field to webhooks

* fix: temporarily remove filter

* feat: add webhooks as workflow actions

* test: test execution of synchronous app-defined methods and server scripts

* chore: shorten the description and change the fieldname of the field 'execute_asynchronously' to 'asynchronous'

* test: server script executipn

* fix: add field to UI

* test: change customer to domain

* test: change Customer to Domain

* fix: patch for change in webhook fields

* chore: fetch only used fields in get_all

* fix: don't run test logic in application code 🙂

* test: separate tests for workflow tasks

* Revert "fix: patch for change in webhook fields"

This reverts commit 2e9c51c43ca2b3698991fbe75cc4032368ab174c.

* chore: break into smaller functions

* test: webhooks with workflow tasks

isolate mock responses to test_sync_tasks

* Revert "fix: change test casing"

This reverts commit e2bad96ed01dea0a26d002ea44a1e0175525ed31.

* Revert "fix: change the casing of docevent options"

This reverts commit ddfc81bf775fad74225f25815b8e3e7b255dc9eb.

* fix: webhook casing

* fix: type hint for doc
2025-07-29 11:01:44 +05:30