Gavin D'souza
c00a5003f4
refactor(tests): frappe.db.delete > frappe.db.sql
...
Use frappe.db.delete wherever possible. Get rid of all the frappe.db.sql
;)
This commit focuses on the frappe.tests module
2021-08-19 19:48:42 +05:30
mergify[bot]
4cbf2c40e6
Merge pull request #13958 from ankush/pw_reset
...
fix: broken template in password reset
2021-08-19 12:46:29 +00:00
mergify[bot]
53e2c21a6a
Merge pull request #13915 from gavindsouza/newsletter-refactor
...
refactor(minor): Newsletter
2021-08-19 12:35:52 +00:00
mergify[bot]
eb218a06d1
Merge pull request #13959 from mituldavid/testing-library
...
test: Add support for Testing-Library queries within Cypress tests
2021-08-19 04:51:56 +00:00
MitulDavid
29dfffb9c5
refactor: Replace .format() with f-strings
2021-08-18 19:32:16 +05:30
MitulDavid
93198b7123
test: Replace existing queries with Testing-Library queries
2021-08-18 19:11:01 +05:30
Shariq Ansari
3baa33d5da
fix: Use IP Address instead of Email field ( #13553 )
2021-08-18 13:21:10 +05:30
Rushabh Mehta
cf67f9d283
fix(minor): remove url from metatags
2021-08-18 12:01:44 +05:30
Leela vadlamudi
d3bc38f5aa
Merge pull request #13961 from leela/fix-amend-patch-query
...
fix: rename cancelled docs patch query
2021-08-17 23:49:31 +05:30
leela
05166f919c
fix: rename cancelled docs patch query
...
use backquotes in queries where column names are dynamic(To avoid query
issues incase reserved keywords used as a table columns.)
2021-08-17 22:48:52 +05:30
MitulDavid
b417218f1d
test: Add support for Testing-Library queries within Cypress tests
2021-08-17 19:06:01 +05:30
Ankush Menat
d41121643e
fix: broken template in password reset
2021-08-17 15:59:12 +05:30
Suraj Shetty
54a331a05e
Merge pull request #13952 from shariquerik/workspace2-fixes
2021-08-17 15:04:28 +05:30
shariquerik
e401366cf9
test: Renamed changed values
2021-08-17 12:12:46 +05:30
shariquerik
013f1f471d
fix: Switch Public-Private, Change Customize to Edit, Add Settings button to redirect to workspace document
2021-08-17 11:11:15 +05:30
shariquerik
0215bd06ec
fix: Make Shortcut's & Card's default size col-4
2021-08-17 11:09:22 +05:30
shariquerik
9b15009e7a
fix: Enable paragraph text styling (Bold, Italic, link)
2021-08-17 11:08:35 +05:30
gavin
fb5b474f3a
Merge pull request #13946 from scdanieli/fix-broken-link
...
fix: broken link
2021-08-17 10:37:55 +05:30
Gavin D'souza
87f05c2e6b
ci: Handle payload elements as not set/None
...
alt motive: Re-trigger GHAs that have been showing waiting for too
long ;)
2021-08-17 09:57:32 +05:30
Samuel Danieli
1e38d5a281
fix: broken link
2021-08-16 18:55:09 +02:00
rohitwaghchaure
1ae57811b4
Merge pull request #13939 from rohitwaghchaure/perf-grid-rendering-debouned-refersh
...
perf: Grid rendering
2021-08-15 11:35:01 +05:30
Rohit Waghchaure
4312d15f57
perf: Grid rendering
2021-08-14 19:35:36 +05:30
Ankush Menat
ead26527b7
ci: ignore js only changes while running unittests ( #13932 )
...
* ci: ignore js only changes while running unittests
- IF PR only changes JS files then unittests / patch tests wont run.
- Change done to save resources / concurrent builds.
* ci: ignore md files in build
2021-08-13 18:14:47 +05:30
Suraj Shetty
b75691d7db
Merge pull request #13935 from frappe/mergify/surajshetty3416/config-update
2021-08-13 18:02:36 +05:30
Suraj Shetty
ccebece486
ci(Mergify): configuration update
...
Signed-off-by: Suraj Shetty <null>
2021-08-13 17:37:20 +05:30
Gavin D'souza
6feae59b20
fix: Hanlde Newsletter.get_email_groups & tests cleanup
2021-08-13 17:23:01 +05:30
Gavin D'souza
f2641c37f2
test: Delete newsletters and email docs created in test
2021-08-13 13:04:52 +05:30
Gavin D'souza
cefa75c8dc
test: Setup email group at the start of testcase
2021-08-13 12:44:25 +05:30
mergify[bot]
bd6ed2033f
Merge pull request #13152 from shariquerik/wiki-based-desk
...
feat: Workspace 2.0
2021-08-13 06:44:32 +00:00
mergify[bot]
c6f1f91668
Merge pull request #13926 from rohitwaghchaure/fixed-grid-performance-issue
...
perf: Grid rendering
2021-08-13 06:08:13 +00:00
mergify[bot]
b6945a374a
Merge pull request #13841 from gavindsouza/execute-query
...
feat: Execute queries directly in frappe.qb
2021-08-13 06:08:07 +00:00
Rohit Waghchaure
e63222cc9a
fix: grid frozen issue
2021-08-13 11:11:15 +05:30
Suraj Shetty
66924817ca
Merge pull request #13909 from frappe/dependabot/npm_and_yarn/path-parse-1.0.7
...
chore(deps): bump path-parse from 1.0.6 to 1.0.7
2021-08-13 09:45:20 +05:30
shariquerik
bdad9e8751
test: focus and type error fix
2021-08-12 21:02:32 +05:30
shariquerik
d3e7f0ac36
test: minor fix
2021-08-12 20:30:15 +05:30
shariquerik
0ada551207
fix: Removed build.json, changed patch to v14
2021-08-12 19:52:28 +05:30
Gavin D'souza
bf14e1f2b1
test: Add test for patch_query_execute
2021-08-12 18:37:05 +05:30
Gavin D'souza
30cf8fd58d
refactor: Use run instead of frappe.db.sql
2021-08-12 18:36:43 +05:30
mergify[bot]
29b222105b
Merge pull request #13850 from kevinpthorne/fix-inner-btn-menu-item
...
fix(deskUI): menu items reappear before inner page buttons disappear
2021-08-12 12:38:58 +00:00
Gavin D'souza
189f9f81ae
fix(Newsletter): Remove "double" validations
...
Validations for checking recipients and statuses were being checked again later on, via validate_send. This gets rid of doing it twice
2021-08-12 17:47:38 +05:30
Gavin D'souza
8fc2577e9a
fix: Remove cross import statements
2021-08-12 17:44:14 +05:30
shariquerik
e4e79dd424
test: minor fix
2021-08-12 17:41:53 +05:30
Gavin D'souza
233b42b945
Merge branch 'develop' of github.com:frappe/frappe into execute-query
2021-08-12 17:35:25 +05:30
Gavin D'souza
43b9b452ff
fix: Don't clear Newsletter table at setupClass
2021-08-12 17:30:23 +05:30
mergify[bot]
3dc9dfe0c7
Merge pull request #13842 from netchampfaris/safe-render-off
...
fix: ability to disable safe_render for template pages
2021-08-12 11:54:32 +00:00
Gavin D'souza
d5739cd43b
fix: Add exceptions classes for Newsletter
2021-08-12 16:47:01 +05:30
Gavin D'souza
1015283731
fix(global_search): Typecast variable for comparision
...
Previously start was being type casted with int. That was reverted by refactoring query to use new Query Builder
This bug was introduced via ee3c84beef
2021-08-12 16:23:40 +05:30
Gavin D'souza
a5010af92a
test: Update tests for Newsletter
...
Added tests for better coverage: Increased to 77% ~ near complete
coverage of controller class, missing tests for API endpoints
2021-08-12 16:17:31 +05:30
Gavin D'souza
c5eb78edd7
refactor: Simplify validations, fix test_send
2021-08-12 16:12:04 +05:30
shariquerik
fa53d7473e
fix: Updated Public Page edit restriction message for user without access
2021-08-12 15:55:34 +05:30