vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
37562 commits 1 branch 0 tags 587 MiB
Commit graph

37562 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gavin D'souza
c28fa39d1d refactor: frappe.desk.form.utils.add_comment 
* Check read permission for reference document before allowing to drop a
  comment: if you can't see the document, should you be able to link a
  documnet to it? i think not
* Simplify logic + add type hints
* Delegate serialization to the API layer; return Comment object instead
 2022-04-18 12:36:01 +05:30
Gavin D'souza
42a020978d refactor(minor): frappe.client.attach_file 
* Use standard doc.check_permission instead
* Don't re-check for http method type inside API
* Cleanup variable naming
* Return file object - let the API layer manage marshalling /
  serialization
 2022-04-18 12:04:02 +05:30
Gavin D'souza
801874154d fix: Add return value for doc.delete 2022-04-18 12:02:19 +05:30
Gavin D'souza
f801fee8f3 style: Run pre-commit linters 2022-04-13 10:55:35 +05:30
Gavin D'souza
97e911e069 Merge branch 'develop' of github.com:frappe/frappe into refactor-file 2022-04-13 10:49:26 +05:30
gavin
0ef7e99062
Merge pull request #16596 from gavindsouza/test-nestedset 
test: Added TestCase for NestedSet (Tree DocTypes)
 2022-04-13 00:31:56 +05:30
Gavin D'souza
70a8a49c9c fix: new_doctype API testing util 
Use kwargs instead of mapping defined kwargs to single actions
 2022-04-12 19:06:35 +05:30
Gavin D'souza
dfadf42d87 test: Added tests for nestedset 2022-04-12 19:06:01 +05:30
Gavin D'souza
20742e396f Merge branch 'develop' of github.com:frappe/frappe into test-nestedset 2022-04-12 18:09:22 +05:30
Gavin D'souza
01e101d4b8 chore: Add typing and and style conflicts 2022-04-12 15:40:37 +05:30
mergify[bot]
fcb86d7f96
Merge pull request #16559 from frappe/sitemap-publish-condition 
fix: sitemap condition
 2022-04-12 08:06:02 +00:00
Ankush Menat
3fb1eaf13b
perf: dont query for impossible child/ancestor (#16577) 
Also avoid manual plucking
 2022-04-12 13:31:57 +05:30
Gavin D'souza
de0614aaaa Merge branch 'develop' of github.com:frappe/frappe into sitemap-publish-condition 2022-04-12 13:21:21 +05:30
Gavin D'souza
93ee8b2e38 refactor(minor): Sitemap 2022-04-12 13:19:33 +05:30
mergify[bot]
0ed9440653
Merge pull request #16590 from nabinhait/ignore-permlevel-for-fields 
feat: Ignore permlevel for specific fields
 2022-04-12 07:39:04 +00:00
Suraj Shetty
278204eeca
Merge branch 'develop' into ignore-permlevel-for-fields 2022-04-12 12:49:22 +05:30
gavin
b15e174c87
Merge pull request #16511 from gavindsouza/deferred_insert-refactor 
refactor: Deferred insert
 2022-04-12 12:43:17 +05:30
gavin
18108eef65
fix(desk): Use Int control for Long Int (#16572) 
Type `Long Int` doesn't have a JS control, we can use the Int's instead. Prior to this, forms of DocTypes with Long Int fields would just not render :trollface: 

<img width="1440" alt="Screenshot 2022-04-11 at 3 36 40 PM" src="https://user-images.githubusercontent.com/36654812/162716347-c924775c-50ee-4e8c-8627-21c178f4e221.png">
 2022-04-12 06:59:05 +00:00
Gavin D'souza
a0bdf499b5 style: Resolve conflicts with linters post codebase format 2022-04-12 12:26:36 +05:30
Nabin Hait
b4476e0257 feat: Ignore permlevel for specific fields 2022-04-12 12:24:23 +05:30
Gavin D'souza
88e53556b0 Merge branch 'develop' of github.com:frappe/frappe into deferred_insert-refactor 2022-04-12 12:23:55 +05:30
Gavin D'souza
f6c879ab1d refactor: Route History 
* Use newer deferred_insert APIs
* Refactor query to use QB notation
* Styled with black-ish
 2022-04-12 12:14:51 +05:30
Ankush Menat
da5a5eda02
fix: incorrect type in make_property_setter query (#16584) 
* fix: incorrect type in make_property_setter query

* fix: Remove redundant as_list kwarg

Co-authored-by: gavin <gavin18d@gmail.com>
 2022-04-12 12:00:11 +05:30
Gavin D'souza
022bbe9889 chore: Ignore codebase formatting change in blame 
The previous record was inconsequential as the merge was squashed
 2022-04-12 11:30:28 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453) 
Co-authored-by: Frappe Bot <developers@frappe.io>
 2022-04-12 10:59:25 +05:30
Abhishek Saxena
5c8856d66e
refactor: db.sql calls to frappe.qb (#16107) 
# Changes

- Introduces `subqry` class to use in where clause when there is a non-column condition. eg.
> .where(subqry(no_of_roles) == 0)
- Convert SQL queries to frappe.qb 

# Testing

Functions with query refactors
- frappe.boot.get_user_pages_or_reports() -> Same output of `get_bootinfo()` as develop
- frappe.boot.get_unseen_notes() -> Forms the same query as develop 
```sql
SELECT `name`,`title`,`content`,`notify_on_every_login`
FROM `tabNote` WHERE `notify_on_every_login`=1
AND `expire_notification_on`>'2022-03-30 01:10:53.393874'
AND (SELECT `nsb`.`user` FROM `tabNote Seen By` `nsb` WHERE `nsb`.`parent`=`tabNote`.`name`) NOT IN ('Administrator')
```
- frappe.installer._delete_doctypes() -> installed and uninsalled a dummy app to drop tables

### Not tested
- frappe.make_property_setter()
- frappe.realtime.get_pending_tasks_for_doc() [whitelist method]
- frappe.sessions.Session.start()
- frappe.twofactor.cache_2fa_data()
 2022-04-12 05:07:25 +00:00
mergify[bot]
31d87176c1
Merge pull request #16570 from resilient-tech/fix-theme-switcher 
fix: theme switcher shortcut issue
 2022-04-11 11:26:56 +00:00
Shariq Ansari
b51d8379b5
fix: Card link indicator hover color same as link background color (#16568) 2022-04-11 16:15:35 +05:30
lapardnemihk1099
5993a8ba57 chore: sider issues fixed 2022-04-11 14:45:13 +05:30
lapardnemihk1099
27d226f295 test: theme switcher dialog shortcut test 2022-04-11 14:32:14 +05:30
mergify[bot]
bb6d682c07
Merge pull request #16507 from phot0n/from-signature 
feat(minor): use specific email signature via from field
 2022-04-11 08:19:05 +00:00
Shariq Ansari
1e63475b2a style: Added gap between from and to field 2022-04-11 13:07:52 +05:30
Shariq Ansari
0739104d2a
Merge branch 'develop' into from-signature 2022-04-11 12:47:11 +05:30
Shivam Mishra
e89fd7a2af
fix: sitemap condition 2022-04-10 16:22:56 +05:30
mergify[bot]
b73580a262
Merge pull request #16478 from ChillarAnand/fmatch 
feat: Added fuzzy search to awesome bar
 2022-04-10 03:19:27 +00:00
Suraj Shetty
908a169626
Merge branch 'develop' into fmatch 2022-04-10 08:24:55 +05:30
mergify[bot]
6dd292c044
Merge pull request #16543 from kamaljohnson/add-after-insert-option-to-server-script 
feat: add "After Insert" doctype event to server script
 2022-04-10 02:44:26 +00:00
mergify[bot]
9910c79596
Merge pull request #16471 from phot0n/use-backticks 
fix: use backticks for fieldname while preparing filters
 2022-04-10 02:34:47 +00:00
Suraj Shetty
2a994a3be4
Merge branch 'develop' into use-backticks 2022-04-10 07:50:53 +05:30
HENRY Florian
cc9613f5c2
fix: update french translation (#16550) 2022-04-10 07:48:55 +05:30
Mohammed Redah
60814c4e3f
fix: Export Links in Customize Form (#16333) 
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
 2022-04-10 07:46:43 +05:30
Suraj Shetty
5b8d930165
Merge pull request #16554 from netchampfaris/system-console-logs-route-fix 2022-04-10 07:45:24 +05:30
Faris Ansari
9e4182d91f fix: new route syntax for Logs in System Console 2022-04-09 16:37:59 +05:30
Suraj Shetty
97a610a412
Merge pull request #16553 from frappe/dependabot/npm_and_yarn/moment-2.29.2 2022-04-09 07:33:10 +05:30
dependabot[bot]
42cfcdadf9
chore(deps): bump moment from 2.24.0 to 2.29.2 
Bumps [moment](https://github.com/moment/moment) from 2.24.0 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.24.0...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-04-09 01:08:28 +00:00
Komal-Saraf0609
02286e4e6f
test: Added test script for control type "Attach" (#16355) 
Adding automation test script for control/fieldtype "Attach".

The above test script does the following testing:

1. Creating a new doctype with attach fieldtype.
2. Attaching a new image using the "Link" option from the options which the "Attach" button offers.
3. Checking if the URL of the attached image is getting displayed in the field of the newly created doctype.
4. Checking if the clicking on the "Clear" button clears the text in the field and again displays the "Attach" button.
5. Doing all the above testing by using the "Library" option from the options which the "Attach" button offers.
 2022-04-08 13:42:58 +00:00
Rushabh Mehta
a682516f71 fix(style): minor style fixes 2022-04-08 10:38:03 +05:30
Rushabh Mehta
c54f694e7c fix(style): minor style fixes 2022-04-08 07:56:23 +05:30
Rushabh Mehta
c0d8dfed15 fix(style): minor style fixes 2022-04-08 07:50:07 +05:30
Rushabh Mehta
96a6233953 fix(style): minor style fixes 2022-04-08 07:19:44 +05:30