Commit graph

34843 commits

Author SHA1 Message Date
Sagar Vora
c56ded1c4b fix: set missing permlevel for Role Profile 2021-10-18 16:58:37 +05:30
gavin
51ce9f5832
Merge pull request #14444 from NagariaHussain/chore-try-on-fc-button
chore: Try on FCloud button in README
2021-10-18 14:08:56 +05:30
Suraj Shetty
def460715e
Merge pull request #14478 from surajshetty3416/fix-listview-printformat 2021-10-18 13:58:27 +05:30
Suraj Shetty
0bff45add2
Merge branch 'frappe:develop' into fix-listview-printformat 2021-10-18 13:54:18 +05:30
Suraj Shetty
c624b54eca fix: Set limit_page_length to get all letterhead
`limit` is not a valid argument for `frappe.client.get_list`
2021-10-18 13:54:00 +05:30
Summayya Hashmani
20d7a9df78
feat: Add confirm password field (#14281)
* fix: remove commented code

* refactor: add confirm password field

* fix: remove dialog and add inline warning

* fix: capitalize words and text function

* fix: capitalize words

* style: Fix formatting

* refactor:update class name

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* refactor: remove indicator class and add margin

Co-authored-by: Summayya <frappe@Summayyas-MacBook-Air.local>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-10-18 08:02:35 +00:00
Suraj Shetty
202d94715f
Merge pull request #14476 from surajshetty3416/fix-auto-email-report-download 2021-10-18 12:39:11 +05:30
gavin
8980e733c1
Merge pull request #14475 from gavindsouza/misc-fixes-2
fix: Remove unnecessary missing_ok kwarg from unlink
2021-10-18 12:36:49 +05:30
Suraj Shetty
5c5c176872 fix: Check if parent exist in col before getting doc
This fixes following error while downloading auto email report

```
Traceback (most recent call last):
  File "/Users/sps/benches/develop/apps/frappe/frappe/app.py", line 66, in application
    response = frappe.api.handle()
  File "/Users/sps/benches/develop/apps/frappe/frappe/api.py", line 54, in handle
    return frappe.handler.handle()
  File "/Users/sps/benches/develop/apps/frappe/frappe/handler.py", line 31, in handle
    data = execute_cmd(cmd)
  File "/Users/sps/benches/develop/apps/frappe/frappe/handler.py", line 67, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/Users/sps/benches/develop/apps/frappe/frappe/__init__.py", line 1205, in call
    return fn(*args, **newargs)
  File "/Users/sps/benches/develop/apps/frappe/frappe/email/doctype/auto_email_report/auto_email_report.py", line 196, in download
    data = auto_email_report.get_report_content()
  File "/Users/sps/benches/develop/apps/frappe/frappe/email/doctype/auto_email_report/auto_email_report.py", line 98, in get_report_content
    columns, data = make_links(columns, data)
  File "/Users/sps/benches/develop/apps/frappe/frappe/email/doctype/auto_email_report/auto_email_report.py", line 253, in make_links
    doc = frappe.get_doc(col.parent, doc_name) if doc_name else None
  File "/Users/sps/benches/develop/apps/frappe/frappe/__init__.py", line 883, in get_doc
    doc = frappe.model.document.get_doc(*args, **kwargs)
  File "/Users/sps/benches/develop/apps/frappe/frappe/model/document.py", line 62, in get_doc
    raise ValueError('First non keyword argument must be a string or dict')
ValueError: First non keyword argument must be a string or dict
```

The issue was introduced via https://github.com/frappe/frappe/pull/13340
2021-10-18 12:20:06 +05:30
Gavin D'souza
30c39acabe fix: Don't unlink file blindly
This made sense with the missing_ok. But now, a try-except seems
unnecessary too. Also, possibly destructive. Best to stray away from
these things.
2021-10-18 12:07:42 +05:30
Gavin D'souza
f51b1cc739 fix: Remove unnecessary missing_ok kwarg from unlink
missing_ok added in PY38, this change breaks installs for PY37. ref: https://docs.python.org/3/library/pathlib.html#pathlib.Path.unlink
2021-10-18 11:51:33 +05:30
mergify[bot]
75b7efe76c
Merge pull request #14473 from frappe/child-table-fix
fix: child table layout in the web-form
2021-10-18 06:02:21 +00:00
Summayya Hashmani
4146cd3cca
refactor: child table layout in the web-form 2021-10-18 09:28:44 +05:30
gavin
b73c77a128
Merge pull request #14459 from gavindsouza/console-on_exit
fix: Rollback while exiting console
2021-10-14 18:23:36 +05:30
Gavin D'souza
6712bd9c93 fix: Leaking color in bench --help
Since the character to render NC was cut off due to the char limit, the
whole list of following commands and descriptions would also turn
yellow. Let's keep it colourless in --help. Only, make it yellow when
the command is executed directly.
2021-10-14 17:33:35 +05:30
Gavin D'souza
bc9b3e826b fix: Rollback, Release locals & Close db connection
When exitting console, rollback and destroy the Frappe connection. This
rollback is added so that rollback_observers are executed in case
methods are run in the console which shouldn't be committed.

For instance, running File.optimize will make changes to the file on
disk but may not update the corresponding data in the DB.
2021-10-14 17:30:51 +05:30
mergify[bot]
00d137d1cb
Merge pull request #14454 from Aradhya-Tripathi/at/patch/builder
feat: prepending `tab` to doctypes in query builder
2021-10-14 11:09:42 +00:00
gavin
ac5bf003cc
chore: Update CODEOWNERS 2021-10-14 16:05:18 +05:30
Aradhya-Tripathi
c6542749cd feat: prepending tab to table name for UPDATE and INSERT 2021-10-14 15:00:01 +05:30
Suraj Shetty
1eb772f555
Merge pull request #14449 from surajshetty3416/fix-print-format-default 2021-10-14 11:08:37 +05:30
Suraj Shetty
22ffe27217 fix: Permission check for default print format 2021-10-14 11:00:46 +05:30
Suraj Shetty
6565966dde
Merge pull request #14448 from surajshetty3416/fix-reload-issue 2021-10-14 10:02:17 +05:30
Suraj Shetty
08e5aa6afe revert: Override app link click to avoid page reload
This PR reverts unnecessary change  made in https://github.com/frappe/frappe/pull/14394
2021-10-14 09:55:14 +05:30
Hussain Nagaria
cb4b9868d3 chore: Try on FCloud button 2021-10-13 18:41:08 +05:30
Ankush Menat
a6bfbe4f1a
Merge pull request #14427 from ankush/app_uninstall_failure
fix: app uninstallation failure if module def link field isn't called "module"
2021-10-13 16:38:18 +05:30
gavin
8e7d83c88d
Merge pull request #14246 from saxenabhishek/aks-fix-migration
feat: Hash based comparison migration
2021-10-12 17:50:49 +05:30
Ankush Menat
35b242fe27
test: remove app unit tests 2021-10-12 17:33:29 +05:30
abhishek
ba78852c73 docs: add docstring for import_file_by_path 2021-10-12 17:15:12 +05:30
Ankush Menat
70fcac8acf
refactor: change _delete_modules for testability 2021-10-12 17:10:14 +05:30
Ankush Menat
aa372b0990
fix: change order of deletion
Previous order was:
1. Delete DocTypes
2. Delete linked records
3. Drop tables

Now if linked records belonged to deleted doctypes it causes
uninstallation failure.

Changed order to:

1. Delete linked records
2. Delete DocTypes
3. Drop tables
2021-10-12 16:52:18 +05:30
Ankush Menat
412aa9f5cc
fix: fieldname for linkfield hardcoded to "module"
Remove_app assumed that all link fileds linking to "Module Def" are
called "module", this causes uninstall failure and leaves bench in
pseudo-irrecoverable state. (requiring some manual cleanup)
2021-10-12 16:52:18 +05:30
Ankush Menat
ae88fca3ef
refactor: split remove_app in smaller functions 2021-10-12 16:52:17 +05:30
Suraj Shetty
05231f97f8
Merge pull request #14424 from frappe/fix-group-by-child-table-field 2021-10-12 14:20:36 +05:30
Suraj Shetty
18df0b0f8c test: Fix test 2021-10-12 13:46:06 +05:30
Suraj Shetty
74ec9657da test: Update aggregation test 2021-10-12 13:36:30 +05:30
Suraj Shetty
828d158e4d
Merge pull request #14380 from pateljannat/discussions-single-topic 2021-10-12 13:35:42 +05:30
Mohammad Hasnain Mohsin Rajan
b3465f7972
Merge pull request #14429 from anupamvs/customize-print-format-btn-issue
fix: Customize is not listed in menu item [Print]
2021-10-12 13:01:00 +05:30
Anupam
f6e83dbcaf fix: Customize is not listed in menu item [Print] 2021-10-12 12:35:40 +05:30
Suraj Shetty
ab00980389
refactor: Use f-string
Co-authored-by: gavin <gavin18d@gmail.com>
2021-10-12 12:06:08 +05:30
Suraj Shetty
8febefae9c test: Add test case to validate aggregation
- based on child table field
2021-10-12 12:05:05 +05:30
Suraj Shetty
c6538cf318
Merge branch 'develop' into discussions-single-topic 2021-10-12 11:41:04 +05:30
Suraj Shetty
14ae20bdb8 fix: Push aggregate_on_field to field list
- for proper extraction of child table
2021-10-12 09:54:09 +05:30
abhishek
86f29aeaa3 fix: missing logical cases
- handle first time imports
- update hash and timestamps
2021-10-12 03:21:08 +05:30
mergify[bot]
d7edd05a5d
Merge pull request #14309 from shariquerik/hide-show-filter
fix: Hide 'Show Saved' filter button if there is no saved filters
2021-10-11 14:30:45 +00:00
Mohammad Hasnain Mohsin Rajan
b7de4b3cae
Merge pull request #14355 from shariquerik/notification_overlap_filter
fix: Filter pop-up overlaps the Notification Window
2021-10-11 19:36:19 +05:30
Shariq Ansari
875f35ec14
fix: Rate limiter on blog feedback (#14322)
* fix: Added rate limiter on blog feedback

* test: Updated test to support rate limiter
2021-10-11 19:35:51 +05:30
mergify[bot]
20c38aa704
Merge pull request #14414 from mituldavid/comment-imgs
fix: Private images in comments are not visible
2021-10-11 13:43:36 +00:00
Gavin D'souza
2622f3398e style: Black-ish queries
* feat(minor): Added DocType to frappe.query_builder namespace
2021-10-11 19:00:52 +05:30
abhishek
f3d810414a refactor: sync_for() - first install module 2021-10-11 18:59:06 +05:30
abhishek
0be59cee80 chore: add missing document_types 2021-10-11 18:59:06 +05:30