Commit graph

44493 commits

Author SHA1 Message Date
avazquez@ctgalega.com
c65e866ec4 fix: linters 2023-12-17 20:19:12 +01:00
avazquez@ctgalega.com
c8d06c4ad5 fix: Consider allDay on Calendar View 2023-12-17 20:03:10 +01:00
Ankush Menat
ca33deae12 fix: cast SQL booleans to python 2023-12-17 12:07:14 +05:30
Ankush Menat
3adc83e7c6
perf(migrate): update only affected users via role profile (#23821)
This is same as https://github.com/frappe/frappe/pull/23820 but for role
profile
2023-12-16 08:29:26 +00:00
Ankush Menat
c38e842646
perf(migrate): Only re-evaluate users which are potentially changed (#23820)
When roles are added in fixture `desk_access` always appears to be
"changed" because of how fixtures work.

This causes all users with the said role to be re-evaluated. This is
unnecessary computation because desk_access rarely changes in most apps.

Fix: See if role's desk access is same as user's desk access and don't
re-evalute them.

E.g. If role fixture without desk access is being migrated then it will
skip all users who are already website users. Likewise role with desk
access will skip all users who are already system users.
2023-12-16 08:18:46 +00:00
Ankush Menat
40e48c9ac4
feat: describe-database-table to get stats about a table (#23813)
* feat: `describe-database-table` to get stats about a table

This provides description of table, indexes, total row count in machine
parseable format.

Towards https://github.com/frappe/press/issues/1265

* Update test_commands.py
2023-12-15 17:53:11 +05:30
Ankush Menat
d39ecd3932
fix: Consider user and sender both for "system user" (#23806)
Email is "sender" which might not be linked with any user.
2023-12-15 12:51:29 +05:30
Shariq Ansari
254e22f5ab
Merge pull request #23804 from shariquerik/load-100-for-larger-screen
fix: load 100 records for larger screen
2023-12-15 12:36:06 +05:30
Shariq Ansari
2fa1120b0f fix: consider height istead of width 2023-12-15 11:45:14 +05:30
Shariq Ansari
87e0ccd555 fix: load 100 records for larger screen 2023-12-15 11:31:25 +05:30
Niraj Gautam
eb5448209e
fix(jinja): Update error message in validate_template function (#23783)
[skip ci]
2023-12-14 21:10:47 +05:30
Ankush Menat
b7c2989823
feat: add-database-index command to add and persist custom indexes (#23787) 2023-12-14 15:16:49 +00:00
Ankush Menat
687752359d
perf: Primary key is never nullable (#23788)
People ususally write queries like these...

```
frappe.get_all(doctype, {"name": ("in", list_of_docs))
```

Ocassionally, the `list_of_docs` is empty because it's dynamically
generated and in this case we end up doing full table scan to find... nothing!
2023-12-14 15:01:19 +00:00
Akhil Narang
cd7be151f7
fix(rq_job): resolve deprecation warning (#23784)
env/lib/python3.11/site-packages/rq/job.py:796: DeprecationWarning: job.exc_info is deprecated, use job.latest_result() instead.
warnings.warn("job.exc_info is deprecated, use job.latest_result() instead.", DeprecationWarning)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-14 15:22:26 +05:30
Gursheen Kaur Anand
9ec54feff9
fix: skip using frm object for routing to audit trail (#23603)
[skip ci[
2023-12-14 11:03:59 +05:30
Ankush Menat
174e24f159 fix: validate custom portal menu entries during sync 2023-12-13 17:55:05 +05:30
Ankush Menat
119a4bdbc1
fix: remove delay from numeric field selection (#23759) 2023-12-13 16:16:27 +05:30
Ankush Menat
957f9a01b5
fix: discard deleted doctypes unconditionally (#23770) 2023-12-13 15:57:18 +05:30
Arjun
8e4b0ade78
fix: remove web_form rate limit key (#23767) 2023-12-13 15:39:10 +05:30
Ritwik Puri
0aea1de0f4
chore: remove testing internet connection for emails (#23581) 2023-12-13 09:55:29 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified (#23697)
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
Ankush Menat
21261e63e6
fix: Workflow doc states not existing on new forms (#23756)
[skip ci]
2023-12-12 21:43:19 +05:30
Ankush Menat
7edb80bf5c
fix: correct error message (#23746)
[skip ci]
2023-12-12 14:49:37 +05:30
dependabot[bot]
fff9635328
build(deps): bump actions/setup-python from 4 to 5 (#23743)
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-12 14:10:44 +05:30
Smit Vora
f62f4472e6
fix: ignore if controller doesn't have get_list attr (#23736) 2023-12-11 23:24:00 +05:30
Raffael Meyer
24a266fe98
Merge pull request #23737 from barredterra/users-for-leaderboard
fix: get users for leaderboard
2023-12-11 18:23:44 +01:00
barredterra
2f7b9f8a5a fix: get users for leaderboard 2023-12-11 18:07:30 +01:00
Ankush Menat
8129fe7268
fix: Avoid duplicate contact names (#23731) 2023-12-11 17:15:37 +05:30
Ankush Menat
f0aaeadd49 fix: Correct fallback for social login key 2023-12-11 12:48:47 +05:30
Ankush Menat
e4a9431c9c
fix: change webhook header types to small text (#23722)
closes https://github.com/frappe/frappe/issues/18650
2023-12-11 06:30:01 +00:00
Ankush Menat
7027e8b4dc
fix: ecsape search string (#23717)
[skip ci]
2023-12-11 11:20:02 +05:30
Ankush Menat
81b75374b0
fix: escape username on avatar control (#23713)
[skip ci]
2023-12-11 11:09:49 +05:30
Sagar Vora
8cc4fc349a chore: improve condition to avoid re-initializing flag 2023-12-11 10:53:04 +05:30
Corentin Flr
4b367245eb
Merge pull request from GHSA-v3vh-7qx4-f582 2023-12-11 10:40:27 +05:30
Suraj Shetty
f847a61a16
Merge pull request #23698 from surajshetty3416/perf-website-load 2023-12-08 21:50:42 +05:30
Suraj Shetty
bc2b41d2f5 perf: Simplify dynamic route evaluation to speed up route resolution
validate complete route only if starting of the path matches with the webform route

This avoids the expensive matching from huge route_map (in sites with lots of web forms)
2023-12-08 21:15:34 +05:30
Akhil Narang
c0de1aa0df
refactor(sentry): don't require passing in an exception (#23689)
`sys.exc_info()` works out for our use case

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-08 21:07:17 +05:30
Suraj Shetty
7452e71d02 perf: Use get_cached_doc instead of get_doc
- Makes document pages with no-cache load a bit faster
2023-12-08 20:55:25 +05:30
Shariq Ansari
c312f66e96
Merge pull request #23272 from blaggacao/fix/list-view-settings
fix(list_settings): don't count tags to total fields
2023-12-08 19:39:17 +05:30
David Arnold
8c4d3e5ed9
fix: revert wrong cleanup attempt 2023-12-08 13:40:51 +01:00
mergify[bot]
bfc2c07630
fix: undefined variable name fixed in dark.scss (backport #23646) (#23693)
Co-authored-by: MasterCat <mastercat@link-igor.de>
2023-12-08 17:57:18 +05:30
Fisher Yu
84fcd857e4
feat(minor): child table field as standard filter in list view (#23625) 2023-12-08 16:56:40 +05:30
sibi kumar k
01d6679c8c
fix: Add filter in Workspace Card Links Block (#23578) 2023-12-08 16:47:23 +05:30
Shariq Ansari
32e1c715fe
Merge pull request #23672 from shariquerik/check-if-autoname-is-prompt 2023-12-08 16:46:42 +05:30
Akhil Narang
e1f6237cec
Merge pull request #23682 from akhilnarang/fix-sentry-user-name
fix(sentry): set the user's name correctly
2023-12-08 16:29:03 +05:30
Akhil Narang
faef64bab4
fix(sentry): set the user's name correctly
https://docs.sentry.io/platforms/python/enriching-events/identify-user/

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-08 16:13:15 +05:30
Shariq Ansari
52cea3e01c chore: better code 2023-12-08 15:49:33 +05:30
Shariq Ansari
adbd88d394 test: fixed failing test 2023-12-08 15:20:50 +05:30
Ankush Menat
57699a54b1
fix: Show server script name in traceback (#23676)
* fix: Show server script name in traceback

* chore: typo

Co-authored-by: Sagar Vora <sagar@resilient.tech>

---------

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-12-08 15:01:13 +05:30
Shariq Ansari
b98c550823
Merge pull request #23677 from shariquerik/priortize-link-title-fix 2023-12-08 14:12:19 +05:30