Currently we are doing aggregation of remaining slices manually BUT this
breaks basic principle of DRY:
- dashboard chart decides how many groups to consider
- frappe charts has different maxSlices config
This results in mess like frappe computing "Other" and Frappe charts
computing "rest" separately.
Fix: Just pass all data to charts and let it figure out the "Rest".
* feat: Added Subscription Banner for remotely logging into FrappeCloud dashboard from site (#18263)
* feat: added Subscription Banner and Manage Subscription button
* feat[patch]: added a patch for adding `Manage Subscription` button in
navbar_settings
* chore: removed console ;)
* refactor: make the `Manage Subscription` navbar item optional
* keep it hidden by default, only show when the site configs are present
* style: prettier, isort and stuff
* chore: handling null responses, translation and refactored patch
* fix: correct index reset
* perf: reduce network/db calls
If not sys manager then why make a request?
* fix: removed network call and added subscription_expiry to boot process
* chore: added enable_manage_susbcriptions as daily background job and refactored patch
* chore: added hook to hooks.py
* this looks clean enough, also don't have insert for child tables ;)
Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 68f315d372cc8c6e41f2aabda61eba0d42dcf6e4)
# Conflicts:
# frappe/patches.txt
* chore: conflicts
* style: format
[skip ci]
Co-authored-by: Rutwik Hiwalkar <50401596+rutwikhdev@users.noreply.github.com>
* fix: Add translate function to strings
fix: Add translate function to strings
* fix: add more strings to translate function
* fix: Add strings on translate function HTML tags
* fix: lint text on translate function
* fix: use single quotes on translate strings
* fix: Add template literals to translate HTML strings
* Update frappe/public/js/frappe/ui/toolbar/about.js
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
* fix: typo on dashboard_view
* fix: add string to translate function
* fix: add string to translate function
* fix: add string to translate function
* fix: upddate translatet text to single quote
* fix: update translated strings to single quote
* fix: add country to translate function
* fix: add country to translate function
* fix: add string to translate function
* fix: add string to translate function
* fix: add string to translate function
* fix: Revert translate for country
* fix: revert single quote to Search for icons text
* fix: refactor the translate labels directly to html variable
* Fix chart translation issue
also used .html() instead of .text() in line 58, because otherwise it resulted in html escape errors. In french ' is used in many words and when using the text() method it results in this string being inserted '
* refactor: use data attribute
for semantic consistency
Co-authored-by: Ankush Menat <ankush@frappe.io>
