Commit graph

40330 commits

Author SHA1 Message Date
Raffael Meyer
c7ef28fa0c
fix: don't validate to & from dates if any one is missing in validate_from_to_dates (#19079) 2022-12-03 18:32:59 +05:30
Ankush Menat
9c104a8e5e fix: Warn about incompatible mariadb versions 2022-12-03 12:20:35 +05:30
Ankush Menat
11cdd21b88 fix: drop mariadb 10.2 checks 2022-12-03 12:20:35 +05:30
Sagar Sharma
cc9499c613
chore: typo in validate_loop msg (#19091)
* fix: typo in `validate_loop` msg

* chore: update translations

[skip ci]

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-12-03 12:08:41 +05:30
Ankush Menat
7d52df875f
perf(install): bulk insert country and currencies (#19084) 2022-12-03 12:03:05 +05:30
Raffael Meyer
04d1292cf1
fix: consistent translation in meta.get_label (#19080) 2022-12-02 23:38:15 +05:30
Ankush Menat
28360e3983
perf: dont clear all cache during default install (#19078)
When installing frappe all system settings are for some reason moved to
tabDefaultValue, each default insert clears cache so meta is fetched
again on each insert.

Overall this results ins ~13% of install time.
2022-12-02 12:48:19 +05:30
Ankush Menat
c1f3cb101c
test: custom grid buttons (#19073)
[skip ci]
2022-12-01 13:16:00 +05:30
Matthew Enderle
3885833764
fix: socketio spawn error (#19070)
* fix: socketio spawn error

Restarting supervisorctl fails when attempting to spawn the instance due to syntax.

* refactor: accurate expansion of optional chaining

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-12-01 10:41:42 +05:30
Shariq Ansari
ef5c618954
Merge pull request #19063 from shariquerik/do-not-escape-undefined 2022-11-30 20:34:34 +05:30
Sagar Vora
2e2f8e8175
fix: only check for special characters in fieldname (#19061)
* fix: only check for special characters in fieldname

* chore: revert #18965
2022-11-30 16:03:02 +05:30
Shariq Ansari
903ade145a fix: do not escape undefined txt 2022-11-30 15:48:03 +05:30
Nikhil
53957447b3
fix: check for bad zip files during unzipping in file doctype (#19058)
* check for bad zip files
2022-11-30 14:34:09 +05:30
Ankush Menat
83f591e69b
fix: empty search shows None (#19055)
[skip ci]
2022-11-30 12:52:59 +05:30
Shariq Ansari
3fd5b3703b
Merge pull request #19049 from frappe/mergify/bp/develop/pr-18858 2022-11-29 18:20:48 +05:30
Shariq Ansari
6babd4ec04
Merge pull request #18999 from CleoMenezesJr/develop 2022-11-29 18:00:04 +05:30
Anh Lê
7a68797d96 fix: Optimize check field type is tab break if the doctype has a workflow (#18858)
Co-authored-by: Anh Le <anhle>
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
(cherry picked from commit d9ce6c12bf59ca9d96e385a09ef39ab417c24e2e)
2022-11-29 12:29:34 +00:00
Shariq Ansari
cc4e2868fc
fix: keep actions on right
Make action button's font text smaller with lesser padding
2022-11-29 17:20:13 +05:30
Ankush Menat
5d1444c21c
docs: add missing help text for commands (#19039)
closes https://github.com/frappe/frappe/issues/19036

[skip ci]
2022-11-29 16:01:25 +05:30
Shariq Ansari
c46c1e66d7
Merge pull request #18887 from abdo-host/patch-1 2022-11-29 15:58:53 +05:30
Shariq Ansari
a6d715b943
Merge branch 'develop' into patch-1 2022-11-29 15:12:19 +05:30
Ritwik Puri
1113d8e611
Merge pull request #18940 from phot0n/refactor-prepared-report
refactor!: prepared report
2022-11-29 14:46:04 +05:30
phot0n
8c28a233e2 fix: check read permission when downloading prepared report file 2022-11-29 14:43:27 +05:30
phot0n
5444df7036 chore: use default timeout 25 mins for prepared report 2022-11-29 13:46:11 +05:30
phot0n
f88d76f011 chore: convert job_id to link fieldtype in prepared report doctype 2022-11-29 13:46:11 +05:30
phot0n
1a5019432d refactor(minor): disable_prepared_report -> enable_prepared_report
for role permission for page and report
2022-11-29 13:46:11 +05:30
phot0n
c8ea0a72d0 fix: render filters on refresh
onload hook gave inconsistent behaviour
2022-11-29 13:46:11 +05:30
phot0n
246caea70e test: prepared report tests
* fix: update job_id for prepared report
2022-11-29 13:46:11 +05:30
phot0n
0370c80e41 chore: patches for copying disable_prepared_report and removing prepared report settings from system settings 2022-11-29 13:46:11 +05:30
phot0n
a69c82e06c feat(minor): option to show charts, total_row with prepared reports 2022-11-29 13:46:11 +05:30
phot0n
bf132ab2a8 fix: use doc.get to check if columns field exists or not 2022-11-29 13:46:11 +05:30
phot0n
0d275b68f2 fix: get_prepared_data - add with_file_name param for returning filename of the attachment 2022-11-29 13:46:11 +05:30
phot0n
eea2fd9782 fix: dont show filters when not present in prepared report 2022-11-29 13:46:11 +05:30
phot0n
917dfdae78 refactor(minor): use virtual docfield for report_start_time - and renamed it to queued_at
* chore: rename Report End Time label to Finished At
2022-11-29 13:46:11 +05:30
phot0n
08bae70908 perf: use modified for fetching old logs for clearing 2022-11-29 13:46:11 +05:30
phot0n
433615beed chore: add queued_by virual docfield in prepared report 2022-11-29 13:46:11 +05:30
phot0n
18d48ddeb8 refactor: cleanup peprared result render and old logs cleanup
* directly fetch columns from result file rather than storing it in db
* remove prepared report settings from system settings
* remove disable_prepared_report from report doctype
2022-11-29 13:46:11 +05:30
phot0n
6218a99301 refactor(minor): dry-er code in generate_report 2022-11-29 13:46:11 +05:30
phot0n
cd468c3229 fix(ux): don't show report_name field on prepared report doc 2022-11-29 13:46:11 +05:30
phot0n
ecbafb5a23 feat(minor): add job_id column to prepared report
* chore: make report_name mandatory
2022-11-29 13:46:11 +05:30
phot0n
4fe8eadf5e refactor: remove unnecessary fields from prepared report
* removed ref_report_doctype
* changed title_field from ref_report_doctype to report_name (both are same)
* changed report_name field to link type
* changed autonaming to hash based
* added status in list view via document states
2022-11-29 13:46:11 +05:30
phot0n
9bfc43c148 fix: use after_insert hook for enqueuing report generation
this removes the need of additionally calling enqueue_report method

* enqueue report in long queue
* reduce the timeout from 100 mins to 30 mins
2022-11-29 13:46:11 +05:30
Ankush Menat
442060a96a
Merge pull request #17150 from ankush/bulk_object_inserts
feat: bulk insert simple Docs and iterator support for db.bulk_insert
2022-11-29 13:33:25 +05:30
Ankush Menat
7a3faf23e1
Merge pull request #18664 from barredterra/csv-params
feat: configurable CSV delimiter and quoting
2022-11-29 13:27:24 +05:30
Ankush Menat
465b3f6968 test: use _dict in tests
form_dict is usually _dict, otherwise some unrelated tests will fail.
2022-11-29 11:53:52 +05:30
HarryPaulo
f25358ad63
fix: "_dict" is an invalid attribute name because it starts with "_" (#19010)
* fix: "_dict" is an invalid attribute name because it starts with "_"

* chore: move to frappe namespace
2022-11-29 11:43:23 +05:30
Ankush Menat
c89cdb4f0c test: handle multi-queue consumers 2022-11-29 11:30:12 +05:30
Ankush Menat
6dda853278
fix: broken link for email tracking pixels (#19030) 2022-11-28 20:46:51 +05:30
Shariq Ansari
abb9055be4
fix(UX): Make fetch_from read_only if fetch_is_empty is not set (#19025)
* fix(UX): Make fetch_from read_only if fetch_is_empty is not set

* Update frappe/public/js/frappe/form/controls/base_input.js

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-11-28 16:53:34 +05:30
barredterra
b1f6152f38 fix: pop from form_params 2022-11-28 12:19:14 +01:00