gavin
c84feb16e9
fix: Avoid possible whitespace bug
...
* Handles semgrep warning
* Changed "" to None as a precaution against future whitespace bugs via human error
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2021-05-08 12:39:27 +05:30
Gavin D'souza
926d13e69e
fix: Skip field-method conflicts validation on new docs
2021-05-07 18:02:25 +05:30
Gavin D'souza
87ed7796de
fix: Use older logic to set module_name and custom vars
2021-05-06 16:56:50 +05:30
Gavin D'souza
877f9d08df
fix: Use fallback values if doctype values unset
2021-05-06 16:56:50 +05:30
Gavin D'souza
843c544117
refactor: Rename function and add docstring
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-05-06 16:56:50 +05:30
Gavin D'souza
05712abc60
fix: Check for db value if cache doesn't exist
...
in get_controller, if cached value doesn't exist for a DocType in the
frappe.db.value_cache, then query the db as fallback before the final
fallback of assuming module as Core and non custom
2021-05-06 16:56:49 +05:30
Gavin D'souza
a3b79081d6
fix: Use Document in case get_controller raises import errors
2021-05-06 16:56:49 +05:30
Gavin D'souza
ce4253c631
fix: Ignore 'special' DocTypes to avoid breaking changes
...
eg:
Fieldname 'Delete' conflicting with a controller method of the name delete in Custom DocPerm
Fieldname 'Delete' conflicting with a controller method of the name delete in DocPerm
Fieldname 'Precision' conflicting with a controller method of the name precision in Custom Field
Fieldname 'Precision' conflicting with a controller method of the name precision in Customize Form Field
Fieldname 'Precision' conflicting with a controller method of the name precision in DocField
2021-05-06 16:56:49 +05:30
Gavin D'souza
78e1297392
chore: Drop dead file
2021-05-06 16:56:49 +05:30
Gavin D'souza
c652c7b7f5
feat: Validate field name conflicts in DocType.validate
...
# Conflicts:
# frappe/core/doctype/doctype/doctype.py
2021-05-06 16:56:49 +05:30
Gavin D'souza
255a959a3e
chore: Rename function to validate conflicting methods and properties
2021-05-06 16:56:49 +05:30
Gavin D'souza
9aa2f366dd
fix: Don't execute dynamic properties to check if conflicts exist
2021-05-06 16:56:49 +05:30
gavin
e9d6378e5c
Merge pull request #13129 from gavindsouza/misc-fixes-py3
...
fix: Misc fixes
2021-05-06 16:54:24 +05:30
mergify[bot]
585b123bd7
Merge pull request #13134 from ankush/hooks_template_fixes
...
fix: missing comma and uncommented code in hooks.py template
2021-05-06 09:32:55 +00:00
Ankush Menat
9e39249059
fix: comment user_data_fields and fix structure
2021-05-06 14:01:56 +05:30
Ankush Menat
aba315daf8
fix: missing comma in hooks template
2021-05-06 14:01:39 +05:30
Faten Elhariry
e4744724a0
fix: RTL styling ( #13107 )
...
Co-authored-by: unknown <Administrator@DESKTOP-TKAA1PU.mans.edu.eg>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-05-06 11:37:54 +05:30
Gavin D'souza
0ad122421d
fix: Don't hide warnings unnecessarily
2021-05-05 18:51:51 +05:30
Gavin D'souza
e1c69cecca
chore: Update usages of inspect getargspec
...
Deprecated since version 3.0: Use getfullargspec() for an updated API that is usually a drop-in replacement, but also correctly handles function annotations and keyword-only parameters.
ref: https://docs.python.org/3/library/inspect.html#inspect.getargspec
2021-05-05 18:31:26 +05:30
mergify[bot]
aad9189e1e
Merge pull request #13102 from gavindsouza/show-config-enhancements
...
refactor(CLI): Show config
2021-05-05 12:30:43 +00:00
gavin
7ad99349d9
Merge pull request #13120 from gavindsouza/pddr-levy
...
perf(PDDR): Replace filter_by like with full text filter
2021-05-05 17:38:54 +05:30
Gavin D'souza
bf9fcb3ff6
chore(cli): Add pending deprecation warning
...
* Add PDW for --as-dict in command set-config
* Move all top level imports inside each util to optimize imports for
CLI
* Set always show filter for DeprecationWarning, PendingDeprecationWarning via frappe module
2021-05-05 15:33:44 +05:30
Gavin D'souza
8cd6b520ed
refactor(minor): Bench set-config
...
* Replace --as-dict with a more apt --parse
* Fixed styling
* Renamed variables
2021-05-05 13:37:09 +05:30
Leela vadlamudi
3875004d7e
Merge pull request #13057 from leela/email-refactoring
...
refactor: Email Module - 1
2021-05-05 11:45:04 +05:30
Gavin D'souza
86d6eb51a6
perf: Replace filter_by like with full text filter
...
* Remove like %email% in where clause
* Add fallback for all dict getattrs to owner
2021-05-05 11:38:15 +05:30
mergify[bot]
c3f473c451
Merge pull request #12965 from resilient-tech/allow-scroll
...
fix(UI): dont disable dialog scroll on focusing a Link/Autocomplete field
2021-05-05 05:31:43 +00:00
mergify[bot]
6632a224ae
Merge pull request #13095 from deepeshgarg007/duration_field_export
...
fix: Error while exporting reports with duration field
2021-05-05 04:16:07 +00:00
Gavin D'souza
73ff84da8e
chore: Drop redundant command auto-deploy
2021-05-04 18:10:31 +05:30
Gavin D'souza
3c1b6c66d9
fix(bench-console): Show only apps in namespace
2021-05-04 18:09:53 +05:30
Gavin D'souza
bcbc0d0a7c
fix: Show complete frappe.conf including common conf
2021-05-04 18:08:21 +05:30
Gavin D'souza
3b34474f8d
test: Add tests for bench show-config
2021-05-04 13:24:43 +05:30
mergify[bot]
d0fbc17261
Merge pull request #13098 from resilient-tech/fix-translate-error
...
fix(setup): do not show messsage when exception is handled
2021-05-04 05:24:43 +00:00
mergify[bot]
ea85308321
Merge pull request #13101 from shariquerik/patch-upadte-notification-channel
...
fix: Patch Update Notification channel
2021-05-04 05:13:11 +00:00
mergify[bot]
52a3f2f5df
Merge pull request #13103 from ankush/clean_boilerplate
...
chore: remove py2 specific code from boilerplate
2021-05-04 05:09:00 +00:00
mergify[bot]
7247099450
Merge pull request #13099 from resilient-tech/fix-reloader
...
fix: disable reloading files in `__pycache__` directory
2021-05-04 05:06:33 +00:00
mergify[bot]
c2be57ed9c
Merge pull request #12898 from NagariaHussain/feat-url-validation-option
...
feat: URL option for Data fieldtype
2021-05-03 18:10:08 +00:00
Hussain Nagaria
098b68fc20
fix: Make URL regexp scheme agnostic
2021-05-03 23:23:17 +05:30
Ankush Menat
a617348a79
chore: remove py2 specific code from boilerplate
2021-05-03 20:11:00 +05:30
shariquerik
d8d133e6c3
fix: sider fix
2021-05-03 19:48:52 +05:30
Gavin D'souza
991965fe6b
fix: Format JSON outputs better
2021-05-03 19:48:50 +05:30
shariquerik
3c322c1298
fix: Patch Update Notification channel
...
git status
2021-05-03 19:35:21 +05:30
Gavin D'souza
95db79a1d0
feat(cli): Format option in bench show-config
2021-05-03 19:33:50 +05:30
Gavin D'souza
bb25caa97f
refactor: bench show-config
...
* Handle no site being specified. Fixes https://github.com/frappe/frappe/issues/13100
* Remove tabbed output in favour of table
* Add multi site support
2021-05-03 19:15:13 +05:30
Sagar Vora
e288b781bf
fix: add docstring
2021-05-03 18:00:37 +05:30
Sagar Vora
b214a993da
fix: disable reloading files in __pycache__ directory
2021-05-03 17:54:13 +05:30
Sagar Vora
ac9fe71733
fix(setup): do not show messsage when exception is handled
2021-05-03 17:14:45 +05:30
Sagar Vora
ed2ca98502
fix: hide scrollbar on touch devices
2021-05-03 16:03:46 +05:30
Deepesh Garg
4e4e0fa3d9
fix: Errors
2021-05-03 15:35:46 +05:30
Deepesh Garg
eafadcca47
fix: Error while exporting reports with duration field
2021-05-03 15:16:24 +05:30
mergify[bot]
111d13f93b
Merge pull request #13056 from pateljannat/password-field-in-web-form
...
feat: Add password fieldtype option for Web Form
2021-05-03 08:33:56 +00:00