Commit graph

46163 commits

Author SHA1 Message Date
Akhil Narang
5da663d5c2
chore: cleanup get_recent_backup()
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-10 12:57:16 +05:30
Ankush Menat
c1bf152b89
fix: handle interface error during report timeout (#25893) 2024-04-10 06:57:36 +00:00
Revant Nandgaonkar
7e16e902d9
feat: allow wildcard for doctype in permission hooks (#25729)
* feat: allow wildcard for doctype in permission hooks

* fix: pass doctype to permission query

* fix: combine methods instead of alternate

* test: wildcard has_permssion hook

* test: wildcard has_permssion make note public

* fix: fetch list of hooks once
2024-04-10 11:44:37 +05:30
barredterra
e6f1767fa9 test: fix css query 2024-04-09 19:29:53 +02:00
barredterra
2c8dbb730a Merge remote-tracking branch 'upstream/develop' into list-padding 2024-04-09 18:54:18 +02:00
Ankush Menat
bef9bdc5ee
fix: log out reliability (#25865)
* fix: Avoid possible cache eviction issue

Clear cache after removing data from DB, so a concurrent request can't put stale data in cache.

* fix: explicitly login as guest after logging out

Avoids problem with some other code potentially re-adding current
session in cache or DB.

* test: avoid hard coded admin pw

* test: reset user after running tests

* fix: only login as guest if in request

Background jobs, some other user disabling someone else etc
2024-04-09 18:56:52 +05:30
Ankush Menat
fc78c068f9
fix(link): get_input_value returns "" (#25878)
Steps to repro:
- Setup show title in link field
- on list view filter by that field
- Use the URL and open the page again
- filters will be erased

This is happening because:
- title->value map needs a db call to complete
- in meantime if we ask for input value we get empty value (because input is empty) and then we end up returning `""`
2024-04-09 18:31:24 +05:30
Ankush Menat
28177c8574
fix: limit title length on form (#25880) 2024-04-09 18:10:06 +05:30
Akhil Narang
812f29bd08
Merge pull request #25802 from barredterra/bulk-actions-workflow
fix: don't show bulk actions for doctype with workflow
2024-04-09 15:00:44 +05:30
Akhil Narang
aca9c7f475
Merge pull request #24373 from treasuryesc/develop
fix: error in copy paste from Excel into grid (closes #24371)
2024-04-09 12:38:45 +05:30
Akhil Narang
13aed45308
chore(table): simplify logic
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-09 12:37:11 +05:30
Akhil Narang
2a1d87590c
Merge pull request #25867 from akhilnarang/fix-unhandled-TypeError
fix(layout): handle `fieldobj` being null
2024-04-09 11:56:18 +05:30
Akhil Narang
883196d39b
fix(layout): handle fieldobj being null
`make_control` doesn't return anything when the control name is invalid
Handle in `make_field` and `init_field`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-09 11:54:17 +05:30
Raffael Meyer
21049be8e7
fix: don't underline shortcuts during In-Context Translation (#25864) 2024-04-09 10:37:52 +05:30
Nabin Hait
5b5ac8c877
fix: Get filter value based on depends_on field (#25861) 2024-04-08 21:14:31 +05:30
Ankush Menat
9dad8b1d55
Merge pull request #21014 from BreadGenie/whats-new
feat: `What's New`
2024-04-08 19:05:30 +05:30
Ankush Menat
618c2e60a1 test: fix failing tests 2024-04-08 18:55:05 +05:30
Ankush Menat
a61b0f6ffe fix(UX): show title instead of name 2024-04-08 18:45:34 +05:30
Ankush Menat
6873eab7b4 refactor: move to boot
- Remove API call
- Remove notification setting, don't think we need this
2024-04-08 18:40:03 +05:30
Ankush Menat
ea45d959b3 fix: correct HTTP response code for rate limit 2024-04-08 18:24:38 +05:30
Ankush Menat
491c995313 fix: cold start 2024-04-08 18:24:38 +05:30
Ankush Menat
82f377b6ab refactor: default changelog API 2024-04-08 18:24:38 +05:30
Ankush Menat
bd2dc42b94 perf: speed up changelog fetching
- implicit limit
- bench level cache for each app
2024-04-08 18:24:38 +05:30
Ankush Menat
d2b38666f6 refactor: fetch changelog in background once a week 2024-04-08 18:24:38 +05:30
Ankush Menat
465efe8ea6 refactor: rename variable for last date of feed 2024-04-08 18:24:35 +05:30
Sanket322
9ee221bc41
fix: add before_print in doctype event (#25858) 2024-04-08 18:05:16 +05:30
Ankush Menat
c817c7f769 perf: extend scheduler jitter to weekly/monthly jobs too 2024-04-08 17:04:00 +05:30
Ankush Menat
6a831224a1 refactor: dumb, fast changelog feed in UI 2024-04-08 17:00:46 +05:30
Ankush Menat
000f062580 refactor: better fieldname for posting_timestamp
Also index the field
2024-04-08 16:56:11 +05:30
Ankush Menat
a5eb5aa236 chore: compat changes with latest version
- change sort field
2024-04-08 16:45:51 +05:30
Ankush Menat
b525b7365e chore: shorten events tab 2024-04-08 16:34:49 +05:30
Ankush Menat
8d9304abbe Merge branch 'develop' into whats-new 2024-04-08 16:32:15 +05:30
Ankush Menat
c14e5cc152
fix: index sort field by default in tabFile (#25853) 2024-04-08 16:28:21 +05:30
Akhil Narang
2d71c2cbcd
Merge pull request #25854 from akhilnarang/sentry-fix-exception-check
fix(sentry): correctly skip `frappe.ValidationError` and its children
2024-04-08 16:14:14 +05:30
Akhil Narang
38af00f0db
fix(sentry): correctly skip frappe.ValidationError and its children
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-08 16:03:13 +05:30
Frappe PR Bot
c77332e07e
chore: update POT file (#25838) 2024-04-08 07:38:41 +00:00
Ankush Menat
da682ae44c
fix: type error in workflow (#25847)
if state is null, we can't get roles for it.
2024-04-08 12:59:23 +05:30
Richard Case
551c8d5ef4
fix: log report errors to aid debugging (#25738) 2024-04-08 12:21:41 +05:30
Ankush Menat
9524413eff
fix: limit select user to desk users by default (#25843) 2024-04-08 12:20:34 +05:30
Ankush Menat
2a363e7aed
Merge pull request #25833 from ankush/drop_ui_test
chore: Drop API tests
2024-04-07 11:32:22 +05:30
Ankush Menat
adcb9ef72a chore: Drop API tests
These are already tested with far more coverage in server side tests.
2024-04-07 11:29:41 +05:30
Ankush Menat
0a06455012
Merge pull request #24209 from barredterra/attribution-page
feat: auto-generated attribution page
2024-04-07 11:04:46 +05:30
barredterra
43a991ecc5 fix: limit attribution page to system users 2024-04-06 20:23:56 +02:00
barredterra
027682fcc9 feat: link to attribution page in about modal 2024-04-06 20:21:14 +02:00
barredterra
595bb20a97 Merge remote-tracking branch 'upstream/develop' into attribution-page 2024-04-06 20:00:16 +02:00
Ankush Menat
41ca767f66
Merge pull request #25592 from ankush/extensible_socketio
feat: Extensible SocketIO
2024-04-06 21:49:54 +05:30
Ankush Menat
266b2797aa refactor: use Fetch API instead of superagent 2024-04-06 21:26:45 +05:30
Ankush Menat
2a56869c99 refactor: better permission checking on sockets
- no more "can subscribe X"
- add a new util function on socket `has_permission`

Basic usage:

```js
socket.has_permission(doctype, [name]).then(() => { // do something });
```
2024-04-06 21:14:48 +05:30
Ankush Menat
4778090024 refactor!: Frappe handlers using same extensible socketio 2024-04-06 18:39:16 +05:30
Ankush Menat
a313fb90cb fix(DX): no need to specify separate hook for socketio 2024-04-06 18:28:49 +05:30