Ankush Menat
cc2bb85484
fix: correct arg type
...
assign_to expects a list of strings of users not a single string.
2024-01-04 18:39:15 +05:30
Ankush Menat
3836d942ac
fix: logic to disable broken account
...
This doesn't work because when email is broken we still continue and
down the line changes get rolled back.
2024-01-04 17:39:25 +05:30
Ankush Menat
71908f1e00
refactor: respect multi-tenancy
...
redis set/get don't consider site
2024-01-04 17:39:25 +05:30
Ankush Menat
807cfd66f1
fix: Reset failed attempts ONLY if succesful connection is made
2024-01-04 17:39:25 +05:30
Raffael Meyer
dd690c79d1
fix: use correct parent field in rebuild_tree() ( #24107 )
...
* fix: use correct parent field in rebuild tree
* refactor!: ignore parent_field parameter to rebuild_tree
2024-01-04 16:07:39 +05:30
Ankush Menat
92c4d291c9
Merge pull request #24111 from ankush/perm_messages
...
fix(UX)!: permission error messages
2024-01-04 10:54:41 +05:30
Ankush Menat
94f53d3f91
fix!: frappe.has_permission(throw=True) works as expected
...
- This wasn't throwing PermissionError
- It was erasing all perm check messages
2024-01-04 10:37:07 +05:30
Ankush Menat
3349f2b6e6
fix: nested has_permission calls erase messages
2024-01-04 10:31:55 +05:30
Ankush Menat
04acd0bda4
fix: don't add fallback for child table ( #24105 )
2024-01-03 12:18:06 +00:00
Ankush Menat
cc9679ac76
Merge pull request #24086 from AlexandreLumertz/patch-1
...
fix: timeout occurs when there are too many users linked to the profile
2024-01-03 15:54:10 +05:30
Ankush Menat
1a9aba2858
test: remove invalid assertion ( #24101 )
...
This workspace no longer exists so test fails.
2024-01-03 15:53:30 +05:30
Ankush Menat
3a7efa9ad1
perf: Update roles affected by role profile in background
2024-01-03 15:37:48 +05:30
Ankush Menat
b0d73336a5
Merge pull request #24096 from ankush/hl_report
...
fix: syntax highlighting in report
2024-01-03 15:30:15 +05:30
Ankush Menat
6e8fe0f855
fix(DX): Correct syntax highlighting in report
2024-01-03 15:29:24 +05:30
Ankush Menat
6ac6b69b83
fix: syntax highlighting in system console
2024-01-03 15:26:20 +05:30
Ankush Menat
3dfb2d0d4f
fix: hide script in query report
...
It's not used at all so why show it?
2024-01-03 15:14:51 +05:30
Shariq Ansari
e6d0d9ab12
Merge pull request #24093 from shariquerik/bump-datatable-4
...
build(deps): bump datatable to latest
2024-01-03 15:01:29 +05:30
Shariq Ansari
1659f01f05
build(deps): bump datatable to latest
2024-01-03 14:57:41 +05:30
Ankush Menat
6594fde7f9
Merge pull request #24054 from frappe/dynamic-link-format
...
fix: broken `dynamic_link` to `link` formatting in query report
2024-01-02 19:33:54 +05:30
Raffael Meyer
bb6911101e
fix: remove Guest permission on Help Article ( #24082 )
2024-01-02 16:20:20 +05:30
Rushabh Mehta
4c9bf957d8
Merge pull request #24077 from rmehta/remove-settings-workspace
...
fix(minor): Remove unused Settings workspace and some minor style fixes
2024-01-02 15:49:04 +05:30
Rushabh Mehta
d1f2f42015
fix(minor): move missing settings to tools
2024-01-02 15:47:53 +05:30
Rushabh Mehta
4756bfda20
fix(minor): Remove unused Settings workspace and some minor style fixes
2024-01-02 15:25:28 +05:30
Akhil Narang
ef14d9705a
Merge pull request #23831 from git-avc/fix-calendar-view
...
fix: consider allDay on Calendar View
2024-01-02 14:14:02 +05:30
Akhil Narang
c58e2c5eb3
fix: lint
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-02 13:55:48 +05:30
Ankush Menat
2b23b8d663
fix: validate server scripts with FrappeTransformer ( #24068 )
2024-01-02 07:19:20 +00:00
Saqib Ansari
2ef75be7ff
chore: update datatable
2024-01-02 12:35:10 +05:30
Akhil Narang
44fad9a9f1
Merge pull request #24066 from akhilnarang/sentry-request-data
...
feat(sentry): log request json body / form data
2024-01-02 11:40:12 +05:30
Akhil Narang
da8e88e66c
feat(sentry): log request json body / form data
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-02 11:39:16 +05:30
Ankush Menat
e296a81ed9
refactor: remove dead handling for "fnargs" ( #24064 )
...
This was added for some function here: 2dd28afcb7 (diff-4a7c68f7105f3a52a7504ce52ab85bd106df91e69ab07a9f12fe23dc258870a6R266)
It's not used anywhere.
2024-01-02 05:55:15 +00:00
Ankush Menat
b71d01e1b4
fix: View logging fails if no referrer
...
```
AttributeError: 'NoneType' object has no attribute 'startswith'
File "frappe/app.py", line 110, in application
response = frappe.api.handle(request)
File "frappe/api/__init__.py", line 49, in handle
data = endpoint(**arguments)
File "frappe/api/v1.py", line 36, in handle_rpc_call
return frappe.handler.handle()
File "frappe/handler.py", line 49, in handle
data = execute_cmd(cmd)
File "frappe/handler.py", line 85, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "__init__.py", line 1680, in call
return fn(*args, **newargs)
File "frappe/utils/typing_validations.py", line 31, in wrapper
return func(*args, **kwargs)
File "frappe/website/doctype/web_page_view/web_page_view.py", line 58, in make_view_log
if not frappe.utils.is_site_link(path):
File "frappe/utils/data.py", line 2488, in is_site_link
if link.startswith("/"):
```
2024-01-01 19:15:25 +05:30
Ankush Menat
e163dbe5e2
chore: disable v13 releases
2024-01-01 12:54:04 +05:30
Ankush Menat
8a7707e3fa
fix(DX): store tracebacks with context ( #24059 )
2024-01-01 07:16:47 +00:00
Ankush Menat
78cd62fec0
chore: faster total rows estimation ( #24058 )
2024-01-01 07:09:36 +00:00
Ankush Menat
d5a727dc58
fix: Rate control read only mode ( #24055 )
...
- It should inherit ControlFloat as underlying value is float.
closes https://github.com/frappe/frappe/issues/24053
2024-01-01 06:43:14 +00:00
Saqib Ansari
05225e077e
fix: broken dynamic_link to link formatting in query report
2024-01-01 11:56:09 +05:30
avc
c00d5ac258
feat(UX): cancel new row with escape key ( #23928 )
...
* feat: (UX) cancel new row with escape key
* fix: linters
* fix: more linters
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-01-01 11:49:24 +05:30
Xiaoguang Sun
1fe3b5d5bc
refactor(workspace): Optimize save call on workspace doc ( #24052 )
...
Optimize Workspace.save_page to call doc.save() only once therefore
eliminate sending unnecessary queries to database.
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
2024-01-01 11:38:40 +05:30
Ankush Menat
64c221343e
perf: skip ifnull checks on modified field ( #24042 )
2023-12-30 06:39:32 +00:00
Raffael Meyer
a99f72ff2f
Merge pull request #24039 from barredterra/blog-post-list-indicator
2023-12-30 01:54:51 +01:00
barredterra
cd37bf0337
fix(Blog Post): correct indicator filter
2023-12-30 01:37:53 +01:00
Md Hussain Nagaria
646dac7eee
Merge pull request #24038 from frappe/fix-wg-base-replace
2023-12-29 22:52:01 +05:30
Hussain Nagaria
b9fef7eb8d
test: base class update on has web view update
2023-12-29 22:02:38 +05:30
Hussain Nagaria
ce3e029769
fix: incorrect class tags generation
2023-12-29 21:12:21 +05:30
Ankush Menat
19e0fe65f5
fix: allow guests to view published Newsletters
2023-12-29 18:04:29 +05:30
Ankush Menat
8c515a9a5d
fix: correct perm check for guests
...
Allow viewing document page if doctype allows guest to view
2023-12-29 17:59:39 +05:30
Ankush Menat
38314aec59
fix: Check permissions before rendering web view ( #24032 )
2023-12-29 17:07:17 +05:30
Ankush Menat
585200988b
feat: simple procline for scheduler
...
Makes it easy to tell if scheduler is for some reason "stuck".
2023-12-29 14:39:40 +05:30
Ankush Menat
31d72c33b4
chore: use site as "user" ( #24026 )
...
For us, a user is single site. This is because logic like "issue affects
more than 1 user" only makes sense for site. Same client/server script
can affect multiple user on same site but it's not a useful error for
us.
[skip ci]
2023-12-29 11:55:26 +05:30
Jannat Patel
bdc495f5d1
fix: show right permission for user cannot create doctypes ( #24027 )
2023-12-29 11:54:03 +05:30