Commit graph

1574 commits

Author SHA1 Message Date
Ankush Menat
ccaf4c1e7e
Merge pull request #19854 from gavindsouza/get_all-virtual-dts
fix: Interface DatabaseQuery to virtual doctypes' get_list
2023-02-03 17:30:57 +05:30
Ankush Menat
75d092ef7d
Revert "fix: Report sidebar must consider Permission Query" (#19921) 2023-02-03 15:13:18 +05:30
Ankush Menat
07529ff1c3
fix: Consider parenttype when renaming (#19901) 2023-02-02 17:05:44 +05:30
Gavin D'souza
3cd781e316 Merge branch 'develop' into get_all-virtual-dts 2023-02-02 13:55:24 +05:30
Gavin D'souza
fdff6351cd test: Add test for DatabaseQuery for virtual doctypes 2023-02-02 13:45:35 +05:30
Gavin D'souza
c4061904da test: Split DBQuery & ReportView API tests into separate cases 2023-02-02 13:45:17 +05:30
Ritwik Puri
dd1cac0acc
Merge pull request #19885 from phot0n/fix-email-queue-sender
fix: use sender from formatted email body for email queue
2023-02-01 22:02:18 +05:30
phot0n
a0d1d1bd0e test: fix test_unsubscribe 2023-02-01 21:37:23 +05:30
phot0n
5236aeb4b0 test: email queue sender with always_use_account_name_as_sender_name and always_use_account_email_id_as_sender 2023-02-01 20:18:51 +05:30
Gavin D'souza
7ce0c4c8b3 Merge branch 'develop' into permlevel-apis 2023-01-31 17:47:59 +05:30
Ankush Menat
13162d8fbd fix: Only apply perm query to non-admin users 2023-01-30 11:24:16 +05:30
Marica
57c991f055
Merge branch 'develop' into report-sidebar-respect-perm-query 2023-01-30 11:12:38 +05:30
marination
1e4d28cc19 fix(test): Remove try-finally & ignore perms on test user's report insertion 2023-01-30 11:08:14 +05:30
Ankush Menat
70ee9272b1
fix: sanitize traceback for common secrets (#19805) 2023-01-27 12:44:33 +05:30
barredterra
4bcb12617c fix: assertAlmostEqual with precision 2023-01-26 11:39:41 +01:00
Gavin D'souza
6b0e4695a8 Merge branch 'develop' into permlevel-apis 2023-01-25 12:08:47 +05:30
Ankush Menat
c24cd12a27
Merge pull request #19755 from gavindsouza/maxsplit-as-needed
refactor: Add a maxsplit limit to string splits
2023-01-25 11:10:48 +05:30
barredterra
a33e34519a feat: add test case for long passwords 2023-01-24 15:04:47 +01:00
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
gavin
6f04951801
Merge branch 'develop' into report-sidebar-respect-perm-query 2023-01-24 11:57:08 +05:30
Ankush Menat
87561940a4
feat: Interactively add a new patch (#19722) 2023-01-23 15:04:43 +05:30
Gavin D'souza
9efe84a644 fix(reportview): Remove aggregate_on_field added in fields
Essentially reverts changes added via
https://github.com/frappe/frappe/pull/14424 but works just the same
without the additional column :thonk:

The added column's data in mariadb was essentially garbage data. Wasn't
meaningful from what I could tell - couldn't play well with postgres
either
2023-01-20 19:26:56 +05:30
gavin
4be74bc013
Merge branch 'develop' into permlevel-apis 2023-01-19 11:00:15 +05:30
Ankush Menat
fa55793a52
Merge pull request #19405 from netchampfaris/refactor-qb-engine
refactor: qb.engine
2023-01-18 21:17:17 +05:30
Ankush Menat
e31db5d502
fix: handle tel: links in emails (#19635) 2023-01-17 20:31:06 +05:30
Ankush Menat
433115f62d
test: rollback test transaction after executing cmd (#19606)
In command tests if connection is active then due to repeatable read
isolation you will continue to read old data which might be modified by
the command you're trying to test.

It makes sense to end transaction after each command execution here.

[skip ci]
2023-01-16 18:43:52 +05:30
marination
968648e1b6 test: Test if permission query via server script is applied on cached allowed reports 2023-01-16 18:38:26 +05:30
Ankush Menat
c7edd7e57c chore: remove unnecessary assertion 2023-01-16 18:02:40 +05:30
Ankush Menat
8adfdcbc1d tests: clear DB transactions before all db calls
Because of repeatable read isolation,
changes from externally executed command dont reflect until transaction is ended.
2023-01-16 17:32:29 +05:30
Faris Ansari
543458b473 fix: handle empty list as filters 2023-01-16 15:38:15 +05:30
Gavin D'souza
f0a282e941 test: Add test for linked table permission check 2023-01-16 14:28:13 +05:30
Faris Ansari
5bc5ff100b test: tests for various filter options 2023-01-16 14:12:04 +05:30
Gavin D'souza
7e38d7fe63 test: Make test_child_table_join more resilient 2023-01-16 13:56:37 +05:30
Ankush Menat
5e2bbf834f refactor: filter out apps not installed on bench 2023-01-16 13:54:40 +05:30
Gavin D'souza
9012b95a9a fix(postgres): group_by in reportview, tests
Add approporiate group_by, order_by clauses in reportview and tests for
featureset compatibility with postgres
2023-01-11 12:42:45 +05:30
gavin
2b27652bd4
Merge branch 'develop' into permlevel-apis 2023-01-10 17:45:46 +05:30
Gavin D'souza
d2ad86d2fe test: Add tests for permlevel handing in get_list 2023-01-10 17:44:06 +05:30
Ankush Menat
1eaca4e1d5
fix: RSS feed escaping (#19546)
if title contains reserved chars then malformed XML is generated.

Try title with ampersand in it.

[skip ci]
2023-01-10 11:45:31 +05:30
Faris Ansari
60febc9799 fix: list filter
filters as list must always be list of list
2023-01-09 19:44:11 +05:30
Gavin D'souza
6aea25a6c1 test: Update tests to handle missing attributes based on permlevel 2023-01-09 18:48:48 +05:30
Faris Ansari
be654eaa60
Merge branch 'develop' into refactor-qb-engine 2023-01-09 15:23:20 +05:30
Ankush Menat
075a2d778e feat: UnixTimestamp QB function 2023-01-09 12:05:52 +05:30
Marica
53563b9283
Merge branch 'develop' into kanban-access-w-perms 2023-01-03 12:37:41 +05:30
Faris Ansari
b7c0ba1bea fix: allow dynamic fields in filters
e.g.,
`filters={'link.field': 'value'}`
`filters={'child.field': 'value'}`
2022-12-31 22:55:00 +05:30
Faris Ansari
7ca39a81bf fix: explicitly specifiy order 2022-12-31 22:18:07 +05:30
Ankush Menat
a43a0149eb refactor: improve test, rate limiting 2022-12-30 13:42:42 +05:30
marination
49143922c5 chore: Kanban and ToDo UI test helpers
- `create_admin_kanban` and `create_todo` UI test helpers
- `switch_to_user` Cypress command: logs out and logs in as specified user
- Used `remove_role` in permissions test
- Used `switch_to_user` command in test helper
2022-12-28 23:00:00 +05:30
Faris Ansari
726fcfdb79 refactor: qb.engine
- simplify
- qb.engine.get_query -> qb.get_query
- qb.engine.build_conditions -> qb.get_query
2022-12-25 23:19:11 +05:30
Shariq Ansari
289aa9a13b test: test valid & invalid key 2022-12-21 14:43:10 +05:30
Ankush Menat
db35431b8c fix(postgres): psql with remote databases
If you dont use unix socket psql command doesn't work.
2022-12-20 15:14:38 +05:30