vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
39923 commits 1 branch 0 tags 587 MiB
Commit graph

39923 commits

This branch
This branch
All branches
Author SHA1 Message Date
Shariq Ansari
cdadff1f4e
Merge branch 'develop' into patch-1 2022-11-03 15:25:09 +05:30
Shariq Ansari
cfc773c648
Merge pull request #18740 from shariquerik/file-cropper-fix 
fix: file cropper broken in webform
 2022-11-03 15:22:33 +05:30
Shariq Ansari
cc3e70b9ac fix: file cropper broken in webform 2022-11-03 14:04:36 +05:30
Ankush Menat
a1a296ac75
fix: ignore global translations (#18733) 
_("string") outside of function/methods don't make any sense cause they
are initialized the moment module is imported. This is already checked
in CI yet people make this mistake.

Ignore and refuse to translate in those cases.
 2022-11-03 03:00:03 +05:30
Sagar Vora
5e679bf539
chore: bump cryptography to 38.0.3 (#18730) 2022-11-03 01:24:55 +05:30
Raffael Meyer
11d4cf4396
fix: hide value only if it's equal to the label (#18722) 2022-11-02 13:55:09 +05:30
DrZoidberg09
58cef6005a
fix: search.py after PR #17828 (#18719) 
* fix search.py

After the PR #17828 in some cases an "IndexError: list assignment index out of range" error is thrown. This should fix it.

* Update search.py

Yes, that should be even better

* style: formatting

[skip ci]
 2022-11-02 13:11:20 +05:30
Ponnusamy
58c262a3ed
List view -> add custom buttons to menu 2022-11-02 12:27:50 +05:30
Shariq Ansari
7bbd36345a
Merge pull request #18712 from Ponnusamy1-V/patch-1 2022-11-01 20:05:42 +05:30
Ponnusamy
0cf2043ab0
fix: not able to click checkbox in file grid view 2022-11-01 19:32:46 +05:30
Shariq Ansari
fe8c545829
Merge pull request #18708 from shariquerik/list-view-format-fix 2022-11-01 19:16:05 +05:30
Shariq Ansari
3bccc75620
Merge pull request #18707 from shariquerik/webform-validation-fix 2022-11-01 18:10:01 +05:30
Shariq Ansari
97f97a81f9 fix: show 0 for empty currency, float, & duration fields in list view 2022-11-01 18:07:44 +05:30
Shariq Ansari
cc20037af9 fix: webform validation script not working 2022-11-01 17:44:44 +05:30
Ankush Menat
9e5c0740dc
Merge pull request #18699 from ankush/symlinked_files 
fix: support symlinked /files directory
 2022-11-01 14:06:05 +05:30
Ankush Menat
589bcf149a
Merge pull request #18701 from shariquerik/workspace-message 
fix(UX): Info message on workspace for better UX
 2022-11-01 14:05:45 +05:30
Shariq Ansari
3d1e14e127
Merge branch 'develop' into workspace-message 2022-11-01 13:56:49 +05:30
Shariq Ansari
302024608e fix: added go to workspace link in sidebar 2022-11-01 13:53:12 +05:30
Ankush Menat
fec24632a9 style: format 
[skip ci]
 2022-11-01 13:36:37 +05:30
Ankush Menat
56640a0723 fix: support symlinked and /files directory 
Easiest way to move site/files or site/private directories is to symlink
them, the validation for file path was failing because it resolves only
until site path.

Resolving real path doesn't seem to be _REALLY_ required here.
 2022-11-01 13:25:21 +05:30
Shariq Ansari
c66d264871 fix(UX): Info message on workspace for better UX 2022-11-01 13:12:26 +05:30
Ritwik Puri
c76c02f43d
Merge pull request #18697 from phot0n/custom-module-def-ux 
fix: make module def custom checkbox readonly in prod mode
 2022-11-01 12:50:07 +05:30
phot0n
3ccd5f7d60 fix: make module def custom checkbox readonly in prod mode 2022-11-01 12:44:38 +05:30
Ankush Menat
f0ab6cb488
Revert "fix: use is_file_path_valid instead of is_safe_path (#18316)" (#18688) 
This reverts commit d35aa6c545.
 2022-11-01 12:40:54 +05:30
Aradhya Tripathi
5ed696cd3d
fix(qb): fixed implicit join for child tables (#18692) 
* test: Added test for multiple joins
 2022-11-01 11:25:02 +05:30
DrZoidberg09
0bc2f16772
fix: Signature form (#18477) 
Co-authored-by: Ankush Menat <ankush@frappe.io>
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
 2022-10-31 19:45:46 +05:30
DrZoidberg09
cd9ee5b98c
refactor: allow to include head.html in custom app (#18671) 
* Update base.html

* Create head.html

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2022-10-31 16:55:53 +05:30
Sagar Vora
cb7d25a293
fix(meta): ensure that insert_after is always considered when sorting fields (#18682) 
* fix(meta): ensure that `insert_after` is always considered when sorting fields

* test: add nosemgrep to comment

Co-authored-by: Dany Roberts <danyrt@wahni.com>
 2022-10-31 15:37:55 +05:30
Sagar Vora
623633f35e
chore: bump Pillow to 9.3.0 (#18683) 2022-10-31 13:24:59 +05:30
Ankush Menat
e564dcb3fc
fix(UX): session expiry explanation and defaults (#18680) 
closes https://github.com/frappe/frappe/issues/12957
 2022-10-31 11:28:49 +05:30
Ankush Menat
8cca50bf26
refactor: remove naming case feature (#18672) 
This has never worked since 2016... which can mean two things:
- No one really uses this.
- If I fix this now suddenly people will find different behaviour in
  naming because `name_case` is selected in some doctypes (but never
  tested)
 2022-10-31 11:23:49 +05:30
Sagar Vora
6d45b500a1
perf: load _doc_before_save sooner to avoid DB call in check_if_latest (#18666) 
* perf: load `_doc_before_save` sooner to avoid DB calls in `check_if_latest`

* fix: specify `for update` in `load_doc_before_save`
 2022-10-29 17:55:57 +05:30
Sagar Vora
8f057ef04a
perf: ensure cache works for non_standard_user_types when empty (#18665) 2022-10-29 17:55:19 +05:30
Sagar Vora
764370f3c6
fix: set proper cache key for singles when name is passed as None (#18667) 
[skip ci]
 2022-10-29 17:34:52 +05:30
Shadrak Gurupnor
9c0e111383
fix: handle exceptions thrown in post_schema_updates (#18648) 
* fix: handle exceptions thrown in post_schema_updates

* chore: removed nested try-finally block
 2022-10-28 22:37:58 +05:30
Faris Ansari
aa8957e785
fix(insert_many): list instead of set to maintain order (#18641) 2022-10-28 14:37:17 +05:30
Sagar Vora
d35aa6c545
fix: use is_file_path_valid instead of is_safe_path (#18316) 
* fix: use `validate_file_path` instead of `is_safe_path`

* test: specify `is_private` for file with private URL
 2022-10-28 13:56:24 +05:30
Ankush Menat
1c613179bb
fix: correct stacklevel for warnings (#18633) 
Stacklevel=2 just points to frame that called warning and not frame
where it originated. This frame is useless in most cases as you can just
`grep` for it instead of looking at log.

stacklevel=3 gives frame which is calling the code with warnings.

[skip ci]
 2022-10-28 12:22:24 +05:30
Shariq Ansari
ae23fd971c
Merge pull request #18590 from NagariaHussain/fix-link-routing 
fix(router-js): handle case when link is not of same host
 2022-10-27 18:52:38 +05:30
Shariq Ansari
ce7096ff66
Merge branch 'develop' into fix-link-routing 2022-10-27 16:35:02 +05:30
Hussain Nagaria
ccbd6ffab3 fix(formatting): use snake case for variable names 2022-10-27 16:30:28 +05:30
Ankush Menat
3ddac5fe92
refactor: accurate translation caching (#18595) 
* refactor: rename poorly named functions

* refactor: getting translation from apps

- use generator
- use sane name for cache key
- avoid manual handling of frappe.local state just use cache() interface
 2022-10-27 16:28:02 +05:30
Sagar Vora
cf02106683
Merge pull request #18593 from resilient-tech/recorder-fix 
fix: use `async...await` when parsing route
 2022-10-27 08:53:05 +00:00
Sagar Vora
22990ff343 fix: use async...await when parsing route 2022-10-27 13:59:08 +05:30
Hussain Nagaria
8cdda2e721 fix(router-js): handle case when link is not of same host 2022-10-27 13:48:16 +05:30
Ankush Menat
c5c91bdbd3
fix(UX): warn about Etc/* timezones behaviour (#18587) 2022-10-27 11:52:47 +05:30
Faris Ansari
5c2b917f52
refactor(minor): Tab layout in Website Theme form (#18570) 2022-10-26 00:15:47 +05:30
Wolfram Schmidt
66fbd14c3a
chore: fix DE translations 
added missing translation

[skip ci]
 2022-10-25 12:06:49 +05:30
dependabot[bot]
ce9570de56
build(deps): bump bruceadams/get-release from 1.2.3 to 1.3.1 (#18535) 
Bumps [bruceadams/get-release](https://github.com/bruceadams/get-release) from 1.2.3 to 1.3.1.
- [Release notes](https://github.com/bruceadams/get-release/releases)
- [Commits](https://github.com/bruceadams/get-release/compare/v1.2.3...v1.3.1)

---
updated-dependencies:
- dependency-name: bruceadams/get-release
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[skip ci]
 2022-10-25 11:30:08 +05:30
Andrew McLeod
01fe2da368
fix(email): generate random filename when attachment filenames are same upon inbound email (#18483) 
Fix issue when an email has multiple inline images with the same filename. Currently the cid_map is overwritten; instead, attach the files with different names. Emails where every inline image has the filename 'image.png', only one of the images ends up correctly linked.
 2022-10-24 00:37:49 +05:30