gavin
d279f1bb87
Merge pull request #17103 from ruthra-kumar/run_tests_on_module_def
...
feat: run tests on Module Def
2022-06-08 12:45:39 +05:30
Ankush Menat
b418aea169
Merge pull request #17097 from mmdanny89/mmdanny89-dev
...
fix: infinite loop graphic bar
2022-06-08 12:09:49 +05:30
Naveen
fd8af163ba
ci: Set permissions for GitHub actions ( #17102 )
...
chore: Set permissions for GitHub actions
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ )
Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
2022-06-08 11:55:16 +05:30
ruthra kumar
a202f1a621
feat: run tests all doctypes in module def
2022-06-08 11:54:36 +05:30
Ankush Menat
59a9be4caf
refactor: simplify timegrain conditions
...
All special handling for timegrains is same as general handling, no idea why it's done
like this.
2022-06-08 11:53:14 +05:30
Suraj Shetty
43bb6ee9ac
Merge pull request #17104 from surajshetty3416/fix-user-role
2022-06-08 10:28:12 +05:30
Suraj Shetty
fca0853ebd
fix: Avoid unnecessary "Not Found" error message
2022-06-08 09:54:30 +05:30
Suraj Shetty
0c28820bcc
fix: Reset role editor while loading new user form
2022-06-08 09:41:35 +05:30
Ankush Menat
eac73f6765
fix: better error logging for setup exceptions ( #17096 )
...
fix: better error loggin for setup failure
2022-06-07 19:05:30 +05:30
mmdanny89
4850c0d4fe
infinite loop graphic bar
...
When Period is Yearly and Date Range is Last Year in Graphic Bar
2022-06-07 09:12:23 -04:00
Shariq Ansari
6b476e4043
revert: remove global click event from workspace ( #17093 )
2022-06-07 15:50:21 +05:30
HENRY Florian
f4ccac24b7
fix: update fr translation ( #17090 )
2022-06-07 14:55:19 +05:30
gavin
e533925eae
Merge pull request #17089 from gavindsouza/misc-fixes-10
...
fix(email): Maintain multi-tenancy translation sanity in error messages
2022-06-07 13:43:21 +05:30
Gavin D'souza
1b1479ef37
fix(email): Maintain multi-tenancy translation sanity in error messages
...
Defining translated strings as globals means the strings are evaluated
at import time. So the value of these variables is set based on which
site or user initializes the module. This makes it possible for an
english user to get Russian errors.
---
Other changes: Remove unreachable code, avoid importing _socket.error alias to
OSError
2022-06-07 13:22:45 +05:30
Ankush Menat
94920ab4ae
Merge pull request #16727 from ankush/pg_transaction_management
...
fix: explicitly start a new transaction
2022-06-07 12:46:23 +05:30
Anoop
747198cf17
fix: failing package import ( #17075 )
...
* local variable files initialized with get_doc_files return list
* removed for_sync argument not supported anymore by import_file_by_path
2022-06-07 11:51:51 +05:30
Ankush Menat
df3601b67b
Merge pull request #17084 from phot0n/fix-assigned-to-count-order
...
fix: use desc ordering when fetching Assigned To data
2022-06-06 23:13:29 +05:30
phot0n
d018da1819
fix: use desc ordering when fetching Assigned To data
2022-06-06 22:40:58 +05:30
Ernesto Ruiz
e925600b70
fix: link to Google Settings in Website Settings ( #17083 )
2022-06-06 20:13:48 +05:30
Faris Ansari
3d07a51442
fix: check read permission on link sub-fields ( #17082 )
2022-06-06 19:54:54 +05:30
Ankush Menat
09dc131c4a
Merge pull request #17061 from ankush/reduce_caching
...
perf!: improve document caching
2022-06-06 19:06:04 +05:30
gavin
11d00e72f8
Merge pull request #17005 from gavindsouza/filters_config-fixes
...
fix: filters_config
2022-06-06 16:34:39 +05:30
Ankush Menat
111df3a8d7
perf: improve document caching
...
As per current implementation whenever `get_doc` is called, document is
cached. However, this cache is only ever used by `get_cached_doc`. Going
through the codebase of both FF/ERPNext you'll find that `get_doc` is
used a lot more than `get_cached_doc`. So in many places, all this
caching overhead is unnecessary.
This change removes implicit caching from get_doc and replaces it with
cache-replacement instead. i.e. cache is only updated if it exists but
not created from get_doc.
Pros:
- faster `get_doc`
- lower memory usage on Redis
- Reduces chances of OOM by blowing up worker's memory as old docs can't
be GCed until
- Correctness i.e. caching only what gets used from cache.
Con:
- After this change. First call to `get_cached_doc` will always be a cache miss. DUH.
2022-06-06 16:18:23 +05:30
Ankush Menat
d3b366f147
feat: cache_locally to limit caching in local.cache
2022-06-06 16:18:23 +05:30
Gavin D'souza
50b0eb8cca
perf: Initialize Query engine only if used
2022-06-06 15:42:59 +05:30
Gavin D'souza
cc16342bb8
fix(filter): Fetch correct filter values
2022-06-06 15:31:47 +05:30
Ankush Menat
dd62749948
Merge pull request #17071 from ankush/quick_awesomebar
...
feat(workspace): start searching on alphabetic keypress
2022-06-06 15:21:53 +05:30
gavin
c8207768db
Merge branch 'develop' into filters_config-fixes
2022-06-06 15:03:06 +05:30
Ankush Menat
c7b0351d0e
Merge branch 'develop' into pg_transaction_management
2022-06-06 14:37:29 +05:30
gavin
27ddfae59b
Merge pull request #17074 from frappe/revert-16978-mention-permissions
...
Revert "fix: mention only users that can be read"
2022-06-06 13:57:08 +05:30
gavin
be6183d408
Merge pull request #17066 from gavindsouza/allow-relative-restore-paths
...
fix(restore): Remove incorrect validation that doesn't allow relative paths
2022-06-06 13:42:01 +05:30
Ritwik Puri
d9900d4742
Revert "fix: mention only users that can be read ( #16978 )"
...
This reverts commit 576af52ec6
2022-06-06 13:14:09 +05:30
HENRY Florian
e0c25d2b2c
fix: update fr translation ( #17070 )
2022-06-05 22:38:52 +05:30
Ankush Menat
3272852b12
fix(UX): blur awesomebar after selecting result
2022-06-05 20:15:39 +05:30
Ankush Menat
0890046349
fix: dont show KB shortcut with no description
2022-06-05 20:15:39 +05:30
Ankush Menat
a65940e1c1
feat(UX): start typing on workspace to launch awesomebar
2022-06-05 20:15:36 +05:30
Ankush Menat
359c7768f5
fix: multiple postgres transaction abort issues
...
- wrap setup fixtures in savepoint
- wrap scheduled_job_type in savepoint
- ignore duplicates where it's ignored by exc
- dont attempt to delete from deleted table
- delete custom field and commit - stale meta causes future inserts to
insert unknown field.
2022-06-05 00:26:15 +05:30
Ankush Menat
8861752675
fix: restart transaction after commit
2022-06-05 00:26:12 +05:30
Ankush Menat
654ded1a05
chore: print full stack on postgres DB errors
2022-06-04 22:42:03 +05:30
Gavin D'souza
e13df5ba49
fix(restore): Remove incorrect validation that doesn't allow relative paths
2022-06-04 18:20:44 +05:30
Ankush Menat
9137a597eb
ci: update apt cache ( #17057 )
2022-06-02 14:40:14 +05:30
Deepesh Garg
ce45bafb6e
Merge pull request #17054 from deepeshgarg007/v14-beta-release-fix
...
chore: fix semantic release config
2022-06-02 12:07:30 +05:30
Deepesh Garg
ebd2bd791c
chore: fix semantic release config
2022-06-02 12:06:37 +05:30
Suraj Shetty
830ace2c36
Merge pull request #17021 from surajshetty3416/fix-document-signature-2
2022-06-01 20:31:15 +05:30
Suraj Shetty
2c95434114
style: Fix linter warnings
2022-06-01 19:57:28 +05:30
Suraj Shetty
a4d7cfdd24
fix: Update exception message
2022-06-01 19:53:57 +05:30
Suraj Shetty
121fb49fb5
refactor: Remove unnecessary code
2022-06-01 18:10:30 +05:30
Suraj Shetty
0cd41fbf0c
Merge branch 'develop' into fix-document-signature-2
2022-06-01 18:01:12 +05:30
Suraj Shetty
58d0bcd736
Merge pull request #17046 from surajshetty3416/fix-error-page
...
fix: Catch any exception and show proper error page
2022-06-01 18:00:46 +05:30
Suraj Shetty
105b398c68
fix: Randomize key length to make it harder to brute force
2022-06-01 17:59:44 +05:30
