Commit graph

33138 commits

Author SHA1 Message Date
Sagar Vora
d2becc7f1d fix: no API call required to set cookie in browser 2023-07-22 17:54:41 +05:30
Shariq Ansari
95167a19df fix: remove store from each control 2023-07-22 13:07:50 +05:30
Shariq Ansari
c58f4e152c fix: separate fetch from field code from text control 2023-07-22 12:53:45 +05:30
Ankush Menat
9608c32db7
perf: lazy load dashboard links (#21752) 2023-07-21 13:10:30 +05:30
Faris Ansari
ebacca3863
fix: better job naming for enqueue_doc (#21755)
DocType.method instead of frappe.utils.background_jobs.run_doc_method
2023-07-21 11:45:06 +05:30
Ankush Menat
fb2ab0b5be
Merge pull request #21737 from ankush/perf/workflow_transitions
perf: workflow transitions and bulk workflow
2023-07-20 17:30:40 +05:30
Gughan Ravikumar
b2d32a2d63
Don't allow export of Virtual DocFields (#21749) 2023-07-20 17:25:12 +05:30
Ankush Menat
c90374c286 perf: Lazily compute common workflow transitions 2023-07-20 16:45:23 +05:30
Ankush Menat
e2bd9d5269 fix(rq_worker): show current job iff for same site 2023-07-20 14:05:24 +05:30
Ankush Menat
96e6291692
fix: don't allow setting 0 as max backups (#21747)
This causes new backups to get deleted immediately.

If you want only 0 backups, then don't take backups.
2023-07-20 13:52:54 +05:30
Shariq Ansari
a34d87d440
Merge pull request #21706 from shariquerik/oauth-confirm-screen 2023-07-20 12:22:07 +05:30
Ankush Menat
c2a5adadbe
fix: actually debounce list view updates (#21738)
Immediately debouncing and executing creates a new function everytime and doesn't actually "debounce" it just "delays". 🗿

[skip ci]
2023-07-19 20:42:43 +05:30
Ankush Menat
948b24ee04 fix: duplicate on_row_checked call 2023-07-19 19:38:07 +05:30
Ankush Menat
06a905f600 fix: disable list view updates during bulk approval
Also defer document refreshes by up to 5 seconds.

Rarely anyone needs truly realtime list view updates. It's better batch
them over at least 5 or so seconds if there's a high volume of changes.
2023-07-19 19:38:05 +05:30
Ankush Menat
453892cdef
fix!: Dont show bold fields in quick entry. (#21733)
IDK if "BOLD" implies it should be shown in quick entry.
Frequent misunderstanding: https://github.com/frappe/frappe/issues/21726
2023-07-19 17:27:26 +05:30
Ankush Menat
892c5e30a2 refactor: Simpler workflow caching
Entire document is cached, so no need to create another layer of cache.
2023-07-19 16:45:44 +05:30
Ankush Menat
d68e46d2cc fix: disable workflow emails by default
make it opt-in instead.
2023-07-19 16:45:44 +05:30
Ankush Menat
42aff950ce
feat(DX): normalize queries in recorder (#21735)
Attempt to normalize query by removing "variables"
This gives a different view of similar duplicate queries.

These two are distinct queries:
```sql
select * from user where name = 'x'
select * from user where name = 'z'
```

But their "normalized" form would be same:
```sql
select * from user where name = ?
```

This helps highlight queries ran in loop which might not register as
duplicate but are possibly "duplicate".
2023-07-19 16:45:30 +05:30
Shariq Ansari
ce79dd0b89 fix: increase form builder height 2023-07-19 12:44:40 +05:30
Ritwik Puri
5b547d5665
Merge pull request #21724 from phot0n/allow-bulk-retry-email
fix: allow users having access to email queue to bulk retry sending
2023-07-19 02:12:59 +05:30
phot0n
df3f6b3a9f fix: allow users having access to email queue to bulk retry sending 2023-07-19 02:11:10 +05:30
Shariq Ansari
264372a2a3 fix: show list of user details that we are giving access to if scope is openid 2023-07-18 20:53:31 +05:30
barredterra
c39473b9b0 fix: invalidate cache when language is updated 2023-07-18 13:02:08 +02:00
barredterra
588bbd9d1c fix: include languages when clearing website cache 2023-07-18 12:53:57 +02:00
mergify[bot]
9c481cfd68
Merge pull request #21680 from resilient-tech/compare-amended-from
fix: compare with `doc.amended_from` while saving version for newly amended doc
2023-07-18 04:22:32 +00:00
Gursheen Kaur Anand
149467a71b
fix: fetch portal sidebar items (#21703) 2023-07-18 09:34:52 +05:30
Shariq Ansari
06d8a6ba9b fix(UI): pae layout breaking after upgrading bootstrap to v4.6.2 2023-07-17 17:49:02 +05:30
Sagar Vora
86f0c4e52c fix: store version for name 2023-07-17 16:13:44 +05:30
Sagar Vora
7d7c440a1b fix: compare with doc.amended_from while saving version for newly amended doc 2023-07-17 16:04:28 +05:30
Shariq Ansari
cbe9ec26bd fix: do not show Home primary button 2023-07-17 15:48:30 +05:30
Sagar Vora
4684e72142 fix: use current redirect URIs instead of legacy ones 2023-07-17 14:29:22 +05:30
Shariq Ansari
539607d87a fix(UX): OAuth confirm access screen 2023-07-17 13:09:38 +05:30
Ankush Menat
8436f775a5
feat(DX): PEP517 compatible build in new apps (#21704)
* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes https://github.com/frappe/frappe/issues/21612
2023-07-17 12:56:41 +05:30
Deepesh Garg
e38078a69f
test: Patch hooks for testing (#21702)
* test: Patch hooks for testing

* test: hooks patcher

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-07-17 12:41:27 +05:30
Raffael Meyer
b6cd6535db
feat: better Email search (#20323)
* refactor: get_contact_list

* test: get_contact_list

* feat: search all emails, not just the primary one
2023-07-17 00:40:17 +05:30
Ankush Menat
3f142c1dce fix: respect system setting for tracebacks
closes https://github.com/frappe/frappe/issues/19826
2023-07-16 19:18:16 +05:30
Ankush Menat
19f962975a fix: report name without filters 2023-07-16 17:29:28 +05:30
Ankush Menat
8f9b89557b fix: double urlencoding 2023-07-16 17:23:39 +05:30
Shariq Ansari
d423dedcd3
Merge pull request #21377 from shariquerik/move-form-builder-in-doctype-form 2023-07-16 14:38:08 +05:30
Shariq Ansari
628bdd18d2 fix: allow to add all states even if it is already added 2023-07-16 13:40:06 +05:30
Shariq Ansari
ae8af1d1d3 fix: removed unused form builder page 2023-07-16 13:30:14 +05:30
Shariq Ansari
4763dd5293 fix: show fields table for fallback also in customize form 2023-07-16 13:26:12 +05:30
Shariq Ansari
b3333b803c fix: throw error and store save if validation fails 2023-07-16 13:24:24 +05:30
Ankush Menat
8f552b8fe2
Merge pull request #21695 from ankush/perf/desk_requests
perf(desk): reduce unnecessary requests on first load
2023-07-16 13:06:16 +05:30
Deepesh Garg
e32e74f2f1
feat: Custom naming series parser via hooks (#21690)
* feat: Custom naming series parser via hooks

* chore: use assignment operatot

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

* test: Unit test for custom parser

* test: Unit test for custom parser

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-07-16 12:57:40 +05:30
Ankush Menat
d9a698d4c5 fix: lower rapid-reload threshold 2023-07-16 12:43:47 +05:30
Ankush Menat
54b36e8604 perf: lazy load tag list for awesome bar
In last 7 days not a single person has used this feature on FC (based on
endpoint logs).

fix: When user knowingly triggers by typing text starting with `#` we
fire request to get tags lazily.
2023-07-16 12:43:47 +05:30
Ankush Menat
b919618032 perf: eliminate request for user permissions
This is ALWAYS required, then it can just be part of boot. Eliminates 1
unnecessary request.
2023-07-16 12:43:43 +05:30
Shariq Ansari
3b2f2ef418 test: fix sidebar UI Test 2023-07-16 12:06:48 +05:30
Ankush Menat
52c2e6d47b fix: Accurately determine rapid reloads
Assuming rapid-reload ~= user frustrated with old assets. We weren't
actually checking if load was "reload". This cleared cache when tabs
were opened and effectively made cache useless.
2023-07-15 22:02:30 +05:30