Commit graph

22821 commits

Author SHA1 Message Date
mathieu.brunot
d38e9855be
Merge remote-tracking branch 'origin/develop' into ci/reports
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
2019-12-14 14:38:43 +01:00
mergify[bot]
62baf3e7cf
Merge pull request #9037 from surajshetty3416/fix-desk-modules
fix: Add a patch to fix all user's home settings
2019-12-14 12:35:31 +00:00
mergify[bot]
59613665e7
Merge pull request #9026 from surajshetty3416/fix-report-column-hide
fix(report): Hidden columns should be hidden even after refresh
2019-12-14 12:16:54 +00:00
Suraj Shetty
09ec275c2b fix: Remove limit 2019-12-14 17:44:17 +05:30
Suraj Shetty
310233c56a
fix: Show default currency as a fallback for currency fieldtype (#8944)
* fix: Show default currency as a fallback for currency fieldtype

* test: Add a test for currency formatting
2019-12-14 17:34:04 +05:30
Prssanna Desai
e5c1f80071 fix(Grid): Child table pagination fixes (#9034)
* fix: don't render result if grid_rows is undefined and fix truncate_rows

* fix: change page length to 50

* fix: grid pagination ui test

* fix: confirm before deleting all child table rows
2019-12-13 22:35:27 +05:30
mergify[bot]
579ebb8b81
Merge pull request #9038 from prssanna/upload-fix
fix: grid file upload fix
2019-12-13 12:12:33 +00:00
prssanna
ce7929e1e2 fix: grid file upload fix 2019-12-13 15:56:59 +05:30
Suraj Shetty
129bc14495 fix: Add a patch to fix all user's home settings 2019-12-13 14:09:23 +05:30
Himanshu
f9777268b8 feat: add default email account for email linking (#8833)
* feat: add default email account for email linking

* fix: remove unused import

* fix: remove try-catch
2019-12-12 16:10:56 +00:00
Suraj Shetty
d1c0579c70 fix(file): Public-private issue (#9029)
* fix: Pass file's is_private for doc creation

* fix: File is_private and file_url mismatch

* fix: Check if file_url exists

* fix: Validation check

* fix(postgres): Convert is_private to int

* fix: File path for content_hash
2019-12-12 20:00:30 +05:30
Khushal Trivedi
6ab38c2af5 fix: link field search taking trailing and leading spaces (#9031) 2019-12-12 19:24:17 +05:30
Oshosanya Michael
8a11fb57cd feat: Allow full database config on creating site (#8874)
* Allow setting db port on install

* Allow setting db port on install

* Allow full db config on creating site

* bug fix

* bug fix

* Escape character

* Update frappe/commands/site.py

allow only integer argument

Co-Authored-By: Chinmay Pai <chinmaydpai@gmail.com>

* Update frappe/database/db_manager.py

No need to escape integer variable

Co-Authored-By: Chinmay Pai <chinmaydpai@gmail.com>

* cast port to integer to surpress pymysql error

* cast port to string to surpress pymysql error

* Removed type casting
2019-12-12 13:17:07 +05:30
Shivam Mishra
eeabcb8155 fix: height for null state on list view (#8997)
* fix: height for null state on list view

* Update list.less
2019-12-12 11:51:20 +05:30
Suraj Shetty
80fd42aba2 fix: Hidden columns should be hidden even after refresh 2019-12-12 11:35:22 +05:30
mergify[bot]
e689b7adfd
Merge pull request #9008 from Thunderbottom/auto-commit-prepared-rep
fix(patch): auto commit on more than 10000 writes
2019-12-12 05:47:32 +00:00
Prssanna Desai
90f89a754a fix(Leaderboard): Leaderboard timespan options (#8953)
* fix: change leaderboard timespan options and add select from date option

* fix: leaderboard timespan options grouping and add quarter_start and quarter_end to datetime.js

* fix: codacy

* fix: add last month
2019-12-11 21:28:59 +05:30
rohitwaghchaure
234ab445a8
Merge pull request #8974 from rohitwaghchaure/fixed_css_for_dashboard_progress_bar
fix: padding for progress bar in dashboard
2019-12-11 12:24:32 +05:30
mergify[bot]
7509736c21
Merge pull request #9015 from zerodhatech/develop
fix(filters): set default id to empty string instead of 0
2019-12-11 06:35:04 +00:00
Shridhar
b3b70f3b7f Bug fixed ID value should not be set to 0 by default 2019-12-11 09:21:17 +05:30
mergify[bot]
5613c78ebf
Merge pull request #9009 from frappe/perm-error
fix: permission error
2019-12-10 18:58:38 +00:00
mergify[bot]
315ea7a2a4
Merge pull request #9012 from Mangesh-Khairnar/fix-scheduler
fix(scheduler): import update site config
2019-12-10 13:07:09 +00:00
Saqib
b0622255d4 revert: changes in currency formatting (#8996)
* fix: reverted currency formatting

* ux: added description for currency's number format
* It doesn't have any effect on how the currency is formatted.

* fix: revert json changes in currency master
2019-12-10 15:50:26 +05:30
Mangesh-Khairnar
a87ca0a6a9 fix(scheduler): import update site config 2019-12-10 15:19:46 +05:30
Shivam Mishra
37dba69db0
fix: permission error 2019-12-10 11:42:25 +05:30
Chinmay D. Pai
deaa865fa8
fix(patch): auto commit on more than 10000 writes
fixes issue where patch fails with:

frappe.exceptions.ValidationError: Too many writes in one request. Please send smaller requests

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-10 09:16:37 +05:30
mergify[bot]
acc27a147a
Merge pull request #8963 from prssanna/next-doc-fix
fix: Ambiguous column error when going to next doc
2019-12-09 16:58:17 +00:00
Mangesh-Khairnar
710947c66c fix(autocomplete): parse options (#8998)
* fix(autocomplete): parse options

* fix: add ignore validation flag

* fix: minor change
2019-12-09 15:17:06 +00:00
Chinmay Pai
d169f41a54 fix(email): try to encode email part to utf-8 (#8965)
fixes issues with class objects other than str

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/doctype/email_account/email_account.py", line 281, in receive
    communication = self.insert_communication(msg, args=args)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/doctype/email_account/email_account.py", line 338, in insert_communication
    email = Email(raw)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 372, in __init__
    self.parse()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 393, in parse
    self.process_part(part)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 445, in process_part
    self.text_content += self.get_payload(part)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 489, in get_payload
    charset = self.get_charset(part)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 484, in get_charset
    charset = chardet.detect(frappe.safe_encode(part))['encoding']
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/chardet/__init__.py", line 34, in detect
    '{0}'.format(type(byte_str)))
TypeError: Expected object of type bytes or bytearray, got: <class 'email.message.Message'>

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-09 19:25:43 +05:30
prssanna
3bd310b2e1 fix(tests): add UI test for next previous document navigation 2019-12-09 19:20:55 +05:30
Rushabh Mehta
7328abe30d
fix: make padding a bit more consistent 2019-12-09 18:19:02 +05:30
mergify[bot]
34a696f397
Merge pull request #8949 from scmmishra/chart-opts-query-report
fix: query report chart options
2019-12-09 11:38:11 +00:00
mergify[bot]
75a1eb9653
Merge pull request #8994 from scmmishra/summary-details
fix: summary tag should have cursor pointer
2019-12-09 11:32:46 +00:00
mergify[bot]
499897a3c5
Merge pull request #8969 from Alchez/dev-sign-up-role
fix: add default role on sign up via SSO
2019-12-09 11:14:32 +00:00
Rohit Waghchaure
2477d5eb37 fix: padding for progress bar in dashboard 2019-12-09 13:25:28 +05:30
mergify[bot]
0ec968414c
Merge pull request #8993 from saurabh6790/scheduled_job_type_frequency
fix: add hourly long frequency to scheduled job type
2019-12-09 06:14:47 +00:00
Shivam Mishra
d3fecebd83 feat: summary tag should have cursor pointer 2019-12-09 11:28:44 +05:30
Saurabh
ae418b90c5 fix: add hourly long frequency to scheduled job type 2019-12-09 11:13:45 +05:30
mergify[bot]
c63db4777a
Merge pull request #8980 from rohitwaghchaure/fixed_xml_file_not_able_to_download_develop
fix: not able to download XML file
2019-12-08 07:32:41 +00:00
mergify[bot]
a1e18f9c5b
Merge pull request #8906 from ruchamahabal/list_group_by_filter_fix
fix: list view group by filter ambiguous column name
2019-12-08 06:13:56 +00:00
mergify[bot]
923a823002
Merge pull request #8982 from Thunderbottom/password-reset-fix
fix(security): invalidate reset_password_key on password reset
2019-12-08 04:24:00 +00:00
mergify[bot]
9be88c6961
Merge pull request #8706 from hrwX/pref_global_search
fix: Missing results in global search
2019-12-08 04:18:09 +00:00
Chinmay D. Pai
35024c18fc
fix(security): invalidate reset_password_key on password reset
currently there is no way to invalidate reset_password_key on updating
password through the user settings. so whenever the user sets a new
password we'll invalidate the reset_password_key, so that existing links
to reset user passwords cannot be used.

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-07 19:00:54 +05:30
Rohit Waghchaure
80f87a37fb fix: not able to download XML file 2019-12-07 12:53:04 +05:30
mergify[bot]
2743863407
Merge pull request #8977 from Thunderbottom/background-job-fix
fix: use get_status for rq job status
2019-12-06 18:01:44 +00:00
Chinmay D. Pai
196b2ad254
fix: use get_status for rq job status
job.status has been replaced with job.get_status() in the latest release (1.0)

https://github.com/rq/rq/releases/tag/v1.0

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-06 22:43:49 +05:30
rohitwaghchaure
fe78181fde
Merge pull request #8976 from rohitwaghchaure/fixed_patch_reload_doc_doc_for_v12
fix: patch
2019-12-06 18:27:22 +05:30
Rohit Waghchaure
f772e6ab22 fix: patch 2019-12-06 18:22:46 +05:30
rohitwaghchaure
0672efc2a5
Merge pull request #8975 from rohitwaghchaure/fixed_patch_reload_doc_doctype_action
fix: patch
2019-12-06 18:07:51 +05:30
Rohit Waghchaure
86ecf4fbc1 fix: patch 2019-12-06 18:06:52 +05:30