vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
33855 commits 1 branch 0 tags 587 MiB
Commit graph

33855 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gavin D'souza
d5739cd43b fix: Add exceptions classes for Newsletter 2021-08-12 16:47:01 +05:30
Gavin D'souza
a5010af92a test: Update tests for Newsletter 
Added tests for better coverage: Increased to 77% ~ near complete
coverage of controller class, missing tests for API endpoints
 2021-08-12 16:17:31 +05:30
Gavin D'souza
c5eb78edd7 refactor: Simplify validations, fix test_send 2021-08-12 16:12:04 +05:30
Gavin D'souza
83f56f2c45 Merge branch 'develop' of github.com:frappe/frappe into newsletter-refactor 2021-08-12 11:14:48 +05:30
mergify[bot]
c2524c797f
Merge pull request #13395 from nextchamp-saqib/chart-in-custom-script-reports-dev 
feat: allow duration fields in aggregate function fields
 2021-08-12 03:51:21 +00:00
mergify[bot]
579e73d7df
Merge pull request #13839 from ankush/report_source_url 
fix(DX): sourceURL to debug report and page JS
 2021-08-12 03:37:53 +00:00
Gavin D'souza
b28a5beb53 refactor(minor): Newsletter Controller 
* Resolve conflicting methods in the controller
* Add docstring
 2021-08-11 21:01:56 +05:30
Gavin D'souza
cda48832f4 chore(test): Update API usages 
Striving for better readability

* Use frappe.db.delete instead of frappe.db.sql
* Use named kwargs instead of positional
 2021-08-11 20:49:32 +05:30
Gavin D'souza
e80d5f25c6 refactor: Newsletter failure handling 
Don't raise after handling generic Exception class. Just log error and
go on. This way, other newsletters will continue to loop instead of
breaking after one failure

Added more context (docname) to logged error
 2021-08-11 20:49:32 +05:30
Gavin D'souza
46c6b6621e refactor: Newsletter 
* Re-send Newsletter only to the recipients who haven't received it yet (Check Email Queue before setting email recipients)
* Re-structed code, broken larger methods to "byte" sized "bits" (hehe)
* Added validations for recipients list
* Added Newsletter.newsletter_recipients property
* Used newer APIs and Fixed namespaces for usages/imports
* Added convenience methods for Newsletter APIs
* Added type annotations for all(?) methods
 2021-08-11 20:48:59 +05:30
mergify[bot]
86e512452d
Merge pull request #13855 from netchampfaris/frappe-scanner 
feat: frappe.ui.Scanner
 2021-08-11 09:34:39 +00:00
Mohammad Hasnain Mohsin Rajan
b4453396f4
fix: website_content_field based indexing fails since fields are not passed correctly(#13907) 2021-08-11 12:23:03 +05:30
mergify[bot]
be5f7125cf
Merge pull request #13777 from jon-nfc/issue-13738 
feat: Improve LDAP implementation to be standards compliant
 2021-08-11 06:01:55 +00:00
mergify[bot]
29203416ad
Merge pull request #13904 from saxenabhishek/aks-style-qb 
style: split qb.table into doctype and table
 2021-08-11 05:24:34 +00:00
Saqib Ansari
23d8c336b4 chore: ignore console statements 2021-08-10 19:47:44 +05:30
Saqib Ansari
e742719c56 Merge branch 'develop' of https://github.com/frappe/frappe into frappe-scanner 2021-08-10 19:46:05 +05:30
Suraj Shetty
17882e4633
Merge branch 'develop' into chart-in-custom-script-reports-dev 2021-08-10 11:12:50 +05:30
mergify[bot]
25fcc60d7a
Merge pull request #13891 from Komal-Saraf0609/timeline_cancel_functionality 
test: Added test case for cancel functionality
 2021-08-10 05:37:51 +00:00
Suraj Shetty
1d878199f1
Merge pull request #13899 from surajshetty3416/fix-print-format-header 2021-08-10 11:05:35 +05:30
Suraj Shetty
dfa1c688fb
Merge pull request #13889 from surajshetty3416/core-test-coverage 2021-08-10 10:56:44 +05:30
mergify[bot]
afd69729de
Merge pull request #13835 from MitulDavid/image-processing 
feat: Image cropping and optimization
 2021-08-10 05:16:08 +00:00
Suraj Shetty
291d7b0f16 fix: Call is_rtl function to get the actual value 2021-08-10 10:13:19 +05:30
MitulDavid
401b56ee39 fix: Image with .jpeg extension breaks file uploader 2021-08-10 08:26:44 +05:30
mergify[bot]
a6d9170e5f
Merge pull request #13878 from AfshanKhan/fix-date-formatting-for-babel 
fix: format string for formating date
 2021-08-09 16:20:11 +00:00
Komal-Saraf0609
b46b5546f7 test: Corrected function description and shorten some of the selectors by removing unwanted classes 2021-08-09 20:42:26 +05:30
Saqib Ansari
99442cca4a fix: hide empty dialog if camera not found 2021-08-09 18:44:24 +05:30
Saqib Ansari
51e45de747 feat: Barcode option for data fields 2021-08-09 17:55:47 +05:30
Saqib Ansari
5058a77056 feat: handle exceptions on scan 2021-08-09 17:55:11 +05:30
Saqib Ansari
d20ed0edd7 feat: stop scanning on dialog hide 2021-08-09 17:51:22 +05:30
Saqib Ansari
a028e9f830 fix: undefined variable errorMessage 2021-08-09 17:30:50 +05:30
MitulDavid
ccfe4a857c refactor: Minor changes to doc image upload, UI test 2021-08-09 17:28:57 +05:30
Leela vadlamudi
40362c0ac5
Merge pull request #13861 from leela/amended-doc-naming 
refactor: set amended docname to original docname
 2021-08-09 17:22:55 +05:30
Komal-Saraf0609
eb669c16f6 test: fixing sider issues 2021-08-09 17:17:27 +05:30
Komal-Saraf0609
716452ea69 test: Added test case for cancel functionality 2021-08-09 16:48:49 +05:30
Suraj Shetty
aea6e55a50
Merge branch 'develop' into core-test-coverage 2021-08-09 15:58:58 +05:30
mergify[bot]
7915e20cba
Merge pull request #13885 from ChillarAnand/handler 
fix: Show command and error message when an exception is raised
 2021-08-09 10:28:13 +00:00
ChillarAnand
703edfed73 fix: Show command and error message when an exception is raised 2021-08-09 15:34:52 +05:30
leela
80d111baf2 refactor: set amended docname to original docname 
Currently, whenever a document is amended it's name is set
to name-X(X is a counter) when amended again and so on. In this PR,
we have postfixed all cancelled document names with '-CAN' and new
cancelled documents gets a name as original_name-CANC-X.
so that amended docs can use the original name instead of name-X.
 2021-08-09 14:59:07 +05:30
Suraj Shetty
a1a18a917e
Merge pull request #13883 from frappe/db-set-no-reload-doc-before-save 
fix: do not reset doc_before_save on db_set
 2021-08-09 14:34:01 +05:30
Saqib Ansari
37b59acd2f Merge branch 'develop' of https://github.com/frappe/frappe into frappe-scanner 2021-08-09 14:02:47 +05:30
Saqib Ansari
0cf2fd9b5c Merge branch 'frappe-scanner' of https://github.com/netchampfaris/frappe into frappe-scanner 2021-08-09 14:02:37 +05:30
mergify[bot]
dbcf05481f
Merge pull request #13879 from ankush/fix_child_validation 
fix: validate code fields of children too
 2021-08-09 07:07:42 +00:00
Suraj Shetty
92a3c3be8e
Merge branch 'develop' into db-set-no-reload-doc-before-save 2021-08-09 10:26:57 +05:30
Suraj Shetty
49684ca399 refactor: Make coverage context manager 
- Decoupled coverage code from testing to setup code coverage before any import happen to get accurate coverage (before it used to skip import statements for some files)
 2021-08-09 09:50:41 +05:30
mergify[bot]
77c6f5d955
Merge pull request #13857 from hasnain2808/wrapable-code-editor 
feat: wrappable code editor
 2021-08-09 03:30:32 +00:00
MitulDavid
11eefe3eee test: Add test for image cropping and optimization UI 2021-08-08 18:09:58 +05:30
MitulDavid
cd3fb58fc6 refactor: Image optimization checkbox 2021-08-08 17:46:09 +05:30
Saif
7400d7ca37
fix: do not reset doc_before_save on db_set 2021-08-07 13:09:28 +05:00
Your Name
946243d511 style: split qb.table into doctype and table 2021-08-07 03:31:35 +05:30
Afshan
c7ad1be6b8 fix: format string for formating date 2021-08-06 22:10:37 +05:30