Commit graph

36127 commits

Author SHA1 Message Date
Gavin D'souza
d5b3fc04e0 fix: Breaking backup tests due to site settings 2022-01-13 13:25:32 +05:30
Gavin D'souza
9e281e7b19 refactor: Test Commands
* Separate out test case for backup cases
  * Split each case into separate tests
  * Add teardown to remove files geenrated in custom paths
* Rename test that wasn't running
* Rename test cases for consistency
2022-01-12 16:01:03 +05:30
mergify[bot]
a54bf39ec3
Merge pull request #15591 from sumaiya2908/html-editor-fixes
fix: html mode for ace editor
2022-01-12 07:14:33 +00:00
Rushabh Mehta
712cf9563e
Merge pull request #15563 from Alchez/dev-connected-app-auth-url
fix: allow longer authorization URIs
2022-01-12 12:19:16 +05:30
Rushabh Mehta
beada02a7e
Merge pull request #15436 from sumaiya2908/cleanup-portal
refactor(UI): cleanup portal pages
2022-01-12 10:36:03 +05:30
Summayya
75c0e76030 fix: html mode for ace editor 2022-01-11 19:33:30 +05:30
mergify[bot]
85fc42a1ea
Merge pull request #15549 from nextchamp-saqib/handle-504-errors
fix: catch exceptions while parsing json on request failure
2022-01-11 13:28:38 +00:00
Summayya
9ce0031d7c refactor: code indentation 2022-01-11 18:18:50 +05:30
Summayya
425f6eca43 refactor: code indentation 2022-01-11 18:17:09 +05:30
Ankush Menat
eeff2a22f8
fix: enable languages inserted during setup (#15588) 2022-01-11 18:13:11 +05:30
Suraj Shetty
0c23852287
Merge branch 'develop' into cleanup-portal 2022-01-11 17:44:01 +05:30
Suraj Shetty
cfc55c7597
Merge pull request #15586 from surajshetty3416/fix-date-control 2022-01-11 17:02:53 +05:30
Saqib Ansari
6a55fd535d Merge branch 'develop' of https://github.com/frappe/frappe into handle-504-errors 2022-01-11 14:35:52 +05:30
mergify[bot]
6f8f792c01
Merge pull request #15574 from resilient-tech/fix-limit-in-get-method
fix: limit in `Document.get`
2022-01-11 08:18:12 +00:00
Suraj Shetty
1d1ed171a1 fix: Pass date object instead of string for selectDate to work
"Today" button was not working because get_now_date was returning string
2022-01-11 13:47:27 +05:30
Summayya Hashmani
645fde2e67
fix: email fetch error for imaplib (#15581)
* fix: remove maxline for imaplib

* refactor: remove redundant line

Co-authored-by: Summayya <frappe@Summayyas-MacBook-Air.local>
2022-01-11 08:11:38 +00:00
mergify[bot]
2081f485c8
Merge pull request #15354 from cpdeethree/frappe-postgres-changes
fix: SQL queries to improve Postgres support
2022-01-11 08:09:05 +00:00
cpdeethree
58f7b02c30 fix: add test_for prepare_select_args 2022-01-11 13:25:40 +05:30
Suraj Shetty
4b5e67e165
Merge pull request #15580 from surajshetty3416/fix-datetime-control 2022-01-11 11:16:35 +05:30
Pruthvi Patel
a87899c215 test: add test for limit 2022-01-11 11:12:53 +05:30
Suraj Shetty
3d77f544fd fix(datetime): Fix side-effect due to __run_link_triggers
- `__run_link_triggers` should only affect link fields
- Removed usage of `__run_link_triggers` from base control and introduce `force_set_value` for more explicit action.
2022-01-11 10:09:14 +05:30
mergify[bot]
5feebe22b0
Merge pull request #15569 from ankush/drop_py37
fix!: drop py3.7 support for v14
2022-01-10 11:28:06 +00:00
mergify[bot]
2446c5e099
Merge pull request #15564 from Havenir/fix-communication-get-contacts
fix: communication method "get_contacts"
2022-01-10 11:22:35 +00:00
Pruthvi Patel
d1852242a0 fix: limit in Document.get 2022-01-10 15:52:25 +05:30
Ankush Menat
3d474b5927 fix: drop py3.7 support for v14 2022-01-10 13:45:18 +05:30
Ahmad
9ebfc1ced9 refactor: communication.py 2022-01-07 17:33:54 +05:00
Ahmad
6afa5c8da3 fix: email_string parsing when pulling email 2022-01-07 17:33:35 +05:00
Rohan Bansal
10c5e732a5 fix: allow longer authorization URIs 2022-01-07 17:54:28 +05:30
Saqib Ansari
1bde3b48bd fix: parsing exception from traceback 2022-01-07 14:56:25 +05:30
Saqib Ansari
307c7ced69 chore: check custom exception handlers only for json response 2022-01-07 14:55:54 +05:30
Gavin D'souza
981564e544 Merge branch 'develop' into frappe-postgres-changes 2022-01-07 11:37:28 +05:30
Gavin D'souza
d9b571cf43 refactor(minor): DatabaseQuery.prepare_select_args
* Used regex to replace instead of re-iteration (for-loop)
* Used f-strings for better readability
* Renamed and re-ordered vars, code block
2022-01-07 11:35:52 +05:30
Suraj Shetty
b64cab6867
Merge pull request #15543 from alyf-de/white-space-unset 2022-01-07 11:16:58 +05:30
mergify[bot]
7f74a3164d
Merge pull request #15551 from hrwX/custom_translations
feat: add translations to datatable
2022-01-07 05:25:03 +00:00
Conor
55392b64e7 fix: Revert changes made to fix collation differences
Due to collation differences in MariaDB and Postgres, tests gave
inconsistent results. This was to be handled in tests alone instead of
the application. It was unnecessary. Collation changes should be made at DBMS config
level only. Accomodating for those in the application will unnecessarily
degrade performance for everyone.

Other changes:
* use pluck in user_type
* revert ordering in nestedset
* revert parsing in order_field
* use preferred APIs & styling

Co-authored-by: gavin <gavin18d@gmail.com>
2022-01-07 10:45:10 +05:30
Conor
1c40881c41 fix: refactor postgres arg prep into its own function 2022-01-07 10:45:05 +05:30
Conor
40ba1ac9ba fix: Postgres Compatibility
* Handle inconsistencies in type handling in DatabaseQuery & Database
  APIs
* Update incompatible queries with frappe.qb notation
* Fixed use cases discovered by failing ERPNext CI tests

fix: db independent syntax for user_type

fix: handle postgres datetime values

feat: add ability to auto commit on db inserts

feat: add ability to escape underscore in postgres

fix: handle missing data in test runner bootstrapping

fix: db independent syntax for queries

fix: refactor to use qb

fix: update cache for language

fix: use pluck in email_queue

Co-authored-by: gavin <gavin18d@gmail.com>

fix: don't auto insert on tests for make_property_setter

fix: remove auto_commit in custom_field insertion

fix: remove auto_commit functionality

fix: review comments

fix: revert link validation

fix: style suggestion for readability

Co-authored-by: gavin <gavin18d@gmail.com>

fix: revert .lower() in link validation

fix: add rollback for setup_wizard

Revert "fix: add rollback for setup_wizard"

This reverts commit 83b3b0913db17718ccd5edae01858cff15603829.

Revert "feat: add ability to escape underscore in postgres"

This reverts commit 8ed9c2aa3306438e94bb813f60e65b416d0b947b.

fix: more concise representation of order fields

Co-authored-by: gavin <gavin18d@gmail.com>
2022-01-07 10:44:57 +05:30
Suraj Shetty
d52f12424a
Merge branch 'develop' into custom_translations 2022-01-07 09:45:14 +05:30
Summayya
6d98860386 fix: my account link unclickable 2022-01-06 21:08:21 +05:30
mergify[bot]
2aa062720a
Merge pull request #14978 from hrwX/multistep_webforms
feat: Multistep webforms
2022-01-06 15:15:32 +00:00
barredterra
ea5695700c feat: add german translations for datatable menu 2022-01-06 15:52:05 +01:00
Raffael Meyer
f04be3f876
fix: sider 2022-01-06 15:44:29 +01:00
barredterra
24ac11c98f fix: update yarn.lock 2022-01-06 15:43:17 +01:00
mergify[bot]
7a6ddb15be
Merge pull request #15554 from shariquerik/single-card-form-fix
fix: Single card form css fix in dark mode
2022-01-06 14:14:56 +00:00
Suraj Shetty
f930fd0fe1
Merge branch 'develop' into multistep_webforms 2022-01-06 18:31:37 +05:30
Suraj Shetty
335eafe0ba
Merge branch 'develop' into single-card-form-fix 2022-01-06 18:30:25 +05:30
Suraj Shetty
2c6f8f04c3
Merge pull request #15502 from surajshetty3416/fix-datetime-filter 2022-01-06 18:29:55 +05:30
Shariq Ansari
3f476fc17c
Merge branch 'develop' into single-card-form-fix 2022-01-06 16:23:20 +05:30
Shariq Ansari
080b3b889f fix: border color fix in dark mode 2022-01-06 16:08:10 +05:30
Verequies
379342d0ca fix: Postgres Compatibility for Standard Views
Core/User DocType: Add 'group_by' for PostgreSQL

Signed-off-by: Verequies <hamishclaxton@gmail.com>

fix: Postgres Compatibility for Standard Views

Desk/Dashboard DocType: Fix lowercase table name

Signed-off-by: Verequies <hamishclaxton@gmail.com>

Desk/Page/Setup Wizard: Fix data not being commited to database

Signed-off-by: Verequies <hamishclaxton@gmail.com>

Model/db_query: Fix queries with order_by and group_by for PostgreSQL

Signed-off-by: Verequies <hamishclaxton@gmail.com>

Model/db_query: Fix order_by without table name for PostgreSQL

Signed-off-by: Verequies <hamishclaxton@gmail.com>
2022-01-06 14:02:23 +05:30