Commit graph

42745 commits

Author SHA1 Message Date
Ankush Menat
d68e46d2cc fix: disable workflow emails by default
make it opt-in instead.
2023-07-19 16:45:44 +05:30
Ankush Menat
42aff950ce
feat(DX): normalize queries in recorder (#21735)
Attempt to normalize query by removing "variables"
This gives a different view of similar duplicate queries.

These two are distinct queries:
```sql
select * from user where name = 'x'
select * from user where name = 'z'
```

But their "normalized" form would be same:
```sql
select * from user where name = ?
```

This helps highlight queries ran in loop which might not register as
duplicate but are possibly "duplicate".
2023-07-19 16:45:30 +05:30
Shariq Ansari
ce79dd0b89 fix: increase form builder height 2023-07-19 12:44:40 +05:30
Ankush Menat
6dda420176 ci: dont run tests on every push
Rationale:
- PRs already run test by merging PR in develop branch (this is how
  github works)
- Running tests on practically identical code JUST after merge rarely
  helpes. This has found failures from conflicting changes maybe once or
  twice a year. That much CO2 is not justified.
- Instead added daily scheduled tests so things like cypress dashboards
  still work and a *bisect* if requried in future can be done.
2023-07-19 12:15:41 +05:30
Ankush Menat
03a582d7cd
build(deps): update pyyaml to 6.0.1 (#21728) 2023-07-19 11:41:17 +05:30
Ritwik Puri
5b547d5665
Merge pull request #21724 from phot0n/allow-bulk-retry-email
fix: allow users having access to email queue to bulk retry sending
2023-07-19 02:12:59 +05:30
phot0n
df3f6b3a9f fix: allow users having access to email queue to bulk retry sending 2023-07-19 02:11:10 +05:30
Suraj Shetty
688fa27456
Merge pull request #21718 from barredterra/clear-language-cache 2023-07-18 17:27:09 +05:30
barredterra
c39473b9b0 fix: invalidate cache when language is updated 2023-07-18 13:02:08 +02:00
barredterra
588bbd9d1c fix: include languages when clearing website cache 2023-07-18 12:53:57 +02:00
mergify[bot]
9c481cfd68
Merge pull request #21680 from resilient-tech/compare-amended-from
fix: compare with `doc.amended_from` while saving version for newly amended doc
2023-07-18 04:22:32 +00:00
Gursheen Kaur Anand
149467a71b
fix: fetch portal sidebar items (#21703) 2023-07-18 09:34:52 +05:30
Shariq Ansari
ed9848a133
Merge pull request #21710 from shariquerik/page-layout-breaking 2023-07-17 19:05:15 +05:30
Shariq Ansari
a5025cbd0c build(deps): Again bump bootstrap to v4.6.2 2023-07-17 18:21:12 +05:30
Shariq Ansari
f4c4de4c6e
Merge branch 'frappe:develop' into page-layout-breaking 2023-07-17 18:20:14 +05:30
Shariq Ansari
06d8a6ba9b fix(UI): pae layout breaking after upgrading bootstrap to v4.6.2 2023-07-17 17:49:02 +05:30
Ankush Menat
e50ff81f41 Revert: bootstrap update 2023-07-17 17:06:47 +05:30
Sagar Vora
86f0c4e52c fix: store version for name 2023-07-17 16:13:44 +05:30
Sagar Vora
7d7c440a1b fix: compare with doc.amended_from while saving version for newly amended doc 2023-07-17 16:04:28 +05:30
Sagar Vora
d11768d928
Merge pull request #21707 from resilient-tech/social-login-links 2023-07-17 14:34:00 +05:30
Sagar Vora
4684e72142 fix: use current redirect URIs instead of legacy ones 2023-07-17 14:29:22 +05:30
Ankush Menat
8436f775a5
feat(DX): PEP517 compatible build in new apps (#21704)
* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes https://github.com/frappe/frappe/issues/21612
2023-07-17 12:56:41 +05:30
Deepesh Garg
e38078a69f
test: Patch hooks for testing (#21702)
* test: Patch hooks for testing

* test: hooks patcher

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-07-17 12:41:27 +05:30
Raffael Meyer
b6cd6535db
feat: better Email search (#20323)
* refactor: get_contact_list

* test: get_contact_list

* feat: search all emails, not just the primary one
2023-07-17 00:40:17 +05:30
Ankush Menat
d17a336249
build(deps): bump JS dependencies (#21697)
- Bootstrap
- html5-qrcode
- editorjs
- jquery
- jsbarcode
- localforage
- sass
- rtlcss
- socketio server and client
- sortablejs
- superagent

TODO (maybe separate PRs):
- redis v4
- esbuild latest (ugh)
2023-07-16 23:01:45 +05:30
Ankush Menat
3f142c1dce fix: respect system setting for tracebacks
closes https://github.com/frappe/frappe/issues/19826
2023-07-16 19:18:16 +05:30
Ankush Menat
19f962975a fix: report name without filters 2023-07-16 17:29:28 +05:30
Ankush Menat
8f9b89557b fix: double urlencoding 2023-07-16 17:23:39 +05:30
Shariq Ansari
d423dedcd3
Merge pull request #21377 from shariquerik/move-form-builder-in-doctype-form 2023-07-16 14:38:08 +05:30
Shariq Ansari
628bdd18d2 fix: allow to add all states even if it is already added 2023-07-16 13:40:06 +05:30
Shariq Ansari
ae8af1d1d3 fix: removed unused form builder page 2023-07-16 13:30:14 +05:30
Shariq Ansari
4763dd5293 fix: show fields table for fallback also in customize form 2023-07-16 13:26:12 +05:30
Shariq Ansari
b3333b803c fix: throw error and store save if validation fails 2023-07-16 13:24:24 +05:30
Ankush Menat
8f552b8fe2
Merge pull request #21695 from ankush/perf/desk_requests
perf(desk): reduce unnecessary requests on first load
2023-07-16 13:06:16 +05:30
Shariq Ansari
686589d3ee test: fix form_builder UI test 2023-07-16 13:01:56 +05:30
Deepesh Garg
e32e74f2f1
feat: Custom naming series parser via hooks (#21690)
* feat: Custom naming series parser via hooks

* chore: use assignment operatot

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

* test: Unit test for custom parser

* test: Unit test for custom parser

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-07-16 12:57:40 +05:30
Ankush Menat
d9a698d4c5 fix: lower rapid-reload threshold 2023-07-16 12:43:47 +05:30
Ankush Menat
54b36e8604 perf: lazy load tag list for awesome bar
In last 7 days not a single person has used this feature on FC (based on
endpoint logs).

fix: When user knowingly triggers by typing text starting with `#` we
fire request to get tags lazily.
2023-07-16 12:43:47 +05:30
Ankush Menat
b919618032 perf: eliminate request for user permissions
This is ALWAYS required, then it can just be part of boot. Eliminates 1
unnecessary request.
2023-07-16 12:43:43 +05:30
Shariq Ansari
a7eb3a452b test: fix grid_configuration UI test 2023-07-16 12:23:28 +05:30
Shariq Ansari
3b2f2ef418 test: fix sidebar UI Test 2023-07-16 12:06:48 +05:30
Ankush Menat
ba311a3ec8
Merge pull request #21693 from ankush/perf/desk_assets
perf: accurate cache eviction for assets
2023-07-15 22:22:18 +05:30
Ankush Menat
52c2e6d47b fix: Accurately determine rapid reloads
Assuming rapid-reload ~= user frustrated with old assets. We weren't
actually checking if load was "reload". This cleared cache when tabs
were opened and effectively made cache useless.
2023-07-15 22:02:30 +05:30
Ankush Menat
79532ea0f2 fix: incorrect cache clearing of assets
- Build version wasn't correctly computed since v14 update of build
  system. This makes client side cache useless.
- We clear cache assuming rapid reloads,but opening new tab also does
  that. This makes the cache effectively useless for most users.
2023-07-15 21:59:04 +05:30
Ankush Menat
702e38cd74
fix(UX): Highlight prepared reports older than 1 day (#21689)
In MOST cases prepared report that are older than 1 day are stale.

[skip ci]
2023-07-15 19:16:03 +05:30
Ankush Menat
2264c4cf47 fix: cast port to integer
closes https://github.com/frappe/frappe/issues/21687
2023-07-15 17:46:45 +05:30
Ankush Menat
b4ea330c86
Merge pull request #21683 from ankush/on_demand_tags
perf: lazy load sidebar tag stats
2023-07-15 13:36:09 +05:30
Ankush Menat
b2b0bb69bb fix: Correct event for sidebar dropdown
- Click only gets called first time and not reliable next times
- Click will also get called when it's used for collapsing dropdown,
  which doesn't make sense here.
2023-07-15 13:14:04 +05:30
Ankush Menat
9a9705bd11 fix(UX): Show loading state while loading tags 2023-07-15 12:54:08 +05:30
Ankush Menat
5841f29610 refactor: rename poorly named variables
stats are actually columns in DB
columns are for verifying if DB column exists hence db_columns
other stats was result.

Renamed everything to avoid confusion.
2023-07-15 12:34:49 +05:30