Commit graph

1145 commits

Author SHA1 Message Date
devdiogenes
95d0fecee7 fix: Makes Condition Examples title translatable 2026-04-22 18:50:01 +00:00
Bowrna
c70e396e46 fix(login): Redirect to FC dashboard site page 2026-03-27 11:34:58 +05:30
AarDG10
df95bed674 perf: cache current_site_info for 10 mins
Cache Data for 10 mins TTL, and use the cache for lookup instead. Reduces unnecessary calls.
2026-03-14 16:32:44 +05:30
Akhil Narang
3e4f139ff3
fix: use string representation of exceptions in translated strings (#37756)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-03-06 13:02:16 +05:30
Saqib Ansari
b7111330bd
fix: don't throw if request fails (#37761) 2026-03-04 18:04:27 +05:30
Akhil Narang
461ea81783
fix(ldap): sync backend and frontend restrictions (#37411)
Only System Managers can use this functionality.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-23 12:53:49 +00:00
Aarol D'Souza
c55ff193a6
fix: add type hints to whitelisted methods 3 (#37149)
* fix(apps): add type hints to whitelisted methods

* fix(recorder): add type hints to whitelisted methods

* fix(comments): add type hints to whitelisted methods

* fix(oauth2): add type hints to whitelisted methods

* fix(google_calendar): add type hints to whitelisted methods

* fix(print): add type hints to whitelisted methods

* fix(print_format_builder): add type hints to whitelisted methods

* refactor(network_printer_settings): remove unused args

* fix(document): add type hints to whitelisted methods

* fix(user_settings): add type hints to whitelisted methods

* fix(mapper): add type hints to whitelisted methods

* fix(connected_app): add type hints to whitelisted methods

* fix(google_contacts): add type hints to whitelisted methods

* fix(frappecloud_billing): add type hints to whitelisted methods

* test: rewrite test to fit the strict type check

* fix(social_login_key): add type hints to whitelisted methods

* fix(share): add type hints to whitelisted methods

* fix(webhook): add type hints to whitelisted methods

* fix(workflow): add type hints to whitelisted methods

* fix(workflow main): add type hints to whitelisted methods

* fix(workflow_action): add type hints to whitelisted methods

* fix: flexible type hint

* fix(client): add type hints to whitelisted methods

* fix: fix some of the tighter types

* fix(frappecloud_billing): add str typehint to whitelisted endpoint

* fix: target_doc can be dict/json string

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-20 06:50:19 +00:00
Kerolles Fathy
1232588bb5
fix(google_calender): check cancelled event exists before update it (#37031)
- Add existence check before updating cancelled events to prevent `DoesNotExistError`

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2026-02-16 14:10:52 +05:30
Akhil Narang
27970539af
fix(oauth2): introspect_token requires token (#35647)
https://datatracker.ietf.org/doc/html/rfc7662#section-2

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-05 13:41:12 +00:00
Akhil Narang
8723a2b6ee
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-22 21:06:48 +05:30
sokumon
dd2dc053ca chore: more renames to /desk 2025-12-18 20:45:04 +05:30
Ankush Menat
9979314b32 test: commit to trigger sendmail 2025-12-17 16:36:06 +05:30
Soni Karm
ff3ada7030
feat: add response headers field to integration request (#35189) 2025-12-11 13:34:19 +00:00
sokumon
49714e916f chore: rename from app to desk 2025-11-14 23:05:13 +05:30
Akhil Narang
60e714e2e1
fix: commit before trying to delete user
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-14 18:36:34 +05:30
Akhil Narang
c94b4c0e8b
fix(ldap): escape filter characters
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-10-08 12:07:26 +05:30
Akhil Narang
6ca4d4d167
refactor(treewide): ruff format
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-26 13:16:43 +05:30
Anoop
ef34a7ce7d
fix: check participant email exists before adding to guest list (#33944) 2025-09-08 18:25:25 +05:30
Anoop
804e211b2d
fix: owner getting added to google event participant list (#33939) 2025-09-08 14:23:37 +05:30
Raizaaa
aa3bb0e4d7 fix: remove trailing spaces in translatable strings 2025-08-27 13:23:17 +03:00
Raizaaa
481c439dc2 docs(google_settings): update documentation link 2025-08-18 17:18:02 +03:00
Akhil Narang
debd500cf3
fix: validate social login key JSON fields (#33622)
Any misconfiguration would break login page otherwise

Resolves #33579

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-08-14 12:56:12 +05:30
Hussain Nagaria
89da9934bc
refactor: fetch openID config in backend (#33586) 2025-08-11 12:48:23 +05:30
Ayush Chaudhari
761751f269
feat: App-Defined Workflow Tasks and Server Scripts on Transition (#33255)
* feat: add workflow task doctypes

* chore: add Workflow Task to Script Type of Server Scripts

* chore: add description for Workflow Tasks

* feat: fetch dotted paths and corresponding names from hooks

* fix: use Select field instead of Autocomplete

* feat: execute tasks in the background on state transition

* fix: throw error when task not found

* fix: naming for transition task set by user

* fix: child table views

* feat: support for server scripts

* chore: comments and description

* fix: change the casing of docevent options

* fix: change test casing

* feat: Add Workflow Transition field to webhooks

* fix: temporarily remove filter

* feat: add webhooks as workflow actions

* test: test execution of synchronous app-defined methods and server scripts

* chore: shorten the description and change the fieldname of the field 'execute_asynchronously' to 'asynchronous'

* test: server script executipn

* fix: add field to UI

* test: change customer to domain

* test: change Customer to Domain

* fix: patch for change in webhook fields

* chore: fetch only used fields in get_all

* fix: don't run test logic in application code 🙂

* test: separate tests for workflow tasks

* Revert "fix: patch for change in webhook fields"

This reverts commit 2e9c51c43ca2b3698991fbe75cc4032368ab174c.

* chore: break into smaller functions

* test: webhooks with workflow tasks

isolate mock responses to test_sync_tasks

* Revert "fix: change test casing"

This reverts commit e2bad96ed01dea0a26d002ea44a1e0175525ed31.

* Revert "fix: change the casing of docevent options"

This reverts commit ddfc81bf775fad74225f25815b8e3e7b255dc9eb.

* fix: webhook casing

* fix: type hint for doc
2025-07-29 11:01:44 +05:30
Soham Kulkarni
64db88228f
refactor: seperate blogs into a seperate app (#32737)
* fix: remove doctypes,workspace blocks, files

* fix: minor python tests and UI tests

* fix: remove blog post from tests

* fix: remove blogger as role for tests

* fix: add check for if doctype exists

* fix: ui test

* fix: more cleanup

* fix: cleanup comments and fix test_query

* fix: resolve conflicts

* fix: add warning and handle comments
2025-07-28 14:35:02 +05:30
Nihantra C. Patel
03109a7b67
fix: Remove specific links from Integrations workspace and reindex (#33285)
* fix: update the Integrations workspace

* fix: Remove specific links from Integrations workspace and reindex

* fix: again update the Integrations workspace

* fix: remove patch as per comment

* fix: remove custom button Newsletter from email group doctype
2025-07-16 12:14:15 +05:30
18alantom
3eab2b73b7
chore: update readme 2025-07-04 15:24:44 +05:30
18alantom
c4f2335f11
fix: support public client 2025-07-04 15:05:50 +05:30
18alantom
db4a7504e5
fix: add hooks to handle cors 2025-07-04 13:18:43 +05:30
18alantom
e76c1830e1
chore: add global flag for Social Login Key 2025-07-04 11:25:06 +05:30
18alantom
933ec04074
chore: fix typo 2025-07-03 15:12:25 +05:30
Alan
c174e9cbdc
fix: apply fixes on accepted Copilot suggestions
Update frappe/integrations/oauth2.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update frappe/integrations/README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update frappe/integrations/utils.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update frappe/integrations/utils.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-07-03 15:01:47 +05:30
18alantom
befca37299
chore: README for integrations with OAuth2 docs
- Update descriptionsi in OAuth Settings
2025-07-03 14:42:28 +05:30
18alantom
5ca8ad9d84
refactor: deprecate OAuth Provider Settings
OAuth Settings has its fields now (only one)
2025-07-03 14:07:38 +05:30
18alantom
1215afdf96
feat(OAuth2): support RFC 9728
adds OAuth Settings to configure settings pertaining to Frappe used as
an OAuth auth server and resource server
2025-07-03 13:20:52 +05:30
18alantom
4cd8115c4c
refactor: unify how .well-known routes are handled 2025-07-02 15:17:42 +05:30
18alantom
3a47801598
feat(OAuth2): support RFC 7591
This allows a client to be registered without manual intervention.
2025-07-02 13:01:37 +05:30
18alantom
f8425b6520
feat(OAuth2): support RFC 8414
This allows an OAuth client to get metadata about the auth server, i.e.
the frappe bench being used as an OAuth2 auth server.

Metadata includes values for auth server urls and endpoints and
supported types and modes.
2025-07-01 13:40:18 +05:30
Soham Kulkarni
77eda41443
Merge pull request #32351 from sokumon/offsite-backups-removal
refactor: separating backup integrations into an app
2025-06-17 23:30:51 +05:30
Sagar Vora
b3e1eda4c8
feat: global frappe.in_test flag (#32960)
* feat: global `frappe.in_test` flag

* feat: helper utility to toggle `frappe.in_test`

* fix: use `toggle_test_mode` util

* fix: use `frappe.in_test`

* chore: add comment explaining global `in_test`

* chore: ignore commit replacing flag usage

* test: temporarily disable `frappe.in_test`

this worked earlier because flag was set in werkzeug.local which was separate for API test client

* test: add comment explaining change
2025-06-17 19:19:31 +05:30
sokumon
63cf3676a0 fix: remove utils file and typo 2025-06-17 18:39:21 +05:30
sokumon
80aaf1f31e fix: add a better config dict to GoogleOAuth instead of args 2025-06-14 23:59:22 +05:30
sokumon
a639828bd4 fix: add abiltiy to extend the Domain callback methods via google oauth constructor 2025-06-14 23:59:22 +05:30
sokumon
422995cd45 fix: seperate backup options into app 2025-06-14 23:59:22 +05:30
Karuppasamy
22d16ba1ca
fix: update Keycloak redirect_url to correct login method endpoint (#32908) 2025-06-12 13:38:42 +05:30
Ankush Menat
8088bd3891
chore: Drop empty UnitTestCases (#32867)
Next to zero adoption after introduction, just noise in codebase.

I don't see any point in arguing about purity of test cases when
existence and quality of test cases is usually the bigger problem.

Dropped using semgrep
2025-06-10 05:28:53 +00:00
Ankush Menat
2dfb96f91c
fix: handle snapshot isolation errors better (#32318)
* fix: Avoid Snapshot violation

- Main thread created and "read" user
- Other thread modified something
- Main thread wants to delete or "write" to same row.

This violates snapshot isolation.

* fix: treat snapshot violation as deadlock for now

* test: handle snapshot violations
2025-04-28 06:18:38 +00:00
Ankush Menat
33e28e0b28
Merge pull request #31989 from revant/clear-expired-tokens
fix: add clear_old_logs OAuth Bearer Token
2025-04-17 18:25:38 +05:30
Ankush Menat
acea1aedbf perf: handle clearing large oauth token table 2025-04-17 18:05:37 +05:30
gavin
792f1c237f
Merge pull request #32167 from gavindsouza/bp-pr-32074
perf(events): get_events performance & Google Calendar Integration fixes
2025-04-16 13:33:33 +02:00