Commit graph

37005 commits

Author SHA1 Message Date
Sagar Vora
dc4d07cb61 style: use walrus operator 2022-03-13 12:54:04 +05:30
Sagar Vora
f6c546159c perf: cache single documents 2022-03-12 00:10:36 +05:30
Rushabh Mehta
7ace873c3a
Merge pull request #16211 from nikochiko/notifications-hasrole
fix: use parent_doctype=... while fetching users from Has Role table
2022-03-11 15:28:47 +05:30
gavin
a886d793f2
Merge pull request #16254 from gavindsouza/db-api-consistency
feat(db): Alias is_missing_table for consistency in APIs
2022-03-11 14:26:03 +05:30
Gavin D'souza
ad1e180666 feat(db): Alias is_missing_table for consistency in APIs 2022-03-11 14:03:21 +05:30
mergify[bot]
41ffb79828
Merge pull request #16250 from resilient-tech/typo-database-py
fix: typo in database file for v12 - latest
2022-03-11 08:27:43 +00:00
lapardnemihk1099
f4d3effaf2 fix: typo in database file for v12 - latest 2022-03-11 13:29:01 +05:30
mergify[bot]
878f06dbb8
Merge pull request #16053 from bhavesh95863/patch-1
fix: ignore link validation for sort workspace
2022-03-11 05:55:05 +00:00
Shariq Ansari
f5f0176853
Merge branch 'develop' into patch-1 2022-03-10 17:52:13 +05:30
mergify[bot]
9bd1333538
Merge pull request #16188 from resilient-tech/hyphen-dobara
feat: allow hyphens in DocType name (again)
2022-03-10 07:09:49 +00:00
Pruthvi Patel
b1d55680a3
fix: Consider title field only if it's value exists (#16236)
* fix: consider title field only if it's value exists

* chore: make `title` bold
2022-03-10 12:28:23 +05:30
mergify[bot]
a465018088
Merge pull request #16217 from shariquerik/failing-ui-test-fix
test: failing report_view UI test fix
2022-03-10 06:55:33 +00:00
mergify[bot]
302f4645e0
Merge pull request #16234 from anandology/show-traceback-as-string
fix: show traceback as string instead of bytes
2022-03-10 05:01:35 +00:00
Anand Chitipothu
f811927895 fix: show traceback as string instead of bytes
Issue: #16233
2022-03-10 10:15:27 +05:30
Sagar Vora
a6d991272e fix: sider warning 2022-03-10 09:38:32 +05:30
Sagar Vora
5d93907a19 fix: improve modify_query regex 2022-03-10 09:28:13 +05:30
Kaustubh Maske Patil
4a42488b6d fix: Use parent_doctype=... syntax while fetching users with a particular role 2022-03-09 21:52:08 +05:30
Sagar Vora
9cd25d72d5
fix: clear filters before setting them (#16077)
* fix: clear filters before setting them

* fix: dont set dirty state for reports without JSON

* fix: cleaner alternative to clearing filters

* fix: move condition outside loop

* fix: reorder if-else block to avoid hitting else block inadvertently
2022-03-09 18:50:18 +05:30
Ankush Menat
28e57d9d3d
Merge pull request #16222 from ankush/attach_limit
fix(ux): remove attachment limits
2022-03-09 14:00:56 +05:30
gavin
7698ac69f3
Merge pull request #16178 from gavindsouza/email-signature-fix
fix: Double signature in composed Email
2022-03-09 13:38:38 +05:30
gavin
010eba2961
Merge pull request #16225 from gavindsouza/update-document-title-fix
fix(rename_doc): Allow updating only document title or name
2022-03-09 13:20:37 +05:30
Gavin D'souza
e8ec8410e6 fix(rename_doc): Allow updating only document title or name 2022-03-09 12:57:27 +05:30
Ankush Menat
a6c257261b fix(ux): remove attachment limits 2022-03-09 12:19:46 +05:30
gavin
749f2b8afc
Merge pull request #16205 from gavindsouza/linked-with-refactor
refactor: Show Document Links
2022-03-09 12:08:27 +05:30
Shariq Ansari
845b6ab1d7
Merge branch 'develop' into failing-ui-test-fix 2022-03-08 16:56:53 +05:30
Himanshu
ce77e97db6
feat: enable tls for ngrok (#16216)
* styled site module: sorted imports, space fixes
2022-03-08 16:46:59 +05:30
Shariq Ansari
ae18ef1679
Merge branch 'develop' into failing-ui-test-fix 2022-03-08 16:29:42 +05:30
Shariq Ansari
c2abb00886 test: failing report_view UI test fix 2022-03-08 15:44:14 +05:30
Gavin D'souza
3858eff51e fix: Don't add signature only when called from API 2022-03-07 18:17:31 +05:30
gavin
3f6558fd39
Merge branch 'develop' into linked-with-refactor 2022-03-07 17:11:22 +05:30
Gavin D'souza
39fc90cb5b fix(ux): Pop from message_log if DoesNotExistError 2022-03-07 16:35:53 +05:30
Gavin D'souza
38fbe76ebf fix: Eliminate broken & impermissible links from get_linked_docs 2022-03-07 15:50:17 +05:30
Gavin D'souza
6edb1f09e4 refactor: Fetch Linked Documents in single request ;)
This action was broken into some heavy UI stuff that seems to be handled
from the current UI from what I can tell and a request triggered from
the Desk for every suspected linked document (talk about self DOS xD)

Removed long dead with_doctype option in get_linked_docs API. How do i
know it's been long dead? I've not come across code that won't very
obviously break when hit with any non None value.
2022-03-07 15:02:20 +05:30
mergify[bot]
d4b2318569
Merge pull request #16202 from resilient-tech/unused
chore: remove unused variable `doc_before_save`
2022-03-07 07:32:50 +00:00
Mohammad Hasnain Mohsin Rajan
f21b343488
perf: role instead of users in workflow actions (#15789)
Create a single workflow action document for pending transitions.
The Roles that are allowed to make the transition are stored in a Table MultiSelect field.
Workflow action doctype is filtered on the basis of applied roles on the visiting user.
The user column is retained for backward compatibility.

BREAKING CHANGE: The user field will no longer be used, A new field that stores applicable roles will be used instead.
2022-03-07 13:01:31 +05:30
Sagar Vora
def10e1e13 chore: remove unused variable doc_before_save 2022-03-07 12:41:45 +05:30
Jannat Patel
12ae7b9239
fix: User Account Auto Deletion in Hours (#16135)
* fix: data-deletion-in-hours

* test: process_auto_request function

* fix: import and comment

* fix: patch for auto account deletion hours

Co-authored-by: gavin <gavin18d@gmail.com>
2022-03-07 10:38:25 +05:30
mergify[bot]
dc7647f86d
Merge pull request #16195 from alyf-de/translate-query-report-columns
feat: translate column names in export of query report
2022-03-07 04:59:45 +00:00
barredterra
8126a18f05 feat: translate column names in CSV file from query report 2022-03-03 19:58:20 +01:00
barredterra
6cdab154f5 feat: translate column names in excel file from query report 2022-03-03 19:58:08 +01:00
Gavin D'souza
89a7dac300 fix: Add signature only if not Communication.flags.skip_add_signature
This is added to handle purposely removed signature or custom signatures
added via the Email Composer or via the email.make API
2022-03-03 19:38:34 +05:30
Sagar Vora
9f90d8b42a test: add test for allowing hyphen in DocType name 2022-03-02 20:31:41 +05:30
Sagar Vora
98188ddcba feat: allow hyphens in DocType name (again) 2022-03-02 20:22:09 +05:30
Gavin D'souza
0ef99c3886 fix: Add signature to Communication.content if not already added
This fix adds a signature forcibly if found under the sender's
User.email_signature or default outgoing email account's signature
field.

The previous method of adding a comment into the Email didn't work since
Quill would discard comments before setting them. Adding signatures in
get_formatted_html didn't seem apt since it's used in QueueBuilder to
re-construct the Email before processing the Email Queue. This meant
that the email content that was added in the Communication record would
not be final. Now, we treat the signature as part of the Communication
content.
2022-03-02 19:41:51 +05:30
Gavin D'souza
da2dbfaae9 refactor!: Deprecate ignore_permissions & flags in communication.make
API
2022-03-02 16:25:02 +05:30
Gavin D'souza
525f1656ad fix: Double signature in composed Email
Re-do of https://github.com/frappe/frappe/pull/12520
Undone by https://github.com/frappe/frappe/pull/12878

Changes done to reflect current state of version-13

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2022-03-02 16:25:02 +05:30
gavin
97f7472438
Merge pull request #16182 from frappe/mergify/bp/develop/pr-15912
fix: Add freeze message when renaming document (backport #15912)
2022-03-02 15:44:38 +05:30
Gavin D'souza
1bd01f71d1 fix: Set freeze, freeze_message via xcall 2022-03-02 15:22:38 +05:30
coffee-dev-sl
b1d83fe0db feat(toolbar.js model.js): Add freeze message when renaming document
(cherry picked from commit 45c9cc444266cd36f009baca6de1528a2d8e84de)

# Conflicts:
#	frappe/public/js/frappe/form/toolbar.js
2022-03-02 15:22:28 +05:30
mergify[bot]
05b19ccd90
Merge pull request #15791 from dj12djdjs/fix-rename-tool
fix: Specify message why document was not renamed.
2022-03-01 17:32:30 +00:00