Ankush Menat
e35d774eda
Merge pull request #24708 from ankush/pw
...
fix: filter autocomplete doctypes
2024-02-02 19:14:51 +05:30
Ankush Menat
7580125bae
fix: Filter auto repeat doctypes
2024-02-02 18:57:47 +05:30
Ankush Menat
7487df22c9
refactor: use frappe.get_system_settings
...
because it's cached and doesn't hit frappe.db at all.
2024-02-02 18:43:43 +05:30
Ankush Menat
6341ef3ac7
fix: kanban hide "add column" for std fields ( #24707 )
...
* fix: build events
* fix(kanban): Don't show custom column option on standard fields
2024-02-02 18:31:03 +05:30
Ankush Menat
dd839e4d50
fix: lower default retention periods ( #24697 )
...
These can still be configured to different number. We are just changing
defaults. Why?
- Scheduled job log - errors get logged in error log anyway. Success log
isn't that useful of 90 days?
- Prepared report - most reports are expired in a day or max a week.
Rarely last month's report makes any sense today.
2024-02-02 17:33:58 +05:30
Akhil Narang
f19c25ec42
Merge pull request #24432 from blaggacao/chore/cleanup-frappe-connect-2
...
chore: cleanup frappe connect II/II
2024-02-02 16:53:19 +05:30
Corentin Flr
11baf6e03c
fix(login): Escape translated strings ( #24431 )
...
* Use `tojson` instead of `json` Jinja filter
2024-02-02 15:33:55 +05:30
Ankush Menat
380b33d49e
fix: Dashboard view realtime error ( #24698 )
...
filter_area doesn't exist on DashboardView, so this inherited function
breaks down.
2024-02-02 09:38:16 +00:00
Ankush Menat
d26c67df75
fix: virtual fields are never writable ( #24693 )
2024-02-02 13:37:46 +05:30
Akhil Narang
81d8a0b8b9
Merge pull request #24659 from jll-02/patch-7
...
chore(deps): removes unused cariocffi dependency
2024-02-02 12:37:01 +05:30
David Arnold
c09f48f5d7
feat: comply trackers with utm and add utm_content for a/b testing ( #24521 )
...
* feat: comply trackers with utm and add utm_content for a/b testing
* fix: make all other than source optional
this is plausible.io best practice
* fix: medium is not specified to be lowercase
* fix: ensure proper parameter quoting
2024-02-02 11:33:22 +05:30
Ankush Menat
c479a038a8
fix: Avoid enqueueing during install ( #24679 )
...
This isn't strictly required but if bench isn't running this can break
installation.
2024-02-01 14:12:54 +00:00
Ankush Menat
aad0c19f3a
fix: lazy translate circular imports ( #24672 )
...
* Revert "fix: remove _lt from frappe.model.std_fields (#24662 )"
This reverts commit 833d108614
2024-02-01 12:27:25 +00:00
Maharshi Patel
3fb418f28f
Merge pull request #23907 from marination/dynamic-header-footer-develop
...
feat: Letterhead Scripts & fix disappearing header in pdf
2024-02-01 17:43:12 +05:30
Raffael Meyer
4d63a12ab6
fix(Data Import): scheduler not needed in dev mode ( #24667 )
2024-02-01 17:11:41 +05:30
Rucha Mahabal
aed3586095
fix: enable syntax highlighting for PythonExpression code fields ( #24669 )
2024-02-01 17:10:21 +05:30
Ankush Menat
4553de8ba0
fix: never show virtual fields in list view ( #24666 )
...
* fix: never render virtual fields in list view
* fix: Hide "in list view" for virtual columns
2024-02-01 16:22:07 +05:30
Raffael Meyer
855202d20a
Merge pull request #24614 from barredterra/data-import-transatability
2024-02-01 11:37:41 +01:00
Raffael Meyer
833d108614
fix: remove _lt from frappe.model.std_fields ( #24662 )
2024-02-01 16:05:25 +05:30
Raffael Meyer
2de2b59f00
Merge pull request #24663 from barredterra/translate-data-export
2024-02-01 11:10:30 +01:00
barredterra
281c1de639
fix(Data Export): translate multiselect
2024-02-01 10:51:57 +01:00
Raffael Meyer
b5f3873177
Merge pull request #24465 from barredterra/extract-js-microtemplate
2024-02-01 10:32:42 +01:00
Akhil Narang
ea65d86d72
Merge pull request #24625 from blaggacao/fix/shell-escaping
...
fix: shell escaping on external commands
2024-02-01 12:45:21 +05:30
jll-02
12a246d697
chore(deps): removes unused cariocffi dependency
2024-02-01 08:15:00 +01:00
Ankush Menat
bedf5ba65e
Merge pull request #24656 from ankush/retry_contact
...
fix: outgoing email account handlng
2024-02-01 11:52:07 +05:30
Ankush Menat
dae99eb53c
fix: Fetch SMTP server inside context
...
Currently if smtp server creation fails email queue is endlessly
retried. It should just fail if there's no outgoing account.
2024-02-01 11:10:57 +05:30
Ankush Menat
78665d98b2
fix: Bail if no SMTP acccount can be found
...
Currently we give this weird error instead of just saying no outgoing email account is configured.
```
AttributeError: 'NoneType' object has no attribute 'get_smtp_server'
File "frappe/email/queue.py", line 154, in flush
email_queue.send()
File "frappe/email/doctype/email_queue/email_queue.py", line 160, in send
with SendMailContext(self, smtp_server_instance) as ctx:
File "frappe/email/doctype/email_queue/email_queue.py", line 236, in __init__
self.smtp_server: SMTPServer = smtp_server_instance or self.email_account_doc.get_smtp_server()
```
2024-02-01 11:10:57 +05:30
Ankush Menat
3634d11b6a
fix: Retry contact update if it fails due to conflict ( #24654 )
2024-02-01 05:14:00 +00:00
Ankush Menat
0458544c3b
refactor!: Simplify asset caching ( #24649 )
...
Few changes:
1. Client side asset caching is needlessly complicated with 2 layer of
caching. Browser already caches things, moving them again to
localstorage is uselss and counterproductive because of limits on localstorage.
2. `frappe.assets` was an object that should've been a class.
3. lots of old js syntax.
2024-01-31 21:23:04 +05:30
Ankush Menat
a69aad85b2
Merge pull request #24647 from ankush/dynamic_link_deletion
...
fix: Enqueue deletion of dynamic link after comitting
2024-01-31 18:57:06 +05:30
Ankush Menat
5e904d407e
Merge pull request #24474 from blaggacao/fix/run-tests-module-def
...
fix: run-tests --module-def as not all doctypes are guaranteed to have test_*.py files
2024-01-31 18:52:45 +05:30
Ankush Menat
fc942856e0
Merge pull request #24641 from barredterra/fix-permcheck
...
fix: use the correct doc method
2024-01-31 18:49:41 +05:30
Ankush Menat
dd6f20b301
Merge pull request #24644 from ankush/clear_sitemap_cache
...
fix: clear sitemap cache periodically
2024-01-31 18:41:54 +05:30
Ankush Menat
ca293c9aa3
fix: Enqueue deletion of dynamic link after comitting
2024-01-31 18:37:12 +05:30
Ankush Menat
3962b6ff24
Merge pull request #24642 from ankush/fix_no_notify
...
fix: don't notify links if not public
2024-01-31 18:26:14 +05:30
Ankush Menat
ffb9c9cf6a
fix: clear sitemap cache periodically
2024-01-31 18:25:28 +05:30
Ankush Menat
d2d669b720
fix: don't notify links if not public
2024-01-31 18:09:20 +05:30
barredterra
09919a3e58
fix: use the correct doc method
2024-01-31 12:55:41 +01:00
marination
4d2c4f020b
fix: Check if header/footer html exists before trying to extract
...
- issue: AttributeError: 'NoneType' object has no attribute 'extract', when no letterhead html was present
2024-01-31 12:54:20 +01:00
Shariq Ansari
96f35300a2
Merge pull request #24637 from shariquerik/typeerror
...
fix: typeerror in onboarding_tours.js
2024-01-31 16:31:18 +05:30
Shariq Ansari
e7b3a785c1
fix: typeerror in onboarding_tours.js
2024-01-31 16:12:56 +05:30
Ankush Menat
a25e68a763
fix: make rate_limiter respect multitenancy ( #24634 )
...
* fix: make rate_limiter respect multitenancy
* fix: lower rate limit window for password reset
* refactor: Use redis_wrapper
2024-01-31 09:16:27 +00:00
David Arnold
161bb42508
fix: deprioritize precedence of db_name argument to connect
2024-01-31 09:59:14 +01:00
Rucha Mahabal
53d6d156ec
chore: cleanup doctype descriptions ( #24609 )
2024-01-31 12:00:39 +05:30
Ankush Menat
b2abc2c9d1
Merge pull request #24624 from ankush/fix_private_file
...
perf: optional faster perm check for files
2024-01-31 11:06:09 +05:30
Ankush Menat
dedadbb0d9
perf: optional faster perm check for files
2024-01-31 10:49:18 +05:30
David Arnold
3abbde3284
fix: shell escaping on external commands
2024-01-30 18:23:05 +01:00
Ankush Menat
40438b400f
ci: set node env as production in tests
2024-01-30 21:55:51 +05:30
mergify[bot]
5031e9dbf4
Merge branch 'develop' into chore/cleanup-frappe-connect-2
2024-01-30 15:48:28 +00:00
Ankush Menat
e1f20f7305
Merge pull request #24621 from ankush/short_circuit_guest
...
fix: short circuit private files perm check
2024-01-30 20:48:42 +05:30
