* refactor: Rename is_custom to use_report_chart
* fix: Patch to move is_custom data to use_report_chart
* fix: Import rename_field
* fix: Rename is_custom in depends_on
* fix: Reload doc before renaming field
the default policy encodes special characters correctly, and is not set
by _default_ unless python3.8 is used. so we'll explicitly define the
policy to be used for the email body
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
email addresses get formatted incorrectly inside the email queue,
causing emails to be sent with encoded-words addresses instead of
proper, human readable email addresses. this particularly happens when
the address has special and accented characters. an example of
encoded-words address looks like:
=?utf-8?q?=C3=A1dministr=C3=A1tor?= <admin@example.com>
instead of something like:
ádministrátor <admin@example.com>
another issue that causes this is validations that strip html tags from
field when ignore_xss_filter is not set in a docfield. setting
ignore_xss_filter for the email field inside email queue fixes
this issue.
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Reference: https://web.dev/samesite-cookies-explained/
Scenario:
A user is logged in on a frappe instance. (with, say, sid=abcd)
In an OAuth like flow, a third party site, say, GitHub redirects the user to the frappe instance.
Now because SameSite=Strict is set, the browser can't send the cookies it has (sid=abcd) to the frappe server.
Once the frappe server receives this request without cookies, It assumes that this is an unauthenticated user, and sets cookies in response as sid=Guest.
Reference: f3e14b4ac7/frappe/sessions.py (L178)
Once the browser receives these values in response (sid=Guest) it overwrites the existing cookie values(sid=abcd) and sets sid=Guest,
This effectively causes the user session to be terminated.
currently the system tries sending emails to all users that have
'thread_notify' enabled, including the default example emails that the
Administrator and Guest accounts have. this patch disables email
notifications for these accounts, and additionally tries to disable it
for any other user accounts with example emails
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
