Commit graph

49079 commits

Author SHA1 Message Date
Akhil Narang
e5c75c3874
fix(user): stricter name validation
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-12 16:50:11 +05:30
Akhil Narang
48d3a86144
revert: "fix(UX): Show reason for read only form in headline (#31511)" 2025-03-12 09:27:19 +00:00
Sagar Vora
cc023453e8
Merge pull request #31666 from sagarvora/add-slots
fix: add `__slots__` to NamespaceDict
2025-03-12 14:15:24 +05:30
Sagar Vora
ad33435b33
Merge pull request #31660 from sagarvora/frappelocal
perf: faster local attr lookup
2025-03-12 14:13:46 +05:30
Sagar Vora
26bbb5985e
perf: use client_cache for print_sql (#31663)
* perf: use `client_cache` for `print_sql`

* chore: revert change to conn error handling code

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2025-03-12 08:43:09 +00:00
Sagar Vora
a5dd24ebe9 fix: add __slots__ to NamespaceDict 2025-03-12 14:05:27 +05:30
Sagar Vora
3c8912f6e7 perf: faster local attr lookup 2025-03-12 14:03:36 +05:30
Sagar Vora
45b375ae2c
Merge pull request #31664 from sagarvora/faster-_dict-getattr
perf!: faster frappedict getattr
2025-03-12 13:49:05 +05:30
Sagar Vora
c592f323ff fix: restore dict.__getattribute__ for NamespaceDict 2025-03-12 13:28:12 +05:30
Sagar Vora
20220ef894
fix: avoid one time setup (#31650) 2025-03-12 12:44:19 +05:30
Sagar Vora
04eee35b40 perf: faster frappedict getattr 2025-03-12 12:43:01 +05:30
Raffael Meyer
2b9aa25520
ci: ignore "skip-release-notes" when generating release notes (#31656) 2025-03-11 16:22:33 +00:00
Raffael Meyer
ddbb987831
Merge pull request #31654 from barredterra/auto-add-label
ci: add label based on PR title
2025-03-11 16:46:52 +01:00
Ejaaz Khan
8e74155534
Merge pull request #31645 from iamejaaz/32254-auto-email-bg
perf: generate auto email reports in background
2025-03-11 19:58:51 +05:30
Ejaaz Khan
dbec126b5e refactor: change queue from default to long 2025-03-11 19:48:59 +05:30
Raffael Meyer
538bad98f6
Merge pull request #31639 from sattamjh/sattamjh-patch-1
fix: prioritize English language selection for Guest user with additional browser language settings
2025-03-11 13:11:14 +01:00
Ejaaz Khan
7d120575db refactor: remove unused import 2025-03-11 15:44:30 +05:30
Ejaaz Khan
d1cc0ee951 perf: generate auto email reports in background 2025-03-11 15:42:00 +05:30
Soham Kulkarni
eb335b9046
Merge pull request #31640 from sokumon/translate-report-data
feat: make translate report data configurable
2025-03-11 14:33:31 +05:30
sokumon
e46ebf4e02 feat: make translate report data configurable 2025-03-11 10:55:01 +05:30
Sattam
a88f2a8fc5
fix: prioritize English language selection for Guest user despite additional browser language settings
Description:
- Resolved an issue where the system incorrectly activated a non-English language for Guest users, even when English was the primary language in the browser settings.
- The bug occurred when additional languages (e.g., Arabic) were configured in the browser and one of those languages was already enabled in Frappe.
- Ensured that English is prioritized as the default language for Guest users when it is present in the browser language list, regardless of other enabled languages.
- Added a fix to explicitly enable English language for Guest users to prevent unintended language switching.

Steps to Reproduce:
- Create a new clean site and add additional languages (e.g., Arabic) in the browser settings.
- Ensure the additional language (e.g., Arabic) is already enabled in the database, which is by default.
- Observe that the system switches to the non-English translation (e.g., Arabic) for Guest users, even if English is the primary language in the browser settings.

Root Cause Analysis:
- Initially suspected `translate.py` was involved in language resolution.
- Checked enabled languages at the console using:
  `frappe.get_all("Language", filters={"enabled": 1}, pluck="name")`
  Result: ['fr', 'fa', 'es', 'de', 'ar']
- Identified that English was not enabled in the system, despite being a default requirement.
- Traced the issue to `languages.csv`, where English was not included among the enabled languages.

Fix:
- Enabled English in `languages.csv` to ensure it is included among the supported languages.
- This ensures English is chosen when included in the browser settings, resolving the issue.
2025-03-11 04:02:40 +03:00
Raffael Meyer
215ebfbd24
Merge pull request #31637 from barredterra/crowdin-file-naming
chore: fix file naming for Crowdin integration
2025-03-11 01:53:44 +01:00
barredterra
885390c1cf chore: fix file naming for Crowdin integration 2025-03-11 01:34:01 +01:00
Ejaaz Khan
721af96f04
Merge pull request #31630 from iamejaaz/31611-link-field-export
fix: custom column export issue in report
2025-03-10 21:35:01 +05:30
Ankush Menat
14006b2c25
refactor: trim __init__.py (#31575)
* refactor: move init.py utils to utils/*

* refactor: split messages.py from init.py
2025-03-10 21:12:19 +05:30
Ankush Menat
6946e3353f refactor: split messages.py from init.py 2025-03-10 21:02:13 +05:30
Ankush Menat
ae4e2ede1a refactor: move init.py utils to utils/* 2025-03-10 21:01:14 +05:30
Ejaaz Khan
ea90228748 fix: custom column export issue in report 2025-03-10 20:46:55 +05:30
Ankush Menat
8d15d28463
fix: check permission on new doc (#31626)
User might only have "only if creator" permission so checking on doctype
will incorrectly flag it.

Not sure if there's any better/simpler way to handle this. This is weird
edge case on how files operate.
2025-03-10 13:30:13 +00:00
Soham Kulkarni
4f823f5a10
Merge pull request #31612 from sokumon/respect-precision
fix: add currency precision formatting while exporting report
2025-03-10 17:32:35 +05:30
sokumon
74fd714277 fix: change if to elif 2025-03-10 16:49:20 +05:30
sokumon
77e318d9d6 fix: small change 2025-03-10 15:26:38 +05:30
sokumon
2b8a6352ea fix: add all formating fields inside one function 2025-03-10 14:54:54 +05:30
Akhil Narang
f518ea34de
Merge pull request #31615 from tarunps/fix/pub-email-attachment-attachment
fix(email_account): make attachments public by default
2025-03-10 14:52:46 +05:30
DHia' A. SHalabi
d3ffa75288
Merge pull request #31602 from dhiashalabi/fix/update-popup-msg-format
refactor: Use f-string for version update message formatting
2025-03-10 14:51:15 +05:30
Akhil Narang
6d08df2653
Merge pull request #31584 from akhilnarang/fix-field-sanitisation
fix(db_query): improve regex
2025-03-10 14:34:54 +05:30
Tarun Pratap Singh
88bf5a74a7 fix(email_account): make attachments public by default 2025-03-10 14:26:52 +05:30
sokumon
1d096040d8 fix: change condition 2025-03-10 13:20:33 +05:30
sokumon
d511499c1a fix: add currency precision formatting while exporting report 2025-03-10 13:02:56 +05:30
Hicham Dachir
381ee5682c
fix: add newline to JSON exports
Add empty line in the end of auto generate/update doctype files, in order to follow the python code style
2025-03-10 06:44:25 +00:00
Ejaaz Khan
1c3ec9bf81
Merge pull request #31581 from tarunps/fix/use-more-filter-types
fix(list_view): use more filter type values to set value on new entry
2025-03-10 12:05:31 +05:30
Tarun Pratap Singh
2012c5478f fix(list_view): use more filter type values to set value on new entry 2025-03-10 11:39:30 +05:30
Ejaaz Khan
f417acaef2
Merge pull request #31552 from CaioMatins/fix-dashboard-permission-query
fix: correct permission query condition in Dashboard
2025-03-09 10:46:16 +05:30
Ejaaz Khan
20ac9a77aa
Merge pull request #31599 from iamejaaz/31598-minor-grid-boder
fix(minor): border radius issue on grid
2025-03-09 06:27:23 +05:30
Ejaaz Khan
2b80a33b9a fix(minor): border radius issue on grid 2025-03-09 05:53:34 +05:30
Ejaaz Khan
21300127ce
Merge pull request #31594 from iamejaaz/32254-auto-email-bg
perf: queue auto email report separately
2025-03-09 01:25:27 +05:30
Ejaaz Khan
a4d44a3eca perf: queue auto email report separately 2025-03-09 01:10:33 +05:30
Soham Kulkarni
7d1718c54e
Merge pull request #31593 from sokumon/translate-report-data
fix: add check to see all variants of english language
2025-03-08 19:57:54 +05:30
sokumon
e73e43a9a7 fix: add check to see all variants of english 2025-03-08 19:21:22 +05:30
Sagar Vora
9e15327a31
Merge pull request #31590 from sagarvora/update-if-needed
perf: restrict doctypes to update and fetch fields in one go
2025-03-08 14:37:37 +05:30