vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
22270 commits 1 branch 0 tags 587 MiB
Commit graph

22270 commits

This branch
This branch
All branches
Author SHA1 Message Date
mergify[bot]
e5fca3d703
Merge pull request #8741 from cclauss/patch-1 
fix(data_migration): Undefined name e in data_migration_run.py
 2019-11-03 06:30:12 +00:00
mergify[bot]
69d4efd3af
Merge pull request #8742 from gavindsouza/reload-dev 
fix: reload via navbar does not reroute to homepage
 2019-11-02 14:18:18 +00:00
Gavin D'souza
6a5692e728 fix: reload via navbar doesnt re-route to homepage 2019-11-02 19:23:42 +05:30
Christian Clauss
fac8dbff01
Undefined name: e in data_migration_run.py 
The current code raises a NameError which is never logged.

[flake8](http://flake8.pycqa.org) testing of https://github.com/frappe/frappe on Python 3.8.0

$ __flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics__
```
./frappe/data_migration/doctype/data_migration_run/data_migration_run.py:417:63: F821 undefined name 'e'
					self.update_log('pull_failed', {migration_id_value: cstr(e)})
                                                              ^
./frappe/patches/v5_0/fix_email_alert.py:12:37: F821 undefined name 'email_alert'
				notification.days_in_advance = -email_alert.days_in_advance
                                    ^
2     F821 undefined name 'e'
2
```
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
 2019-11-02 13:12:45 +01:00
Revant Nandgaonkar
a633d22945
Merge pull request #8720 from revant/port-code 
fix: add missing code for social login key
 2019-11-01 13:50:37 +05:30
mergify[bot]
0e38a965ad
Merge pull request #8670 from Alchez/dev-search-with-special-char 
fix: include items with hyphen in global search irrespective of query
 2019-10-31 17:24:58 +00:00
Suraj Shetty
6b08730a09
style: fix codacy 2019-10-31 15:14:37 +05:30
mergify[bot]
340b2b036a
Merge pull request #8711 from hrwX/no_customize_form_for_custom_dt 
fix: Reroute to doctype if custom doctype
 2019-10-31 09:43:21 +00:00
mergify[bot]
fdb0beb197
Merge pull request #8715 from prssanna/notifications-fix 
fix: Red badge icons on dashboard not working
 2019-10-31 09:42:46 +00:00
Suraj Shetty
93583e4e66
fix: Route to Customise Form if meta does not exists 2019-10-31 14:51:32 +05:30
Suraj Shetty
3bb28ee013
fix: Remove unwanted check 2019-10-31 14:47:55 +05:30
mergify[bot]
991f559f05
Merge pull request #8719 from thefalconx33/float_parse_fix 
fix: number format issue while parsing float values
 2019-10-31 09:15:03 +00:00
Suraj Shetty
2345d90598
fix: typo in email template (#8717) 
fix: typo in email template
 2019-10-31 14:16:56 +05:30
mergify[bot]
f772151bd1
Merge pull request #8710 from scmmishra/clear-filter-patch 
fix: hide clear-filter by default
 2019-10-31 08:41:56 +00:00
Revant Nandgaonkar
314aed831b fix: add missing code for social login key 
add missing code for using custom social login key
 2019-10-30 17:26:45 +05:30
thefalconx33
69fbdf4208 fix: parsing of float value 2019-10-30 16:59:18 +05:30
prssanna
7b7130d979 fix: codacy 2019-10-30 16:51:49 +05:30
Shivam Mishra
30052bb403 fix: typo in email template 2019-10-30 14:15:28 +05:30
prssanna
325a2c864e fix: Allow show_open_count_list to be called outside class 2019-10-30 12:07:44 +05:30
Shivam Mishra
8334845627 fix: hide clear-filter by default 2019-10-30 11:41:49 +05:30
Himanshu Warekar
e6ca8545a4 fix: reroute to doctype if custom 2019-10-30 11:09:02 +05:30
Shivam Mishra
9bbd627db8
Merge pull request #8702 from hrwX/align-dropdown 
fix(Select): specify top for dropdown arrow
 2019-10-30 10:37:59 +05:30
Suraj Shetty
642c025652
Merge pull request #8705 from surajshetty3416/grid-arrow-fix 
fix(grid): Arrow Key Navigation
 2019-10-29 22:08:44 +05:30
Suraj Shetty
6a81145df1 style: Fix formatting issues 2019-10-29 18:50:40 +05:30
mergify[bot]
1b16d4a843
Merge pull request #8692 from netchampfaris/block-cards-globally 
feat: Ability to block module cards for all users
 2019-10-29 13:05:51 +00:00
Saif Ur Rehman
6c77346b52 fix(Grid): arrow key navigation 2019-10-29 18:29:59 +05:30
mergify[bot]
05b46932a0
Merge pull request #8703 from Thunderbottom/email-encoding-fix 
fix: decode non-ascii characters for formataddr
 2019-10-29 12:46:44 +00:00
mergify[bot]
2372bf3f4e
Merge pull request #8434 from gbm001/develop 
fix: Non-ASCII characters in HTTP headers.
 2019-10-29 12:43:14 +00:00
Faris Ansari
f0ffbe1a7b fix: Method name 2019-10-29 18:09:06 +05:30
Faris Ansari
a50323e5a3 fix: Translate select options 2019-10-29 18:03:52 +05:30
Himanshu
23b93ecfb5
Update controls.less 2019-10-29 17:17:50 +05:30
Chinmay D. Pai
2bdcdf5dcf
fix: decode non-ascii characters for formataddr 
formataddr[1] by default encodes non-ascii characters to `=?utf-8?q`, which needs to be decoded to a human-readable string format. using decode_header and make_header we can decode the string back to human-readable format.

before:

In [1]: formataddr(("Tèst", "notifications@erpnext.com"))
Out[1]: '=?utf-8?b?VMOoc3Q=?= <notifications@erpnext.com>'

after:

In [2]: make_header(decode_header(formataddr(("Tèst", "notifications@erpnext.com"))))
Out[2]: 'Tèst <notifications@erpnext.com>'

references:
[1]: https://docs.python.org/3/library/email.utils.html#email.utils.formataddr

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2019-10-29 16:22:25 +05:30
Himanshu Warekar
9904bbe387 fix: specify top for dropdown arrow 2019-10-29 16:16:28 +05:30
mergify[bot]
51e74d037c
Merge pull request #8701 from hrwX/email_dialog_fix 
fix(Communication): check if frm exists
 2019-10-29 10:36:43 +00:00
mergify[bot]
c307dd7fd2
Merge pull request #8700 from scmmishra/query-report-enhancements 
refactor: allow hiding of columns in query report
 2019-10-29 10:31:46 +00:00
mergify[bot]
43c5a9676e
Merge pull request #8691 from netchampfaris/data-import-beta-updates 
fix: Data Import Updates
 2019-10-29 10:03:29 +00:00
mergify[bot]
7c10d256aa
Merge pull request #8695 from ruchamahabal/fix_module_view 
fix(Desk): show/hide cards not working after changing order of cards
 2019-10-29 10:01:35 +00:00
Himanshu Warekar
711f7e7645 fix: check if frm exists 2019-10-29 15:28:11 +05:30
Himanshu
bf57a1d79a Patch(Tags): Check if column exists (#8682) 
* fix: tags patch

* fix: auto_commit_on_many_writes

* fix: check if tag exists

* fix: check if tag or tag link exists

* fix: check if column exists

* fix: set autocommit false

* fix: use ignore in insert query for bulk insert

* fix: add option to ignore duplicates
 2019-10-29 09:52:38 +00:00
mergify[bot]
9793ed8e5b
Merge pull request #8699 from Alchez/dev-auto-email-type-error 
fix: build filter metadata before allowing user to send email (develop)
 2019-10-29 09:46:47 +00:00
mergify[bot]
9bed16f12c
Merge pull request #8629 from ruchamahabal/bulk_update_fix 
fix: bulk update tool updating records but not showing result
 2019-10-29 09:45:47 +00:00
Faris Ansari
26625e5cf4 fix: Show failed logs 2019-10-29 15:12:24 +05:30
Shivam Mishra
92ffbfb067 refactor: allow hiding of columns in query report 2019-10-29 15:11:59 +05:30
mergify[bot]
c57961e931
Merge pull request #8694 from surajshetty3416/apply-rule-only-once 
feat(EPS): Apply rule only once
 2019-10-29 08:53:13 +00:00
Rohan Bansal
c1a0deeb7e fix: build filter metadata before allowing user to send email 2019-10-29 13:31:41 +05:30
Shivam Mishra
fbef91da14
Merge pull request #8696 from scmmishra/group-by-enhance 
refactor: add data and int to group by
 2019-10-29 13:10:38 +05:30
mergify[bot]
0ab6a823ba
Merge pull request #8697 from scmmishra/clear-filter 
fix: layout for clear filter
 2019-10-29 07:17:57 +00:00
Shivam Mishra
3d396adf34 style (codacy): added semi-colon 2019-10-29 12:32:17 +05:30
Shivam Mishra
c8419d5e03 fix: show clear-filter button is default filter exists 2019-10-29 12:25:13 +05:30
Shivam Mishra
e4c21740d0 fix: clear filter button layout 2019-10-29 12:10:55 +05:30