Commit graph

164 commits

Author SHA1 Message Date
Gavin D'souza
c489846547 Merge branch 'develop' into unnecessary_comprehensions 2021-06-11 19:30:23 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Ankush Menat
4754ab71d1
perf(minor): remove unnecessary comprehensions
- remove several unnecessary comprehensions from functions that accept a generator.
- Using `[x for x in iter]` causes a list to be built first then passed to the outer function.
- `any` and `all` can take generator instead. This makes memory usage O(1) and actually makes these functions short-circuiting. E.g. if the first condition fails then `all` will immediately return false instead of evaluating all the entries.
- `sum`, `min`, `max` => memory usage become O(1)
- `list`, `set`, `.join()` => roughly halves memory usage, as list is not required to be built.
- lastly, it's two fewer characters to read/think about.
2021-05-12 20:38:18 +05:30
leela
72ca7e9753 refactor: remove six dependency 2021-05-07 07:42:04 +05:30
Gavin D'souza
0ad122421d fix: Don't hide warnings unnecessarily 2021-05-05 18:51:51 +05:30
Rohan Bansal
86851028ea feat: manage Python 3 compatiblity with dependencies 2021-04-14 14:40:58 +05:30
Aditya Hase
2b1458e3fb
fix: Include dropped and renamed tables in touched tables list 2021-04-12 22:29:49 +05:30
Suraj Shetty
e6ef907184 fix(virtual doctype): Avoid circular calls 2021-04-04 10:13:18 +05:30
Suraj Shetty
65b55f6a90 fix: Check if doctype is virtual doctype before getting value 2021-04-02 16:24:29 +05:30
Shridhar
056b8c0fc6 feat: added get value for virtual doctype 2021-04-01 10:04:11 +05:30
Chinmay Pai
043a6c0804
Merge branch 'develop' into virtual_doctype 2021-03-17 20:18:44 +05:30
Aditya Hase
b0456503f2
perf: Remove frappe.utils.background_job from import tree 2021-02-21 09:42:04 +05:30
Aditya Hase
2413f7e6ec
perf: Replace markdown2.UnicodeWithAttrs with frappe.utils.UnicodeWithAttrs 2021-02-21 09:41:10 +05:30
Chinmay Pai
bcbe162367
chore: change an instance of virtual_doctype to is_virtual 2021-01-11 13:13:39 +05:30
Shridhar Patil
3aebcb1691
chore: clean up database schema sync for virtual doctype
Co-authored-by: Chinmay D. Pai <chinmay.pai@zerodha.com>
Signed-off-by: Chinmay D. Pai <chinmay.pai@zerodha.com>
2021-01-11 13:13:39 +05:30
Shridhar
42d889d2a4
fix: handle virtual doctype flag for existing doctypes 2021-01-11 13:13:38 +05:30
Shridhar
0b4940f017
fix: skip table creation for virtual doctype 2021-01-11 13:13:37 +05:30
Rushabh Mehta
c873c36971 feat(minor): add before_commit methods 2020-12-17 18:46:06 +05:30
everyx
f71a8e0afc fix: PRIMARY KEY must be NOT NULL error when install with MySQL 5.7+ 2020-11-24 14:36:53 +08:00
Gavin D'souza
3b5ec6aa88 fix: Sider + improper command ending 2020-11-17 12:45:55 +05:30
Gavin D'souza
c4e57926f9 feat(postgres): Show restore progress if pv is available 2020-11-17 12:33:21 +05:30
Gavin D'souza
142b6009fe fix: Better error message on missing table 2020-11-10 10:49:40 +05:30
Gavin D'souza
e8fdaa195b refactor: PostgreSQL module methods correspond to MariaDB
* Added bootstrap_database, import_db_from_sql function APIs similar
to MariaDB implementations
2020-11-09 18:55:29 +05:30
Gavin D'souza
b371c70053 refactor: Meaningful variable names 2020-11-09 18:54:47 +05:30
Gavin D'souza
7b1fa59a29 feat: Restore partial backups via bench partial-restore 2020-11-09 18:51:33 +05:30
Rushabh Mehta
1df7831d67 fix(minor): postgres/database.py error handling for missing table 2020-10-26 12:24:11 +05:30
Rushabh Mehta
8707ed1f27 fix(minor): remove "Custom Link" and add patch 2020-10-26 10:02:04 +05:30
Rushabh Mehta
7f9284f3ef fix(tests): postgres gotcha, errors will rollback? 2020-10-26 10:02:04 +05:30
Rushabh Mehta
a0a3606a7f fix(tests): add test cases for custom_link and custom_action 2020-10-26 10:02:04 +05:30
Rushabh Mehta
8a198f363b fix(default): cast as string as required 2020-10-26 10:02:04 +05:30
Suraj Shetty
d546a84659
refactor: Make code more readable 2020-10-18 11:47:28 +05:30
Sebastien Braun
cbf815f25b fix: use configured postgres port in setup_db 2020-10-17 08:08:44 +02:00
Rushabh Mehta
38e024ebbb
Merge pull request #11306 from rmehta/system-console
feat(system console): Added a System Console to help in debugging and Console Log
2020-09-03 11:12:23 +05:30
Rushabh Mehta
5e4ee1a6bc fix(minor): quote the column names in alter table 2020-08-31 11:29:18 +05:30
Rushabh Mehta
1b73602a17 feat(system console): Added a System Console to help in debugging and Console Log 2020-08-31 11:29:18 +05:30
Gavin D'souza
a7af5d0a09 fix: Re-connect to database in case connection is closed 2020-08-19 15:45:10 +05:30
Rushabh Mehta
0192bcf45f fix(minor): frappe.db.set_value to allow multiple values 2020-08-17 22:19:44 +05:30
Rushabh Mehta
56853a0533 fix(linting): sider 2020-08-17 11:10:48 +05:30
Rushabh Mehta
b71acfd5fa fix(minor): print query and values directly if mogrify fails 2020-08-17 10:45:58 +05:30
Rushabh Mehta
b09beb9147 fix(tests): cleanup 2020-08-17 09:41:54 +05:30
Rushabh Mehta
aad2375cf3 fix(major): make document events more efficient, fix bug in cache_manager.get_doctype_map 2020-08-17 09:41:54 +05:30
Rushabh Mehta
26a9230fdd fix(tests): more debugging 2020-08-17 09:41:54 +05:30
Rushabh Mehta
e262ef6add fix(minor): logging fix in document.py 2020-08-17 09:41:54 +05:30
Rushabh Mehta
ef1d1b0dc4 fix(minor): typo 2020-08-17 09:41:54 +05:30
Rushabh Mehta
c83a9a142b fix(minor): mogrify 2020-08-17 09:41:54 +05:30
Rushabh Mehta
eba6dfa12a fix(major): frappe.db.set_value will lock the row 2020-08-17 09:41:54 +05:30
Rushabh Mehta
e421bc19f6 fix(major): frappe.db.set_value will lock the row 2020-08-17 09:41:54 +05:30
Rushabh Mehta
4d97635ab4 fix(major): frappe.db.set_value will lock the row 2020-08-17 09:41:54 +05:30
Rushabh Mehta
14d9c28eb7 fix(test): try with print_sql 2020-08-17 09:41:54 +05:30
Raffael Meyer
0bfba240cf
feat: allow long passwords (#11065)
Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>
2020-08-12 16:09:59 +05:30