Commit graph

33094 commits

Author SHA1 Message Date
Gavin D'souza
e6bdfd8d4f Merge branch 'develop' of github.com:frappe/frappe into unnecessary_comprehensions 2021-06-14 11:53:21 +05:30
Leela vadlamudi
b4f4e48bd6
Merge pull request #13484 from frappe/mergify/bp/develop/pr-13314
fix: encode error to add outgoing mail to sent folder
2021-06-14 10:53:12 +05:30
Suraj Shetty
3b0b147847
Merge pull request #13468 from leela/clickable-urls-in-texteditor 2021-06-14 10:05:45 +05:30
Suraj Shetty
eae6ab3cf9
style: Add missing semicolon 2021-06-14 10:05:14 +05:30
Suraj Shetty
fa97515cf2
Merge pull request #13396 from nextchamp-saqib/shortcut-for-actions-menu-item
fix: cannot set shortcut for actions menu item
2021-06-14 09:44:22 +05:30
Suraj Shetty
62bcd72400
Merge pull request #13479 from frappe/mergify/bp/develop/pr-13439 2021-06-14 09:42:53 +05:30
Suraj Shetty
c299dead5e
Merge pull request #13483 from surajshetty3416/fix-grid-delete-all
fix: Grid delete all should trigger form change
2021-06-14 09:41:48 +05:30
leela
c523e760fd fix: encode error to add outgoing mail to sent folder
Failed to add outgoing mail to sent folder because of encoding issue.
fixed it by using safe_encode method.

(cherry picked from commit 5165e2afa3884310fd653280c834d984a5feda8d)
2021-06-14 09:37:02 +05:30
Suraj Shetty
ff75a72a6e fix: Grid delete all should trigger form change 2021-06-14 09:13:26 +05:30
Gavin D'souza
254b8ae1b3 fix: Use set difference instead of comprehension
Bug introduced via b0bb0cf2c4 due to
improper comprehension definition
2021-06-11 21:07:16 +05:30
Gavin D'souza
1b6c41cbfc fix: Don't re-define pluck bug
Introduced via 974bf463df
2021-06-11 19:44:22 +05:30
Rohit Waghchaure
0e99ea6c4c fix: property to hide grid delete button
(cherry picked from commit d44a4ad730464137cac7a52b372163862687516b)
2021-06-11 14:07:00 +00:00
Gavin D'souza
f92c5d9898 refactor: Unnecessary/illogical check
because cint(False) gives 0
2021-06-11 19:34:34 +05:30
Gavin D'souza
888aa8ad84 refactor(minor): DatabaseQuery.extract_tables 2021-06-11 19:34:24 +05:30
Gavin D'souza
ee75fb38cc style: Restructured if blocks in db_query 2021-06-11 19:34:16 +05:30
Gavin D'souza
974bf463df refactor: Simplify string representations
* Simplify existing %s, .format representations to f-string
* Simplify logic
* Remove redundant tokens
2021-06-11 19:34:00 +05:30
Gavin D'souza
b0bb0cf2c4 refactor(minor): Use set comprehension instead of difference 2021-06-11 19:33:44 +05:30
Gavin D'souza
cd6f353175 chore: Remove dead and sort imports 2021-06-11 19:33:32 +05:30
Gavin D'souza
c489846547 Merge branch 'develop' into unnecessary_comprehensions 2021-06-11 19:30:23 +05:30
gavin
0ba9cd4ca5
Merge pull request #13405 from frappe/dependabot/npm_and_yarn/jquery-3.5.0
chore(deps): [security] bump jquery from 2.2.4 to 3.5.0
2021-06-11 16:37:52 +05:30
Gavin D'souza
1e7cffe8bc chore(ci): Add wait time before checking list view
Cypress form.js tests run just fine locally but not on GHA :thonk:
2021-06-11 16:22:00 +05:30
leela
e534dc0a02 feat: Make url's clickable in text editor when typed/copied
Using a Quill module named quill-magic-url to automatically convert
typed/copied urls into links.
2021-06-10 21:30:53 +05:30
mergify[bot]
88cb19c64c
Merge pull request #13467 from frappe/dependabot/npm_and_yarn/normalize-url-4.5.1
chore(deps): bump normalize-url from 4.5.0 to 4.5.1
2021-06-10 12:40:25 +00:00
dependabot[bot]
f3550f8461
chore(deps): bump normalize-url from 4.5.0 to 4.5.1
Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/sindresorhus/normalize-url/releases)
- [Commits](https://github.com/sindresorhus/normalize-url/commits)

---
updated-dependencies:
- dependency-name: normalize-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-10 11:34:24 +00:00
gavin
dcffc3da42
Merge pull request #13342 from frappe/snyk-fix-6e146ccf3b6880cf19fb4ae0c547a43b
chore(Snyk): Security upgrade cssnano from 4.1.10 to 5.0.0
2021-06-10 17:03:51 +05:30
Gavin D'souza
8524c289f4 Merge branch 'develop' of github.com:frappe/frappe into snyk-fix-6e146ccf3b6880cf19fb4ae0c547a43b 2021-06-10 16:45:49 +05:30
dependabot-preview[bot]
14a1b7f4ac
chore(deps): [security] bump jquery from 2.2.4 to 3.5.0
Bumps [jquery](https://github.com/jquery/jquery) from 2.2.4 to 3.5.0. **This update includes security fixes.**
- [Release notes](https://github.com/jquery/jquery/releases)
- [Commits](https://github.com/jquery/jquery/compare/2.2.4...3.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-06-10 11:13:37 +00:00
mergify[bot]
75a5eb2444
Merge pull request #13341 from alyf-de/messages-translation-context
feat: add context to strings in confirm and prompt dialogs
2021-06-10 10:00:40 +00:00
barredterra
bd1cca90c5 Merge branch 'develop' into messages-translation-context 2021-06-10 09:36:47 +02:00
Leela vadlamudi
550bb6404e
Merge pull request #13442 from leela/refactor-communication
refactor: sendmail of communication doctype
2021-06-09 11:46:21 +05:30
leela
63f4e9ed7b test: testcases for communication email mixin 2021-06-09 11:33:44 +05:30
leela
efb3489a23 refactor: sendmail of communication doctype
Added a CommunicationEmailMixin that has all mail related
functionality
2021-06-08 12:28:30 +05:30
Leela vadlamudi
8b85ac6cf4
Merge pull request #13441 from PMojito/patch-3
fix:check is_submittable attr exists in meta before accessing
2021-06-08 06:28:26 +05:30
Brian Pond
d8113698d1
bug: db_query.py
The object 'meta' does not always have the attribute 'is_submittable.'
This extra syntax checks for existence first.
2021-06-07 16:15:59 -07:00
gavin
513871d8f9
Merge pull request #13432 from gavindsouza/doc.get_url
chore: Use get_absolute_url to doc.get_url
2021-06-07 17:03:52 +05:30
gavin
928de48d9c
Merge pull request #13434 from gavindsouza/rm-frappe-reqstxt
fix: Remove frappe from boilerplate requirements.txt
2021-06-07 17:01:57 +05:30
Gavin D'souza
8e8490976c fix: Remove frappe from boilerplate requirements.txt
Remove frappe from new app boilerplates to avoid possible supply chain attacks. Don't make pip fetch frappe from PyPI
2021-06-07 14:10:49 +05:30
Gavin D'souza
674c8cf77b chore: Use get_absolute_url to doc.get_url
Avoid re-implementation to reduce interfaces for possible bugs/fixes
2021-06-07 12:09:22 +05:30
Sagar Vora
02765c98c9
fix: ensure Page.add_dropdown_item returns link even if it already exists (#13420) 2021-06-06 13:47:17 +05:30
Leela vadlamudi
ce26ad2aef
Merge pull request #13421 from leela/fix-pop-inbound-mails
fix: inbound mail handling for pop3 protocol
2021-06-04 07:11:01 +05:30
leela
70a1cfb1ab fix: inbound mail handling for pop3 protocol 2021-06-04 06:55:17 +05:30
Gavin D'souza
a3b68cbc2e chore(cov): Drop duplicate pattern in omit list 2021-06-03 21:46:39 +05:30
Suraj Shetty
3b32f542a7
Merge pull request #13417 from gavindsouza/patch-tests 2021-06-03 21:32:59 +05:30
Gavin D'souza
9b164571c3 fix: Update coverage omit files
Apply 0d8aeba3ee for parrallel test runner
2021-06-03 20:51:28 +05:30
Gavin D'souza
a74ffda29b chore: Drop dead code to handle webnotes frappe naming 2021-06-03 18:59:29 +05:30
Gavin D'souza
0d8aeba3ee fix: Update coverage omit files
Files that don't end with .py or .pyo ot .pyc are automatically
skipped by coveragepy. Updated omit list accordingly to remove non
python importable files.

ref: https://coverage.readthedocs.io/en/coverage-5.5/source.html#execution
2021-06-03 18:59:00 +05:30
Gavin D'souza
5aeef088ad fix: Remove reloading statements for non existing dts 2021-06-03 18:47:31 +05:30
Gavin D'souza
95ab1a60b4 ci: Add frappe patch test
* Generated v10 backup archive
    * used old v7 erpnext backup hosted via build.erpnext.com
    * upgraded to v10 frappe + erpnext
    * uninstalled and deleted erpnext related data
* Hosted backup on https://frappeframework.com/files/v10-frappe.sql.gz
2021-06-03 17:38:03 +05:30
Gavin D'souza
0e811e0193 chore: Drop unlinked patches (pre v10) 2021-06-03 13:24:29 +05:30
Gavin D'souza
73f320ee39 chore: Drop patches before added before v10
* This change will not allow direct upgrade from frappe versions older than v10 to v13 and newer
* Removed patch records and execute commands that could've been
  guessed aren't needed by sleuthing and guessing. since 2017 had 3 major releases: v8, v9 and v10 unsure which execute lines are required so kept all that were last updated in that year
2021-06-03 13:21:04 +05:30