Gavin D'souza
e71eef0ecc
chore: Drop dead code (pythonrc file)
2021-07-14 20:40:34 +05:30
Gavin D'souza
2ac1c45c66
refactor: Maintain common list for Frappe Coverage settings
...
* Maintain common settings for coverage settings of parallel and base test suites
* Expand FRAPPE_EXCLUSIONS list based on coveralls.io report
2021-07-14 20:40:24 +05:30
Gavin D'souza
8faf2fd759
refactor(minor): frappe.translate module
...
* Remove unset limit for lru cache in get_parent_language
* Simplify get_user_lang and add relevant comment
2021-07-14 19:33:48 +05:30
Gavin D'souza
e8d50b9d3c
chore: Add types for frappe.translate module
...
*only for recently modified functions
2021-07-14 19:32:30 +05:30
Gavin D'souza
e00aaf8cc4
BREAKING CHANGE: Drop frappe.lang in favour of frappe.local.lang
2021-07-14 19:30:01 +05:30
Gavin D'souza
44367c89ba
Merge branch 'develop' of github.com:frappe/frappe into lang-resolution
2021-07-14 19:04:42 +05:30
mergify[bot]
9053ae9a46
Merge pull request #13701 from shariquerik/code-editor-scrollbar-glitch
...
fix: Code Editor scrollbar glitch
2021-07-14 10:29:10 +00:00
gavin
f4d67d617b
Merge pull request #13240 from codescientist703/link-field-fix
...
fix: added suitable filtering mechanism to link field
2021-07-14 12:40:45 +05:30
Sagar Vora
b4ea6c8890
fix: dont refresh form dashboard in layout.refresh_sections ( #13650 )
2021-07-14 12:21:28 +05:30
Gavin D'souza
0598ddf70e
fix: Clear preferred_language cookie post login
...
If preferred_language was set in cookie pre login, clear it after a
successful login so that User or Site specific settings can be applied
2021-07-14 12:21:12 +05:30
Gavin D'souza
736c6c9b8a
fix: Don't redefine datetime
...
* Sort imports
* Update file header
2021-07-14 12:21:12 +05:30
Gavin D'souza
76ec9e44e4
refactor: Rename guess_language as get_language
...
Guess suggests there's some AI involvement. The get_language function
has a defined priority. It is deterministic, hence teh name change.
2021-07-14 12:21:12 +05:30
Gavin D'souza
c47cbfd2ef
refactor: Set Language in HTTPHeader
...
Order of priority for setting language:
1. Form Dict => _lang
2. Cookie => preferred_language
3. Request Header => Accept-Language
4. User document => language
5. System Settings => language
Cookie is placed at #2 since the language picker in the navbar depends
on it. And the Accept-Language header sends values based on the client's locales.
---
Form Dict _lang now accepts language codes too. Previously, language
names were used...for whatever reason.
2021-07-14 12:21:12 +05:30
Gavin D'souza
caafd9e2b5
refactor: Simplify HTTPRequest class
...
* For the sake of Readability and ease of understanding
* Style updates
2021-07-14 12:21:12 +05:30
Fahim Ali Zain
f5bd21cf46
fix: preferred_language cookie support for all users
2021-07-14 12:21:12 +05:30
Gavin D'souza
f96ebb1f66
perf: Skip guess_language if _lang is provided
2021-07-14 12:21:12 +05:30
Fahim Ali Zain
9d9d76efe6
fix: frappe.local.lang resolution
2021-07-14 12:21:11 +05:30
shariquerik
0eafadf002
fix: Code Editor scrollbar glitch
2021-07-14 12:10:11 +05:30
Gavin D'souza
6f17e3d45f
perf(test_search): Setup and teardown tests only if needed
2021-07-14 12:02:33 +05:30
Leela vadlamudi
ee1b27587d
Merge pull request #13698 from leela/fix-email-attachments
...
fix: sending document as an attachment through mail
2021-07-14 10:47:28 +05:30
leela
f2267bec25
fix: sending document as an attachment through mail
...
Currently sending document as an attachment is failing and the fix is to
make it work by fixing the bug introduced in latest refactoring.
2021-07-14 10:28:10 +05:30
mergify[bot]
6128123eed
Merge pull request #13687 from bhavesh95863/patch-6
...
fix: Duplicate if condition removed
2021-07-13 15:22:34 +00:00
gavin
59f4b4d754
Merge pull request #13554 from gavindsouza/drop-data-import-legacy
...
chore: Drop Data Import Legacy
2021-07-13 20:39:00 +05:30
codescientist703
b619c3d330
test: added test for order of link
2021-07-13 20:24:24 +05:30
mergify[bot]
e528c959e8
Merge pull request #13692 from resilient-tech/fix-boilerplate
...
fix: escape quotes before declaring variables when making a new app
2021-07-13 14:21:24 +00:00
Pruthvi Patel
bed64ef0ad
test: change app description to test if quotes are being escaped
2021-07-13 18:49:26 +05:30
codescientist703
79124873c3
fix: fixed sider recommendation
2021-07-13 18:43:34 +05:30
mergify[bot]
2ca636be31
Merge pull request #13640 from alyf-de/bench_version_branch_commit
...
feat: different output formats for `bench version`
2021-07-13 12:59:36 +00:00
barredterra
199990decc
Merge branch 'develop' into bench_version_branch_commit
2021-07-13 14:30:56 +02:00
Sagar Vora
b23dd71116
fix: escape quotes before declaring variables when making a new app
2021-07-13 17:56:47 +05:30
Suraj Shetty
e2bee9b46d
Merge pull request #13689 from surajshetty3416/fix-customize-form
2021-07-13 17:26:53 +05:30
Suraj Shetty
cf67dbce5a
fix: Add missing fieldtypes in for custom fields
2021-07-13 16:56:49 +05:30
barredterra
fc2c887635
test: fix return code
2021-07-13 13:23:25 +02:00
gavin
9c0acea286
Merge pull request #13630 from frappe/dependabot/npm_and_yarn/minimist-1.2.5
...
chore(deps): [security] bump minimist from 1.2.0 to 1.2.5
2021-07-13 16:42:30 +05:30
barredterra
04094110f5
fix: handle detached head
...
Workaround for https://github.com/gitpython-developers/GitPython/issues/633
2021-07-13 13:11:15 +02:00
dependabot-preview[bot]
8bc498c18c
chore(deps): [security] bump minimist from 1.2.0 to 1.2.5
...
Bumps [minimist](https://github.com/substack/minimist ) from 1.2.0 to 1.2.5. **This update includes security fixes.**
- [Release notes](https://github.com/substack/minimist/releases )
- [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-07-13 10:42:00 +00:00
Bhavesh Maheshwari
68930a022a
fix: Duplicate if condition remove
2021-07-13 15:55:24 +05:30
gavin
a837a4d69c
Merge pull request #13680 from frappe/mergify/bp/develop/pr-13667
...
fix: custom script to duplicate row not working in v13 (backport #13667 )
2021-07-13 13:21:55 +05:30
Gavin D'souza
8dcb7a1eaa
style: Remove redundant comments
2021-07-13 12:04:50 +05:30
Gavin D'souza
2aa2586a0c
fix: Drop deprecated validate_csv_import_file def
2021-07-13 12:04:18 +05:30
Gavin D'souza
baea532c3d
fix: Move depr module module utils in exporter
2021-07-13 11:27:58 +05:30
Gavin D'souza
0d0e527416
chore: Show deprecation warning in command help
2021-07-13 11:21:21 +05:30
Gavin D'souza
dc50b77179
chore: Drop Data Import Legacy
2021-07-13 11:21:21 +05:30
mergify[bot]
df9386208a
Merge pull request #13655 from MitulDavid/patch-1
...
fix: Accurately cast fieldtype in frappe.db.get_single_value()
2021-07-13 05:50:12 +00:00
Rushabh Mehta
372447846e
fix(minor): website_builder.scss removed border for cards
2021-07-13 10:14:43 +05:30
Rushabh Mehta
959a5549d1
fix(minor): website_builder.scss padding and line-height for cards
2021-07-13 09:51:40 +05:30
Mitul David
42585579e6
refactor: Replace str.format() with f-strings
2021-07-12 19:13:29 +05:30
rohitwaghchaure
10fde05950
fix: custom script to duplicate row not working in v13 ( #13667 )
...
(cherry picked from commit 1615baf69a476a4c8361cd8af19e2edada6b4784)
2021-07-12 12:15:28 +00:00
mergify[bot]
d8c4ad379c
Merge pull request #13488 from shariquerik/custom-report-link-fix
...
fix: Invalid Custom Report link on Workspace
2021-07-12 12:10:08 +00:00
Mitul David
934fc17a3b
refactor: Improve readability, consistency
2021-07-12 15:52:57 +05:30