Commit graph

39466 commits

Author SHA1 Message Date
Ankush Menat
e8af6b2c16 feat: make attachments public on doctypes
When this checkbox is checked, while uploading docs using fileuploader
the default visibility will be set to "public".

At present all uploaded attachments are private, however in following
cases it makes sense to set default as public:

1. Blog post
2. Item catalog
3. Website item

Considering this we decided to add this configurtion so developers can
specify sane default while user still has control over it using
"Customize form"

Enabled this for "blog post" doctype

Unrelatd change: consistent "form settings" section on DocType and customize
form
2022-08-26 12:42:26 +05:30
Ankush Menat
bde4e44cf4 fix: don't attempt to delete workspace in prod 2022-08-26 12:34:00 +05:30
Suraj Shetty
81fa146330
fix: Do not show "Not Saved" on loading System Settings (#17967) 2022-08-26 10:44:51 +05:30
Ankush Menat
7e34da6bec build(deps): bump werkzeug
Werkzeug has faster router now
2022-08-26 10:23:09 +05:30
Ankush Menat
17d327719e build(deps): drop unused dependencies
- googlemaps
- google-auth-httplib2
- urllib3
- pypng
- pyasn1
- gitdb
2022-08-26 10:23:09 +05:30
Ankush Menat
8950c4170b
ci: only wait for assets in server task
[skip ci]
2022-08-25 23:22:06 +05:30
Ankush Menat
9d06979b2d
ci: misc ci things (#17960)
* ci: skipped jobs should exit with neutral status

* ci: dont cache NPM

We don't use npm, why is this even here?

* ci: supress non-failure compile messages

1000s of files make it difficult to find where failure actually occured.

* ci: install wkhtml after other deps

two apt processes clash each other and waste time till lock is released.

Also silence download... no one cares.

* ci: build assets concurrently

* style: clean up messy bash script

* ci: rename patch job
2022-08-25 19:16:25 +05:30
HENRY Florian
aac5e3d3c1
chore: update fr translation (#17950) 2022-08-25 13:52:33 +05:30
Ankush Menat
9ce3d3c81b docs: warning for remove subtree
[skip ci]
2022-08-25 11:35:53 +05:30
Raffael Meyer
d05ed27a01
feat: remove subtree (#17647)
* feat: remove subtree

* test: remove_subtree
2022-08-25 11:34:05 +05:30
Ankush Menat
9d6814dbc9
Merge pull request #17938 from ankush/add_user_cm
feat(bench): add new bench command for add user
2022-08-24 15:57:14 +05:30
Suraj Shetty
b2e1b8057e
Merge pull request #17937 from surajshetty3416/fix-base-control 2022-08-24 15:06:41 +05:30
Ankush Menat
6ec5c05e4e test: simplify user addition test 2022-08-24 14:50:22 +05:30
Alaa Alsalehi
40f54d04b7 feat(bench): add new bench command for add user 2022-08-24 14:29:50 +05:30
Suraj Shetty
2e91e92227 fix: Set last_value for check
- Revert https://github.com/frappe/frappe/pull/17390 since it used to set this.value before triggering change events... due to this this.last_value & this.value was having same value in change events of some control (eg. link field)
- set_input has the responsibility to set this.value and this.last_value properly.
2022-08-24 14:04:17 +05:30
Ankush Menat
80c4a0b3e3
Merge pull request #17884 from ankush/owner_perm
fix: permissions dont refresh when switching doc
2022-08-24 13:34:43 +05:30
Ankush Menat
722d57637f refactor: convert control.perm to a property 2022-08-24 12:40:50 +05:30
Ankush Menat
80d264a7b4 fix: permissions dont refresh when switching doc
Grid permissions aren't refreshed when switching docs.

Setup permissions like this:

1. Normal perm - read
2. If owner - read + write + others
3. Open a normal doc -> is read only so grid is read only.
4. Now go back and open a created doc -> grid will be read only or empty
   (if no rows)

fix: make grid.perm a computed property that refers to form instead of
duplicating this.

ref: ISS-22-23-01733
2022-08-24 12:40:50 +05:30
Ankush Menat
4e6a5b6cd9
ci: enable codecov annotations (#17929) 2022-08-24 11:50:23 +05:30
Raffael Meyer
63a60c6457
fix: translate import warnings (#17924) 2022-08-24 11:37:41 +05:30
Ankush Menat
2623b7e63c test: top bar for website 2022-08-24 11:03:53 +05:30
Faris Ansari
9358655ae2
fix: 'TopBarItem' object does not support item assignment #17926
TypeError: 'TopBarItem' object does not support item assignment
2022-08-24 10:39:20 +05:30
Ankush Menat
cdb0732646
perf: avoid coalescing wherever possible (#17920) 2022-08-24 10:30:51 +05:30
Shariq Ansari
5a0b854700
Merge pull request #17918 from shariquerik/standard-webform-fix 2022-08-23 20:57:09 +05:30
Shariq Ansari
d17fd03958 chore: moved include script from html to web_form.bundle.js 2022-08-23 17:00:27 +05:30
Shariq Ansari
78ab3d8429 chore: removed unused code 2022-08-23 16:39:14 +05:30
Shariq Ansari
5ca89e0dad revert: use meta fields in standard webforms 2022-08-23 16:33:14 +05:30
Ritwik Puri
7fae79c200
Merge pull request #17883 from phot0n/fetch-domain-values
fix: fetch email domain values for email account
2022-08-23 11:16:58 +05:30
mergify[bot]
ff0f0db2e8
Merge pull request #17294 from resilient-tech/remove-old-ref
chore: remove old code where User Permissions were set in `tabDefaultValue`
2022-08-23 05:13:07 +00:00
Suraj Shetty
3d84a748b7
Merge pull request #17863 from shariquerik/web-form-misc-fixes 2022-08-23 09:54:23 +05:30
phot0n
141693a75b fix: use debounced frappe.call on domain selection
Also removed  tag from domain and service labels in email account doctype
2022-08-23 00:36:53 +05:30
Shariq Ansari
2b57e77f29 feat: added not saved indicator if form is dirty 2022-08-22 19:40:51 +05:30
Shariq Ansari
7d245268ea style: rating field style changes in view mode
color field causing error in view mode (fixed)
2022-08-22 19:04:47 +05:30
Sagar Vora
c5face41b3 fix: clear notifications cache when deleting a Notification 2022-08-22 19:04:18 +05:30
Sagar Vora
2866721a78 test: clear lang_full_dict from local cache 2022-08-22 19:04:18 +05:30
Sagar Vora
63e760e3ad chore: remove old code where User Permissions were set in tabDefaultValue 2022-08-22 19:03:30 +05:30
Shariq Ansari
fb8ba3d881 fix: include Color field in Web Form fieldtypes 2022-08-22 18:21:48 +05:30
Shariq Ansari
02da933c16 fix: setup field's change event instead of input change event 2022-08-22 18:19:38 +05:30
Shariq Ansari
4b4d66d2a3 fix: title should never be empty 2022-08-22 16:47:15 +05:30
Shariq Ansari
309b42f1a3 fix: show webform name and webform doc name on header 2022-08-22 15:57:46 +05:30
Shariq Ansari
d0111f7d14
Merge pull request #17847 from shariquerik/edit-public-workspace-fix 2022-08-22 15:31:49 +05:30
Shariq Ansari
66389932d1 fix: show introduction in edit mode 2022-08-22 13:19:03 +05:30
Shariq Ansari
b1944916c3 fix: show discard dialog only if form is dirty 2022-08-22 13:16:30 +05:30
Ankush Menat
7b3cc322f1
Merge pull request #17891 from ankush/misc_fixes
perf: ~45% faster Desk first response
2022-08-22 11:45:20 +05:30
Ankush Menat
b30a78aa40
perf: install hiredis for faster response parsing (#17893) 2022-08-22 11:39:18 +05:30
Ankush Menat
794a2b8101
Merge pull request #17894 from ankush/db_no_getall
chore: db.get_all -> get_all
2022-08-22 11:38:04 +05:30
Ankush Menat
1de22b6082 chore: ignore fluff change in blame
[skip ci]
2022-08-22 11:35:53 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Ankush Menat
4241f8c8c0 perf: simpler/faster preload header computation
We parse entire response to find preload headers, instead just use
include_style and include_script to include assets directly into preload
headers. This shaves off ~13% overhead in response.
2022-08-21 18:46:58 +05:30
Ankush Menat
48869d506f perf: dont order by for uniq searches 2022-08-21 17:37:40 +05:30