Corentin Flr
e8fe24d7df
feat(router): Go to default workspace when clicking app logo ( #25706 )
2024-03-29 15:44:25 +05:30
Ankush Menat
87ffe25e71
fix: reserved keywords as col name ( #25718 )
2024-03-29 15:43:33 +05:30
Akhil Narang
34f1b9cb65
Merge pull request #25719 from akhilnarang/fix-enqueue-method
...
fix(enqueue): pass the original method argument here
2024-03-29 14:17:34 +05:30
Akhil Narang
8658196650
fix(enqueue): pass the original method argument here
...
Don't pass the stringified version - this is what goes to RQ, and the string we construct isn't always "correct"
For example, 87d121f47a/frappe/email/doctype/email_queue/email_queue.py (L735-L736)
2024-03-29 14:05:33 +05:30
Akhil Narang
2feacf5443
Merge pull request #25683 from akhilnarang/rollback-new-site
...
feat: rollback new site creation on failure
2024-03-29 12:42:38 +05:30
Akhil Narang
ee8e2fef8c
refactor(new-site): update rollback prompt
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:12:19 +05:30
Akhil Narang
197b1ab77c
refactor(installer): use frappe.generate_hash() to generate database name
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:12:19 +05:30
Akhil Narang
07f93e2817
fix(generate_hash): Deprecate txt parameter - its not used.
...
`length` has a default value anyway, no need of checking and setting a default.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:12:15 +05:30
Akhil Narang
1847e9cae8
fix: pass function as lambda
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
9940868063
fix: switch to datetime.now() instead of our get_datetime()
...
`get_datetime()` will query the DB to get the system timezone, not something we currently have.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
4b2fde1d8f
fix: check if rollback callback is defined
...
Don't raise exceptions where a simple print() will suffice
Print exception before prompting for rollback
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
c58e986a87
chore: check whether we're in an interactive session or not
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
147c0c8b37
feat: initial failed site rollback implementation
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
46981622ec
feat: generate a non-deterministic database name every time - include current date in the hash
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
1ffc4c7834
chore: update output to let the user know they can pass --force
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
8cd23ecef5
chore: drop unused parameter
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Raffael Meyer
c43ec1cc37
Merge pull request #25707 from barredterra/translatable-insights-ad
2024-03-28 17:21:16 +01:00
barredterra
449d7d3b3d
fix: make insights ad translatable
2024-03-28 17:19:53 +01:00
Ankush Menat
be579f9a8d
fix: sql_ddl - always ensure commit ( #25704 )
2024-03-28 13:13:55 +00:00
Ankush Menat
87d121f47a
Merge pull request #25660 from uhrjun/develop
...
fix: incorrect status on data import
2024-03-28 17:17:41 +05:30
Ankush Menat
9f7c385b11
fix: erase logs in case of complete failure
2024-03-28 16:59:36 +05:30
avc
81833afda0
fix: let's colored tags in listview ( #25552 )
2024-03-28 15:58:12 +05:30
Akhil Narang
2710c28870
fix(importer): set Pending status as a fallback
...
Will match scenarios like success == failed == 0
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-28 15:14:56 +05:30
Ankush Menat
f22120190d
fix: Correct logic for comlete success
2024-03-28 14:48:10 +05:30
Ankush Menat
141e082b39
Merge pull request #25698 from ankush/fix_virtual_order_by
...
fix: recorder sorting with multi-col
2024-03-28 13:36:42 +05:30
Ankush Menat
7220a7d898
fix: recorder sorting with multi-col
2024-03-28 13:26:34 +05:30
Ankush Menat
23204c0c05
Merge pull request #25256 from ankush/no_commit_doc_events
...
fix: disable transaction commits during doc events
2024-03-28 12:28:12 +05:30
Ankush Menat
e5a64fd50c
test: transaction control
2024-03-28 11:58:38 +05:30
Ankush Menat
f66b23b96d
fix: handle nested event calls
...
Treat disable_transaction_control as a stack incr/decr when moving in
and out of context.
2024-03-28 11:27:24 +05:30
Ankush Menat
0cbd7c825b
Merge pull request #25650 from akhilnarang/fix-replyto-communication-reply
...
fix: set correct Reply-To header for replies
2024-03-28 10:03:57 +05:30
Ankush Menat
5fce9a471e
Merge pull request #25693 from barredterra/less-ads
...
fix: advertise insights to system manager only
2024-03-28 01:13:55 +05:30
barredterra
57bcfe548e
fix: advertise insights to system manager only
2024-03-27 19:55:38 +01:00
Ankush Menat
e5b1747f75
Merge pull request #25691 from barredterra/translatable-ads
...
fix: make ads translatable
2024-03-28 00:21:13 +05:30
barredterra
7426805425
fix: make ads translatable
2024-03-27 19:47:42 +01:00
Ankush Menat
3fea2726f3
fix: modified index sync
2024-03-27 23:56:03 +05:30
Ankush Menat
83eadd7257
Merge pull request #25677 from barredterra/in-context-translation
...
feat: In-Context Translation
2024-03-27 20:42:07 +05:30
Ankush Menat
67bcda333e
fix: auto add modified index when sort_field is set to it ( #25686 )
...
This is 2nd most common sort order, so we should support adding index
for it automatically.
Not quite sure on generalizing this behaviour *YET*
2024-03-27 14:40:26 +00:00
Ankush Menat
8dd10b3a03
fix: incorrect UI icon for desc sort ( #25687 )
2024-03-27 14:11:22 +00:00
Ankush Menat
85f66c083e
fix: preserve original error message ( #25682 )
2024-03-27 13:13:49 +00:00
barredterra
41a28e7381
fix: load crowdin script using https
2024-03-27 13:15:53 +01:00
Raffael Meyer
8cebe9f2de
Merge pull request #25678 from barredterra/translatable-web-footer
2024-03-27 13:07:17 +01:00
barredterra
b056147fea
fix: translatable web footer
2024-03-27 13:05:50 +01:00
barredterra
90610a7e8e
feat: In-Context Translation
2024-03-27 12:53:15 +01:00
Akhil Narang
722bb3b0fc
Merge pull request #25659 from marination/wkhtml-options
...
fix: Use CssParser to correctly pass options to wkhtmltopdf
2024-03-27 17:15:36 +05:30
Ankush Menat
59b95a4d19
fix: invalid filter on email acccount ( #25674 )
2024-03-27 11:09:59 +00:00
marination
96667b1bab
chore: Use dict comprehension instead of nested loops
2024-03-27 12:00:49 +01:00
Ankush Menat
f11313d4c9
Merge pull request #25453 from RitvikSardana/develop-ritvik-filter-eval-support
...
feat: add eval support for link field filters
2024-03-27 15:31:31 +05:30
Kevin Shenk
12f193231d
refactor: enable website utils in safe_exec ( #25365 )
...
Frappe Builder uses safe_exec to fetch dynamic data, and there are a few functions in website utilities which would be nice to have on that end, get_html_content_based_on_type especially. I added a few others which seemed useful and safe as well.
2024-03-27 15:26:28 +05:30
Ankush Menat
b7bc5d3236
fix(round 3): switch to creation sorting ( #25669 )
2024-03-27 08:59:04 +00:00
Ankush Menat
c051c7aba8
fix: keep modified indexed if that's what schema asks for ( #25668 )
2024-03-27 08:49:49 +00:00
