Commit graph

43444 commits

Author SHA1 Message Date
Maharshi Patel
e99f07c8a3 fix(minor): dark mode checkbox disabled state. 2023-09-21 11:30:01 +05:30
Maharshi Patel
37f03069bf
Merge branch 'develop' into feat-desk-refresh 2023-09-20 22:24:33 +05:30
Maharshi Patel
9b6d6267dd fix: awesome_bar & sidebar cypress test as per espresso. 2023-09-20 22:22:44 +05:30
Corentin Flr
41d30e7213
feat: Add custom icons with the app_include_icons hook (#22254)
* feat: Add custom icons with the `app_include_icons` hook

These custom icons are available on the desk only. They can be picked in the `ControlIcon` picker.

Co-authored-by: Abraham Kalungi <85731451+kalungia@users.noreply.github.com>

* fix: skip conf for including icons

* test: Fix test_include_icons

---------

Co-authored-by: Abraham Kalungi <85731451+kalungia@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-20 20:23:17 +05:30
HENRY Florian
42ee7f9b2d
feat: bulk update fields select sorted by translated labels (#22318)
* feat: bulk update fields sorted translated alpha sort

* chore: implement review from @barredterra

* chore: fix linter/prettier

* fix: convert to string

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 18:52:21 +05:30
Ankush Menat
ff26528ab0 style: format 2023-09-20 18:16:10 +05:30
Psyi Rius
36c182e72c
chore(js): improved cryptic looking sanitise regex with info (#22357) 2023-09-20 17:39:33 +05:30
Anand Baburajan
5004374ecc
chore: handle invalid connections conf for internal links (#22486)
* chore: handle invalid connections conf for internal links

* chore: remove unnecessary None
2023-09-20 11:14:51 +00:00
Maharshi Patel
2cb6076b59 fix: cypress, dark mode, grid search, timeline
fixes for Espresso
* due to have fixed height of the grid heading, the search bar was not visible now
  added class that will double the height of the grid heading row if filter row is present.
* dark mode fixes: button active state, Awesomeplete dropdown, Quill editor.
* timeline style fixes
2023-09-20 16:35:30 +05:30
Bernd Oliver Sünderhauf
67376e26d4
fix: Set system timezone for Administrator and Guest users. (#22440)
* fix: Set system timezone for Administrator and Guest users.

* refactor: use constant instead of duplicating

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 15:26:00 +05:30
mergify[bot]
69b0fcf06e
Merge pull request #22316 from cogk/fix-email-subject-decode
fix: Fix email subject decoding
2023-09-20 09:41:59 +00:00
Corentin Flr
15010cf8a9
fix: Fix typo in form_tour (#22474) 2023-09-20 13:22:09 +05:30
David Arnold
086435c004
feat: add upstream json argument to integrations make_request (#22462)
* feat: add upstream json argument to integrations make_request

* style: format

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 13:15:22 +05:30
Ankush Menat
3a0522f0ba
Merge pull request #22480 from ankush/reportview
fix: reportview where fields dont have label
2023-09-20 12:53:21 +05:30
Ankush Menat
9a36a09bee fix: remove unnecessary conditional
both code branches exactly same, so why bother
2023-09-20 12:30:44 +05:30
Ankush Menat
d7f4518de3 fix: handle df without labels in report view 2023-09-20 12:30:41 +05:30
Ankush Menat
56371f09e0 Revert "fix!: Bind development server only to localhost (#22397)"
This reverts commit 9244140816.

Breaks docker development installs
2023-09-20 11:43:56 +05:30
Ankush Menat
acd1b9d64e
fix: Don't run query if dn is None (#22475) 2023-09-19 15:11:15 +00:00
Suraj Shetty
be5e05f7a2
Merge pull request #22436 from 0xsirsaif/bench-listapps-refactor 2023-09-19 20:32:55 +05:30
Suraj Shetty
004789b599
Merge pull request #22471 from niraj2477/add-print-shortcut 2023-09-19 16:16:45 +05:30
Suraj Shetty
7905423128
Merge pull request #22446 from surajshetty3416/fix-dashboard-chart-permission 2023-09-19 15:33:25 +05:30
14987
b7e35e558e
feat: Add print shortcut 2023-09-19 15:14:51 +05:30
Shadrak Gurupnor
c4afd035e8
feat: view committed queries in console log (#22466)
* feat: show committed queries in console log

* chore: typo
2023-09-19 14:38:23 +05:30
Maharshi Patel
a06808baaa fix: don't override label in set_action when icon is present 2023-09-19 13:15:38 +05:30
Corentin Flr
d73a854191
feat(UX): Add autocomplete for User timezone (#22456)
* feat(UX): Add autocomplete for User timezone

* Revert "feat(UX): Add autocomplete for User timezone"

This reverts commit a721b4a1ef8e0e6b656b6795b832324a955b2f7a.

* fix: convert tz to autocomplete

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-18 22:37:32 +05:30
Ankush Menat
6939a24d43 test: update tests for ui changes
- update selectors
- remove color check code
2023-09-18 21:23:49 +05:30
Ankush Menat
1ebbbc772e Merge branch 'develop' into feat-desk-refresh 2023-09-18 21:05:37 +05:30
Ankush Menat
e152ebc0a3 chore: typo 2023-09-18 20:16:27 +05:30
Ankush Menat
8779be9b49
fix: propogate correct HTTP status code (#22450) 2023-09-18 10:30:12 +00:00
Ankush Menat
8cb13f922a chore(DX): Annotate all local proxies 2023-09-18 15:36:58 +05:30
Maharshi Patel
969fd71d01 fix: dark mode and misc
* timeline, quill toolbar, attach control, modal backdrop.
* datatable, notification color and spacing, checkbox disabled state and more.
* workspace edit mode, grid link icon, label and input spacing.
2023-09-18 15:28:22 +05:30
Ankush Menat
6a2bfbf61d
fix: Ignore perm while updating module onboarding (#22448)
* fix: Ignore perm while updating module onboarding

* fix: incorrect error message
2023-09-18 09:00:53 +00:00
Ankush Menat
6a2266c641
Merge pull request #22445 from ankush/perm_ux
fix: permission manager if-owner behaviour
2023-09-18 14:05:52 +05:30
Ankush Menat
0381f836d6 fix: update correct role permission rule
Right now if you have if-owner rule on doctype then whatever you change
will only apply to last inserted rule because we don't check if-owner
value

Long term better fix: Identify with perm rule name instead of arbitrary
"primary keys" defined in code.
2023-09-18 13:45:20 +05:30
Suraj Shetty
df30e1c6f0 fix: Only allow user with role set in Dashboard chart
If roles are set is Dashboard Chart, only
user with those roles can access the chart.
If not set, DocType or Report permissions should be used
2023-09-18 13:44:09 +05:30
Ankush Menat
b484c65283 fix: check if owner while deleting permission
If doctype has 2 rules: 1 with if-owner and one without then deleting one deletes both.
2023-09-18 12:33:26 +05:30
Ankush Menat
fb65ab1a4e fix: notify when rule already exists 2023-09-18 12:28:14 +05:30
mergify[bot]
091c6ca49f
Merge pull request #22441 from blaggacao/develop
fix: `flt` with trailing zeros
2023-09-18 06:35:05 +00:00
Ankush Menat
f1ffc3fd39 test: fix bankers rounding test
One more `null` needs to be passed for "not passing precision"
2023-09-18 11:42:21 +05:30
Ankush Menat
7b91df0db6 Merge branch 'develop' into blaggacao/develop 2023-09-18 11:36:38 +05:30
Ankush Menat
808316cc13
Merge pull request #22444 from ankush/perf_docinfo
perf: docinfo
2023-09-18 11:32:04 +05:30
Ankush Menat
d20e436e0f perf: fetch user info in one query 2023-09-18 11:16:20 +05:30
David Arnold
2ddd808b58
test: add more test cases with number & currency formatting 2023-09-17 16:44:13 +02:00
David Arnold
0568795edd
Revert "fix: make flt value idempotent"
This reverts commit 4d0b0d35ef.
2023-09-17 15:39:57 +02:00
David Arnold
9f0c8be183
test: add failing test case for js flt 2023-09-17 15:36:36 +02:00
Ankush Menat
8f34d6fc3e perf: docinfo
- Dont query versions if disabled
2023-09-17 14:16:47 +05:30
saif
8b83e051d0 refactor: Improve list_apps function readability and maintainability.
- Improve variable naming and reduce redundancy.
- Reorganize and simplify code structure.
2023-09-17 11:41:13 +03:00
mergify[bot]
3239636e7d
Merge pull request #22187 from cogk/ux-list-view-sort-columns
feat(list): Sort by column by clicking on col title
2023-09-17 07:19:26 +00:00
Corentin Flr
2f1119bfcc
Merge branch 'frappe:develop' into ux-list-view-sort-columns 2023-09-17 08:57:37 +02:00
Ankush Menat
ea7b080e70 chore: nudge towards properly skipping onboarding
Escape doesn't totally skip
2023-09-15 19:14:24 +05:30