Akhil Narang
ea65d86d72
Merge pull request #24625 from blaggacao/fix/shell-escaping
...
fix: shell escaping on external commands
2024-02-01 12:45:21 +05:30
Ankush Menat
bedf5ba65e
Merge pull request #24656 from ankush/retry_contact
...
fix: outgoing email account handlng
2024-02-01 11:52:07 +05:30
Ankush Menat
dae99eb53c
fix: Fetch SMTP server inside context
...
Currently if smtp server creation fails email queue is endlessly
retried. It should just fail if there's no outgoing account.
2024-02-01 11:10:57 +05:30
Ankush Menat
78665d98b2
fix: Bail if no SMTP acccount can be found
...
Currently we give this weird error instead of just saying no outgoing email account is configured.
```
AttributeError: 'NoneType' object has no attribute 'get_smtp_server'
File "frappe/email/queue.py", line 154, in flush
email_queue.send()
File "frappe/email/doctype/email_queue/email_queue.py", line 160, in send
with SendMailContext(self, smtp_server_instance) as ctx:
File "frappe/email/doctype/email_queue/email_queue.py", line 236, in __init__
self.smtp_server: SMTPServer = smtp_server_instance or self.email_account_doc.get_smtp_server()
```
2024-02-01 11:10:57 +05:30
Ankush Menat
3634d11b6a
fix: Retry contact update if it fails due to conflict ( #24654 )
2024-02-01 05:14:00 +00:00
Ankush Menat
0458544c3b
refactor!: Simplify asset caching ( #24649 )
...
Few changes:
1. Client side asset caching is needlessly complicated with 2 layer of
caching. Browser already caches things, moving them again to
localstorage is uselss and counterproductive because of limits on localstorage.
2. `frappe.assets` was an object that should've been a class.
3. lots of old js syntax.
2024-01-31 21:23:04 +05:30
Ankush Menat
a69aad85b2
Merge pull request #24647 from ankush/dynamic_link_deletion
...
fix: Enqueue deletion of dynamic link after comitting
2024-01-31 18:57:06 +05:30
Ankush Menat
5e904d407e
Merge pull request #24474 from blaggacao/fix/run-tests-module-def
...
fix: run-tests --module-def as not all doctypes are guaranteed to have test_*.py files
2024-01-31 18:52:45 +05:30
Ankush Menat
fc942856e0
Merge pull request #24641 from barredterra/fix-permcheck
...
fix: use the correct doc method
2024-01-31 18:49:41 +05:30
Ankush Menat
dd6f20b301
Merge pull request #24644 from ankush/clear_sitemap_cache
...
fix: clear sitemap cache periodically
2024-01-31 18:41:54 +05:30
Ankush Menat
ca293c9aa3
fix: Enqueue deletion of dynamic link after comitting
2024-01-31 18:37:12 +05:30
Ankush Menat
3962b6ff24
Merge pull request #24642 from ankush/fix_no_notify
...
fix: don't notify links if not public
2024-01-31 18:26:14 +05:30
Ankush Menat
ffb9c9cf6a
fix: clear sitemap cache periodically
2024-01-31 18:25:28 +05:30
Ankush Menat
d2d669b720
fix: don't notify links if not public
2024-01-31 18:09:20 +05:30
barredterra
09919a3e58
fix: use the correct doc method
2024-01-31 12:55:41 +01:00
Shariq Ansari
96f35300a2
Merge pull request #24637 from shariquerik/typeerror
...
fix: typeerror in onboarding_tours.js
2024-01-31 16:31:18 +05:30
Shariq Ansari
e7b3a785c1
fix: typeerror in onboarding_tours.js
2024-01-31 16:12:56 +05:30
Ankush Menat
a25e68a763
fix: make rate_limiter respect multitenancy ( #24634 )
...
* fix: make rate_limiter respect multitenancy
* fix: lower rate limit window for password reset
* refactor: Use redis_wrapper
2024-01-31 09:16:27 +00:00
Rucha Mahabal
53d6d156ec
chore: cleanup doctype descriptions ( #24609 )
2024-01-31 12:00:39 +05:30
Ankush Menat
b2abc2c9d1
Merge pull request #24624 from ankush/fix_private_file
...
perf: optional faster perm check for files
2024-01-31 11:06:09 +05:30
Ankush Menat
dedadbb0d9
perf: optional faster perm check for files
2024-01-31 10:49:18 +05:30
David Arnold
3abbde3284
fix: shell escaping on external commands
2024-01-30 18:23:05 +01:00
Ankush Menat
40438b400f
ci: set node env as production in tests
2024-01-30 21:55:51 +05:30
Ankush Menat
e1f20f7305
Merge pull request #24621 from ankush/short_circuit_guest
...
fix: short circuit private files perm check
2024-01-30 20:48:42 +05:30
Ankush Menat
d838da51dd
fix: short circuit private files perm check
...
For guest users there's no point in checking permissions, they'll eventually fail... instead just fail immediately.
2024-01-30 20:31:28 +05:30
Akhil Narang
075ce78fbe
Merge pull request #24616 from akhilnarang/fix-import-log-success-rows
...
fix: show successful rows in the import log
2024-01-30 17:26:36 +05:30
Akhil Narang
db1e692d4f
chore: reword checkbox
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-30 17:08:14 +05:30
Akhil Narang
ba64285c66
Revert "fix(data_import): respect the value of show_failed_logs checkbox"
...
This reverts commit 34f03a2de2
2024-01-30 17:07:47 +05:30
Shariq Ansari
dc7637991e
Merge pull request #24582 from shariquerik/if_owner_and_report_perm_fix
...
fix: do not allow to set if_owner & report perm together
2024-01-30 14:28:37 +05:30
Ankush Menat
d53a0ae45e
Revert "fix(module_map): only include apps installed on the site - not everything on the bench" ( #24605 )
2024-01-30 07:39:09 +00:00
Rucha Mahabal
3990da0620
feat: show doctype description in list views ( #24583 )
2024-01-30 09:39:59 +05:30
Raffael Meyer
a378c8bee2
chore: regenerate pot file ( #24600 )
2024-01-30 08:19:32 +05:30
Ankush Menat
2f28a5e224
Merge pull request #23904 from cogk/fix-fieldlevel-access-to-shared-document-list
...
fix(meta)!: Allow level 0 fields if a doc has been shared with user
2024-01-29 20:17:29 +05:30
Ankush Menat
d2d1b14cc6
fix: Always allow meta/standard fields in perm level
...
Perm levels CANNOT applied on these fields so these should ALWAYS be allowed.
2024-01-29 20:00:41 +05:30
Ankush Menat
3bea50d519
fix: Return empty result if no perm level access ( #24591 )
2024-01-29 19:48:19 +05:30
Ankush Menat
797cd696a7
Merge branch 'develop' into fix-fieldlevel-access-to-shared-document-list
2024-01-29 19:39:56 +05:30
Shariq Ansari
1cce6588ee
fix: sentry minor fix ( #24588 )
2024-01-29 18:08:11 +05:30
mergify[bot]
c9f8daf82d
Merge pull request #24511 from akhilnarang/module-map-only-site-apps
...
fix(module_map): only include apps installed on the site - not everything on the bench
2024-01-29 12:18:59 +00:00
Akhil Narang
db72dd37aa
refactor: fallback to all apps on bench when site isn't ready yet
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-29 17:31:52 +05:30
Shariq Ansari
08d5880683
Merge pull request #24584 from shariquerik/revert-quick-list-indicator
...
revert: added back quick list status indicator
2024-01-29 17:31:25 +05:30
Akhil Narang
f967aa9508
feat: print a warning if module names conflict
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-29 17:25:37 +05:30
Akhil Narang
f48ec5b690
refactor(module_map): fetch only installed apps if a site is initialized
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-29 17:25:37 +05:30
Shariq Ansari
0973e20c19
revert: added back quick list status indicator
2024-01-29 17:09:00 +05:30
Ankush Menat
4dce9d0d37
ci: skip UI test for PO files ( #24581 )
2024-01-29 11:17:04 +00:00
Shariq Ansari
d89cec362c
fix: do not allow to set if_owner & report perm together
2024-01-29 16:46:42 +05:30
Ankush Menat
89e89f72d5
chore: New translations main.pot (German) ( #24557 )
2024-01-29 11:16:25 +00:00
Dany Robert
eeac2bb6f0
fix(mobile): scroll issue after workspace change ( #24555 )
2024-01-29 16:27:15 +05:30
Akhil Narang
9b2e0446c5
Merge pull request #24575 from akhilnarang/sort-grid_row-options
...
fix(grid_row): sort options based on selected data first, so as to maintain order
2024-01-29 13:47:04 +05:30
Akhil Narang
b2002e6aed
fix(grid_row): sort options based on selected data first, so as to maintain order
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-29 13:31:09 +05:30
Ankush Menat
555bed36a2
fix: ignore dead columns in user_settings ( #24572 )
2024-01-29 13:14:34 +05:30
