Commit graph

5097 commits

Author SHA1 Message Date
Ankush Menat
b247c3853e test: sort before comparing 2023-05-16 17:57:41 +05:30
Ankush Menat
85377eddfe chore(ux): better labels 2023-05-16 11:04:16 +05:30
Shariq Ansari
70d86032a5
Merge pull request #20997 from shariquerik/form-builder-create-doctype 2023-05-16 11:00:56 +05:30
mergify[bot]
561db7e5cc
fix: unable to access url file from the timeline section (backport #20836) (#21011)
Co-authored-by: Sameer Chauhan <sameer@extensioncrm.com>
Co-authored-by: sameer Chauhan <sameer55chauhan@gmail.com>
2023-05-16 08:15:00 +05:30
Shariq Ansari
0ea65f0a36
Merge branch 'develop' into form-builder-create-doctype 2023-05-15 18:03:44 +05:30
Ankush Menat
6a30344a5f fix: limit RQ job refresh to list view only 2023-05-15 17:04:41 +05:30
Shariq Ansari
e2e0d3a021
Merge branch 'develop' into form-builder-create-doctype 2023-05-15 16:43:11 +05:30
Ankush Menat
8df00dc54b
fix(UX): sort modules on user doctype (#20998)
[skip ci]
2023-05-15 16:42:37 +05:30
Shariq Ansari
fc8a44e78d chore: Use Form Builder banner on fields sections 2023-05-15 15:59:28 +05:30
Ankush Menat
95287c060c test: server script rate limiting 2023-05-15 11:04:23 +05:30
Ankush Menat
8eb9d2ea18 fix: create partial function for server script execution
rate_limiter passes `frappe.form_dict` instead of original arguments.
This is a workaround to first pass server script by making a partial
function and then rate limiting that.
2023-05-15 11:01:50 +05:30
Ankush Menat
48c36f9c49 feat: Rate limiting on server scripts 2023-05-15 11:01:50 +05:30
Ritwik Puri
da5f642d4c
chore: make skipped and traceback fields read_only in patch log & newline after traceback for better readability while skipping failing patches (#20961) 2023-05-10 19:36:58 +05:30
Shadrak Gurupnor
d9b2d23ec3
feat: track skipped patch with traceback (#20931)
* feat: track skipped patch with traceback

* fix: dump all the patches in patch log

* fix: check non-skipped patches

* fix: print traceback if failed && reload patch_log before migrate

* chore: dont force patch log reload

* chore: remove unnecessary checks

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-05-10 18:44:40 +05:30
Smit Vora
9f35d0e894
fix: don't use default filters for auto-email report (#20876) 2023-05-10 13:12:05 +05:30
Ankush Menat
ef6f4b5956
refactor!: Use job_id for bg job deduplication (#20951) 2023-05-10 12:45:05 +05:30
Ankush Menat
f842c85419 chore: log skipped scheduling events
Rare but Useful for debugging
2023-05-10 10:58:07 +05:30
Ankush Menat
ecce4ba5a7 test: deduplication with unique job id 2023-05-09 14:23:07 +05:30
Ankush Menat
bc3871b657 refactor: standardize assigning job_id 2023-05-09 14:23:04 +05:30
Ankush Menat
4bd02a4ed1 perf: Faster scheduled job deduplication
O(n) to O(1) dedup by specifying unique IDs on scheduled RQ jobs.
2023-05-08 18:28:09 +05:30
Rohan
01a0a0fc0a
fix: ignore virtual doctypes during data export (#20891) 2023-05-04 17:43:22 +05:30
Ankush Menat
93c326b971 feat: let user opt out of telemetry from setup 2023-04-25 14:46:53 +05:30
Ankush Menat
0d1c7fee42 feat: let users disable telemetry from system settings 2023-04-25 10:33:28 +05:30
Ritwik Puri
e6279e08f2
Merge pull request #20823 from phot0n/dnr-update-counter
refactor(minor): remove update counter dialog and make counter editable by default
2023-04-25 01:06:17 +05:30
phot0n
71f45eba68 fix: add confirmation when updating counter and make document type mandatory 2023-04-25 01:02:12 +05:30
phot0n
7ae60ff268 refactor(minor): remove update counter dialog and make counter editable by default 2023-04-24 13:06:51 +05:30
Raffael Meyer
6b57a2d352
fix: endless reload in User when timezone is unset (#20815) 2023-04-24 10:26:43 +05:30
Ankush Menat
4ca74abea5
fix(UX): enable login with link by default (#20772) 2023-04-19 16:14:39 +05:30
Suraj Shetty
52b57d1f84
Merge pull request #20727 from harshtandiya/fix-owner 2023-04-17 12:53:10 +05:30
Mohammad Hussain Nagaria
65903a5d6d
Merge branch 'develop' into fix-owner 2023-04-17 11:47:48 +05:30
Harsh Tandiya
78829441dd fix: make owner restricted
Co-authored-by: Mohammad Hussain Nagaria <NagariaHussain@users.noreply.github.com>
2023-04-17 11:39:25 +05:30
Suraj Shetty
eced6a3dc1 fix(export): Use fieldname if label is not set 2023-04-17 10:09:20 +05:30
Raffael Meyer
652202132d
fix: remove guest permission from language (#20677)
* fix: remove guest permission from language

* fix: allow "All" to select a Language

* fix: allow "All" to read a Language
2023-04-13 18:07:28 +05:30
Anand Baburajan
b62bb8b0ec
fix: allow filter values to be saved in custom report (#20623) 2023-04-13 17:42:21 +05:30
Ankush Menat
cbb7c4a91c test: fix imghdr test 2023-04-13 12:47:37 +05:30
Ankush Menat
0cab0b830d
refactor: replace imghdr with filetype (#20680)
* refactor: replace `imaghdr` with `filetype`

```
11:52:06 worker.1      | /home/ankush/benches/develop/apps/frappe/frappe/core/doctype/file/utils.py:2: DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13
```

* feat: improved extension guessing using filecontent
2023-04-13 12:19:08 +05:30
Ankush Menat
d7b474f4ac
Merge pull request #20648 from ankush/translations_hooks_order
fix(translations)!: load translation in installed app order
2023-04-11 18:29:01 +05:30
Ritwik Puri
82ec29702e
fix: consider user email if send me a copy is checked (#20627)
* fix: consider user email if send me a copy is checked

* test(communication): test cc with include sender
2023-04-11 16:24:47 +05:30
Ankush Menat
0b8b829483 perf: dont cache intermediate translation files
Just caching final files for each language is enough, duplicating
doesn't help much.
2023-04-11 12:10:49 +05:30
Ankush Menat
361e44de1d fix(translations)!: load translation in installed order
- translations are loaded in apps.txt order this doesnt make much sense.
- translations are loaded from apps which aren't even installed, again
  doesn't make sense.

Breaking but necessary change.
2023-04-11 12:10:45 +05:30
Raffael Meyer
e5b1b8d681
fix: improved validation in add_comment (#20520) 2023-04-09 16:40:51 +05:30
Shariq Ansari
3e695a05e6
Merge branch 'develop' into cancel-doc-with-workflow-fix 2023-04-03 16:01:38 +05:30
Daizy Modi
d2bde19b5c
fix: removed unnecessary usage of @frappe.whitelist (#20503) 2023-04-03 15:03:37 +05:30
Daizy Modi
06580bdbff
fix: allow reset_otp_secret only if Two Factor Auth is enabled (#20506)
* fix: display `Reset OTP Secret` button only if Two factor Auth is enabled

* fix: added validations and fetched value from cached doc

* fix: linter changes
2023-04-03 15:02:05 +05:30
Shariq Ansari
a3458798f1
Merge branch 'develop' into cancel-doc-with-workflow-fix 2023-04-02 15:34:36 +05:30
Shariq Ansari
ee9cb43835 fix: get workflow_state_fieldname instead of setting workflow_state to none 2023-04-02 15:33:43 +05:30
Raffael Meyer
ae3b3ebb17
chore: remove excessive whitespace (#20544)
to make the linter happy

[skip ci]
2023-04-01 22:22:03 +05:30
Suraj Shetty
f46d16713f
Merge pull request #20115 from pstuhlmueller/email_sent_as_cc_to_todo_allocated_users 2023-03-31 13:49:04 +05:30
Suraj Shetty
aab37e0a6c
fix: Check if reference_name is set 2023-03-31 13:31:18 +05:30
Himanshu Shivhare
2cb492561a
fix(ux): correct email account setup path in error message (#20513) 2023-03-30 17:57:00 +05:30