Commit graph

5097 commits

Author SHA1 Message Date
Ankush Menat
513a209d53 test: fix test case to modified behaviour
We throw instead of showing warning now
2023-03-29 09:25:20 +05:30
Marica
90f8f945b4
feat: Disable Sharing globally (#20318)
* feat: Disable Sharing globally

- Checkbox in System Settings
- If disabled, avoid share UI render
- Share APIs return None (non-obstructing) if share APIs are invoked

* feat: Settings checkbox must toggle share permission globally

- Treat feature like a perm toggler. Essentially noone is allowed to explicity share anything
- Implicit sharing via `ignore_share_permissions` is allowed. Devs can decide where sharing should happen under the hood
- UI is made read only and not hidden. Users must see who doc is already shared with
- Make sure perm APIs used by share feature return false if sharing is disabled
- Rename checkbox to `Disable Document Sharing`

* test: (server side) Impact of disabling sharing on APIs

- Also, fix missed system setting rename in `assign_to`

* fix: Inform assigner if assignee lacks perms and sharing is disabled

- misc: readable conditions

* fix: throw instead of msgprint

* fix: Typo and appropriate message for `throw`

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-03-28 18:13:37 +05:30
Shariq Ansari
5cc6daa713
Merge branch 'develop' into cancel-doc-with-workflow-fix 2023-03-25 13:21:22 +05:30
Shariq Ansari
d2f529462b fix: cannot restore cancelled document if workflow is active 2023-03-25 13:07:05 +05:30
gavin
86f7219525
fix: Auto-Reload after changing time zone (#20456) 2023-03-24 21:02:30 +05:30
Ankush Menat
5a91ac945c fix: doctype form - hide irrelevant fields 2023-03-23 16:16:14 +05:30
Ankush Menat
7ac6199213
feat: re-enable scheduler from desk (#20434)
[skip ci]
2023-03-23 11:54:24 +05:30
Ankush Menat
cad9228b6b feat: clear integration log request logs (#20373)
* fix: integration request should be cleared

THese are basically logs of requests and shouldn't stay forever.

* fix(UX): show retention policy message on sidebar

These doctypes were added to log settings later.
2023-03-17 14:38:26 +05:30
Suraj Shetty
0743225cd2
fix(patch): move desk prop patch to post model sync (#20361)
* fix(patch): Reload user_email to avoid failure

* fix: move patch to post sync

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>

[Skip ci]
2023-03-16 16:38:52 +05:30
Ankush Menat
fdcdb61a2d
fix: email linking and message_id indexing (#20356)
* fix: find communication regardless of system reply

* perf: convert and index message_id
2023-03-16 14:01:25 +05:30
Ankush Menat
6b79a97566 fix(UX): clear comment to avoid duplicates 2023-03-16 11:03:45 +05:30
Suraj Shetty
8dde2cd43c fix: Clear dasboard comment to avoid duplicate
- on save
2023-03-16 09:45:43 +05:30
Ankush Menat
9430b6a8c2
fix: Permission error while processing role based notifications (#20315) 2023-03-14 17:27:30 +05:30
Ankush Menat
da086a4410
feat: allow configuring ttl for RQ job retention (#20331)
Some might want to keep them around for long, others might wanna get rid
of it to free up memory. Hardcoded defaults dont work for everyone hence
make it configurable.

`no-docs`


[skip ci]
2023-03-14 12:43:41 +05:30
Ankush Menat
709edf1f55 fix: Make corrected bankers rounding default method 2023-03-13 13:10:51 +05:30
Ankush Menat
139d4a87b4 fix: corrected banker's rounding
closes https://github.com/frappe/frappe/issues/19570
2023-03-13 12:30:48 +05:30
Ankush Menat
97ca92e3d1
refactor: change rounding method names (#20299)
These are easy to understand.

Added third method for corrected banker's rounding.
2023-03-10 14:57:15 +05:30
Ankush Menat
92120ea539
fix(UX): dont let users select child table in ref_doctype (#20278)
Child doctypes have no concept of permission so when ref_doctype is
child doctype it will always fail. You should pick ref_doctype that's
typical parent used for perm checks.
2023-03-08 15:06:13 +05:30
Ankush Menat
e4a11fd8cf fix(UX): Warn about changing rounding method 2023-03-08 12:24:50 +05:30
Ankush Menat
86b9ff4266 feat: Allow specifying rounding method in flt 2023-03-08 10:59:02 +05:30
Ankush Menat
48f63f53ab feat: configurable rounding methods 2023-03-08 10:44:44 +05:30
Suraj Shetty
1b1dcd200c
Merge pull request #20264 from surajshetty3416/fix-doc-timestamp-conflict 2023-03-07 12:38:46 +05:30
Suraj Shetty
ce27d7865f fix: Remove unnecessary code to avoid timestamp conflict 2023-03-07 10:48:23 +05:30
barredterra
b2e36634d6 refactor: rename get_time_zone to get_system_timezone 2023-03-04 19:30:03 +01:00
barredterra
3694e654a1 refactor: rename convert_utc_to_user_timezone to convert_utc_to_system_timezone 2023-03-04 19:02:25 +01:00
Ankush Menat
8a4c348808 fix: set owner and modified_by for rq job 2023-03-01 17:45:22 +05:30
Suraj Shetty
7abdad3282 Merge branch 'develop' of https://github.com/frappe/frappe into newsletter-analytics 2023-02-28 14:31:03 +05:30
mergify[bot]
133b3bce7d
fix: Cancel All and Dashboard views title translations (#20173) (#20175)
(cherry picked from commit 7253a10d07e7ad27f8b473af7e10fecd88080409)

Co-authored-by: gsi-joel <126265080+gsi-joel@users.noreply.github.com>
2023-02-28 11:41:13 +05:30
Ankush Menat
e7f604ef48 refactor: rename DocReminder -> Reminder 2023-02-24 13:47:58 +05:30
Ankush Menat
73cd823a0a feat: Document Reminders
There is `Notification` doctype but it doesn't work so well for small
one-off reminders. Imagine these scenarios:

1. Remind me to follow up on this lead in 5 days.
2. Remind me to revoke temporary access I am giving to this user.

For such scenarios, I am proposing a simple reminder system built into
framework. All it does is:

1. For any document you can set a reminder with time and message.
2. When time comes you'll get a system notification with message and
   link to the document.

Permissions:
1. Users can only see their own set reminders.
2023-02-24 12:40:54 +05:30
Ankush Menat
0925453adb chore: format doctype controller boilerplate 2023-02-24 11:39:27 +05:30
Ankush Menat
23bfd5d1b6 fix: doctype editing message 2023-02-24 11:39:27 +05:30
Ankush Menat
22f5a60ebb feat: make webhook requests log clearable 2023-02-23 15:56:13 +05:30
Suraj Shetty
b397ec3858 feat: Track count of views on newsletter emails 2023-02-23 13:45:53 +05:30
Patrick.St
841557338b
fix: sending mails to unintended recipients as cc
Security vulnerability: Unintentionally, all incoming emails are sent as CC to all users in a ToDo as "allocated_to" with the status "Open"
2023-02-21 16:24:02 +01:00
Patrick.St
2a80bb01ac
fix: Incorrect use of the Walrus operator
Incorrect use of the Walrus operator leads to unintended behavior for if-condition: "None" will be appended to cc.
2023-02-21 16:13:07 +01:00
Ankush Menat
8446875257
refactor!: Remove "Set user permission" permtype (#20090)
This has never worked and setting user permission requires system
manager role always (because of permissions on list view)
2023-02-20 16:07:49 +05:30
Ankush Menat
68df7d621f docs: document_naming_settings field label
[skip ci]
2023-02-20 13:13:56 +05:30
Ankush Menat
b55bbd0a8c
fix(UX): Sort case-insensitive where it makes sense (#20088) 2023-02-20 13:07:32 +05:30
Rucha Mahabal
c94d3ccc16
fix: Hide perm level fields for Section, Column and Tab Breaks (#20084) 2023-02-20 12:51:24 +05:30
Ankush Menat
99513db062
feat: fetch from with fields in Customize form (#20046)
extends https://github.com/frappe/frappe/pull/13760/
2023-02-15 13:08:35 +05:30
Samuel Danieli
0bd74bfa5c
chore: do not copy data import status (#20034)
status is used by other fields and may corrupt view if copied
2023-02-14 22:43:31 +05:30
Ankush Menat
1cc51e6bb0
fix: Wait for user creation before creating contact (#20022)
closes https://github.com/frappe/frappe/issues/19995
2023-02-14 12:24:31 +05:30
Ankush Menat
790b09f95f feat: Allow clearing access logs 2023-02-03 22:25:27 +05:30
Ankush Menat
ccaf4c1e7e
Merge pull request #19854 from gavindsouza/get_all-virtual-dts
fix: Interface DatabaseQuery to virtual doctypes' get_list
2023-02-03 17:30:57 +05:30
Ritwik Puri
47edc63170
fix: support for different delimiter for timeline email linking (#19751) 2023-02-03 11:47:38 +05:30
Gavin D'souza
3cd781e316 Merge branch 'develop' into get_all-virtual-dts 2023-02-02 13:55:24 +05:30
Gavin D'souza
d50f6fa7b4 test: cleanup test_create_virtual_doctype 2023-02-02 13:42:29 +05:30
Ankush Menat
1b016d34bd
fix: misc migration related fixes (#19874)
* fix: ignore certain validations during migrate

These are recoverable after migration is completed, better to let update
go through first.

* fix: Let people set arbitrary Data field options

It will be treated as vanilla Data field by default but other apps can
chose to modify behaviour based on it.

AFAIK there is no real side effects of this.
2023-02-01 16:02:59 +05:30
Ankush Menat
338ccc5a2a
fix: sanitize form dict in error logs (#19835)
[skip ci]
2023-01-30 15:22:21 +05:30