Commit graph

2246 commits

Author SHA1 Message Date
Ankush Menat
1bd61d5c25 fix: dont db_set on unsaved document 2022-10-18 17:38:03 +05:30
phot0n
3cae3d057c refactor(minor): made unlock_doc_and_update_status into a simple function
* renamed unlock_doc_and_update_status -> unlock_reference_doc
* added queued_doc property
* renamed check_locked_document -> check_if_locked
* reduced the statuses in submission queue
* refactored unlock_reference_doc a bit
2022-10-13 14:07:11 +05:30
Aradhya
fdf1ed9656 Merge branch 'develop' of https://github.com/frappe/frappe into bg-submissions 2022-10-12 19:34:00 +05:30
Aradhya
01ff3d8bcc fix: fixed locking and checking 2022-10-11 21:20:08 +05:30
Anand Baburajan
feb198a019
docs: fix make_autoname example (#18354) 2022-10-10 21:04:35 +05:30
Aradhya
b733c82a77 feat: Added identifier for locked state of documents
refactor(minor): removed is locked setter to avoid redundancy
2022-10-09 21:26:21 +05:30
Aradhya
0c00c34ad6 fix: temporary document locking 2022-10-09 18:44:28 +05:30
Aradhya
d8ff47aac2 fix: checking and unlocking the correct doc 2022-10-08 04:50:09 +05:30
Aradhya
9074e3e13d feat: Added unlocked button for locked documents not in queue 2022-10-08 01:38:03 +05:30
Ankush Menat
64a0e19329 Revert "fix!: Dont update modified by default in db.set_value (#18301)"
This reverts commit 6aaefd6633.
2022-10-06 22:02:31 +05:30
Ankush Menat
6aaefd6633
fix!: Dont update modified by default in db.set_value (#18301) 2022-10-06 16:01:20 +05:30
Aradhya
b15e07dd79 refactor: better locking and unlocking 2022-10-05 15:58:49 +05:30
Ankush Menat
bd21398252
fix: ignore perm level validation if row deleted (#18290) 2022-10-05 11:16:28 +05:30
Aradhya
198bc39085 refactor: moved submission from document class 2022-10-04 17:20:14 +05:30
Ankush Menat
b8ed8d624c fix: ignore child tables when init-ing parent doc 2022-10-04 14:27:25 +05:30
Aradhya
9cc826541f fix: fixed functionality 2022-10-04 02:41:14 +05:30
Aradhya
eae73ae5d4 feat: log reports for queued submits 2022-10-03 17:36:33 +05:30
Shariq Ansari
fc1e01555b fix: added missing operators 2022-09-30 17:16:40 +05:30
Ritwik Puri
66a31917f7
refactor(minor): reorder and remove unnecessary branches in set_new_name (#18243) 2022-09-29 16:23:55 +05:30
Ankush Menat
0e0e7f276c
fix: dont assume issingle exists (#18236) 2022-09-29 10:45:37 +05:30
Aradhya Tripathi
c15da987eb
Merge branch 'develop' into qb-fixes 2022-09-21 02:24:23 +05:30
Aradhya
38f1a9708a refactor: simplified logic 2022-09-20 01:45:20 +05:30
Ankush Menat
2b6fc68088
Revert "fix: drop Meta cache during update" (#18186)
* Revert "fix: drop Meta cache during update (#18182)"

This reverts commit 656f6df257.

* fix: replace meta cache keys

Old keys stored different types of data `dict` changing key to indicate
change in type.
2022-09-19 21:28:45 +05:30
Ankush Menat
656f6df257
fix: drop Meta cache during update (#18182) 2022-09-19 19:24:17 +05:30
Sagar Vora
b529c27cb5 fix: ensure error is thrown 2022-09-19 16:21:11 +05:30
Sagar Vora
6c6a969d3a perf: simpler, faster meta cache 2022-09-19 16:21:11 +05:30
Sagar Vora
df8399f5d3 perf: initialise field map when initialising meta 2022-09-19 16:21:11 +05:30
Sagar Vora
fc3ee12baf
perf: cache FormMeta directly (#18165)
* perf: cache `FormMeta` directly

* perf: check if `dt` is table, use `db.get_value` instead of `get_all`
2022-09-19 16:10:32 +05:30
Saqib Ansari
6997f9e90f
fix: do not rename fieldtype options (#18143) 2022-09-15 17:30:52 +05:30
Shariq Ansari
235171796d
fix: coalesce not in queries (#18099)
* fix: get workspaces with empty module fields

* Revert "fix: get workspaces with empty module fields"

This reverts commit 1f194be2c3642e31ebe2165e461b2f24be8cda4c.

* fix: always coalesce `not in` queries

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-13 12:08:07 +05:30
Ankush Menat
49af8f7db1
Merge pull request #18050 from ankush/read_only_maintenance
feat: Zero* downtime migrations
2022-09-09 18:17:57 +05:30
Ankush Menat
e1253e8299 fix: remove ad-hoc maintenance mode implementation 2022-09-09 17:34:46 +05:30
Ankush Menat
55617b9e86 fix: defer logging during read only mode
Deferred:
- Error log
- view log
- web page view

Disable:
- "_seen" tracking used on list view to highlight unseen docs.
- "seen" on error log.
- dashboard chart last ts caching
2022-09-09 17:34:46 +05:30
Aradhya
ae18f74311 feat: Added nested set support 2022-09-03 19:15:35 +05:30
Aradhya
ec100d7a8a fix: misc fixes 2022-08-30 16:36:00 +05:30
phot0n
bca63f8e46 chore: remove unused update_log_for_doc_creation flag
* chore: add note/warning for log_types
2022-08-26 18:51:18 +05:30
Aradhya Tripathi
80e64c7143
Merge branch 'develop' into get-all-mod 2022-08-24 19:46:46 +05:30
Ankush Menat
cdb0732646
perf: avoid coalescing wherever possible (#17920) 2022-08-24 10:30:51 +05:30
Sagar Vora
63e760e3ad chore: remove old code where User Permissions were set in tabDefaultValue 2022-08-22 19:03:30 +05:30
Aradhya Tripathi
caf171b363
Merge branch 'develop' into get-all-mod 2022-08-22 14:53:35 +05:30
Ankush Menat
7b3cc322f1
Merge pull request #17891 from ankush/misc_fixes
perf: ~45% faster Desk first response
2022-08-22 11:45:20 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Ankush Menat
61a9349789 perf: use is_virtual_doctype and remove limit
This reduces 1 query for each child table read

Removed limit cause with 1000+ doctypes in frappe+erpnext this cache
will just keep getting trashed for no reason. There's clear upper bound
on size so no need to limit it here.
2022-08-21 17:37:40 +05:30
Aradhya
66ac93e14d Merge branch 'get-all-mod' of github.com:Aradhya-Tripathi/frappe into get-all-mod 2022-08-19 15:57:13 +05:30
Aradhya
e400df90ff refactor: removed iterable from iteration ;/ 2022-08-19 15:56:34 +05:30
Faris Ansari
82fef72ce1
fix(db-query): parenttype condition on child table left join (#17865)
joining only on name is incorrect because parent primary keys are not unique across tables

How was this working all this time? 🥲
2022-08-18 09:04:40 +00:00
Faris Ansari
d11692c52f fix: has_content check for fieldtype TextEditor
When a TextEditor field contains only an image, while checking for
content, HTML tags are stripped off including the only image.
This change adds a loose but explicit check for img tag.
2022-08-17 14:40:40 +05:30
Sagar Vora
c82b6e758e
Merge pull request #17681 from resilient-tech/fix-child-perm
refactor: improved child table permission check
2022-08-09 10:15:36 +00:00
Sagar Vora
7129d6128f chore: lazier import; improved docstrings 2022-08-09 11:50:15 +05:30
gavin
2735d1c558
Merge branch 'develop' into refactor-oauth-tests 2022-08-05 15:37:41 +05:30