Commit graph

1671 commits

Author SHA1 Message Date
marination
1e4d28cc19 fix(test): Remove try-finally & ignore perms on test user's report insertion 2023-01-30 11:08:14 +05:30
Ankush Menat
70ee9272b1
fix: sanitize traceback for common secrets (#19805) 2023-01-27 12:44:33 +05:30
barredterra
4bcb12617c fix: assertAlmostEqual with precision 2023-01-26 11:39:41 +01:00
Gavin D'souza
6b0e4695a8 Merge branch 'develop' into permlevel-apis 2023-01-25 12:08:47 +05:30
Ankush Menat
c24cd12a27
Merge pull request #19755 from gavindsouza/maxsplit-as-needed
refactor: Add a maxsplit limit to string splits
2023-01-25 11:10:48 +05:30
barredterra
a33e34519a feat: add test case for long passwords 2023-01-24 15:04:47 +01:00
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
gavin
6f04951801
Merge branch 'develop' into report-sidebar-respect-perm-query 2023-01-24 11:57:08 +05:30
Ankush Menat
87561940a4
feat: Interactively add a new patch (#19722) 2023-01-23 15:04:43 +05:30
Gavin D'souza
9efe84a644 fix(reportview): Remove aggregate_on_field added in fields
Essentially reverts changes added via
https://github.com/frappe/frappe/pull/14424 but works just the same
without the additional column :thonk:

The added column's data in mariadb was essentially garbage data. Wasn't
meaningful from what I could tell - couldn't play well with postgres
either
2023-01-20 19:26:56 +05:30
gavin
4be74bc013
Merge branch 'develop' into permlevel-apis 2023-01-19 11:00:15 +05:30
Ankush Menat
fa55793a52
Merge pull request #19405 from netchampfaris/refactor-qb-engine
refactor: qb.engine
2023-01-18 21:17:17 +05:30
barredterra
2e816ed68c fix: test_client_insert_many 2023-01-18 13:49:57 +01:00
barredterra
ce545c807d fix: test frappe client 2023-01-18 13:24:13 +01:00
barredterra
913417e1dc fix: naming test cases
... that used to rely on title based naming of Note
2023-01-17 23:51:58 +01:00
barredterra
da925ce681 fix: test cases for frappe client 2023-01-17 21:00:05 +01:00
barredterra
8893788365 fix: undo temp constant in test 2023-01-17 20:14:50 +01:00
barredterra
df2b1ff456 Merge remote-tracking branch 'upstream/develop' into fix-note-2 2023-01-17 19:19:12 +01:00
Ankush Menat
e31db5d502
fix: handle tel: links in emails (#19635) 2023-01-17 20:31:06 +05:30
Ankush Menat
433115f62d
test: rollback test transaction after executing cmd (#19606)
In command tests if connection is active then due to repeatable read
isolation you will continue to read old data which might be modified by
the command you're trying to test.

It makes sense to end transaction after each command execution here.

[skip ci]
2023-01-16 18:43:52 +05:30
marination
968648e1b6 test: Test if permission query via server script is applied on cached allowed reports 2023-01-16 18:38:26 +05:30
Ankush Menat
c7edd7e57c chore: remove unnecessary assertion 2023-01-16 18:02:40 +05:30
Ankush Menat
8adfdcbc1d tests: clear DB transactions before all db calls
Because of repeatable read isolation,
changes from externally executed command dont reflect until transaction is ended.
2023-01-16 17:32:29 +05:30
Faris Ansari
543458b473 fix: handle empty list as filters 2023-01-16 15:38:15 +05:30
Gavin D'souza
f0a282e941 test: Add test for linked table permission check 2023-01-16 14:28:13 +05:30
Faris Ansari
5bc5ff100b test: tests for various filter options 2023-01-16 14:12:04 +05:30
Gavin D'souza
7e38d7fe63 test: Make test_child_table_join more resilient 2023-01-16 13:56:37 +05:30
Ankush Menat
5e2bbf834f refactor: filter out apps not installed on bench 2023-01-16 13:54:40 +05:30
Gavin D'souza
9012b95a9a fix(postgres): group_by in reportview, tests
Add approporiate group_by, order_by clauses in reportview and tests for
featureset compatibility with postgres
2023-01-11 12:42:45 +05:30
gavin
2b27652bd4
Merge branch 'develop' into permlevel-apis 2023-01-10 17:45:46 +05:30
Gavin D'souza
d2ad86d2fe test: Add tests for permlevel handing in get_list 2023-01-10 17:44:06 +05:30
Ankush Menat
1eaca4e1d5
fix: RSS feed escaping (#19546)
if title contains reserved chars then malformed XML is generated.

Try title with ampersand in it.

[skip ci]
2023-01-10 11:45:31 +05:30
Faris Ansari
60febc9799 fix: list filter
filters as list must always be list of list
2023-01-09 19:44:11 +05:30
Gavin D'souza
6aea25a6c1 test: Update tests to handle missing attributes based on permlevel 2023-01-09 18:48:48 +05:30
Faris Ansari
be654eaa60
Merge branch 'develop' into refactor-qb-engine 2023-01-09 15:23:20 +05:30
Ankush Menat
075a2d778e feat: UnixTimestamp QB function 2023-01-09 12:05:52 +05:30
Marica
53563b9283
Merge branch 'develop' into kanban-access-w-perms 2023-01-03 12:37:41 +05:30
Ankush Menat
7772257ccd
Merge branch 'develop' into fix-note-2 2023-01-02 11:28:11 +05:30
Faris Ansari
b7c0ba1bea fix: allow dynamic fields in filters
e.g.,
`filters={'link.field': 'value'}`
`filters={'child.field': 'value'}`
2022-12-31 22:55:00 +05:30
Faris Ansari
7ca39a81bf fix: explicitly specifiy order 2022-12-31 22:18:07 +05:30
Ankush Menat
a43a0149eb refactor: improve test, rate limiting 2022-12-30 13:42:42 +05:30
marination
49143922c5 chore: Kanban and ToDo UI test helpers
- `create_admin_kanban` and `create_todo` UI test helpers
- `switch_to_user` Cypress command: logs out and logs in as specified user
- Used `remove_role` in permissions test
- Used `switch_to_user` command in test helper
2022-12-28 23:00:00 +05:30
Faris Ansari
726fcfdb79 refactor: qb.engine
- simplify
- qb.engine.get_query -> qb.get_query
- qb.engine.build_conditions -> qb.get_query
2022-12-25 23:19:11 +05:30
Shariq Ansari
289aa9a13b test: test valid & invalid key 2022-12-21 14:43:10 +05:30
barredterra
d0f75363a5 refactor: make test for assignment independent of Note 2022-12-20 16:30:11 +01:00
barredterra
3afdb39372 fix: test update with content instead of title 2022-12-20 15:30:15 +01:00
Ankush Menat
db35431b8c fix(postgres): psql with remote databases
If you dont use unix socket psql command doesn't work.
2022-12-20 15:14:38 +05:30
Daizy Modi
d88ef967b9
feat: hook ignore_links_on_delete to skip doctypes on delete (#19347)
* feat: hook `ignore_links_on_delete` to skip doctypes on delete

* fix: helper comment

* fix: helper comment

* test: test case for `ignore_links_on_delete`

* test: fix test case
2022-12-20 11:17:28 +05:30
gavin
2c498910ba
Merge branch 'develop' into runtime-type-checks-api 2022-12-19 15:12:06 +05:30
Gavin D'souza
b8da76d483 test(typing-utils): Specify exc type
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-12-19 15:10:56 +05:30