Ankush Menat
ecdb893286
fix: copy to clipboard strips off newlines
...
input element isn't suitable for this hack, switch to textarea for
supporting newlines in text to be copied.
2021-12-09 09:59:33 +05:30
Ankush Menat
5b6012d0d3
feat: copy error to clipboard
...
Currently error can be reported if email is setup but other than that
only way to find error info is use browser's console.
This change adds a secondary button to copy error info to clipboard.
2021-12-09 09:59:33 +05:30
Ankush Menat
f589342c70
fix: missing content in communication composer
...
`message` is used as args in some places and `txt` in another.
Supporting both since there's no clear interface to this arguments for
this component.
2021-12-09 09:59:33 +05:30
Ankush Menat
3baa09401e
ci: update apt cache before install ( #15226 )
2021-12-09 09:59:19 +05:30
Kevin Backhouse
2f99306d63
Fix ReDoS bug: GHSL-2021-122 ( #15201 )
2021-12-08 04:57:07 +00:00
Faris Ansari
19fb8cd409
Merge pull request #15182 from netchampfaris/cleanup-newsletter
...
fix: Newsletter Enhancements
2021-12-07 18:38:09 +05:30
Faris Ansari
4bb79161be
style: missing semicolon
2021-12-07 17:57:18 +05:30
Faris Ansari
d760e25b63
tests: fix newsletter tests
2021-12-07 17:43:57 +05:30
Faris Ansari
ccc65defb6
fix(newsletter): better open in web link
2021-12-07 17:20:58 +05:30
Faris Ansari
947727ccd7
fix(markdown-editor): preview btn
2021-12-07 17:20:42 +05:30
mergify[bot]
c9426024ca
Merge pull request #15198 from Aradhya-Tripathi/at/fixes
...
fix(qb): Miscellaneous fixes
2021-12-07 10:31:33 +00:00
Faris Ansari
606a0d3809
fix: various fixes
...
- show published newsletters in list view
- show published newsletter as web page
- show status section after newsletter is sent
- add email_sent_at and total_recipients field
2021-12-07 15:52:25 +05:30
Faris Ansari
de7d0337a6
fix: various newsletter form ux fixes
...
- Cancel Scheduling button
- Show dashboard message if newsletter is scheduled
2021-12-07 15:48:35 +05:30
Faris Ansari
1bb3c2d3f4
fix: add on_hide event in form
...
can be used to clearing events, for e.g., clearing setInterval
2021-12-07 15:41:38 +05:30
Faris Ansari
330677bb0a
fix: better sending status
...
- show email sending progress in form dashboard
2021-12-07 15:40:55 +05:30
mergify[bot]
44aaeccef0
Merge pull request #15188 from alyf-de/refactor-module-profile
...
refactor: module profile
2021-12-07 04:12:04 +00:00
barredterra
0e42c55b70
Merge remote-tracking branch 'upstream/develop' into refactor-module-profile
2021-12-06 17:14:50 +01:00
Faris Ansari
9bdb5f2eb2
fix: Explicit attachments table
...
The newsletter content may contain images that get "attached" to the
newsletter document. If this is the case, you can't selectively include
attachments in the newsletter as it attaches all the attachments.
An explicit attachments table solves this problem.
2021-12-06 17:04:24 +05:30
mergify[bot]
bb1d3efc10
Merge pull request #15199 from ruchamahabal/fix-fetch-from
...
fix: Allow Fetch From for a different link field of the same DocType
2021-12-06 10:51:00 +00:00
Faris Ansari
0d3bac5528
fix(ux): Show broken links as dashboard message
2021-12-06 15:38:59 +05:30
Faris Ansari
02759631b4
fix: handle falsy return values in document methods
...
problem: if a whitelisted document method returns a falsy value like
`[]`, `{}`, `0` then response.message is not set and not returned
in the response.
this change checks if the return value is `None` and falsy values
are returned properly in the response
2021-12-06 15:38:59 +05:30
Faris Ansari
742d5e2e06
fix: utility method to create a range of values
...
mimics python's range function
2021-12-06 15:38:58 +05:30
Faris Ansari
f6379fdf40
fix: allow options in datepicker via df.options
...
ability to customize datepicker options via df.options
2021-12-06 15:38:58 +05:30
Faris Ansari
da4160e2dd
fix: Newsletter enhancements and fixes
...
- Organize fields into sections
- Buttons for Send now and Scheduled sending
- Buttons to Send test email and to Check broken links
- Remove Test section
2021-12-06 15:38:58 +05:30
Rucha Mahabal
8340639afd
fix: Allow Fetch From for a different link field of the same DocType
2021-12-06 14:51:37 +05:30
Aradhya
3243fb2083
fix: misc fixes
2021-12-06 13:04:27 +05:30
this-gavagai
8ead1d9c48
fix: Clarified docstatus transition exceptions ( #15194 )
...
* [fix] Clarified docstatus transition exceptions
Exceptions issued by the document.py `check_docstatus_transition` method are potentially very misleading. In cases where an invalid docstatus is used, users receive an confusing exception stating "Cannot change docstatus from 0 to 2" or "Cannot change docstatus from 1 to 0".
This PR adds an additional exception message when an invalid docstatus is used.
* fix: Clarified docstatus transition exceptions
Added additional clarifications to exception messages
2021-12-06 07:28:43 +00:00
barredterra
504f8743c9
fix: remove debugger
2021-12-03 17:24:57 +01:00
barredterra
850cd54b89
refactor: module profile
2021-12-03 17:07:16 +01:00
mergify[bot]
fec76ba950
Merge pull request #15174 from ruchamahabal/event-last-update
...
fix: Delete Event Producer Last Update on trash event of Event Producer
2021-12-03 14:53:51 +00:00
Suraj Shetty
404856bc61
Merge branch 'develop' into event-last-update
2021-12-03 20:09:03 +05:30
mergify[bot]
23e5505923
Merge pull request #15170 from Aradhya-Tripathi/at/fixes
...
fix: fixed list of Field objects as fields in get_values
2021-12-03 14:36:36 +00:00
Raffael Meyer
c5df17e356
fix: cannot uninstall app with virtual doctype ( #15136 )
...
* Update installer.py
* fix: Drop table only if it exists
* revert: "Update installer.py"
This reverts commit 0e8370ede8a9c2b1c0687e5c216ecf67566da0f5.
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2021-12-03 14:34:41 +00:00
mergify[bot]
5172e9e5d2
Merge pull request #15179 from nextchamp-saqib/fix-sql-mask-error
...
fix: IndexError while handling sql timeout error
2021-12-03 13:27:19 +00:00
Suraj Shetty
522227a740
Merge branch 'develop' into fix-sql-mask-error
2021-12-03 18:08:52 +05:30
Summayya Hashmani
db951d2369
frefactor: padd separate padding ( #15178 )
...
Co-authored-by: Summayya <frappe@Summayyas-MacBook-Air.local>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-12-03 11:52:07 +00:00
Saqib Ansari
6f7d030e82
fix: IndexError while handling sql timeout error
2021-12-03 16:06:23 +05:30
Aradhya
e862ae83da
fix: fixed list of Field objects as fields in get_values
...
tests: added test for list of field objects
2021-12-03 14:24:19 +05:30
mergify[bot]
75cebace8c
Merge pull request #15157 from pateljannat/onboarding-step-enhancement
...
fix: form tour field in onboarding step
2021-12-03 08:52:41 +00:00
mergify[bot]
c6187150d3
Merge pull request #15165 from netchampfaris/newsletter-markdown
...
fix(newsletter): use md_to_html instead of markdown
2021-12-03 08:47:51 +00:00
mergify[bot]
8bce576eed
Merge pull request #15125 from ankush/max_attach
...
fix(ux): validate max_attachment count on doctype
2021-12-03 08:35:40 +00:00
Suraj Shetty
aa7f6348cd
Merge branch 'develop' into newsletter-markdown
2021-12-03 13:58:47 +05:30
Suraj Shetty
b4be189eae
Merge branch 'develop' into onboarding-step-enhancement
2021-12-03 13:58:26 +05:30
Suraj Shetty
8a84ae4f08
ci: Use node version 14 to avoid node-sass failure in patch testing build ( #15176 )
2021-12-03 13:57:57 +05:30
Suraj Shetty
49a790d47c
Merge branch 'develop' into onboarding-step-enhancement
2021-12-03 13:36:15 +05:30
Suraj Shetty
e4ad02f7e7
Merge branch 'develop' into newsletter-markdown
2021-12-03 13:29:59 +05:30
Rucha Mahabal
3bdca71924
fix: delete Event Producer Last Update on trash event of Event Producer
2021-12-03 10:37:30 +05:30
Faris Ansari
51c4738a04
fix(newsletter): use md_to_html instead of markdown
...
because valid html is valid markdown and markdown method
doesn't convert markdown if it encounters some html tags
2021-12-02 18:01:43 +05:30
rohitwaghchaure
dad4273997
Merge pull request #15162 from ankush/user_customization
...
feat: reset user-wise grid config to default
2021-12-02 16:59:03 +05:30
Ankush Menat
e0fadef11b
feat: reset user grid config to default
2021-12-02 16:19:38 +05:30
