Commit graph

41011 commits

Author SHA1 Message Date
Shariq Ansari
ed86da416f test: fixed failing web_form UI test 2023-01-26 15:50:12 +05:30
Shariq Ansari
586613d94c test: fixed failing control_color UI test 2023-01-26 15:36:18 +05:30
V Shankar
9bccedc761
feat: change quick entry dialog size based on column breaks (#19715)
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2023-01-26 15:30:47 +05:30
Ritwik Puri
fb9ae0823e
Merge pull request #19716 from resilient-tech/simpler-doc-cache
chore!: remove special local cache for documents (and related `cache_locally` parameter)
2023-01-25 22:21:12 +05:30
Ankush Menat
ffc5447548
fix: set-config without -g must specify site (#19782) 2023-01-25 20:33:55 +05:30
Shariq Ansari
1492f84041
Merge pull request #19732 from riandrys/fix_set_df_property_child_table 2023-01-25 19:55:19 +05:30
Shariq Ansari
f0ad75708e
Merge branch 'develop' into fix_set_df_property_child_table 2023-01-25 19:36:16 +05:30
Shariq Ansari
6a5ee6018a
Merge pull request #19781 from shariquerik/bump-datatable-1 2023-01-25 19:04:26 +05:30
Shariq Ansari
2a1c5f1fa9 build(deps): Bump frappe-datatable to 1.17.1 2023-01-25 18:45:10 +05:30
Shariq Ansari
664fa3ac15
Merge pull request #19778 from shariquerik/bump-datatable 2023-01-25 17:49:02 +05:30
Shariq Ansari
599f5a0ce5 build(deps): Bump frappe-datatable to 1.17.0 2023-01-25 17:25:26 +05:30
Sabu Siyad
cf92c5ac84
fix(translation): empty string passed gets passed (#19776)
It is reserved by GNU gettext: gettext("") returns the header entry with
meta information, not the empty string
2023-01-25 16:05:36 +05:30
Sagar Vora
0fd3c5a0f0
perf(DX): use cached Meta to create FormMeta (#19736) 2023-01-25 11:56:11 +05:30
Ankush Menat
c24cd12a27
Merge pull request #19755 from gavindsouza/maxsplit-as-needed
refactor: Add a maxsplit limit to string splits
2023-01-25 11:10:48 +05:30
Ankush Menat
ca0cb9335c
Merge pull request #19756 from barredterra/password-strength-for-long-passwords
fix: Password strength check for long passwords
2023-01-25 10:51:00 +05:30
Gavin D'souza
e75bfd0e73 refactor: Split objects just once
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2023-01-25 10:45:30 +05:30
Shariq Ansari
643ed3fb66
Merge branch 'develop' into fix_set_df_property_child_table 2023-01-24 21:15:47 +05:30
Raffael Meyer
ad77a74df9
Merge branch 'develop' into password-strength-for-long-passwords 2023-01-24 15:06:05 +01:00
barredterra
a33e34519a feat: add test case for long passwords 2023-01-24 15:04:47 +01:00
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
Shariq Ansari
72ae670b88
Merge pull request #19754 from shariquerik/ldap-test-fix 2023-01-24 18:47:58 +05:30
barredterra
92e684d4fc fix: use new source for zxcvbn 2023-01-24 14:07:34 +01:00
Shariq Ansari
b4ff826711 fix: default_user_type should be Website User if not set 2023-01-24 18:30:51 +05:30
barredterra
2148dc745e refactor: assign instead of update 2023-01-24 13:51:47 +01:00
barredterra
e61d87827b refactor: imports
- remove unused imports
- import only the required patterns, not the entire file
2023-01-24 13:50:17 +01:00
barredterra
d5a72b16ce fix: trim long passwords before check
In order for the check to pass in a reasonable amount of time.
2023-01-24 13:48:07 +01:00
barredterra
8aa8ea0ee2 feat: bump zxcvbn version
zxcvbn 4.4.28 no longer crashes on long, random passwords.
2023-01-24 13:46:57 +01:00
Shariq Ansari
0173d2abfb test: fixed failing LDAP test 2023-01-24 17:56:10 +05:30
Ankush Menat
46ffda6045
Merge pull request #19744 from ankush/incorrect_link
fix: incorrect link when std field has problem
2023-01-24 16:16:18 +05:30
Shariq Ansari
7d2d276d3c
Merge pull request #19743 from shariquerik/grid-in-3-column-ux
Fixes https://github.com/frappe/frappe/issues/19275
2023-01-24 13:07:09 +05:30
Ankush Menat
be7fd7a58d fix: point to custom field link instead 2023-01-24 12:41:05 +05:30
Ankush Menat
479e0c1439 fix: clear cache on every update in notifications
This feels like duplicate but ensures that it gets cleared in every
case. E.g. Some class might have overridden validate or ignore_validate
might be set in which case cache doesn't get cleared.
2023-01-24 12:41:05 +05:30
Shariq Ansari
aabe357ebf
Merge branch 'develop' into grid-in-3-column-ux 2023-01-24 12:36:29 +05:30
Shariq Ansari
1d97023b34 fix(UX): Grid in 3 column layout is broken 2023-01-24 12:34:31 +05:30
dependabot[bot]
788d512a69
chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (#19737)
Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-24 11:33:00 +05:30
Shariq Ansari
af671fc22b
Merge pull request #19710 from shariquerik/pass-strength-progress-bar 2023-01-24 11:31:26 +05:30
Shariq Ansari
56c822b274
Merge pull request #19740 from shariquerik/ldap-fix
Fixes https://github.com/frappe/frappe/issues/19702
2023-01-24 11:25:43 +05:30
Shariq Ansari
229ca404ae fix: LDAP - default user role mandatory logic broken 2023-01-24 11:22:05 +05:30
Shariq Ansari
4afd96baae
Merge pull request #19731 from shariquerik/child-table-fields-in-dialog-readonly-fix
fix: child table readonly field in dialog is not readonly
2023-01-24 09:55:25 +05:30
Sagar Vora
71420eb4e6
refactor: simplified get_controller (#19684)
* refactor: simplified `get_controller`

* chore: more refactor, better error if not subclass

* chore: more correct condition

* refactor: `class_` > `_class`

* chore: use `Meta` instead of DB calls

* chore: `_get_controller` => `import_controller`

* style: remove else block
2023-01-24 01:27:26 +05:30
Riandrys Góngora Román
ba438fe4a6 test: update docfield property using set_df_property in child table
add UI test with cypress on form.js
update docfield property using set_df_property in child table
2023-01-23 11:26:07 -05:00
Riandrys Góngora Román
ce4450cd95 fix(child table): Update docfield property using set_df_property
update docfield property using set_df_property
set_df_property doesn't work when it's call it in form_render event of child table
2023-01-23 11:26:07 -05:00
Ankush Menat
30e9fc4cb6 chore: remove unnessary todo comment 2023-01-23 20:05:28 +05:30
Shariq Ansari
3d280a2d3f fix: child table readonly field in dialog is not readonly 2023-01-23 18:17:21 +05:30
Ankush Menat
3821167f66
Merge pull request #19725 from ankush/migration_fixes_moar
fix: misc migration issues
2023-01-23 16:44:19 +05:30
Ankush Menat
391edba10a fix(UX): better error message for dead link fields
Link fields referring to non-existing doctypes are possible when

- Removing customizations.
- Removing app which added a custom field but didn't clean up after
  itself.

[skip ci]
2023-01-23 16:43:57 +05:30
Shariq Ansari
bbcdd3102e
Merge branch 'develop' into pass-strength-progress-bar 2023-01-23 16:29:47 +05:30
Shariq Ansari
6c1624d41e feat: toggle password icon 2023-01-23 16:23:44 +05:30
Ankush Menat
224ab37924 fix: Dont apply non-standard perms in migrate
ref: agent-job/b8bca95f25
2023-01-23 15:07:13 +05:30
Ankush Menat
87561940a4
feat: Interactively add a new patch (#19722) 2023-01-23 15:04:43 +05:30