Commit graph

40192 commits

Author SHA1 Message Date
Marica
eec7a7fd13
Merge branch 'develop' into get_role_permissions-js-consistency 2022-11-21 14:03:17 +05:30
marination
ed2804d1c5 test: Cypress test to check basic has_perm and get_perm JS APIs
- Test removes System Manager role for user and expects certain perms
- On Kanban Board DocType, only System Manager is allowed to print/export/email/report/share
- DocType level test only
2022-11-21 13:41:04 +05:30
Shariq Ansari
63a69e44d8
Merge pull request #18919 from shariquerik/field-help-link 2022-11-19 12:12:04 +05:30
Shariq Ansari
220dbf3267
Merge pull request #18893 from maharshivpatel/fix-z-index
fixes https://github.com/frappe/frappe/issues/18811
2022-11-19 12:11:28 +05:30
Maharshi Patel
9bbac0f84f fix: update z-index considering sticky tabs 2022-11-18 21:31:37 +05:30
Shariq Ansari
aa3794a489 revert: unused css 2022-11-18 15:33:23 +05:30
Shariq Ansari
799e22a6cf fix: update z-index 2022-11-18 15:31:24 +05:30
Shariq Ansari
64d39ee18a fix: dont show link for fields without label 2022-11-18 15:04:53 +05:30
Mohammad Hussain Nagaria
dae4d57bed
fix: get_title must return string (#18926)
* which was not the case with autoincrement name rule
* only apparent when you set the "Image Field" in form settings
2022-11-18 13:15:34 +05:30
Sagar Vora
ff1c9be33b fix: correct logic for if_owner and refactor 2022-11-18 01:02:05 +05:30
Faris Ansari
74bce62c62
Merge pull request #18841 from netchampfaris/app-include-site-config 2022-11-17 21:13:11 +05:30
Ankush Menat
f488a4953f
chore: validate ui test helpers at runtime (#18922)
[skip ci]
2022-11-17 18:17:22 +05:30
Shariq Ansari
eb5f50e36a
Merge branch 'develop' into field-help-link 2022-11-17 18:06:01 +05:30
Shariq Ansari
25cf0d8b62
Merge pull request #18925 from shariquerik/set-route-option-in-localstorage 2022-11-17 18:05:49 +05:30
Shariq Ansari
c686671b15 fix: set route options in local storage if open in new tab 2022-11-17 17:42:28 +05:30
mergify[bot]
d57182f9e8
Merge pull request #18875 from gavindsouza/socket_io-refactor
refactor: Socket.IO
2022-11-17 11:51:15 +00:00
Gavin D'souza
40df601a73 fix: Auto-add all users to website room
Keep website room open for all - currently only used for discussions
2022-11-17 17:04:07 +05:30
Ankush Menat
9dbccc98cb chore: conflicts 2022-11-17 16:48:21 +05:30
Ankush Menat
dcdc22b53f build: pin pyopenssl
(cherry picked from commit f70db1f5397e1b1795cc3ac957bb9b2519d4341f)

# Conflicts:
#	pyproject.toml
2022-11-17 16:48:21 +05:30
Shariq Ansari
547cdcf567
Merge pull request #18910 from shariquerik/cmd+click-for-div
Fixes https://github.com/frappe/frappe/issues/18788
2022-11-17 16:39:28 +05:30
Shariq Ansari
e78c74cbc1 feat: inline doc link for each field 2022-11-17 16:19:35 +05:30
rohitwaghchaure
d0a872cc1d
Merge pull request #18913 from rohitwaghchaure/indicator-not-working-for-user-configured-columns
fix: grid column indicators not working
2022-11-17 15:46:50 +05:30
gavin
dbed3e4788
Merge branch 'develop' into socket_io-refactor 2022-11-17 15:21:20 +05:30
gavin
862a5a398d fix(socketio): Revert irrelevant & unused changes
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-11-17 15:20:00 +05:30
Rohit Waghchaure
54a85d0636 fix: grid column indicators not working 2022-11-17 15:05:51 +05:30
Faris Ansari
edf01ee1cd
fix(file): attached_to_name can be an integer (#18909)
* fix(file): attached_to_name can be an integer

incorrect validation introduces via
https://github.com/frappe/frappe/pull/18880

* test(file): set correct fieldname

* fix: check for str, int explicitly
2022-11-17 14:43:03 +05:30
Shariq Ansari
8e0e2dad51 fix: (ctrl/cmd)+click for clickable divs 2022-11-17 13:59:56 +05:30
Sagar Vora
f3c00c2bdc
perf: dont fetch meta unless required (#18907) 2022-11-17 13:15:35 +05:30
Ankush Menat
c658d8cb1b
fix: ignore unpicklable hooks (#18902)
If any custom app use import statement in hooks.py everything breaks.
Hooks.py while being python file is still only supposed to be used for
configuring.

This PR ignores unpicklable members of hooks.py
2022-11-17 11:50:18 +05:30
Jannat Patel
6428930857
fix: security issue in discussions component (#18903)
[skip ci]
2022-11-17 11:39:43 +05:30
Ankush Menat
1f6f31fc97 refactor: int > cint 2022-11-17 11:35:24 +05:30
Athul Cyriac Ajay
190e01a5f3 fix: Force integer type in request.max_content_length 2022-11-17 11:35:24 +05:30
gavin
e32f0cd0f8
Merge branch 'develop' into socket_io-refactor 2022-11-16 23:08:23 +05:30
Gavin D'souza
c3c1848b2a fix: Restrict socket data to respective users after commit
Fix conditions to bother only those who asked for the data:
- Clear permissions cache only for updated users' data
- Defer appropriate events until commit to avoid ghost events
- Remove event unused by desk (and other apps)
2022-11-16 23:07:07 +05:30
Gavin D'souza
16bd7a2d0b fix(socketio): Scoping & hoisting bugs
Due to the previous logic, cookie data seemed inconsistent causing ghost
sessions.
2022-11-16 23:02:23 +05:30
Gavin D'souza
96fee8c293 feat: {site}:website room open to all users
- Subscribe to room and pass messages without auth
- Pass `room='website'` to publish_realtime to use
- Pass discussions' comms through particular site's website room
2022-11-16 21:53:49 +05:30
Ankush Menat
70633573c2
fix: dont convert row format if not required (#18900) 2022-11-16 20:48:50 +05:30
Shariq Ansari
2faa8ef292
Merge pull request #18894 from shariquerik/web-form-read-only 2022-11-16 17:56:55 +05:30
Shariq Ansari
990dcc7538
Merge branch 'develop' into web-form-read-only 2022-11-16 17:07:58 +05:30
Ankush Menat
0d5d2cf95c
ci: fix flake8 URL (#18895) 2022-11-16 16:15:31 +05:30
Shariq Ansari
424a7d39bc fix: webform read only field not working 2022-11-16 16:00:24 +05:30
Gavin D'souza
2b7e4554c4 fix(desk): maintain realtime & cached data consistency
- Clear docinfo_update callbacks before setting one; ensure only
  one active callback at any given point.
- Remove document from local cache if list_update sent if not edited
2022-11-16 15:19:03 +05:30
Ankush Menat
45b0c3e28d chore: remove dead code 2022-11-16 14:05:53 +05:30
Maharshi Patel
88e331e236 fix: z-index for barcode and awesomeplete 2022-11-16 12:55:25 +05:30
Faris Ansari
13c8da8ee1
Merge branch 'develop' into app-include-site-config 2022-11-15 19:55:22 +05:30
gavin
24f4b85031
Merge branch 'develop' into socket_io-refactor 2022-11-15 19:19:29 +05:30
Ankush Menat
9fc330ea6c
Revert "fix: remove middleware to clear frappe.local (#18874)" (#18886)
This reverts commit 2971abe517.
2022-11-15 18:45:51 +05:30
marination
92d9e7d611 fix: Don't assign document level perms to doctype level permission store
- If `doc` is passed to `has_perm`, checking for pre-stored doctype level perms is wrong
- It gives back stale values that don't consider document level permissions and only change on reload (window property)
- Get freshly evaluate perms at the doc level
- If no `doc` is involved, doctype level custom window property can be used
2022-11-15 17:57:49 +05:30
Gavin D'souza
3a8fa6cbd5 refactor(socketio): Use same room for doc & info events
other changes
- Name list room as doctype room for more generic use
- avoid re-setting up listeners for generic events
- discard docinfo_subscribe event
2022-11-15 17:55:53 +05:30
Faris Ansari
e10d19a317
Merge branch 'develop' into app-include-site-config 2022-11-15 17:19:59 +05:30