some incoming files could have either filename or fileid for whatever reason. this handles both those cases (at least for now).
Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
so, apparently i messed up some things that were responsible for handling file attachments in email queue and attached on-the-fly generated reports. these issues should be fixed now.
Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
* fix(Custom Report): Load filters from report doc
For Custom Report, load filters only from the report doc. For the report
builder, filters should load similar to listview.
* fix(Kanban): Explicit menu action to save filters
* fix: indent
* fix: Always route to the List view from dashboard
* test(UI): Add UI tests using cypress
* test: Add test configuration for travis
* fix: Lock redis version
* fix: Refactor fill_field command
* fix: Rename setup_wizard test to run first
* test: Add setup for dashboard service
* test: Add build matrix for ui test
* test: Add name to each build matrix
* test: Only include ui test for an extra build stage
* fix: Exclude UI test with python 3.6
* test: Test order
* test: Enable developer_mode
* test(login): Check session user and not hash
* test: Refactor assert
* test: Refactor setup wizard test
* test: Remove setup wizard test
* test: Add blank seed database
* test(form): Scroll to top before save
* test: Fix form test
* test: timeout
* test: more wait
* test: Remove specific selector
* test: Remove wait, delay typing
* test: Blur input after typing
* test: Wait for form to get dirty
* test: Add credentials for frappe org
* test: Remove node install step
* style: Fix linting issues
* fix: List view filters
- ToDo: Dont override frappe.route_options if it is already set
* test: Dont reload page before test
In regards to PDF generation, if developer_mode was set to true, the PDF
generated used to lack css styling. This was because the URL to the CSS
assets used to contain the webserver port number, but given the system
was running in production, the URL was invalid, thereby not being able
to load CSS assets. This fix does not rely on the value of
developer_mode to identify if the system is running in production,
rather, it uses the value of restart_superviosor or systemd_on_update,
to check for the same.
* intial commit
* changes
* added validation
* bux fixes
* confirmed_unsubscribe code raw mysql query removed
* moved everything to single file for optimisation
* UI fixes
* fixed csrf token not found
* removed the older function(method)
* code refracted or added some comment
* changes
* ui enhancement
* codacy fixes
* Ui fixes
* Applied Requested changes
* code optimisation
* fixed unit test
* more validation
* Ui fixes
* removed print statement which was used for tracing
* change
* done changes requested
* done chnages requested
* Make code more self-explanatory
* Fix some code formatting
- Add more descriptive name/id for buttons
- Rearrange a comment
- Remove some unwanted line breaks
- change status values
fixes#15961 issue
In large threads, this leads to snowballing of replies, sometime even
reaching more than 5 million characters.
Email threads are already maintained in ERPNext, and modern clients
are capable of maintaining threads.
The only purpose it serves is maintain threads for text based email
client, and I think we should ignore that use case, for improved user
experience for Frappe/ERPNext users.
