Commit graph

38868 commits

Author SHA1 Message Date
phot0n
f679dc3fdd fix(security): restrict the god google callback
the common google callback can be used to trigger any method in the whole codebase
restrict it by only allowing domain specific callback method and raise
an error if the domain is not found
2022-07-17 21:37:21 +05:30
phot0n
8edae2ce09 fix: encrypt access_token when setting in db after refreshing access_token 2022-07-17 21:35:06 +05:30
Ankush Menat
c200f5b3ae ci: check build requirement before setting up python
[skip ci]
2022-07-15 12:03:47 +05:30
Ankush Menat
1f0e019e89
fix(UX): correct message for empty prepared report (#17517) 2022-07-14 19:02:19 +05:30
Suraj Shetty
bdb36f4c2d
Merge pull request #17515 from surajshetty3416/fix-inbound-notification-receivers
fix: Do not relay email to standard users
2022-07-14 18:32:45 +05:30
Suraj Shetty
0a41c4051c fix: Do not relay email to standard users
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-07-14 18:01:47 +05:30
Shariq Ansari
a8f86abbd8
refactor: Replaced blog's feedback with comment's comment_type='Like' (#17479) 2022-07-14 14:09:00 +05:30
Ankush Menat
95f67b8de8
fix: ignore empty part in naming series (#17508)
on v13 doc.get("") returns entire doc dictionary, this gets strigified
and becomes a problem for naming.
2022-07-14 13:14:58 +05:30
Ankush Menat
2c36874554 style: add config for CSS and SCSS 2022-07-13 20:30:07 +05:30
Ankush Menat
3a7c7ff182 ci: ignore HTML files for server tests 2022-07-13 20:30:07 +05:30
Ankush Menat
99d3fe3893 fix(dark theme): background color on version page 2022-07-13 20:30:07 +05:30
Ankush Menat
5a55507e6d
fix: pass docfield for custom indicator formatter (#17501) 2022-07-13 20:17:31 +05:30
uepselon
2791066bb2
fix: allow System Manager to reset OTP secret
* squashed: Change Admin based OTP reset to role based reset (System Manager)

* fix: show `Reset OTP Secret` button only if applicable

* chore: flatten code, use `only_for` API

Co-authored-by: Leonard Goertz <leonard.goertz@noventive.com>
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2022-07-13 19:35:41 +05:30
Ankush Menat
0164a87ac9
Merge pull request #17350 from Aradhya-Tripathi/get-all-mod
feat: Adding support to Query engine
2022-07-13 18:36:04 +05:30
Ankush Menat
468a5c55a3
ci: fix weird version check in cypress tests (#17499) 2022-07-13 18:08:20 +05:30
Sagar Vora
843f241c13
fix: copy global defaults before updating to avoid cache mutation (#17497)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-07-13 15:11:37 +05:30
mergify[bot]
eb61357160
Merge pull request #16935 from phot0n/google_oauth_refactor
refactor!: GoogleOAuth
2022-07-13 07:57:38 +00:00
Suraj Shetty
a292c7fed2
Merge branch 'develop' into google_oauth_refactor 2022-07-13 13:05:56 +05:30
phot0n
7d5262f5e0 chore: translate authorization message and add nosemgrep 2022-07-13 12:50:04 +05:30
phot0n
9090b0fe3a chore: remove unnecessary failure_query_param for email oauth 2022-07-13 12:41:32 +05:30
Ankush Menat
e762fe9ce1
test: clear filters on ToDo before running test (#17494) 2022-07-13 12:29:41 +05:30
phot0n
31c5f260d7 chore: use f-strings 2022-07-13 12:29:25 +05:30
phot0n
01a1860491 fix(ux): better ux for successful oauthorization 2022-07-13 12:05:46 +05:30
phot0n
5b7d37477e chore: add link for google settings when throwing error 2022-07-13 12:05:46 +05:30
phot0n
d1a199258d fix: pull from accounts for oauth whose refresh_token is not null
* chore: rename Oauth to OAuth
2022-07-13 12:05:46 +05:30
phot0n
81bb9c411a chore: fix sider 2022-07-13 12:05:46 +05:30
phot0n
a50568596a minor: fetch attachment size from get_max_file_size api 2022-07-13 12:05:46 +05:30
phot0n
5ea642ef7f fix(ux): update form header upon successful authorization
* minor: simplified validations for email account
2022-07-13 12:05:46 +05:30
phot0n
da33f6e6d8 fix: remove fetch-from from user email for used_oauth 2022-07-13 12:05:46 +05:30
phot0n
a826f4cc53 fix(ux): consistent field names for ssl and server
* keep server and port together
2022-07-13 12:05:46 +05:30
phot0n
2b7bd4eef0 minor(ux): select field for alternating between basic and oauth authentication 2022-07-13 12:05:46 +05:30
phot0n
2907571098 minor: encrypt email oauth refresh and access token 2022-07-13 12:05:46 +05:30
phot0n
5bf26819a8 fix: better/reduced exception handling for email oauth
Since the places where connection methods are called already
have a lot of exception handling, we can just raise and let them
handle all the probable cases.
2022-07-13 12:05:46 +05:30
phot0n
8b38fcb438 chore: move getting site address to GoogleOAuth 2022-07-13 12:05:46 +05:30
phot0n
431afaeee4 fix: remove commit
* chore: raise not implemented error for services other than gmail

* chore: use fstring for _auth_string property
2022-07-13 12:05:46 +05:30
phot0n
84ad7b74b9 fix: don't show authorize api access button if the form is unsaved 2022-07-13 12:05:46 +05:30
phot0n
484758d6e0 chore: remove additional/unnecessary set_value calls 2022-07-13 12:05:46 +05:30
phot0n
6848c93770 chore: remove GET method whitelisting from google integrations 2022-07-13 12:05:46 +05:30
phot0n
6d3dfca214 fix: consider oauth usage as well for asking/updating user email password 2022-07-13 12:05:46 +05:30
phot0n
5521abd40c fix: use safe decode for uid 2022-07-13 12:05:46 +05:30
phot0n
4d5dec4048 fix: open authorization url on the current browsing context 2022-07-13 12:05:46 +05:30
phot0n
834410a2a5 fix: dont update modified timestamp on generating and refreshing tokens 2022-07-13 12:05:46 +05:30
phot0n
ab9a577474 minor: better oauth flow 2022-07-13 12:05:46 +05:30
phot0n
221423c718 chore: added docstrings 2022-07-13 12:05:46 +05:30
phot0n
e58afca3f6 minor: simplify authorize_google_access 2022-07-13 12:05:46 +05:30
phot0n
ed0a255353 minor: fetch oauth fields from site config 2022-07-13 12:05:46 +05:30
phot0n
de6f1326f7 minor: move oauth access functions from email_account 2022-07-13 12:05:46 +05:30
phot0n
67730b7b26 chore: fix sider 2022-07-13 12:05:46 +05:30
phot0n
064ffef8b9 minor: throw exception if refresh_token is not present 2022-07-13 12:05:46 +05:30
phot0n
06c5a7226d chore: fix linter 2022-07-13 12:05:46 +05:30