Commit graph

1183 commits

Author SHA1 Message Date
Suraj Shetty
bbfc4a9069 fix: Load doc before save in db_set as well
- Because db_set internally triggers on_change event
and on_change handlers might expect doc_before_save.
2019-09-03 08:37:11 +05:30
Faris Ansari
bff94703cf feat: Create NestedSet doctypes via configuration 2019-09-02 15:58:52 +05:30
Suraj Shetty
afba9a0238
Revert "fix: When autoname is not set, treat it as hash" 2019-08-30 14:55:40 +05:30
Suraj Shetty
b3f2fc98b5
fix: When autoname is not set, treat it as hash (#8260)
fix: When autoname is not set, treat it as hash
2019-08-29 11:07:58 +05:30
mergify[bot]
2eebc463db
Merge pull request #8267 from gavindsouza/doctype-fix
refactor: improvement to doctype API
2019-08-27 11:44:50 +00:00
Gavin D'souza
b21223ab64 fix: delete controller code when doctype is deleted 2019-08-27 12:35:33 +05:30
Deepesh Garg
0f60698513 feat: Ignore certain linked documents on cancellation of document (#8255)
* fix: Allow cancellation of doctype if linked with certain doctypes

* fix: Consider docstatus

* fix: Do not allow to delete canceled doc
2019-08-26 17:05:35 +05:30
Faris Ansari
54f2e25687 fix: When autoname is not set, treat it as hash
During collision it only checks for 'hash', but it can be unset too.
2019-08-26 13:45:38 +05:30
mergify[bot]
3bdb4313ef
Merge pull request #8188 from surajshetty3416/enhance-energy-point-system
feat(eps): Add ability to make point rule for document creation
2019-08-21 08:38:20 +00:00
Suraj Shetty
6e3b00be68 fix(postgres): Convert check value to int everytime
Since posgres does not internally coerces boolean to int
(Note: mysql does)
2019-08-19 21:55:47 +05:30
Shivam Mishra
87c83a673b
Merge pull request #8164 from surajshetty3416/fix-comments
refactor: Fix comments in add_user_permissions
2019-08-13 13:23:55 +05:30
Suraj Shetty
0ce31fc61d chore: Remove unwanted/unused db_schema.py 2019-08-12 09:52:08 +05:30
Suraj Shetty
2e2ebcd9cc fix: Comments in add_user_permissions 2019-08-12 09:47:22 +05:30
Aditya Hase
7bcf652a23 fix(search): Reduce restrictions on field contents 2019-07-30 14:27:52 +05:30
Aditya Hase
5d04fb4eb7 fix(search): Reduce restrictions on field contents 2019-07-30 14:25:13 +05:30
Aditya Hase
a534519dfc fix(security): Sanitize fields list, group_by and order_by clause to prevent SQLi 2019-07-30 12:53:58 +05:30
Aditya Hase
8ac155f7b6 fix(security): Sanitize fields list, group_by and order_by clause to prevent SQLi 2019-07-30 12:52:01 +05:30
Aditya Hase
ce60f98ab6 Revert "fix(security): Disallow unnecessary characters in group_by and fields"
This reverts commit fb8993663c.
2019-07-26 20:49:46 +05:30
Aditya Hase
30845b26fa Revert "fix(security): Disallow unnecessary characters in group_by and fields"
This reverts commit 7aa34665c1.
2019-07-26 20:47:47 +05:30
mergify[bot]
82989049a1
Merge pull request #7965 from ruchamahabal/session-defaults
feat: Session defaults
2019-07-26 07:17:37 +00:00
Aditya Hase
7aa34665c1 fix(security): Disallow unnecessary characters in group_by and fields 2019-07-25 20:55:08 +05:30
Aditya Hase
fb8993663c fix(security): Disallow unnecessary characters in group_by and fields 2019-07-25 20:54:08 +05:30
Rucha Mahabal
4b2ab9e00d feat: Session Defaults 2019-07-21 23:16:50 +05:30
deepeshgarg007
041ada51f3 fix: Get cached value only if field present in doc 2019-07-11 15:07:58 +05:30
mergify[bot]
b346b75b46
Merge pull request #7817 from Anurag810/translating_errors
refactor: added missing translation functions
2019-07-03 10:08:02 +00:00
Anurag Mishra
570fd44248 fix: Translating Errors and Messages 2019-07-03 11:52:47 +05:30
Suraj Shetty
7210cef498
Merge pull request #7753 from surajshetty3416/fix-document
fix(document): Use set_value instead of db_set while setting "_seen"
2019-06-29 22:54:55 +05:30
Suraj Shetty
b117f3cb0e fix: Use set_value instead of db_set
- Setting _seen should not trigger on_change methods
2019-06-23 17:15:56 +05:30
Faris Ansari
7cb6b2663b fix: Handle AttributeError when adding seen 2019-06-23 12:41:16 +05:30
Nabin Hait
b375ee9eef fix: merge conflict 2019-06-18 18:45:21 +05:30
Nabin Hait
df438c1697
Revert "fix: Set default only if the dependent field is set (#7130)" (#7644)
This reverts commit 73c1f531e8.
2019-06-05 20:30:13 +05:30
Rushabh Mehta
6480619307
Merge pull request #7572 from surajshetty3416/bulk-workflow-approval
feat(list view): Bulk workflow approval
2019-06-03 16:58:57 +05:30
Suraj Shetty
67b41deb44 test: Add test case to check get_common_transition_actions 2019-06-02 10:56:20 +05:30
Suraj Shetty
12f06d6af7 fix: Change progress title 2019-05-30 17:29:35 +05:30
Karthikeyan S
acd2f589b6 fix(Barcode): excluding Barcode feild from XSS FIlter (#7605)
(cherry picked from commit e579b8960e1c34e7ad0bf794a10596b40530bc09)
2019-05-30 13:51:14 +05:30
Karthikeyan S
0404390064 fix(Barcode): excluding Barcode feild from XSS FIlter (#7604) 2019-05-30 13:50:05 +05:30
Faris Ansari
778bc4349b
fix: Check if value is string (#7583)
Breaks the check when value is a map. So we reverse the check.
2019-05-29 11:40:53 +05:30
Suraj Shetty
1d99c1cc86 fix: Pass complete doc to avoid data loss 2019-05-28 17:00:45 +05:30
Suraj Shetty
cc7ea9fae6 fix: Handle edge cases
Handle edge cases like
- same action is used twice for transision
- workflow field is not set for the doc
2019-05-28 14:48:57 +05:30
Suraj Shetty
b4dfd88f5f fix: Make it work in harmony ☮️ 2019-05-28 12:06:22 +05:30
Suraj Shetty
a1e19ba0a3 feat(list view): Add bulk workflow approval option 2019-05-28 08:37:11 +05:30
Himanshu
73c6520aef fix: Remove update_timeline_links from document.py (#7563) 2019-05-26 15:37:10 +05:30
Faris Ansari
e9b0c2229d fix: Error message for invalid Workflow Transition (#7553)
When you import a document of a DocType which has a workflow, you
shouldn't be able to set the workflow_state to a state except the first.
This patch shows a better error message.
2019-05-25 11:56:20 +05:30
Faris Ansari
6fdbb6fd79 fix: Error message for invalid Workflow Transition (#7552)
When you import a document of a DocType which has a workflow, you
shouldn't be able to set the workflow_state to a state except the first.
This patch shows a better error message.
2019-05-25 11:55:46 +05:30
Rushabh Mehta
1c893e44c0 fix: frappe.conf.db_type -> frappe.db.db_type 2019-05-24 11:44:28 +05:30
Rushabh Mehta
7135c0d9e8 fix(various): after manual testing 2019-05-24 11:22:09 +05:30
Rushabh Mehta
81fa64d4bc refactor(form.js): remove very old API 2019-05-24 09:08:56 +05:30
Rushabh Mehta
83eb9c3acc refactor(form.js): wip 2019-05-24 09:08:56 +05:30
Himanshu
51042b1359 fix(load): alias creation in get communications (#7538)
* fix: alias creation

* fix: fix update_timeline_doc

* fix: add timeline link irrespective of comm medium
2019-05-23 09:35:53 +05:30
Rushabh Mehta
01dc6bee5b fix(delete_fields): handle commit for DDL separately for MariaDB and Postgres 2019-05-22 13:21:07 +05:30