Aarol D'Souza
4ecb9bc57d
fix: clear cache and prevent data access after DocType deletion ( #34307 )
...
* fix: clear cache and prevent data access after DocType deletion
* fix: Handle potential DB failures during migrate
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2025-10-10 08:00:51 +00:00
Dhinesh
123a7a0136
fix: check Submission Queue already exists for the record ( #34094 )
...
* fix: check Submission Queue already exists for the record
* chore: clean up msgprint statments
2025-10-09 15:32:57 +05:30
Ejaaz Khan
e7832bfd4b
Merge pull request #32684 from iamejaaz/32489-role-perm-based-masking
...
feat: show mask data in form, list and report view
2025-10-09 10:55:50 +05:30
Akhil Narang
3dfa9f35dc
fix: escape HTML in filename before display ( #34289 )
...
* Revert "fix: sanitize HTML in file names before saving (#34192 )"
This reverts commit 0120410593
2025-10-07 11:50:09 +05:30
Akhil Narang
5252d5ad47
fix(doctype): restrict length to 61 characters ( #34225 )
...
Default is 140 here, but we restrict it to 61 in the backend
(tab+name should be 64 characters max)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-10-01 06:26:40 +00:00
mergify[bot]
16058b92af
Merge branch 'develop' into 32489-role-perm-based-masking
2025-09-30 09:00:48 +00:00
Akhil Narang
0120410593
fix: sanitize HTML in file names before saving ( #34192 )
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-29 15:55:23 +05:30
Charles-Henri Decultot
72b20fa52b
fix: HTML sanitation for XSS mitigation ( #34168 )
...
* fix: several XSS attack opportunities
* fix: linter
2025-09-29 10:39:04 +05:30
Akhil Narang
355d218f8e
Merge pull request #34162 from akhilnarang/bump-ruff
...
refactor(treewide): bump ruff
2025-09-26 17:44:11 +05:30
Akhil Narang
6ca4d4d167
refactor(treewide): ruff format
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-26 13:16:43 +05:30
Ejaaz Khan
80307c731b
Merge pull request #34101 from Abdeali099/grid-fixes
...
refactor: Enhance grid configuration
2025-09-25 11:30:12 +05:30
Corentin Forler
7743c90783
feat: Optionally show a warning when opening an external link
2025-09-24 16:53:01 +02:00
Akhil Narang
dc2422ebde
fix: don't call file.check_content() twice
...
This first call was sometimes done when `_content` wasn't set, resulting in:
```
File "apps/frappe/frappe/core/doctype/file/file.py", line 138, in validate
self.check_content()
File "apps/frappe/frappe/core/doctype/file/file.py", line 381, in check_content
if self.file_type == "PDF" and self._content and pdf_contains_js(self._content):
^^^^^^^^^^^^^
AttributeError: 'File' object has no attribute '_content'
```
Just calling it in `write_file()` seems good enough
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-24 18:20:09 +05:30
Abdeali Chharchhoda
0b2d0d6458
refactor: update default value for rows_threshold_for_grid_search to 20
2025-09-23 16:23:27 +05:30
Ejaaz Khan
ca67a12e0f
refactor: remove debugging statement
2025-09-22 15:05:27 +05:30
anwarpatelnoori
42c104fa76
fix: mange specific roles without saving the user doc
2025-09-21 11:43:37 +00:00
Hussain Nagaria
7dcc670ca8
Merge pull request #33899 from frappe/feat/control-decimal-width
2025-09-20 18:38:10 +05:30
Hussain Nagaria
5c280c1596
refactor: move to inline comment
2025-09-18 12:26:14 +05:30
Hussain Nagaria
7373d90691
fix: no semgrep on PIL monkey patch
2025-09-18 12:22:37 +05:30
Hussain Nagaria
e21560d237
refactor: remove unnecessary precision setting
2025-09-18 12:18:56 +05:30
Hussain Nagaria
f74c665cc2
test: precision exceeds length
2025-09-18 00:18:32 +05:30
Hussain Nagaria
de6195e12f
test: length and precision for decimal based fields
2025-09-18 00:15:42 +05:30
Ejaaz Khan
54b34c9535
Merge branch 'develop' into 32489-role-perm-based-masking
2025-09-17 16:17:30 +05:30
Hussain Nagaria
c230e86e2c
fix: handle length more robustly
2025-09-17 13:27:13 +05:30
Akhil Narang
36ccf32ab3
fix: don't try to scan encrypted PDFs
...
Also fix reversed logic of JS check
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-10 15:44:09 +05:30
Corentin Forler
64aa4787be
fix: Don't check PDF content if not defined ( #33914 )
2025-09-09 15:29:57 +05:30
Rahul Agrawal
c52e5157b4
feat: allow users to export report in background ( #33861 )
...
* feat: allow users to email prepared report
* fix: add export in background checkbox in export dialog
* chore: use a common function to send report email
* feat: delete generated files from system after user defined duration
* feat: add exported reports in a folder and periodically clean it
* test: add test for export via report
* fix: add exported folder path as constant
* chore: un-edit report.json
* refactor: for readability
* chore: type hint
* refactor: let the BG job fail if email fails
* refactor: consistent `report_name`
* it reads better now, e.g. attached_to_name=report_name instead of attached_to_name=title
* refactor: `return_file` to its inverse `populate_response`
* chore: more specific error message
---------
Co-authored-by: Rahul Agrawal <deathstarconsole@Rahuls-MacBook-Air.local>
Co-authored-by: Hussain Nagaria <hussainbhaitech@gmail.com>
2025-09-05 14:34:55 +00:00
Akhil Narang
60b2d92af8
fix(data_import): set payload count from existing importer
...
Don't create a new one, especially one that doesn't have all parameters (main issue here: console=False)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-03 17:56:41 +05:30
Akhil Narang
7ad1378d00
Merge pull request #33772 from erjeve/fix-data-import-payload-count
...
fix: initialize payload_count in import_file function
2025-09-03 17:10:10 +05:30
Hussain Nagaria
8f83dedbba
feat: allow length change for decimal columns
2025-09-03 15:28:10 +05:30
Hussain Nagaria
dcbc397400
fix: comparison accuracy
2025-09-03 11:33:53 +05:30
Rahul Agrawal
de1249ecec
refactor: extract expression into separate variable
2025-09-03 11:28:46 +05:30
Rahul Agrawal
c4c151ed9b
chore: update field name
2025-09-03 10:57:37 +05:30
Rahul Agrawal
4829b50a8b
feat: allow users to define max signups per hour
2025-09-03 10:36:27 +05:30
Raffael Meyer
cc82ab19ab
feat: syntax highlighting in field description ( #33791 )
2025-09-03 03:21:34 +02:00
Soham Kulkarni
b7129419ef
Merge pull request #33675 from sokumon/pdf-issue
...
fix: scan pdfs before uploading
2025-09-02 18:41:13 +05:30
Akhil Narang
629211f059
fix(server_script): check for type being scheduler AND frequency being cron to show cron field ( #33872 )
...
Resolves #33847
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-02 18:03:31 +05:30
Ejaaz Khan
590fe7e520
Merge branch 'develop' into 32489-role-perm-based-masking
2025-09-02 10:48:06 +05:30
Akhil Narang
bd05f6a7b7
Merge pull request #33534 from AMR-Mannesmann/develop
...
fix: resolve issue in validate_user_pass_login frappe#33528
2025-09-01 19:17:06 +05:30
mergify[bot]
c7ba132315
Merge branch 'develop' into drive-integration
2025-09-01 06:14:16 +00:00
Raffael Meyer
6aed5b91d3
feat!: remove the "Transaction Log" DocType and a related report ( #33844 )
2025-08-31 20:02:43 +02:00
sokumon
fd29103149
fix: make the checking more robust
2025-08-29 13:13:19 +05:30
sokumon
bbc093640b
fix: better message
2025-08-29 13:13:19 +05:30
sokumon
ca5831b1a8
fix: better function name, check before writing the file
2025-08-29 13:13:19 +05:30
sokumon
577ba89c28
fix(XSS): verify pdf content before uploading
2025-08-29 13:13:19 +05:30
Hussain Nagaria
85768a2eb0
fix: don't show filters and columns for Report Builder reports ( #33825 )
2025-08-29 10:49:01 +05:30
Akhil Narang
719af6e722
Merge pull request #33815 from raizasafeel/fix/translation-trailing-spaces
...
fix: remove trailing spaces in translatable strings
2025-08-28 16:31:45 +05:30
Ejaaz Khan
86c719ec6d
Merge pull request #33809 from mihir-kandoi/33758
...
feat: enable non negative validation for Percent type fields
2025-08-28 15:06:48 +05:30
Elton Lobo
d930335161
fix: role based invite restriction ( #33806 )
...
* refactor(user-invitation): validate invite role based on user's roles
* refactor(user-invitation): start error msgs with a capital letter
* docs(user-invitation): update the hooks structure
2025-08-28 12:02:54 +05:30
Raizaaa
aa3bb0e4d7
fix: remove trailing spaces in translatable strings
2025-08-27 13:23:17 +03:00
