Commit graph

5850 commits

Author SHA1 Message Date
Shariq Ansari
0bfe196d0c chore: keep fields table in settings tab at last
if you need to add multiple fields by copy paste from excel
2023-11-01 16:49:08 +05:30
Shariq Ansari
2522d6bfab fix: added is_tree & virtual doctype checkbox in new doctype dialog 2023-11-01 00:33:04 +05:30
Ankush Menat
6062eec0d6 fix(recorder): Always enable sortable 2023-10-31 15:03:11 +05:30
Ankush Menat
55da69ad50 perf: Make amended_from indexed by default
This is checked before every cancellation, so it makes sense to index it.

Not touching any existing records *for now*.
2023-10-31 15:03:11 +05:30
Gursheen Anand
2648535eae feat: set filters when routed from transaction 2023-10-31 13:53:59 +05:30
Gursheen Anand
e624c04125 fix: filter query for non mandatory filters 2023-10-31 13:50:03 +05:30
Gursheen Anand
fe3046a1c5 fix: remove validation for date filters 2023-10-31 13:37:19 +05:30
Gursheen Anand
bc693edc4e fix: make date range filters optional 2023-10-31 13:36:31 +05:30
Shariq Ansari
748ffbe4e4 chore: merge Details & Settings tab into Settings tab 2023-10-31 11:55:03 +05:30
Shariq Ansari
0e397d6f6a fix: minor fixes 2023-10-31 11:50:56 +05:30
Shariq Ansari
787515bf89 chore: add a boilerplate section on creating new doctype 2023-10-31 02:14:54 +05:30
Akhil Narang
6418320d61
fix: directly assign return value (#23007)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-30 21:37:42 +05:30
Kevin Shenk
0c0fbc4248
fix: skip invalid numbers on SMS receiver_list (#22879)
This PR switches the loop in the `validate_receiver_nos` function in the SMS Settings Doctype from `break` to `continue`.

The prior functionality would throw an error if any recipients on the receiver_list were invalid, which created an issue with SMS notifications that send to a user role, since any user without a valid mobile phone number would prevent the notification sending to any users (even those with valid mobile numbers).

By switching the loop from `break` to `continue`, the function still eliminates invalid entries and enforces the existence of at least one valid phone number, but doesn't break sending based on a single absent or invalid recipient entry.

[skip ci]
2023-10-30 18:47:14 +05:30
Akhil Narang
c4544e8989
perf: query fields only once (#22982)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>

[skip ci]
2023-10-30 17:20:32 +05:30
Ankush Menat
5fe80d3f34 chore: bump default session expiry to 7 days 2023-10-30 14:30:15 +05:30
Shariq Ansari
2799700455 fix: open new doctype dailog on /new-doctype-1 2023-10-30 14:09:20 +05:30
Shariq Ansari
8ca4501f7e fix: if Form tab is active hide comments & form message 2023-10-30 13:27:16 +05:30
Shariq Ansari
3407a9963e chore: hide fields table 2023-10-30 12:29:06 +05:30
Shariq Ansari
8b5dffff98 chore: made form tab as a first tab in doctype form 2023-10-30 12:24:08 +05:30
Shariq Ansari
65f62bb52f fix: Create doctype through a dialog 2023-10-30 12:23:28 +05:30
barredterra
c38ff0e83f feat: optionally use gettext for translation 2023-10-29 15:32:01 +01:00
Sagar Vora
9fdd432b4d
Merge pull request #22916 from resilient-tech/fetch-if-empty-revert 2023-10-26 15:14:51 +05:30
Sagar Vora
f08f128b1c fix: improve label and description for fetch_if_empty 2023-10-26 15:02:03 +05:30
Ankush Menat
385fa8aaef
fix!: Correct between filtering (#22918)
* fix: Remove incorrect fallback

If you do +1 on date it will also start considering next date. This was
only done to accomodate date filter on datetime fields. Which also
doesn't really work.

* refactor: simplify fieldtype detection

* fix!: Correct datetime fallbacks for between filters

* chore: remove unncessary test

This is very specific and introduces flake when the job tests run before
it.
2023-10-26 06:23:14 +00:00
Ankush Menat
d196dfeac4 fix: ignore perm while updating notification settings
If you can update user, do you should be able to update notif settings.
2023-10-25 11:22:56 +05:30
Ankush Menat
135fb6a486 chore: remove py2 compatibilty code 2023-10-21 13:40:04 +05:30
Akhil Narang
1119919971
refactor: use gzip library's compress() and decompress() methods directly
The util methods were added for python2.7 compat, mark them as deprecated

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-20 21:17:35 +05:30
Suraj Shetty
716ff2add2
Merge pull request #22693 from maharshivpatel/fix-attach-before-doc-save 2023-10-19 15:55:10 +05:30
ranjit-git
3351dd9020
fix: escpae filename
filenamexss
2023-10-19 12:11:42 +05:30
Maharshi Patel
409a3a8105 Merge branch 'develop' into fix-attach-before-doc-save 2023-10-19 11:40:20 +05:30
Ankush Menat
05d6f5cc8a test: Add cold start tests 2023-10-18 17:55:48 +05:30
Maharshi Patel
deb75cb07e fix(minor): set is_private as int instead of bool 2023-10-18 13:07:18 +05:30
Ankush Menat
d4c49a70c2 fix: handle cold start edge case 2023-10-18 12:56:05 +05:30
Sambasiva Suda
a8452484a0 chore: linter fix 2023-10-18 01:55:33 +05:30
Sambasiva Suda
6193f23fd6 chore: adding test case 2023-10-18 01:47:03 +05:30
Sambasiva Suda
ec0817d182 fix: cron job firing immediately after save 2023-10-18 01:14:54 +05:30
Ankush Menat
adac59363f
Merge pull request #22774 from ankush/rate_limit_ip
feat: rate limit logins based on IP too
2023-10-17 17:40:29 +05:30
Ankush Menat
7f35d0f8e6 style: format 2023-10-17 17:36:19 +05:30
Ankush Menat
768d4ba4b0 feat: rate limit logins based on IP too
Co-Authored-By: Aditya Hase <aditya@adityahase.com>
2023-10-17 17:18:08 +05:30
Ankush Menat
27d50bb0d1 fix!: Enable login tracker by default 2023-10-17 17:18:08 +05:30
shridhar
b864706c55 feat: Auto refresh when user updates theme 2023-10-17 14:55:14 +05:30
Ankush Menat
018ed845bd refactor: defer unnecessary json-dumping of messages
Also avoid accessing locals where interface is present like for popping last message.
2023-10-16 18:13:50 +05:30
Ankush Menat
0a244b10fc test: basic tests v2 API 2023-10-16 18:12:53 +05:30
Ankush Menat
0c61e61743 fix: delete oauth stuff when deleting users 2023-10-16 18:12:53 +05:30
Corentin Flr
89aab5d748
fix(query_doctypes): Allow search in translated name (#22590)
* fix(query_doctypes): Allow search in translated name

* test: Add test for DocType search in foreign language
2023-10-16 15:13:57 +05:30
Maharshi Patel
bbf91b8afc
fix: sync doctype layout on update standard field (#22699)
* fix: sync doctype layout on update standard field

When standard field is deleted & it is not updated in the doctype layout,
Error occurs as it will try to render fields that doesn't exist
and layout won't render.

to fix this, sync doctype layout on update standard field

* refactor: use savepoint decorator

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-10-16 12:19:17 +05:30
Ankush Menat
e20d79bc28
Merge pull request #22730 from nabinhait/server-script-fix
fix: Delete from cache after deleting a server script
2023-10-16 10:22:20 +05:30
Nabin Hait
04c2944886 fix: Delete from cache after deleting a server script 2023-10-15 19:16:13 +05:30
Ankush Menat
65455ffa89 fix(DX): Add simple cron explanation next to cron fields
closes https://github.com/frappe/frappe/issues/21166
2023-10-14 11:27:18 +05:30
Maharshi Patel
1de07a8357 fix(minor): remove __temporary_name after relink
removed __temporary_name as after relink file there is no need to keep it
2023-10-13 10:35:49 +05:30