Commit graph

195 commits

Author SHA1 Message Date
Rushabh Mehta
c2652fed39 fix(minor): page creation 2024-09-06 14:12:34 +05:30
Rushabh Mehta
774d86f642 feat: Workspace Settings - allow enabling and disabling of workspaces during setup 2024-08-04 13:41:08 +05:30
Gursheen Anand
61807dda71 fix: allow creation of workspace based on desk role perms 2024-05-30 17:35:48 +05:30
Ankush Menat
7fe9cc4f09
perf: Don't update session in cache after every request (#26308)
It's just reading and writing same information except last_update inside
data which is never read back from this.
2024-05-04 06:10:38 +00:00
Sabu Siyad
f3a472b76e
fix(ux): translate onboarding step description 2024-03-13 12:08:43 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Rucha Mahabal
68003a23d5
feat: show doctype description on workspace link hover (#24598) 2024-02-06 15:38:59 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
barredterra
89582dc73d fix: include workspaces without domain restriction 2024-01-10 13:13:19 +01:00
Xiaoguang Sun
1fe3b5d5bc
refactor(workspace): Optimize save call on workspace doc (#24052)
Optimize Workspace.save_page to call doc.save() only once therefore
eliminate sending unnecessary queries to database.

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
2024-01-01 11:38:40 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
Ankush Menat
018ed845bd refactor: defer unnecessary json-dumping of messages
Also avoid accessing locals where interface is present like for popping last message.
2023-10-16 18:13:50 +05:30
Maharshi Patel
d23b543dc9 Merge branch 'develop' into feat-desk-refresh 2023-09-15 12:12:25 +05:30
Shariq Ansari
cbb80ed0ee fix: getting workspace roles from doc instead from Has Role doctype 2023-09-12 18:10:41 +05:30
Shariq Ansari
a392f57c5e fix: made workspace indicator color customizable 2023-08-25 15:08:10 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
Shariq Ansari
90f6b44f48 fix: added welcome workspace if user has desk acces but does not have module access
basically if user doesn't have access to any public workspaces

also made welcome workspace hidden if he/she has even one workspace
2023-07-28 19:01:11 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Shariq Ansari
d08b0fa477 fix: allow custom html block based on roles applied
if roles table is empty it will allow access
2023-05-17 17:39:08 +05:30
Shariq Ansari
001425f71b fix: backend to create workspace custom block and update workspace 2023-05-17 14:59:19 +05:30
Ankush Menat
cbbb6a7d85 chore: track onboarding progress
Easy self-onboarding has been hardest to get right in complex business
apps, even though we have worked on this for long long time we have no
clear idea on how well it works, or if it's severly lacking.

We want to improve this by first understanding how efficient current
system is.

This PR adds basic telemetry for which steps are being completed, which
are skipped and what onboarding group is dismissed completely.
2023-05-05 12:54:14 +05:30
Shariq Ansari
41d43b2a06 fix: allow url type shortcut 2023-04-19 23:17:23 +05:30
Shariq Ansari
d46ff2ed24 fix: include number_card in cleanup logic 2023-02-28 13:41:21 +05:30
Shariq Ansari
8780503191 chore: code reformatting 2023-02-28 10:49:17 +05:30
Rohan Bansal
2af64893a3 feat: allow number cards in workspaces 2023-02-17 14:44:54 +05:30
Shariq Ansari
97a57f7105 feat: hide/unhide workspace from sidebar 2023-01-09 17:51:25 +05:30
Rucha Mahabal
14a84793a8
fix: Show quick list only if user has access (#18102) 2022-09-13 16:09:33 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Nabin Hait
53c22b0493 feat: Enable mentions and notify users from any text field 2022-07-22 15:26:37 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Shariq Ansari
78489cd700
feat: Quick List Block for Workspace (#16887) 2022-05-13 15:34:35 +05:30
Rushabh Mehta
6e6fe9521e fix(linting): no single quotes :'| 2022-04-18 17:29:03 +05:30
Rushabh Mehta
57a55e4225 feat(minor): Add document reference to Error Log and doc.log_error 2022-04-18 17:29:03 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Shariq Ansari
3dfd2f2174 fix: removed is_page_allowed method while getting sidebar items (method is useless) 2022-01-24 14:18:29 +05:30
Shariq Ansari
4c994aeca2 fix: updated code to make workspace responsive 2022-01-24 10:50:37 +05:30
Shariq Ansari
b85d5bd483 chore: renamed wspace to workspace 2022-01-12 16:21:14 +05:30
Shariq Ansari
db3870151a fix: Workspace Sidebar, Edit, New Page Fixes
Bugs:
- Clicking on + button multiple time opens multiple block list
- Resizing Onboarding block breaks design
- In edit mode links should not be clickable
- While creating new page we cannot revisit it from sidebar
- While adding multiple links in card getting error

Refactor:
- All Sidebar actions happens while you do it, no need to click Save Customization button
- Updating Sidebar, Creating New Page, Duplicating every action is much faster
- Most of the actions are happening in background while rending page using cached data
2022-01-04 15:35:57 +05:30
Shariq Ansari
5d00602f06 fix: Removing unused code for worspace 2021-09-20 21:27:14 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
shariquerik
013f1f471d fix: Switch Public-Private, Change Customize to Edit, Add Settings button to redirect to workspace document 2021-08-17 11:11:15 +05:30
shariquerik
84f195ca19 fix: Resolved Conflicts 2021-08-03 17:53:14 +05:30
shariquerik
8739b5e3ad fix: Added Onboarding Block 2021-07-20 16:33:13 +05:30
shariquerik
4a05697cfe fix: Role based access to workspace 2021-07-19 11:04:12 +05:30
mergify[bot]
d8c4ad379c
Merge pull request #13488 from shariquerik/custom-report-link-fix
fix: Invalid Custom Report link on Workspace
2021-07-12 12:10:08 +00:00
shariquerik
098005b305 fix: minor fix 2021-07-08 16:52:51 +05:30
Shariq Ansari
29616c080e
Merge branch 'develop' into wiki-based-desk 2021-07-06 22:38:59 +05:30
shariquerik
afe1dbe0f8 fix: Workspace 2.0 2021-07-06 22:05:37 +05:30
leela
b7fb1d475e fix: workspace loading error
Workspace loads to fail if there are no links in any extended workspaces.
2021-06-26 09:43:34 +05:30